)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"20b279e26712c1f5fef5d5d22af4b8f5c7905b92","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate L3HARouter DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_44e8f7b4","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":33},"updated":"2016-08-26 20:23:57.000000000","message":"nit: it\u0027s usually called `circular`, but you don\u0027t need to change it.","commit_id":"358ffff4d4bc23c3332f8dd9b016e245f6e9b4ff"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"ad8d18e4a2b069b9a9bb63b0bbc833584c5b9ec8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate L3HARouter DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_ba78fef3","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":33},"in_reply_to":"fa7ab95a_44e8f7b4","updated":"2016-08-26 21:05:00.000000000","message":"Done","commit_id":"358ffff4d4bc23c3332f8dd9b016e245f6e9b4ff"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"feb3b644a91438562ae5df9e4034f55735fd79c9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate L3HARouter DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of circular imports while"},{"line_number":10,"context_line":"implementation of objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_6afb5947","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"updated":"2016-09-08 17:04:58.000000000","message":"nit: Oslo-Versioned Objects","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4b73407840a4adf1efe02df324a693c90a6e08c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate L3HARouter DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of circular imports while"},{"line_number":10,"context_line":"implementation of objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_d27245b0","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"in_reply_to":"9a89bdaa_6afb5947","updated":"2016-09-09 03:07:55.000000000","message":"+1","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6f22f7aded653f20a156234a1c7477d3e83085ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate L3HARouter DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of circular imports while"},{"line_number":10,"context_line":"implementation of objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_d60f4686","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"in_reply_to":"9a89bdaa_6afb5947","updated":"2016-09-12 05:08:22.000000000","message":"Done","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6f22f7aded653f20a156234a1c7477d3e83085ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate L3HARouter DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of circular imports while"},{"line_number":10,"context_line":"implementation of objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_f6260a15","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"in_reply_to":"9a89bdaa_d27245b0","updated":"2016-09-12 05:08:22.000000000","message":"Done","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c9150d28249c99bbef1967c05fb469cf835bcef3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As there would be issue of circular imports while"},{"line_number":10,"context_line":"implementation of Oslo-Versioned Objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I44e638fb4c19a2bdd513b67baeb7e6a2acc72d2f"},{"line_number":15,"context_line":"Partial-Bug: #1597913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3a98d1f4_4c9f3d50","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"updated":"2016-09-29 15:53:05.000000000","message":"move","commit_id":"86718256b9b1e72d676142960110ff16c9960932"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9903f92c1bc40717b71ec289cee6e023df4f48bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As there would be issue of circular imports while"},{"line_number":10,"context_line":"implementation of Oslo-Versioned Objects for L3HArouter which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor L3HArouter models."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I44e638fb4c19a2bdd513b67baeb7e6a2acc72d2f"},{"line_number":15,"context_line":"Partial-Bug: #1597913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3a98d1f4_4c501d5f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"in_reply_to":"3a98d1f4_4c9f3d50","updated":"2016-09-29 15:54:20.000000000","message":"Done","commit_id":"86718256b9b1e72d676142960110ff16c9960932"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"39efdd6838046236a14bdb0e1efe043d9bf2ff0a","unresolved":false,"context_lines":[{"line_number":737,"context_line":""},{"line_number":738,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":739,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":740,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), l3_hamode_model)"},{"line_number":741,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_8de7a9ab","line":740,"updated":"2016-08-31 12:51:36.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"ce987d815e35f9905dae5546628c11f6685b37fa"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"feb3b644a91438562ae5df9e4034f55735fd79c9","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    if validators.is_attr_set(requested_router_type):"},{"line_number":733,"context_line":"        return requested_router_type"},{"line_number":734,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_aabe4162","line":735,"updated":"2016-09-08 17:04:58.000000000","message":"nit: this should have two breaklines","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6f22f7aded653f20a156234a1c7477d3e83085ca","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    if validators.is_attr_set(requested_router_type):"},{"line_number":733,"context_line":"        return requested_router_type"},{"line_number":734,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_362152fc","line":735,"in_reply_to":"9a89bdaa_327291ae","updated":"2016-09-12 05:08:22.000000000","message":"Done","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4b73407840a4adf1efe02df324a693c90a6e08c1","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    if validators.is_attr_set(requested_router_type):"},{"line_number":733,"context_line":"        return requested_router_type"},{"line_number":734,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_327291ae","line":735,"in_reply_to":"9a89bdaa_aabe4162","updated":"2016-09-09 03:07:55.000000000","message":"+1","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6f22f7aded653f20a156234a1c7477d3e83085ca","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    if validators.is_attr_set(requested_router_type):"},{"line_number":733,"context_line":"        return requested_router_type"},{"line_number":734,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_16228e01","line":735,"in_reply_to":"9a89bdaa_aabe4162","updated":"2016-09-12 05:08:22.000000000","message":"Done","commit_id":"45c4cf5fca4b742a7c4960b55bb3b0d8d76effd9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c9150d28249c99bbef1967c05fb469cf835bcef3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from neutron.db import l3_dvr_db"},{"line_number":43,"context_line":"from neutron.db.l3_dvr_db import is_distributed_router"},{"line_number":44,"context_line":"from neutron.db.models import l3 as l3_models"},{"line_number":45,"context_line":"from neutron.db.models import l3_hamode as l3_hamode_model"},{"line_number":46,"context_line":"from neutron.extensions import l3"},{"line_number":47,"context_line":"from neutron.extensions import l3_ext_ha_mode as l3_ha"},{"line_number":48,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_6cf3199f","line":45,"range":{"start_line":45,"start_character":43,"end_line":45,"end_character":58},"updated":"2016-09-29 15:53:05.000000000","message":"l3ha_model would also work and would be shorter.","commit_id":"86718256b9b1e72d676142960110ff16c9960932"}],"neutron/db/models/l3_hamode.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cb8170eb0ec430c9460e2ee233f0623c533bb434","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":"from sqlalchemy import orm"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib.db import model_base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import constants as n_const"},{"line_number":22,"context_line":"from neutron.db import agents_db"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_d168a2f7","line":19,"updated":"2016-09-27 15:09:38.000000000","message":"This should go in the same import block as sqlalchemy.","commit_id":"e31b946e9f3266c0863f1b37a050fc737ac973fb"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"8df8aac7a09268766b8c39e10294039d912ef2f2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":"from sqlalchemy import orm"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib.db import model_base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import constants as n_const"},{"line_number":22,"context_line":"from neutron.db import agents_db"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_6bac2036","line":19,"in_reply_to":"5a8bc5a2_d168a2f7","updated":"2016-09-28 00:19:25.000000000","message":"Done","commit_id":"e31b946e9f3266c0863f1b37a050fc737ac973fb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9903f92c1bc40717b71ec289cee6e023df4f48bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 eNovance SAS \u003clicensing@enovance.com\u003e"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_ac9521e5","line":1,"updated":"2016-09-29 15:54:20.000000000","message":"the file could be renamed into l3ha.py for shorter name.","commit_id":"86718256b9b1e72d676142960110ff16c9960932"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"20b279e26712c1f5fef5d5d22af4b8f5c7905b92","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        states \u003d {router1[\u0027id\u0027]: \u0027active\u0027}"},{"line_number":984,"context_line":"        with mock.patch.object(self.plugin, \u0027get_ha_router_port_bindings\u0027):"},{"line_number":985,"context_line":"            (self.admin_ctx.session.query("},{"line_number":986,"context_line":"                 l3_hamode_db.L3HARouterAgentPortBinding)."},{"line_number":987,"context_line":"             filter_by(router_id\u003drouter1[\u0027id\u0027]).delete())"},{"line_number":988,"context_line":"            self.plugin.update_routers_states("},{"line_number":989,"context_line":"                self.admin_ctx, states, self.agent1[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_04a26fae","line":986,"range":{"start_line":986,"start_character":17,"end_line":986,"end_character":56},"updated":"2016-08-26 20:23:57.000000000","message":"Shouldn\u0027t this also be affected by this change?","commit_id":"358ffff4d4bc23c3332f8dd9b016e245f6e9b4ff"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"ad8d18e4a2b069b9a9bb63b0bbc833584c5b9ec8","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        states \u003d {router1[\u0027id\u0027]: \u0027active\u0027}"},{"line_number":984,"context_line":"        with mock.patch.object(self.plugin, \u0027get_ha_router_port_bindings\u0027):"},{"line_number":985,"context_line":"            (self.admin_ctx.session.query("},{"line_number":986,"context_line":"                 l3_hamode_db.L3HARouterAgentPortBinding)."},{"line_number":987,"context_line":"             filter_by(router_id\u003drouter1[\u0027id\u0027]).delete())"},{"line_number":988,"context_line":"            self.plugin.update_routers_states("},{"line_number":989,"context_line":"                self.admin_ctx, states, self.agent1[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_9ad7babe","line":986,"range":{"start_line":986,"start_character":17,"end_line":986,"end_character":56},"in_reply_to":"fa7ab95a_04a26fae","updated":"2016-08-26 21:05:00.000000000","message":"yes that should be changed too. Fixed it.","commit_id":"358ffff4d4bc23c3332f8dd9b016e245f6e9b4ff"}]}
