)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"474007c6d42205afd58b3f5d7fa4844b53cfe615","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This makes the notifier subscribe to core resource events"},{"line_number":10,"context_line":"and leverage them if they are available. This solves the"},{"line_number":11,"context_line":"issue where internal core plugin calls from service plugins"},{"line_number":12,"context_line":"were not generating DHCP agent notifications."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I607635601caff0322fd0c80c9023f5c4f663ca25"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_56caf21b","line":12,"updated":"2016-09-07 22:38:55.000000000","message":"this needs a bug report at this point in the release.","commit_id":"2ec9224b2030f3eb11f1a2a6b303a28cff605499"}],"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0802997c0a3bf62bce35f21566b741ea98a2bdc6","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            self._unsubscribed_resources.append(resource)"},{"line_number":228,"context_line":"            registry.unsubscribe_by_resource(self._send_dhcp_notification,"},{"line_number":229,"context_line":"                                             resource)"},{"line_number":230,"context_line":"        if not cfg.CONF.dhcp_agent_notification:"},{"line_number":231,"context_line":"            return"},{"line_number":232,"context_line":"        method_name \u003d \u0027.\u0027.join((resource, event.replace(\u0027after_\u0027, \u0027\u0027), \u0027end\u0027))"},{"line_number":233,"context_line":"        payload \u003d kwargs[resource]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_eaf6e6f7","line":230,"updated":"2016-08-29 16:00:20.000000000","message":"this just seems pointless to invoke if the variable is not set - so why not refrain from binding them then the plugin starts. see https://review.openstack.org/361716 which was abandoned in favor of this","commit_id":"d5ceb2f009c93fce1f388fbe3be01275e7dc8c93"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74ee82d1caf2390826c26309899607d5d0b50bf8","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                             context, **kwargs):"},{"line_number":227,"context_line":"        # we unsubscribe the _send_dhcp_notification method now that we know"},{"line_number":228,"context_line":"        # the loaded core plugin emits native resource events"},{"line_number":229,"context_line":"        if resource not in self._unsubscribed_resources:"},{"line_number":230,"context_line":"            self.uses_native_notifications \u003d True"},{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"},{"line_number":232,"context_line":"            registry.unsubscribe_by_resource(self._send_dhcp_notification,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_dcac578e","line":229,"updated":"2016-09-08 07:09:40.000000000","message":"Can\u0027t we execute this if only if uses_native_notifications is False?","commit_id":"0f6a1543e2c5042f7c129619bd7291fa42810edf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a2763a0b1710cd8117c3fc53382362b8d71c9faf","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                             context, **kwargs):"},{"line_number":227,"context_line":"        # we unsubscribe the _send_dhcp_notification method now that we know"},{"line_number":228,"context_line":"        # the loaded core plugin emits native resource events"},{"line_number":229,"context_line":"        if resource not in self._unsubscribed_resources:"},{"line_number":230,"context_line":"            self.uses_native_notifications \u003d True"},{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"},{"line_number":232,"context_line":"            registry.unsubscribe_by_resource(self._send_dhcp_notification,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_bff785d1","line":229,"in_reply_to":"9a89bdaa_9c0f2f36","updated":"2016-09-08 07:26:49.000000000","message":"if we had an array of flags we wouldn\u0027t :)","commit_id":"0f6a1543e2c5042f7c129619bd7291fa42810edf"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"95015c248755e6be86cc94424e0f38cd904f7b70","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                             context, **kwargs):"},{"line_number":227,"context_line":"        # we unsubscribe the _send_dhcp_notification method now that we know"},{"line_number":228,"context_line":"        # the loaded core plugin emits native resource events"},{"line_number":229,"context_line":"        if resource not in self._unsubscribed_resources:"},{"line_number":230,"context_line":"            self.uses_native_notifications \u003d True"},{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"},{"line_number":232,"context_line":"            registry.unsubscribe_by_resource(self._send_dhcp_notification,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_9c0f2f36","line":229,"in_reply_to":"9a89bdaa_dcac578e","updated":"2016-09-08 07:18:38.000000000","message":"no, we want to ensure each resource is unsubscribed from the API events. If we only did it on false, we would only unsubscribe the first resource that received an event.","commit_id":"0f6a1543e2c5042f7c129619bd7291fa42810edf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        for resource in callback_resources:"},{"line_number":77,"context_line":"            registry.subscribe(self._send_dhcp_notification,"},{"line_number":78,"context_line":"                               resource, events.BEFORE_RESPONSE)"},{"line_number":79,"context_line":"            registry.subscribe(self._native_event_send_dhcp_notification,"},{"line_number":80,"context_line":"                               resource, events.AFTER_CREATE)"},{"line_number":81,"context_line":"            registry.subscribe(self._native_event_send_dhcp_notification,"},{"line_number":82,"context_line":"                               resource, events.AFTER_UPDATE)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_fd20dcf9","line":79,"updated":"2016-09-14 12:00:50.000000000","message":"we are subscribing to AFTER_* events for NETWORKS, PORTS, SUBNETS too. Is it intended? There probably won\u0027t be a huge issue because line 255 will skip the event, but still, could be more specific here.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        for resource in callback_resources:"},{"line_number":77,"context_line":"            registry.subscribe(self._send_dhcp_notification,"},{"line_number":78,"context_line":"                               resource, events.BEFORE_RESPONSE)"},{"line_number":79,"context_line":"            registry.subscribe(self._native_event_send_dhcp_notification,"},{"line_number":80,"context_line":"                               resource, events.AFTER_CREATE)"},{"line_number":81,"context_line":"            registry.subscribe(self._native_event_send_dhcp_notification,"},{"line_number":82,"context_line":"                               resource, events.AFTER_UPDATE)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_c46d0006","line":79,"in_reply_to":"7a8ec9b2_fd20dcf9","updated":"2016-09-14 14:08:00.000000000","message":"Done","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def _native_event_send_dhcp_notification(self, resource, event, trigger,"},{"line_number":226,"context_line":"                                             context, **kwargs):"},{"line_number":227,"context_line":"        # we unsubscribe the _send_dhcp_notification method now that we know"},{"line_number":228,"context_line":"        # the loaded core plugin emits native resource events"},{"line_number":229,"context_line":"        if resource not in self._unsubscribed_resources:"},{"line_number":230,"context_line":"            self.uses_native_notifications \u003d True"},{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_3d05e4c1","line":228,"updated":"2016-09-14 12:00:50.000000000","message":"where is the guarantee that it emits all the needed events though? that\u0027s a general problem I have with callbacks: they are not well defined, and events are usually added ad-hoc.\n\nShould we at least track event types seen?","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def _native_event_send_dhcp_notification(self, resource, event, trigger,"},{"line_number":226,"context_line":"                                             context, **kwargs):"},{"line_number":227,"context_line":"        # we unsubscribe the _send_dhcp_notification method now that we know"},{"line_number":228,"context_line":"        # the loaded core plugin emits native resource events"},{"line_number":229,"context_line":"        if resource not in self._unsubscribed_resources:"},{"line_number":230,"context_line":"            self.uses_native_notifications \u003d True"},{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_d63bfae9","line":228,"in_reply_to":"7a8ec9b2_3d05e4c1","updated":"2016-09-14 14:08:00.000000000","message":"That\u0027s not a problem with callbacks, that\u0027s just a problem with people not calling an expected function. If the plugins were calling the notifier directly you still couldn\u0027t be sure it was calling it at the appropriate times.\n\nI can track event types as well.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"},{"line_number":232,"context_line":"            registry.unsubscribe_by_resource(self._send_dhcp_notification,"},{"line_number":233,"context_line":"                                             resource)"},{"line_number":234,"context_line":"        method_name \u003d \u0027.\u0027.join((resource, event.replace(\u0027after_\u0027, \u0027\u0027), \u0027end\u0027))"},{"line_number":235,"context_line":"        payload \u003d kwargs[resource]"},{"line_number":236,"context_line":"        data \u003d {resource: payload}"},{"line_number":237,"context_line":"        self.notify(context, data, method_name)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_bda3b49d","line":234,"range":{"start_line":234,"start_character":42,"end_line":234,"end_character":69},"updated":"2016-09-14 12:00:50.000000000","message":"(No action required) nit: my paranoia wonders what will happen if we ever change values for AFTER_* constants.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            self._unsubscribed_resources.append(resource)"},{"line_number":232,"context_line":"            registry.unsubscribe_by_resource(self._send_dhcp_notification,"},{"line_number":233,"context_line":"                                             resource)"},{"line_number":234,"context_line":"        method_name \u003d \u0027.\u0027.join((resource, event.replace(\u0027after_\u0027, \u0027\u0027), \u0027end\u0027))"},{"line_number":235,"context_line":"        payload \u003d kwargs[resource]"},{"line_number":236,"context_line":"        data \u003d {resource: payload}"},{"line_number":237,"context_line":"        self.notify(context, data, method_name)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_9631720e","line":234,"range":{"start_line":234,"start_character":42,"end_line":234,"end_character":69},"in_reply_to":"7a8ec9b2_bda3b49d","updated":"2016-09-14 14:08:00.000000000","message":"Then the unit tests would fail. The payloads are static in the tests without reference to constants.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ce46e5acdce69778f5266852cd44d2b4732b3efd","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                                action\u003d\u0027\u0027, **kwargs):"},{"line_number":250,"context_line":"        action \u003d action.split(\u0027_\u0027)[0]"},{"line_number":251,"context_line":"        if (resource in self.uses_native_notifications and"},{"line_number":252,"context_line":"                self.uses_native_notifications[resource][action]):"},{"line_number":253,"context_line":"            return"},{"line_number":254,"context_line":"        if collection and collection in data:"},{"line_number":255,"context_line":"            for body in data[collection]:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_21076b1d","line":252,"updated":"2016-09-14 15:43:13.000000000","message":"neat","commit_id":"181bdb374fc0c944b1168f27ac7b5cbb0ff0f3c3"}],"neutron/pecan_wsgi/hooks/notifier.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _notify_dhcp_agent(self, context, resource_name, action, resources):"},{"line_number":50,"context_line":"        # NOTE(kevinbenton): we should remove this whole method in Ocata and"},{"line_number":51,"context_line":"        # make plugins emit the core resource events"},{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource_name)"},{"line_number":53,"context_line":"        notifier_method \u003d \u0027%s.%s.end\u0027 % (resource_name, action)"},{"line_number":54,"context_line":"        # use plugin\u0027s dhcp notifier, if this is already instantiated"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_3d95e4e3","line":51,"range":{"start_line":51,"start_character":10,"end_line":51,"end_character":52},"updated":"2016-09-14 12:00:50.000000000","message":"Just curious... all of plugins? how do you achieve that?","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _notify_dhcp_agent(self, context, resource_name, action, resources):"},{"line_number":50,"context_line":"        # NOTE(kevinbenton): we should remove this whole method in Ocata and"},{"line_number":51,"context_line":"        # make plugins emit the core resource events"},{"line_number":52,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin_for_resource(resource_name)"},{"line_number":53,"context_line":"        notifier_method \u003d \u0027%s.%s.end\u0027 % (resource_name, action)"},{"line_number":54,"context_line":"        # use plugin\u0027s dhcp notifier, if this is already instantiated"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_16a482a4","line":51,"range":{"start_line":51,"start_character":10,"end_line":51,"end_character":52},"in_reply_to":"7a8ec9b2_3d95e4e3","updated":"2016-09-14 14:08:00.000000000","message":"by removing this and telling them they either need to emit the notifications or call the notifier themselves.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"}],"neutron/plugins/common/utils.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    return core_plugin.create_network(context, {\u0027network\u0027: net_data})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def update_network(core_plugin, context, network_id, net_data):"},{"line_number":176,"context_line":"    network \u003d core_plugin.update_network("},{"line_number":177,"context_line":"        context, network_id, {resources.NETWORK: net_data})"},{"line_number":178,"context_line":"    # bundle the plugin API update with any other action required to"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_bd5e5443","side":"PARENT","line":175,"updated":"2016-09-14 12:00:50.000000000","message":"/me wonders if that could be used outside the tree.","commit_id":"9d24490da8552542309dc7b9d6cbc695af4c6de6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    return core_plugin.create_network(context, {\u0027network\u0027: net_data})"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def update_network(core_plugin, context, network_id, net_data):"},{"line_number":176,"context_line":"    network \u003d core_plugin.update_network("},{"line_number":177,"context_line":"        context, network_id, {resources.NETWORK: net_data})"},{"line_number":178,"context_line":"    # bundle the plugin API update with any other action required to"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_84c77811","side":"PARENT","line":175,"in_reply_to":"7a8ec9b2_bd5e5443","updated":"2016-09-14 14:08:00.000000000","message":"Done","commit_id":"9d24490da8552542309dc7b9d6cbc695af4c6de6"}],"neutron/tests/tempest/api/admin/test_quotas_negative.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        subnet_args \u003d {\u0027tenant_id\u0027: tenant_id,"},{"line_number":73,"context_line":"                       \u0027network_id\u0027: net[\u0027id\u0027],"},{"line_number":74,"context_line":"                       \u0027enable_dhcp\u0027: False,"},{"line_number":75,"context_line":"                       \u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":76,"context_line":"                       \u0027ip_version\u0027: \u00274\u0027}"},{"line_number":77,"context_line":"        subnet \u003d self.admin_client.create_subnet(**subnet_args)[\u0027subnet\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_dd2240b9","line":74,"updated":"2016-09-14 12:00:50.000000000","message":"what\u0027s that change for?","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        subnet_args \u003d {\u0027tenant_id\u0027: tenant_id,"},{"line_number":73,"context_line":"                       \u0027network_id\u0027: net[\u0027id\u0027],"},{"line_number":74,"context_line":"                       \u0027enable_dhcp\u0027: False,"},{"line_number":75,"context_line":"                       \u0027cidr\u0027: \u002710.0.0.0/24\u0027,"},{"line_number":76,"context_line":"                       \u0027ip_version\u0027: \u00274\u0027}"},{"line_number":77,"context_line":"        subnet \u003d self.admin_client.create_subnet(**subnet_args)[\u0027subnet\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_19b03543","line":74,"in_reply_to":"7a8ec9b2_dd2240b9","updated":"2016-09-14 14:08:00.000000000","message":"try running this test with a DHCP agent enabled (even without this patch) and find out. ;)\n\nI\u0027ll move this to a separate patch.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"}],"neutron/tests/unit/services/auto_allocate/test_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd2b6ea359316e84ba87f4f48f402b972d086d96","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                provisioning_exception)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test__save_with_provisioning_error(self):"},{"line_number":162,"context_line":"        self.mixin._core_plugin.create_network.side_effect \u003d Exception"},{"line_number":163,"context_line":"        with testtools.ExpectedException("},{"line_number":164,"context_line":"                exceptions.UnknownProvisioningError) as e:"},{"line_number":165,"context_line":"            self.mixin._save(self.ctx, \u0027foo_t\u0027, \u0027foo_n\u0027, \u0027foo_r\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_b8966292","line":162,"updated":"2016-09-14 12:00:50.000000000","message":"why create? don\u0027t we update_network in the mixin?","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3486a5c64680137b970750266c5a6e891b953c13","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                provisioning_exception)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test__save_with_provisioning_error(self):"},{"line_number":162,"context_line":"        self.mixin._core_plugin.create_network.side_effect \u003d Exception"},{"line_number":163,"context_line":"        with testtools.ExpectedException("},{"line_number":164,"context_line":"                exceptions.UnknownProvisioningError) as e:"},{"line_number":165,"context_line":"            self.mixin._save(self.ctx, \u0027foo_t\u0027, \u0027foo_n\u0027, \u0027foo_r\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a8ec9b2_39009134","line":162,"in_reply_to":"7a8ec9b2_b8966292","updated":"2016-09-14 14:08:00.000000000","message":"whoops. it does both but i should leave it as update to keep the same test.","commit_id":"ba31cc064a4493fbd4b1a6f3ccd76a9d41045d7c"}]}
