)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2ae1a45b16bb76c59033d8c7070d0b215735c480","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-14 14:16:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs_lib add a new methods to add attributs to ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create add_attrs_to_port, an helper method to add attributes"},{"line_number":10,"context_line":"to the table Interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_29495760","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":25},"updated":"2016-08-15 17:29:15.000000000","message":"a new method","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2ae1a45b16bb76c59033d8c7070d0b215735c480","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-14 14:16:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs_lib add a new methods to add attributs to ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create add_attrs_to_port, an helper method to add attributes"},{"line_number":10,"context_line":"to the table Interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_e93e1fb7","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":42},"updated":"2016-08-15 17:29:15.000000000","message":"attributes","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"4ae93e7a1e9ec5518d3ab02895d20cf6644bd630","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-14 14:16:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs_lib add a new methods to add attributs to ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create add_attrs_to_port, an helper method to add attributes"},{"line_number":10,"context_line":"to the table Interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_d7e8d8e4","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":42},"in_reply_to":"3ac371cc_e93e1fb7","updated":"2016-08-16 19:23:25.000000000","message":"\"adds\" not \"add\" or \"new ovs_lib method to add attributes to port\"","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"4ae93e7a1e9ec5518d3ab02895d20cf6644bd630","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovs_lib add a new methods to add attributs to ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create add_attrs_to_port, an helper method to add attributes"},{"line_number":10,"context_line":"to the table Interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I184ea9f757b4918ca712a14314075cb36e9218fa"},{"line_number":13,"context_line":"Partially-implements: blueprint vlan-aware-vms"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_f7c4f45f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":23},"updated":"2016-08-16 19:23:25.000000000","message":"This is redundant isn\u0027t? I would leave out details of implementation.","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"895e6d3b79e640428a2d0d50b18155d0581bbfcb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def get_bridge_external_bridge_id(self, bridge):"},{"line_number":133,"context_line":"        return self.ovsdb.br_get_external_id(bridge, \u0027bridge-id\u0027).execute()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def set_db_attribute(self, table_name, record, column, value,"},{"line_number":136,"context_line":"                         check_error\u003dFalse, log_errors\u003dTrue):"},{"line_number":137,"context_line":"        self.ovsdb.db_set(table_name, record, (column, value)).execute("},{"line_number":138,"context_line":"            check_error\u003dcheck_error, log_errors\u003dlog_errors)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_798324cd","line":135,"updated":"2016-08-15 15:52:13.000000000","message":"here","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"895e6d3b79e640428a2d0d50b18155d0581bbfcb","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                          *interface_attr_tuples))"},{"line_number":222,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_attrs_to_port(self, port_name, *interface_attr_tuples):"},{"line_number":225,"context_line":"        \"\"\"Add new attributes to the port\"\"\""},{"line_number":226,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":227,"context_line":"            txn.add(self.ovsdb.db_set(\u0027Interface\u0027, port_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_d9efb8ae","line":224,"updated":"2016-08-15 15:52:13.000000000","message":"alternatively we could use set_db_attribute() at line 135 and call it a day :)","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"6c975aca88f9e7269afa86a28f58922ed9859be6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                          *interface_attr_tuples))"},{"line_number":222,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_attrs_to_port(self, port_name, *interface_attr_tuples):"},{"line_number":225,"context_line":"        \"\"\"Add new attributes to the port\"\"\""},{"line_number":226,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":227,"context_line":"            txn.add(self.ovsdb.db_set(\u0027Interface\u0027, port_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_3072c811","line":224,"in_reply_to":"3ac371cc_82d76bbe","updated":"2016-08-17 22:45:09.000000000","message":"+1 I\u0027m not seeing what value this method is adding.","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3f7da23eac7a3676d4923be05808f4d99b90810b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                          *interface_attr_tuples))"},{"line_number":222,"context_line":"        return self.get_port_ofport(port_name)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_attrs_to_port(self, port_name, *interface_attr_tuples):"},{"line_number":225,"context_line":"        \"\"\"Add new attributes to the port\"\"\""},{"line_number":226,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":227,"context_line":"            txn.add(self.ovsdb.db_set(\u0027Interface\u0027, port_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_82d76bbe","line":224,"in_reply_to":"3ac371cc_d9efb8ae","updated":"2016-08-16 07:10:17.000000000","message":"I\u0027d prefer that too","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e52f0d74141def5f876ae704212e0137da7a44d9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def add_attrs_to_port(self, port_name, *interface_attr_tuples):"},{"line_number":225,"context_line":"        \"\"\"Add new attributes to the port\"\"\""},{"line_number":226,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":227,"context_line":"            txn.add(self.ovsdb.db_set(\u0027Interface\u0027, port_name,"},{"line_number":228,"context_line":"                                      *interface_attr_tuples))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def replace_port(self, port_name, *interface_attr_tuples):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_2787d710","line":227,"range":{"start_line":227,"start_character":12,"end_line":227,"end_character":19},"updated":"2016-08-15 11:26:21.000000000","message":"Do we need a transaction here? Would be following sufficient?\n\n self.ovsdb.set(\u0027Interface\u0027, port_name, *interface_attr_tuples).execute()","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"748b1f9c2dffb5bb6577b6b23604ca709d1f7ffe","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def add_attrs_to_port(self, port_name, *interface_attr_tuples):"},{"line_number":225,"context_line":"        \"\"\"Add new attributes to the port\"\"\""},{"line_number":226,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":227,"context_line":"            txn.add(self.ovsdb.db_set(\u0027Interface\u0027, port_name,"},{"line_number":228,"context_line":"                                      *interface_attr_tuples))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def replace_port(self, port_name, *interface_attr_tuples):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_31f38e75","line":227,"range":{"start_line":227,"start_character":12,"end_line":227,"end_character":19},"in_reply_to":"3ac371cc_2787d710","updated":"2016-08-15 13:20:50.000000000","message":"As Jakub said, if there is only one operation, you can just use execute(). Part of me thinks that having a function that just wraps another function with nearly the same arguments isn\u0027t that necessary. I\u0027d love to see people using the ovsdb interface directly w/o ovs_lib. It would make it easier for calling code to wrap multiple operations into a single transaction.\n\nI guess I need to get around to finishing up my recursive transactions patch so people can call multiple ovs_lib ovsdb-related functions in a single parent transaction.","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"056756602821a4e99f49ef6139344f07be142d4f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def add_attrs_to_port(self, port_name, *interface_attr_tuples):"},{"line_number":225,"context_line":"        \"\"\"Add new attributes to the port\"\"\""},{"line_number":226,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":227,"context_line":"            txn.add(self.ovsdb.db_set(\u0027Interface\u0027, port_name,"},{"line_number":228,"context_line":"                                      *interface_attr_tuples))"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def replace_port(self, port_name, *interface_attr_tuples):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_2b73d64e","line":227,"range":{"start_line":227,"start_character":12,"end_line":227,"end_character":19},"in_reply_to":"3ac371cc_31f38e75","updated":"2016-08-16 15:45:15.000000000","message":"Perhaps we could live without this method after all.","commit_id":"dfc8e36205aa8dd18131093bbb379751c393f6ae"}]}