)]}'
{"neutron/db/migration/models/head.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b36793f6a8709b62ae542b1d5d644874ae26acac","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":55,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_geneve  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":60,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_9073e77f","line":57,"updated":"2016-08-29 09:50:30.000000000","message":"? Instead, you should remove the line above.","commit_id":"38e77b940e4c182909346dc0075ef7dd83ae9af4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"54608297941de985b7dc95a2b4856b2d5eb97cfa","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":55,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_geneve  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":60,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_fd6b07b7","line":57,"in_reply_to":"fa7ab95a_9073e77f","updated":"2016-08-29 18:47:31.000000000","message":"Done","commit_id":"38e77b940e4c182909346dc0075ef7dd83ae9af4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ca20cd5ef478822fcb40877ffb39ceb8b1963197","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.db import servicetype_db  # noqa"},{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":60,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_ff9ccdc1","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":48},"updated":"2016-09-26 14:51:55.000000000","message":"Are those lines part of your change?","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"12f66100c47cb9e23dc555ff28e74a7d5b1c110c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.db import servicetype_db  # noqa"},{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":60,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_8ef5f9cc","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":48},"in_reply_to":"5a8bc5a2_acf01968","updated":"2016-09-28 01:31:46.000000000","message":"All the relocation patches are removing their own modules. It should be fine without this right?\n\nfrom neutron.plugins.ml2 import drivers","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"232b0c0c32ed0ffcef6b72b3d1c27a91897af483","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.db import servicetype_db  # noqa"},{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":60,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_acf01968","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":48},"in_reply_to":"5a8bc5a2_ff9ccdc1","updated":"2016-09-27 15:23:45.000000000","message":"It kind of looks like this is fixing a separate bug. How about changing to the following:\n\n  from neutron.plugins.ml2 import drivers\n\nThis will go away once all models are relocated, but it covers all the type driver models until then.","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"12f66100c47cb9e23dc555ff28e74a7d5b1c110c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.db import servicetype_db  # noqa"},{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":60,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_ee72fdaf","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":48},"in_reply_to":"5a8bc5a2_ff9ccdc1","updated":"2016-09-28 01:31:46.000000000","message":"No, these got left behind while rebasing. (flat and gre relocation got merged)","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"}],"neutron/db/models/Geneve_allocation_endpoints.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"15acc9d771ef24f5b3016860ee0da32f9a20fa0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_5d6f14c5","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2016-08-16 07:25:29.000000000","message":"Please remove the lines.\n\nAnd file name should be lowercase.","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5c66465600276da6098cbc552781efa9637d394f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_e106c8cc","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"3ac371cc_5d6f14c5","updated":"2016-08-17 13:42:21.000000000","message":"Done","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"}],"neutron/db/models/plugins/ml2/geneve_allocation_endpoints.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0d7889eee5fb60146e18b5ea194ad5d0d31aaddb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import sqlalchemy as sa"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.db import model_base"},{"line_number":16,"context_line":"from sqlalchemy import sql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class GeneveAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_277abbbd","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":26},"updated":"2016-08-23 06:02:39.000000000","message":"Move above.\n\nhttp://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"ecdf55ef44adafbe16cac600db8b276d7132abb5"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"bcddf1a22e7920d4951067b995d3278d84687e3e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import sqlalchemy as sa"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.db import model_base"},{"line_number":16,"context_line":"from sqlalchemy import sql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class GeneveAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_c2a4304c","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":26},"in_reply_to":"1ac06dbe_277abbbd","updated":"2016-08-23 23:59:38.000000000","message":"Done","commit_id":"ecdf55ef44adafbe16cac600db8b276d7132abb5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b36793f6a8709b62ae542b1d5d644874ae26acac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_102d1746","line":2,"updated":"2016-08-29 09:50:30.000000000","message":"Please rename the file to geneveallocation to reflect other module names (like vlanallocation).","commit_id":"38e77b940e4c182909346dc0075ef7dd83ae9af4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"54608297941de985b7dc95a2b4856b2d5eb97cfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_3d6acfb3","line":2,"in_reply_to":"fa7ab95a_102d1746","updated":"2016-08-29 18:47:31.000000000","message":"Done","commit_id":"38e77b940e4c182909346dc0075ef7dd83ae9af4"}],"neutron/db/models/plugins/ml2/geneveallocation.py":[{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"62b89312bb0e5c4e8ef8430646a0aa07d9f6d150","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import sqlalchemy as sa"},{"line_number":14,"context_line":"from sqlalchemy import sql"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.db import model_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class GeneveAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_0de332a5","line":16,"updated":"2016-09-01 20:24:53.000000000","message":"I feel this line should go up above \u0027import sqlalchemy as sa\u0027 as per the patch [1]\n\n[1] - https://review.openstack.org/#/c/358281/10/neutron/db/extra_dhcp_opt/models.py","commit_id":"4366beadcf0e592d9d63f30753a756608577dc26"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"9107f50302459d05c63ad382323f5d975454fb60","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import sqlalchemy as sa"},{"line_number":14,"context_line":"from sqlalchemy import sql"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.db import model_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class GeneveAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_109e7256","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":37},"updated":"2016-09-02 16:39:52.000000000","message":"As Shashank suggested in patchset 13\nthis import should be with third party library imports [1]\nAn example can be found in [2]\n[1] http://docs.openstack.org/developer/hacking/#import-order-template\n[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_geneve.py#L16\nOther than this, it looks good","commit_id":"58ed5335312129408dc9a283a9c657b72e588c38"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"74f7bb5ea1aea7c0a12f84f30797797e075171cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import sqlalchemy as sa"},{"line_number":14,"context_line":"from sqlalchemy import sql"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.db import model_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class GeneveAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_34ba5de2","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":37},"in_reply_to":"da7fb54a_109e7256","updated":"2016-09-22 18:23:06.000000000","message":"Done","commit_id":"58ed5335312129408dc9a283a9c657b72e588c38"}],"neutron/plugins/ml2/drivers/type_geneve.py":[{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"1ca5739e68c820b3915cc273c0e69a94f847f4b8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b582b1fe","line":15,"updated":"2016-08-15 20:31:56.000000000","message":"import sys ?","commit_id":"b9950a53b55c4837349a4736465b505291e00a1a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7aa874c7f5c2f2bcc57e8610fdd4f3376841286a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_50526b14","line":15,"in_reply_to":"3ac371cc_b582b1fe","updated":"2016-08-15 20:50:19.000000000","message":"My local tox was not working, as I discussed with u on irc. So missed the imports. Fixed now.","commit_id":"b9950a53b55c4837349a4736465b505291e00a1a"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"1ca5739e68c820b3915cc273c0e69a94f847f4b8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"import sqlalchemy as sa"},{"line_number":20,"context_line":"from sqlalchemy import sql"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron._i18n import _, _LE"},{"line_number":23,"context_line":"from neutron.db import model_base"},{"line_number":24,"context_line":"from neutron.db.models import Geneve_allocation_endpoints \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d5792d31","line":21,"updated":"2016-08-15 20:31:56.000000000","message":"from neutron.common import _deprecate ?","commit_id":"b9950a53b55c4837349a4736465b505291e00a1a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7aa874c7f5c2f2bcc57e8610fdd4f3376841286a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"import sqlalchemy as sa"},{"line_number":20,"context_line":"from sqlalchemy import sql"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron._i18n import _, _LE"},{"line_number":23,"context_line":"from neutron.db import model_base"},{"line_number":24,"context_line":"from neutron.db.models import Geneve_allocation_endpoints \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d03e5bb7","line":21,"in_reply_to":"3ac371cc_d5792d31","updated":"2016-08-15 20:50:19.000000000","message":"ditto","commit_id":"b9950a53b55c4837349a4736465b505291e00a1a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e938ff3d2f6afc8123ccf54352e7cfd2b535aebf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron._i18n import _, _LE"},{"line_number":23,"context_line":"from neutron.common import _deprecate"},{"line_number":24,"context_line":"from neutron.db.models import Geneve_allocation_endpoints \\"},{"line_number":25,"context_line":"     as geneve"},{"line_number":26,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":27,"context_line":"from neutron.plugins.ml2.drivers import type_tunnel"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_33bb39e7","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":14},"updated":"2016-08-16 21:58:44.000000000","message":"nit: s/geneve/geneve_models","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5c66465600276da6098cbc552781efa9637d394f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron._i18n import _, _LE"},{"line_number":23,"context_line":"from neutron.common import _deprecate"},{"line_number":24,"context_line":"from neutron.db.models import Geneve_allocation_endpoints \\"},{"line_number":25,"context_line":"     as geneve"},{"line_number":26,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":27,"context_line":"from neutron.plugins.ml2.drivers import type_tunnel"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_4194fc41","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":14},"in_reply_to":"3ac371cc_33bb39e7","updated":"2016-08-17 13:42:21.000000000","message":"Done","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"15acc9d771ef24f5b3016860ee0da32f9a20fa0c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":86,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":87,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), geneve)"},{"line_number":88,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_fd0880db","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":58},"updated":"2016-08-16 07:25:29.000000000","message":"Why do we need to put duplicated comment last?","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2e1050c8982c0f4b440064a26facde4869a66507","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":86,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":87,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), geneve)"},{"line_number":88,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_888eec2b","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":58},"in_reply_to":"3ac371cc_41e6bc15","updated":"2016-08-18 05:08:29.000000000","message":"I saw same line in other patches. I\u0027m not sure but I\u0027m OK.","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5c66465600276da6098cbc552781efa9637d394f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":86,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":87,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), geneve)"},{"line_number":88,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_41e6bc15","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":58},"in_reply_to":"3ac371cc_fd0880db","updated":"2016-08-17 13:42:21.000000000","message":"All the relocate DB model patches had this format, so followed the same. Please suggest if it needs to be changed.","commit_id":"9193dc349ce2a905969ee2ab63b22b21b34e88ef"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"09b2ae22ce539251df301bcea13246e63813a0e9","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":86,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":87,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), geneve_model)"},{"line_number":88,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_2d521dde","line":87,"updated":"2016-08-31 12:45:31.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"982e1c0178edb8167671c824cfcdc49e16a6bab9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f437018fcc13267e83783ff9dff272d568e1b3ab","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":86,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":87,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), geneve_model)"},{"line_number":88,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_89678824","line":87,"in_reply_to":"fa7ab95a_2d521dde","updated":"2016-08-31 17:18:17.000000000","message":"Done","commit_id":"982e1c0178edb8167671c824cfcdc49e16a6bab9"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ca20cd5ef478822fcb40877ffb39ceb8b1963197","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def get_mtu(self, physical_network\u003dNone):"},{"line_number":83,"context_line":"        mtu \u003d super(GeneveTypeDriver, self).get_mtu()"},{"line_number":84,"context_line":"        return mtu - self.max_encap_size if mtu else 0"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_3fd0f6f5","line":85,"updated":"2016-09-26 14:51:55.000000000","message":"nit: Extra line here","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"232b0c0c32ed0ffcef6b72b3d1c27a91897af483","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def get_mtu(self, physical_network\u003dNone):"},{"line_number":83,"context_line":"        mtu \u003d super(GeneveTypeDriver, self).get_mtu()"},{"line_number":84,"context_line":"        return mtu - self.max_encap_size if mtu else 0"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_4c75d5c8","line":85,"in_reply_to":"5a8bc5a2_3fd0f6f5","updated":"2016-09-27 15:23:45.000000000","message":"+1","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"12f66100c47cb9e23dc555ff28e74a7d5b1c110c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def get_mtu(self, physical_network\u003dNone):"},{"line_number":83,"context_line":"        mtu \u003d super(GeneveTypeDriver, self).get_mtu()"},{"line_number":84,"context_line":"        return mtu - self.max_encap_size if mtu else 0"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_2e0b057f","line":85,"in_reply_to":"5a8bc5a2_3fd0f6f5","updated":"2016-09-28 01:31:46.000000000","message":"Done","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"12f66100c47cb9e23dc555ff28e74a7d5b1c110c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def get_mtu(self, physical_network\u003dNone):"},{"line_number":83,"context_line":"        mtu \u003d super(GeneveTypeDriver, self).get_mtu()"},{"line_number":84,"context_line":"        return mtu - self.max_encap_size if mtu else 0"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_4e1051a9","line":85,"in_reply_to":"5a8bc5a2_4c75d5c8","updated":"2016-09-28 01:31:46.000000000","message":"Done","commit_id":"c1ae31f263f445cdaecfb9e862028a478431aead"}]}