)]}'
{"neutron/db/models/gre_allocation_endpoints.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"609740553e3703a123f82006ca4d9a4865df9cbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_841bf41a","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-16 08:54:05.000000000","message":"Please remove useless lines.","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"39dce1bf969f74ced00da328c17b39969d2b336f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f90a9b78","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"3ac371cc_841bf41a","updated":"2016-08-18 18:59:13.000000000","message":"?","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"7d2861fa9c0f528e40602ad4bdf05d1bb90dd9cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_81f16d98","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"3ac371cc_f90a9b78","updated":"2016-08-18 20:00:14.000000000","message":"My bad. I thought I had replied to this. I copied the copyright from the original file where the model was defined. But I did not copy it correctly so fixing it now.","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"609740553e3703a123f82006ca4d9a4865df9cbb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.db import model_base"},{"line_number":17,"context_line":"import sqlalchemy as sa"},{"line_number":18,"context_line":"from sqlalchemy import sql"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class GreAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_446e1c30","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":26},"updated":"2016-08-16 08:54:05.000000000","message":"The sqlalchemy is third-party lib and the neutron.db is project so please move \"from neutron.db import model_base\" below.\n\nhttp://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"296229ed93c3a6f2411c24f40374c511c8ab5900","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.db import model_base"},{"line_number":17,"context_line":"import sqlalchemy as sa"},{"line_number":18,"context_line":"from sqlalchemy import sql"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class GreAllocation(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_4b1c4b77","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":26},"in_reply_to":"3ac371cc_446e1c30","updated":"2016-08-16 18:03:29.000000000","message":"Done","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b2e031ec4ea215a5a97af386c15bf19ead23cd43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ac371cc_5d9a9bc6","updated":"2016-08-19 09:06:13.000000000","message":"This model is specific to ML2 and the corresponding table name is ml2_gre_allocations. How about creating ml2 directory and place this model in ml2 directory? It clarifies it is related to ml2 plugin.","commit_id":"78d61dfc3e7fd1b03d417878abdc67f3da4ef207"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"d815470715b07a967bc8fda31d02e646539189e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_c376b73d","in_reply_to":"1ac06dbe_6fafefe3","updated":"2016-08-19 17:54:22.000000000","message":"Agree. Will make the change. Thanks all.","commit_id":"78d61dfc3e7fd1b03d417878abdc67f3da4ef207"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"c7c786322537b8d90a16a7b8308230aa8aa818ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_6fafefe3","in_reply_to":"1ac06dbe_db7d09e9","updated":"2016-08-19 15:06:37.000000000","message":"FYI - This change affects the current documentation that we have.  Ankur has created a patch[1] for this.\n\n[1] https://review.openstack.org/357947","commit_id":"78d61dfc3e7fd1b03d417878abdc67f3da4ef207"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"be38a32320b9e13bd33084cd8f437154674920dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_db7d09e9","in_reply_to":"3ac371cc_5d9a9bc6","updated":"2016-08-19 14:24:49.000000000","message":"Yeah, we should probably give ml2 an exception because otherwise we loose some context. Alternatively, all ml2 stuff should start with ml2_.","commit_id":"78d61dfc3e7fd1b03d417878abdc67f3da4ef207"}],"neutron/db/models/plugins/ml2/gre_allocation_endpoints.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"66e2526e56592225656a1801bde71885cd899a41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_3711f25d","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":21},"updated":"2016-08-24 08:15:47.000000000","message":"6?","commit_id":"d7e6ce8a6ef31dc47db915d9e9186583f16daf6b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f71205fef38d6b5e2f8bb4954994bfd65aa81717","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_d5946de9","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":21},"in_reply_to":"1ac06dbe_29ddb242","updated":"2016-08-25 14:31:06.000000000","message":"This patch just moves the model, so I think it is reasonable to keep the riginal copyright.","commit_id":"d7e6ce8a6ef31dc47db915d9e9186583f16daf6b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"335482813d73f443cd45113539745a6457d65371","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_29ddb242","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":21},"in_reply_to":"1ac06dbe_3711f25d","updated":"2016-08-25 13:35:18.000000000","message":"Well, this was taken from the original file[1]\n\n[1] https://review.openstack.org/#/c/355643/6/neutron/plugins/ml2/drivers/type_gre.py@1","commit_id":"d7e6ce8a6ef31dc47db915d9e9186583f16daf6b"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"09bafbb00f3bd11615b4c138a1dddcb881c8f7ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_b87c3c73","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":21},"in_reply_to":"1ac06dbe_d5946de9","updated":"2016-08-25 16:58:53.000000000","message":"@victor - Yes","commit_id":"d7e6ce8a6ef31dc47db915d9e9186583f16daf6b"}],"neutron/plugins/ml2/drivers/type_gre.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"609740553e3703a123f82006ca4d9a4865df9cbb","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron._i18n import _, _LE"},{"line_number":22,"context_line":"from neutron.common import _deprecate"},{"line_number":23,"context_line":"from neutron.db.models import gre_allocation_endpoints as gre"},{"line_number":24,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":25,"context_line":"from neutron.plugins.ml2.drivers import type_tunnel"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_64ffd8aa","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":61},"updated":"2016-08-16 08:54:05.000000000","message":"The \"gre\" is too general so I prefer gre_db or gre_model.","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"296229ed93c3a6f2411c24f40374c511c8ab5900","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron._i18n import _, _LE"},{"line_number":22,"context_line":"from neutron.common import _deprecate"},{"line_number":23,"context_line":"from neutron.db.models import gre_allocation_endpoints as gre"},{"line_number":24,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":25,"context_line":"from neutron.plugins.ml2.drivers import type_tunnel"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_eb0d373f","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":61},"in_reply_to":"3ac371cc_64ffd8aa","updated":"2016-08-16 18:03:29.000000000","message":"Done","commit_id":"a0d148ad4dc2a8c9f5e8c5cc617ffc9aab8a820b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f88c8bbbcb7151a4182c0254385cb28deff3a866","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_53807546","line":15,"updated":"2016-08-16 21:51:57.000000000","message":"nit: a break line before this import.","commit_id":"bd1480d0cbec498218e3a718d896014bc480fb7f"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"7f53aa8702c6738e0b3636c32245c38a974ba2f7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b7b1d249","line":15,"in_reply_to":"3ac371cc_53807546","updated":"2016-08-16 23:22:39.000000000","message":"Done","commit_id":"bd1480d0cbec498218e3a718d896014bc480fb7f"}]}