)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"04a1fe64f7a8b09cb8905115742a83a4d35b2eb0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To avoid the issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for PortBindingPort"},{"line_number":11,"context_line":"which has db models and mixins in the same file,"},{"line_number":12,"context_line":"this patch will refactor PortBindingPort models."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa7ab95a_3e6882f5","line":9,"updated":"2016-08-26 12:48:28.000000000","message":"there won\u0027t be an object for the model, we don\u0027t use PortBindingMixin anywhere.","commit_id":"b56cb65979cc738bb68758f0defb34a67cfe07ac"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f6ceb8233d840ae4785ac8189b81f7ed1366fcd4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_e098d0c2","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":79},"updated":"2016-08-29 14:11:37.000000000","message":"nit: exceeds description limit","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e591119ac1fa6fa452a43cdd301cf9374e8a193a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_a6334061","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":79},"in_reply_to":"fa7ab95a_e098d0c2","updated":"2016-08-29 14:34:47.000000000","message":"Done","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f6ceb8233d840ae4785ac8189b81f7ed1366fcd4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_00969492","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":76},"updated":"2016-08-29 14:11:37.000000000","message":"ditto: line 9","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e591119ac1fa6fa452a43cdd301cf9374e8a193a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_e641c8aa","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":76},"in_reply_to":"fa7ab95a_00969492","updated":"2016-08-29 14:34:47.000000000","message":"Done","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f6ceb8233d840ae4785ac8189b81f7ed1366fcd4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_208f1876","line":11,"range":{"start_line":11,"start_character":72,"end_line":11,"end_character":78},"updated":"2016-08-29 14:11:37.000000000","message":"ditto: line 9","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e591119ac1fa6fa452a43cdd301cf9374e8a193a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_8619dcd9","line":11,"range":{"start_line":11,"start_character":72,"end_line":11,"end_character":78},"in_reply_to":"fa7ab95a_208f1876","updated":"2016-08-29 14:34:47.000000000","message":"Done","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f6ceb8233d840ae4785ac8189b81f7ed1366fcd4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_408c1c7f","line":12,"range":{"start_line":12,"start_character":72,"end_line":12,"end_character":77},"updated":"2016-08-29 14:11:37.000000000","message":"ditto: line 9","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e591119ac1fa6fa452a43cdd301cf9374e8a193a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_a60a6077","line":12,"range":{"start_line":12,"start_character":72,"end_line":12,"end_character":77},"in_reply_to":"fa7ab95a_408c1c7f","updated":"2016-08-29 14:34:47.000000000","message":"Done","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f6ceb8233d840ae4785ac8189b81f7ed1366fcd4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5728fea38816b7e500eaa836d5c5dadef51457f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_60ebe013","line":13,"range":{"start_line":13,"start_character":72,"end_line":13,"end_character":77},"updated":"2016-08-29 14:11:37.000000000","message":"ditto: line 9","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"e591119ac1fa6fa452a43cdd301cf9374e8a193a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5728fea38816b7e500eaa836d5c5dadef51457f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_c60f6486","line":13,"range":{"start_line":13,"start_character":72,"end_line":13,"end_character":77},"in_reply_to":"fa7ab95a_60ebe013","updated":"2016-08-29 14:34:47.000000000","message":"Done","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f6ceb8233d840ae4785ac8189b81f7ed1366fcd4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5728fea38816b7e500eaa836d5c5dadef51457f7"},{"line_number":17,"context_line":"Partial-Bug: #1597913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_c0e02cfd","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":6},"updated":"2016-08-29 14:11:37.000000000","message":"Not sure if those lines are necessary given that plans haven\u0027t defined yet.","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b65f215c72d48fe0507efc97a7dba4e56826f00a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate PortBindingPort DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves PortBindingPort model under neutron/db/models for consistency."},{"line_number":10,"context_line":"There are no plans to implement an OVO object for the model at this point in"},{"line_number":11,"context_line":"time. Actually, the model should probably eventually go away from Neutron tree"},{"line_number":12,"context_line":"since it\u0027s not used by reference plugin, and is just a remnant from the times"},{"line_number":13,"context_line":"when the neutron tree contained lots of plugins, some of which were using the"},{"line_number":14,"context_line":"model."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I5728fea38816b7e500eaa836d5c5dadef51457f7"},{"line_number":17,"context_line":"Partial-Bug: #1597913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_69766ba5","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":6},"in_reply_to":"fa7ab95a_c0e02cfd","updated":"2016-08-29 14:39:47.000000000","message":"This is to clarify that the trigger for the move is keeping consistency with other models, not a definite plan to implement an object for the model (as it was stated in previous version of the patch).","commit_id":"f1cf9d467ed1e9d64900e471664100610e9f5271"}],"neutron/db/models/portbindings.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3d38ace5745b0b8302a78e89da3e6d7a163fec72","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import model_base"},{"line_number":19,"context_line":"from neutron.db import models_v2"},{"line_number":20,"context_line":"from sqlalchemy import orm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PortBindingPort(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_a7d6f224","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":26},"updated":"2016-08-16 09:05:27.000000000","message":"Please divide third-party lib and project import in accordance with http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"15f7cc0d1a9d8d68f778d5f562eb598a852b6fe0"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"343db1d72b5cb25b5f0ef71821edc25b357052a9","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import model_base"},{"line_number":19,"context_line":"from neutron.db import models_v2"},{"line_number":20,"context_line":"from sqlalchemy import orm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PortBindingPort(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_ad7d1e70","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":26},"in_reply_to":"3ac371cc_a7d6f224","updated":"2016-08-18 15:04:22.000000000","message":"Done","commit_id":"15f7cc0d1a9d8d68f778d5f562eb598a852b6fe0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d871335d0aabdea61c5f9c93c0648509dde3a5c5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from sqlalchemy import orm"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.db import model_base"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_0eaa0519","line":17,"updated":"2016-08-18 05:43:43.000000000","message":"This empty line is unnecessary.","commit_id":"a3d0020a8a00ab37434c2027001e1e365fe56d88"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"615fb517c6c8be1e7bfe8487209660670dbfe1e4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from sqlalchemy import orm"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.db import model_base"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_4c3fc1b3","line":17,"in_reply_to":"3ac371cc_0eaa0519","updated":"2016-08-18 15:04:41.000000000","message":"Done","commit_id":"a3d0020a8a00ab37434c2027001e1e365fe56d88"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"1d96a9c02c7d4e70fcf875c8b209af4780f7fd31","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.db import model_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import sqlalchemy as sa"},{"line_number":19,"context_line":"from sqlalchemy import orm"}],"source_content_type":"text/x-python","patch_set":10,"id":"da7fb54a_30dd3671","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":37},"updated":"2016-09-02 16:34:30.000000000","message":"this import should be with third party library imports [1]\nAn example can be found in [2]\n[1] http://docs.openstack.org/developer/hacking/#import-order-template\n\n[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_geneve.py#L16\nOther than this, it looks good","commit_id":"074c417014e68dbd41c44f3a03a35f74c92ca2d7"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"b87dde50227287cd7d199b650cb9d8e80ec636ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.db import model_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import sqlalchemy as sa"},{"line_number":19,"context_line":"from sqlalchemy import orm"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_392771b7","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":37},"in_reply_to":"da7fb54a_30dd3671","updated":"2016-09-06 16:39:08.000000000","message":"Done","commit_id":"074c417014e68dbd41c44f3a03a35f74c92ca2d7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1573035b012cc1b203736a8aa2d0b8d8cea4dac5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_9b99a771","line":1,"updated":"2016-09-22 16:02:36.000000000","message":"the naming convention is to have modules use singular form for their names.","commit_id":"0543bf9cfb79d9db2d3c6ff9fb46309e5f9e4ade"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"1d9846426ad4cc483c7cb7a525edb96074febf26","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_35db367e","line":1,"in_reply_to":"5a8bc5a2_9b99a771","updated":"2016-09-22 19:36:57.000000000","message":"Done","commit_id":"0543bf9cfb79d9db2d3c6ff9fb46309e5f9e4ade"}],"neutron/db/portbindings_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3d38ace5745b0b8302a78e89da3e6d7a163fec72","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.api.v2 import attributes"},{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":23,"context_line":"from neutron.db.models import portbindings as port_bindings"},{"line_number":24,"context_line":"from neutron.db import models_v2"},{"line_number":25,"context_line":"from neutron.db import portbindings_base"},{"line_number":26,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_e7ae2a97","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":59},"updated":"2016-08-16 09:05:27.000000000","message":"I prefer portbindings_model.","commit_id":"15f7cc0d1a9d8d68f778d5f562eb598a852b6fe0"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"343db1d72b5cb25b5f0ef71821edc25b357052a9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.api.v2 import attributes"},{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":23,"context_line":"from neutron.db.models import portbindings as port_bindings"},{"line_number":24,"context_line":"from neutron.db import models_v2"},{"line_number":25,"context_line":"from neutron.db import portbindings_base"},{"line_number":26,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8df782f4","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":59},"in_reply_to":"3ac371cc_e7ae2a97","updated":"2016-08-18 15:04:22.000000000","message":"Done","commit_id":"15f7cc0d1a9d8d68f778d5f562eb598a852b6fe0"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"fcee11e0f6b1fa8c304322df2e2ef4d2a1dcb94c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            if host_set:"},{"line_number":76,"context_line":"                if not bind_port:"},{"line_number":77,"context_line":"                    context.session.add(portbindings_model.PortBindingPort"},{"line_number":78,"context_line":"                                       (port_id\u003dport[\u0027id\u0027],"},{"line_number":79,"context_line":"                                        host\u003dhost))"},{"line_number":80,"context_line":"                else:"},{"line_number":81,"context_line":"                    bind_port.host \u003d host"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_5bf599c9","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":59},"updated":"2016-08-24 15:50:07.000000000","message":"nit: should this be indented by one more space?","commit_id":"b56cb65979cc738bb68758f0defb34a67cfe07ac"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7f3d36f75196ae135078dcf582d408d16c221cd1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            if host_set:"},{"line_number":76,"context_line":"                if not bind_port:"},{"line_number":77,"context_line":"                    context.session.add(portbindings_model.PortBindingPort"},{"line_number":78,"context_line":"                                       (port_id\u003dport[\u0027id\u0027],"},{"line_number":79,"context_line":"                                        host\u003dhost))"},{"line_number":80,"context_line":"                else:"},{"line_number":81,"context_line":"                    bind_port.host \u003d host"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_5681c649","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":59},"in_reply_to":"1ac06dbe_5bf599c9","updated":"2016-08-26 04:46:12.000000000","message":"this can actually be indented 4 spaces from above line, it is actually a call to create a new object. and host\u003dhost can be accomodated in same line as long as it does not exceed 79 characters.","commit_id":"b56cb65979cc738bb68758f0defb34a67cfe07ac"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"671f88dfd137ad767d03cdd9438facb4dcde2c37","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            if host_set:"},{"line_number":76,"context_line":"                if not bind_port:"},{"line_number":77,"context_line":"                    context.session.add(portbindings_model.PortBindingPort"},{"line_number":78,"context_line":"                                       (port_id\u003dport[\u0027id\u0027],"},{"line_number":79,"context_line":"                                        host\u003dhost))"},{"line_number":80,"context_line":"                else:"},{"line_number":81,"context_line":"                    bind_port.host \u003d host"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_dee5d6a8","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":59},"in_reply_to":"fa7ab95a_5681c649","updated":"2016-08-26 12:47:47.000000000","message":"Done","commit_id":"b56cb65979cc738bb68758f0defb34a67cfe07ac"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7f3d36f75196ae135078dcf582d408d16c221cd1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":88,"context_line":"            bind_port \u003d context.session.query("},{"line_number":89,"context_line":"                portbindings_model.PortBindingPort).filter_by("},{"line_number":90,"context_line":"                port_id\u003dport_id).first()"},{"line_number":91,"context_line":"            return bind_port.host if bind_port else None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _extend_port_dict_binding_host(self, port_res, host):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_b6905297","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":40},"updated":"2016-08-26 04:46:12.000000000","message":"indent 4 spaces from above line for better readability","commit_id":"b56cb65979cc738bb68758f0defb34a67cfe07ac"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"671f88dfd137ad767d03cdd9438facb4dcde2c37","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":88,"context_line":"            bind_port \u003d context.session.query("},{"line_number":89,"context_line":"                portbindings_model.PortBindingPort).filter_by("},{"line_number":90,"context_line":"                port_id\u003dport_id).first()"},{"line_number":91,"context_line":"            return bind_port.host if bind_port else None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _extend_port_dict_binding_host(self, port_res, host):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_fee29a9e","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":40},"in_reply_to":"fa7ab95a_b6905297","updated":"2016-08-26 12:47:47.000000000","message":"Done","commit_id":"b56cb65979cc738bb68758f0defb34a67cfe07ac"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4eaf69f1d22597fbb828d2a9fb2e68bf951cc9f0","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":113,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":114,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), pmodel)"},{"line_number":115,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_32c51c5b","line":114,"updated":"2016-08-31 12:33:52.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"a3708908c3d22c4738ab92ed3eec11af6a55374a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1573035b012cc1b203736a8aa2d0b8d8cea4dac5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.api.v2 import attributes"},{"line_number":19,"context_line":"from neutron.common import _deprecate"},{"line_number":20,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":21,"context_line":"from neutron.db.models import portbindings as pmodels"},{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":"from neutron.db import portbindings_base"},{"line_number":24,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_1bc5973b","line":21,"range":{"start_line":21,"start_character":46,"end_line":21,"end_character":53},"updated":"2016-09-22 16:02:36.000000000","message":"pb_model?","commit_id":"0543bf9cfb79d9db2d3c6ff9fb46309e5f9e4ade"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1573035b012cc1b203736a8aa2d0b8d8cea4dac5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def _port_model_hook(self, context, original_model, query):"},{"line_number":34,"context_line":"        query \u003d query.outerjoin("},{"line_number":35,"context_line":"            pmodels.PortBindingPort,"},{"line_number":36,"context_line":"            (original_model.id \u003d\u003d pmodels.PortBindingPort.port_id))"},{"line_number":37,"context_line":"        return query"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _port_result_filter_hook(self, query, filters):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_fb3c6b31","line":36,"updated":"2016-09-22 16:02:36.000000000","message":"(No action required) it\u0027s better indeed","commit_id":"0543bf9cfb79d9db2d3c6ff9fb46309e5f9e4ade"}]}