)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a72dfdcf0f80b664e75834e3404d85148b1e645e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for l3agentbinding which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor l3agentbinding models."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idef2fe3e16b245da849e2d29c5578e5f5d081dc4"},{"line_number":15,"context_line":"Partial-Bug: #1597913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a8bc5a2_d0a30e9d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"updated":"2016-09-22 15:53:01.000000000","message":"relocate","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d24e3311b69b6046aab5a5069a600f57a9dd9106","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for l3agentbinding which has"},{"line_number":11,"context_line":"db models definition and mixins in same file, this patch will"},{"line_number":12,"context_line":"refactor l3agentbinding models."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idef2fe3e16b245da849e2d29c5578e5f5d081dc4"},{"line_number":15,"context_line":"Partial-Bug: #1597913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a8bc5a2_4379f192","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"in_reply_to":"5a8bc5a2_d0a30e9d","updated":"2016-09-22 17:31:37.000000000","message":"Done","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"36d06e54f0a33acea79d29e6fed07f88161d5da5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from sqlalchemy import orm"},{"line_number":27,"context_line":"from sqlalchemy.orm import joinedload"},{"line_number":28,"context_line":"from sqlalchemy import sql"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from neutron._i18n import _, _LI"},{"line_number":32,"context_line":"from neutron.common import _deprecate"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f2b426f3","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":10},"updated":"2016-08-16 09:24:06.000000000","message":"Please divide third-party lib and stdlib import in accordance with http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cded1c71f1d605d8c729757da852e0c3d3286de0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from sqlalchemy import orm"},{"line_number":27,"context_line":"from sqlalchemy.orm import joinedload"},{"line_number":28,"context_line":"from sqlalchemy import sql"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from neutron._i18n import _, _LI"},{"line_number":32,"context_line":"from neutron.common import _deprecate"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_ee0b4c22","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":10},"in_reply_to":"3ac371cc_f2b426f3","updated":"2016-08-17 16:42:50.000000000","message":"Done","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"20f00f65c671677fd83c7a78bcbbd6a7bcf6ec00","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":547,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":548,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(),"},{"line_number":549,"context_line":"                                                   router_binding_model)"},{"line_number":550,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_4d81214d","line":548,"updated":"2016-08-31 12:43:43.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"2e7d36cfc2dc8002e7ee2453da5f0a6917752104"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a72dfdcf0f80b664e75834e3404d85148b1e645e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":36,"context_line":"from neutron.db.models import router_l3agent_binding as router_binding_model"},{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":39,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_70e23ad7","line":36,"range":{"start_line":36,"start_character":56,"end_line":36,"end_character":76},"updated":"2016-09-22 15:53:01.000000000","message":"could you please choose something shorter? like \u0027rb_model\u0027? long names are not nice in code.","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d24e3311b69b6046aab5a5069a600f57a9dd9106","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":36,"context_line":"from neutron.db.models import router_l3agent_binding as router_binding_model"},{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":39,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_a368f5bb","line":36,"range":{"start_line":36,"start_character":56,"end_line":36,"end_character":76},"in_reply_to":"5a8bc5a2_70e23ad7","updated":"2016-09-22 17:31:37.000000000","message":"Done","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a72dfdcf0f80b664e75834e3404d85148b1e645e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":107,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":108,"context_line":"            return (context.session.query("},{"line_number":109,"context_line":"                    router_binding_model.RouterL3AgentBinding)."},{"line_number":110,"context_line":"                    join(agents_db.Agent)."},{"line_number":111,"context_line":"                    filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":112,"context_line":"                    agents_db.Agent.admin_state_up)."}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_b0bbe271","line":109,"updated":"2016-09-22 15:53:01.000000000","message":"most changes here and below that require another line to fit in could be avoided if you would choose a shorter name for the module. Consider my suggestion to put the model into l3agent.py","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d24e3311b69b6046aab5a5069a600f57a9dd9106","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    def get_down_router_bindings(self, context, agent_dead_limit):"},{"line_number":107,"context_line":"            cutoff \u003d self.get_cutoff_time(agent_dead_limit)"},{"line_number":108,"context_line":"            return (context.session.query("},{"line_number":109,"context_line":"                    router_binding_model.RouterL3AgentBinding)."},{"line_number":110,"context_line":"                    join(agents_db.Agent)."},{"line_number":111,"context_line":"                    filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":112,"context_line":"                    agents_db.Agent.admin_state_up)."}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_239b05cb","line":109,"in_reply_to":"5a8bc5a2_b0bbe271","updated":"2016-09-22 17:31:37.000000000","message":"Done","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"36d06e54f0a33acea79d29e6fed07f88161d5da5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":34,"context_line":"from neutron.db import l3_db"},{"line_number":35,"context_line":"from neutron.db.models import allowed_address_pair as aap_models"},{"line_number":36,"context_line":"from neutron.db.models import router_l3agent_binding as l3_sched_db"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.extensions import l3"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_d2864ada","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":67},"updated":"2016-08-16 09:24:06.000000000","message":"The \"l3_sched_db\" is not suitable. It\u0027s for l3_agentschedulers_db.","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cded1c71f1d605d8c729757da852e0c3d3286de0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":34,"context_line":"from neutron.db import l3_db"},{"line_number":35,"context_line":"from neutron.db.models import allowed_address_pair as aap_models"},{"line_number":36,"context_line":"from neutron.db.models import router_l3agent_binding as l3_sched_db"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.extensions import l3"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_0e5508f9","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":67},"in_reply_to":"3ac371cc_d2864ada","updated":"2016-08-17 16:42:50.000000000","message":"Done","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f0bcfd4a68ef2a298df022898f02becddf264776","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":26,"context_line":"from neutron.db import l3_agentschedulers_db as l3agent_sch_db"},{"line_number":27,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":28,"context_line":"     as router_binding_model"},{"line_number":29,"context_line":"from neutron.db import models_v2"},{"line_number":30,"context_line":"from neutron.extensions import portbindings"},{"line_number":31,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_5bed7024","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":28},"updated":"2016-08-25 05:18:09.000000000","message":"nit: It seems the new line is not needed. Actually it\u0027s not in neutron/db/l3_dvr_db.py.","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"eef01b20184b7520f5b4bc154326b0ee99c83138","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":26,"context_line":"from neutron.db import l3_agentschedulers_db as l3agent_sch_db"},{"line_number":27,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":28,"context_line":"     as router_binding_model"},{"line_number":29,"context_line":"from neutron.db import models_v2"},{"line_number":30,"context_line":"from neutron.extensions import portbindings"},{"line_number":31,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_7bdd9e13","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":28},"in_reply_to":"1ac06dbe_5bed7024","updated":"2016-08-25 17:32:09.000000000","message":"Done","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"}],"neutron/db/l3_hascheduler_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"36d06e54f0a33acea79d29e6fed07f88161d5da5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":21,"context_line":"from neutron.db import l3_db"},{"line_number":22,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":23,"context_line":"     as bind_l3"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_9215f29c","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":15},"updated":"2016-08-16 09:24:06.000000000","message":"How about \"router_binding_model\"?","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cded1c71f1d605d8c729757da852e0c3d3286de0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":21,"context_line":"from neutron.db import l3_db"},{"line_number":22,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":23,"context_line":"     as bind_l3"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_ce75b098","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":15},"in_reply_to":"3ac371cc_9215f29c","updated":"2016-08-17 16:42:50.000000000","message":"Done","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f0bcfd4a68ef2a298df022898f02becddf264776","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.db import l3_agentschedulers_db as l3_sch_db"},{"line_number":20,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":21,"context_line":"from neutron.db import l3_db"},{"line_number":22,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":23,"context_line":"     as router_binding_model"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_5b78d08f","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":28},"updated":"2016-08-25 05:18:09.000000000","message":"nit: It seems the new line is not needed. Actually it\u0027s not in neutron/db/l3_dvr_db.py.","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"eef01b20184b7520f5b4bc154326b0ee99c83138","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.db import l3_agentschedulers_db as l3_sch_db"},{"line_number":20,"context_line":"from neutron.db import l3_attrs_db"},{"line_number":21,"context_line":"from neutron.db import l3_db"},{"line_number":22,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":23,"context_line":"     as router_binding_model"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_fbd18efc","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":28},"in_reply_to":"1ac06dbe_5b78d08f","updated":"2016-08-25 17:32:09.000000000","message":"Done","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"}],"neutron/db/models/router_l3agent_binding.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"36d06e54f0a33acea79d29e6fed07f88161d5da5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_3297de91","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2016-08-16 09:24:06.000000000","message":"Please remove useless lines.","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cded1c71f1d605d8c729757da852e0c3d3286de0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_0d806bbf","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"3ac371cc_3297de91","updated":"2016-08-17 16:42:50.000000000","message":"Done","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"36d06e54f0a33acea79d29e6fed07f88161d5da5","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import sqlalchemy as sa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.db import agents_db"},{"line_number":20,"context_line":"from neutron.db import model_base"},{"line_number":21,"context_line":"from sqlalchemy import orm"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RouterL3AgentBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_d2448a1c","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":26},"updated":"2016-08-16 09:24:06.000000000","message":"Please divide third-party lib and project import in accordance with http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cded1c71f1d605d8c729757da852e0c3d3286de0","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import sqlalchemy as sa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.db import agents_db"},{"line_number":20,"context_line":"from neutron.db import model_base"},{"line_number":21,"context_line":"from sqlalchemy import orm"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RouterL3AgentBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_4d86e3db","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":26},"in_reply_to":"3ac371cc_d2448a1c","updated":"2016-08-17 16:42:50.000000000","message":"Done","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a72dfdcf0f80b664e75834e3404d85148b1e645e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_30f0b290","line":2,"updated":"2016-09-22 15:53:01.000000000","message":"I don\u0027t think this model should have a separate module for itself. I believe it\u0027s better to keep it in a file with a name like \u0027l3agent\u0027 that would also contain other agent related models.","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d24e3311b69b6046aab5a5069a600f57a9dd9106","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_43ee5123","line":2,"in_reply_to":"5a8bc5a2_30f0b290","updated":"2016-09-22 17:31:37.000000000","message":"Done","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a72dfdcf0f80b664e75834e3404d85148b1e645e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from sqlalchemy import orm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.db import agents_db"},{"line_number":18,"context_line":"from neutron.db import model_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOWEST_BINDING_INDEX \u003d 1"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_90350648","line":18,"range":{"start_line":18,"start_character":23,"end_line":18,"end_character":33},"updated":"2016-09-22 15:53:01.000000000","message":"this should be from neutron-lib.","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d24e3311b69b6046aab5a5069a600f57a9dd9106","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from sqlalchemy import orm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.db import agents_db"},{"line_number":18,"context_line":"from neutron.db import model_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOWEST_BINDING_INDEX \u003d 1"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_63f34d0b","line":18,"range":{"start_line":18,"start_character":23,"end_line":18,"end_character":33},"in_reply_to":"5a8bc5a2_90350648","updated":"2016-09-22 17:31:37.000000000","message":"Done","commit_id":"bc2988ffc047b3969aa6c71621808382534624d0"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"36d06e54f0a33acea79d29e6fed07f88161d5da5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.db import api as db_api"},{"line_number":33,"context_line":"from neutron.db import l3_db"},{"line_number":34,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":35,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":36,"context_line":"     as l3_agentschedulers_db"},{"line_number":37,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":38,"context_line":"from neutron.extensions import l3"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_92633241","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":29},"updated":"2016-08-16 09:24:06.000000000","message":"The \"l3_agentschedulers_db\" is not suitable. Please use suitable name.","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cded1c71f1d605d8c729757da852e0c3d3286de0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.db import api as db_api"},{"line_number":33,"context_line":"from neutron.db import l3_db"},{"line_number":34,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":35,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":36,"context_line":"     as l3_agentschedulers_db"},{"line_number":37,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":38,"context_line":"from neutron.extensions import l3"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8d6c5b36","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":29},"in_reply_to":"3ac371cc_92633241","updated":"2016-08-17 16:42:50.000000000","message":"Done","commit_id":"4d0996b23789e1fac87197afa5ff4e4a51bde787"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f0bcfd4a68ef2a298df022898f02becddf264776","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.db import api as db_api"},{"line_number":33,"context_line":"from neutron.db import l3_db"},{"line_number":34,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":35,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":36,"context_line":"     as binding_model"},{"line_number":37,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":38,"context_line":"from neutron.extensions import l3"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_7b366cb5","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":21},"updated":"2016-08-25 05:18:09.000000000","message":"It\u0027s better to use \"router_binding_model\" for consistency. And the new line is not needed.","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"eef01b20184b7520f5b4bc154326b0ee99c83138","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.db import api as db_api"},{"line_number":33,"context_line":"from neutron.db import l3_db"},{"line_number":34,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":35,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":36,"context_line":"     as binding_model"},{"line_number":37,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":38,"context_line":"from neutron.extensions import l3"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_bbfef668","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":21},"in_reply_to":"1ac06dbe_7b366cb5","updated":"2016-08-25 17:32:09.000000000","message":"Done","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"}],"neutron/tests/unit/db/test_agentschedulers_db.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f0bcfd4a68ef2a298df022898f02becddf264776","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron import context"},{"line_number":34,"context_line":"from neutron.db import agents_db"},{"line_number":35,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":36,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":37,"context_line":"     as router_binding_model"},{"line_number":38,"context_line":"from neutron.extensions import agent"},{"line_number":39,"context_line":"from neutron.extensions import dhcpagentscheduler"},{"line_number":40,"context_line":"from neutron.extensions import l3agentscheduler"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_3be7d441","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":28},"updated":"2016-08-25 05:18:09.000000000","message":"nit: It seems the new line is not needed. Actually it\u0027s not in neutron/db/l3_dvr_db.py.","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"eef01b20184b7520f5b4bc154326b0ee99c83138","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron import context"},{"line_number":34,"context_line":"from neutron.db import agents_db"},{"line_number":35,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":36,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":37,"context_line":"     as router_binding_model"},{"line_number":38,"context_line":"from neutron.extensions import agent"},{"line_number":39,"context_line":"from neutron.extensions import dhcpagentscheduler"},{"line_number":40,"context_line":"from neutron.extensions import l3agentscheduler"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_dbabf21c","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":28},"in_reply_to":"1ac06dbe_3be7d441","updated":"2016-08-25 17:32:09.000000000","message":"Done","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f0bcfd4a68ef2a298df022898f02becddf264776","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.db import l3_dvrscheduler_db"},{"line_number":35,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":36,"context_line":"from neutron.db import l3_hascheduler_db"},{"line_number":37,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":38,"context_line":"     as router_binding_model"},{"line_number":39,"context_line":"from neutron.extensions import l3"},{"line_number":40,"context_line":"from neutron.extensions import l3_ext_ha_mode as l3_ha"},{"line_number":41,"context_line":"from neutron.extensions import l3agentscheduler as l3agent"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_5bd45046","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":28},"updated":"2016-08-25 05:18:09.000000000","message":"nit: It seems the new line is not needed. Actually it\u0027s not in neutron/db/l3_dvr_db.py.","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"eef01b20184b7520f5b4bc154326b0ee99c83138","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.db import l3_dvrscheduler_db"},{"line_number":35,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":36,"context_line":"from neutron.db import l3_hascheduler_db"},{"line_number":37,"context_line":"from neutron.db.models import router_l3agent_binding \\"},{"line_number":38,"context_line":"     as router_binding_model"},{"line_number":39,"context_line":"from neutron.extensions import l3"},{"line_number":40,"context_line":"from neutron.extensions import l3_ext_ha_mode as l3_ha"},{"line_number":41,"context_line":"from neutron.extensions import l3agentscheduler as l3agent"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_bb9f1602","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":28},"in_reply_to":"1ac06dbe_5bd45046","updated":"2016-08-25 17:32:09.000000000","message":"Done","commit_id":"2b3e0fe3d562b15be2d92f995641b4079f395646"}]}
