)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d1065fc20aca7098afc5c47efc578ebc3a8698d3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"repository."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Nate Johnston \u003cNate_Johnston@cable.comcast.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iec36638a7a57cc14753e93c5d207853d4a3e3b6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_5377b49e","line":13,"updated":"2016-09-01 13:47:56.000000000","message":"depends-on?","commit_id":"31f23e18165ba187a752bf4ef072e7559923259d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ddc126b325cd342f6e6c58d7f24e44fc12dd1d8e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"repository."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Nate Johnston \u003cNate_Johnston@cable.comcast.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iec36638a7a57cc14753e93c5d207853d4a3e3b6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_397931fd","line":13,"in_reply_to":"fa7ab95a_5377b49e","updated":"2016-09-01 14:20:14.000000000","message":"Done","commit_id":"31f23e18165ba187a752bf4ef072e7559923259d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4f22b7d71be2d0df639f97fb4202560c5e9945af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove FWaaS policy.json entries"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The FWaaS policy.json entries are being relocated into the FWaaS"},{"line_number":10,"context_line":"repository."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Nate Johnston \u003cNate_Johnston@cable.comcast.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_78100aa9","line":9,"updated":"2016-09-06 20:40:47.000000000","message":"test file must match with the one in /etc","commit_id":"0be342245bb89ffa603e064ae8208d2f3821ef60"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"eac50db943a0d81bba9403d529c3e94ae52ebb26","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove FWaaS policy.json entries"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The FWaaS policy.json entries are being relocated into the FWaaS"},{"line_number":10,"context_line":"repository."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Nate Johnston \u003cNate_Johnston@cable.comcast.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_cfc6ad67","line":9,"in_reply_to":"9a89bdaa_78100aa9","updated":"2016-09-06 21:31:12.000000000","message":"Done","commit_id":"0be342245bb89ffa603e064ae8208d2f3821ef60"}],"etc/policy.json":[{"author":{"_account_id":5109,"name":"chandanc","email":"chandan.dutta.chowdhury@gmail.com","username":"chandanc"},"change_message_id":"5e18e835cd49838409f6c7f113b155b05939ed61","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"update_firewall_group:public\": \"rule:admin_only\","},{"line_number":150,"context_line":"    \"delete_firewall_group\": \"rule:admin_or_owner\","},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    \"create_firewall_policy_v2\": \"\","},{"line_number":153,"context_line":"    \"get_firewall_policy_v2\": \"rule:admin_or_owner or rule:public_firewall_policies\","},{"line_number":154,"context_line":"    \"create_firewall_policy_v2:public\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"update_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":156,"context_line":"    \"delete_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    \"create_firewall_rule_v2\": \"\","},{"line_number":159,"context_line":"    \"get_firewall_rule_v2\": \"rule:admin_or_owner or rule:public_firewall_rules\","},{"line_number":160,"context_line":"    \"update_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":161,"context_line":"    \"delete_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    \"create_qos_queue\": \"rule:admin_only\","},{"line_number":164,"context_line":"    \"get_qos_queue\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":1,"id":"3ac371cc_019a5663","line":161,"range":{"start_line":152,"start_character":0,"end_line":161,"end_character":53},"updated":"2016-08-16 08:34:53.000000000","message":"I don\u0027t think we can use _v2 appended to the resource name. Essentially the first string should be the API method name like (create|update|delete|get)_resource.","commit_id":"469bebab811523aef1e2f1af241de19a5aca5195"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f8bbe7ac00ed6068376b7e1ab1c9f90df20e631a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"update_firewall_group:public\": \"rule:admin_only\","},{"line_number":150,"context_line":"    \"delete_firewall_group\": \"rule:admin_or_owner\","},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    \"create_firewall_policy_v2\": \"\","},{"line_number":153,"context_line":"    \"get_firewall_policy_v2\": \"rule:admin_or_owner or rule:public_firewall_policies\","},{"line_number":154,"context_line":"    \"create_firewall_policy_v2:public\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"update_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":156,"context_line":"    \"delete_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    \"create_firewall_rule_v2\": \"\","},{"line_number":159,"context_line":"    \"get_firewall_rule_v2\": \"rule:admin_or_owner or rule:public_firewall_rules\","},{"line_number":160,"context_line":"    \"update_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":161,"context_line":"    \"delete_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    \"create_qos_queue\": \"rule:admin_only\","},{"line_number":164,"context_line":"    \"get_qos_queue\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":1,"id":"3ac371cc_219c9568","line":161,"range":{"start_line":152,"start_character":0,"end_line":161,"end_character":53},"in_reply_to":"3ac371cc_019a5663","updated":"2016-08-16 16:13:48.000000000","message":"Sridar explained it to me - we can reuse the same method names as FWaaS v1 uses.  The neutron.conf file points to the FWaaS plugin, which will either be the v1 plugin or the v2 plugin.  The plugin then makes sure the right version resources are pulled in through the \"supported_extension_aliases\" variable.  So the methods will all have the same names; it will be determined if they are v1 or v2 based on the back end.\n\nSo I think no changes to policy.json are needed.","commit_id":"469bebab811523aef1e2f1af241de19a5aca5195"},{"author":{"_account_id":5109,"name":"chandanc","email":"chandan.dutta.chowdhury@gmail.com","username":"chandanc"},"change_message_id":"f1b4a17a70376edc26b7e789c21afae5d96a2c7e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"update_firewall_group:public\": \"rule:admin_only\","},{"line_number":150,"context_line":"    \"delete_firewall_group\": \"rule:admin_or_owner\","},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    \"create_firewall_policy_v2\": \"\","},{"line_number":153,"context_line":"    \"get_firewall_policy_v2\": \"rule:admin_or_owner or rule:public_firewall_policies\","},{"line_number":154,"context_line":"    \"create_firewall_policy_v2:public\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"update_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":156,"context_line":"    \"delete_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    \"create_firewall_rule_v2\": \"\","},{"line_number":159,"context_line":"    \"get_firewall_rule_v2\": \"rule:admin_or_owner or rule:public_firewall_rules\","},{"line_number":160,"context_line":"    \"update_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":161,"context_line":"    \"delete_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    \"create_qos_queue\": \"rule:admin_only\","},{"line_number":164,"context_line":"    \"get_qos_queue\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":1,"id":"3ac371cc_6227acb6","line":161,"range":{"start_line":152,"start_character":0,"end_line":161,"end_character":53},"in_reply_to":"3ac371cc_219c9568","updated":"2016-08-16 16:41:06.000000000","message":"I agree, as policy and rule are common resource name across, v1 and v2 we can reuse the existing configuration in policy.json","commit_id":"469bebab811523aef1e2f1af241de19a5aca5195"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0c24c8d1d0bd0603fc3e6fb39782cebf8ced43b0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"update_firewall_group:public\": \"rule:admin_only\","},{"line_number":150,"context_line":"    \"delete_firewall_group\": \"rule:admin_or_owner\","},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    \"create_firewall_policy_v2\": \"\","},{"line_number":153,"context_line":"    \"get_firewall_policy_v2\": \"rule:admin_or_owner or rule:public_firewall_policies\","},{"line_number":154,"context_line":"    \"create_firewall_policy_v2:public\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"update_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":156,"context_line":"    \"delete_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    \"create_firewall_rule_v2\": \"\","},{"line_number":159,"context_line":"    \"get_firewall_rule_v2\": \"rule:admin_or_owner or rule:public_firewall_rules\","},{"line_number":160,"context_line":"    \"update_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":161,"context_line":"    \"delete_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    \"create_qos_queue\": \"rule:admin_only\","},{"line_number":164,"context_line":"    \"get_qos_queue\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":1,"id":"3ac371cc_22c0147b","line":161,"range":{"start_line":152,"start_character":0,"end_line":161,"end_character":53},"in_reply_to":"3ac371cc_6227acb6","updated":"2016-08-16 16:45:27.000000000","message":"Hi chandanc and Nate, thanks for your comment.  I\u0027ll fix it.","commit_id":"469bebab811523aef1e2f1af241de19a5aca5195"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"4c34187bf4a5bdef315ff2d747a753f01dc6c2ff","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    \"remove_rule\": \"rule:admin_or_owner\","},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    \"create_firewall_rule\": \"\","},{"line_number":140,"context_line":"    \"get_firewall_rule\": \"rule:admin_or_owner or rule:shared_firewall_rules or rule:public_firewall_rules\","},{"line_number":141,"context_line":"    \"update_firewall_rule\": \"rule:admin_or_owner\","},{"line_number":142,"context_line":"    \"delete_firewall_rule\": \"rule:admin_or_owner\","},{"line_number":143,"context_line":""}],"source_content_type":"application/json","patch_set":2,"id":"3ac371cc_42bef0d4","line":140,"range":{"start_line":140,"start_character":49,"end_line":140,"end_character":75},"updated":"2016-08-16 16:47:07.000000000","message":"I think previous definition is a bug.  Therefore, I\u0027ve changed from \u0027rule:shared_firewalls\u0027 to \u0027rule:shared_firewall_rules\u0027.","commit_id":"7632904e81e9231b5ceb80c85d0e81e6ad556f28"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"db1e85b084dc509a88b284a8ed70d239555268a8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"shared_firewall_policies\": \"field:firewall_policies:shared\u003dTrue\","},{"line_number":13,"context_line":"    \"shared_subnetpools\": \"field:subnetpools:shared\u003dTrue\","},{"line_number":14,"context_line":"    \"shared_address_scopes\": \"field:address_scopes:shared\u003dTrue\","},{"line_number":15,"context_line":"    \"public_firewall_groups\": \"field:firewall_groups:public\u003dTrue\","},{"line_number":16,"context_line":"    \"public_firewall_policies\": \"field:firewall_policies:public\u003dTrue\","},{"line_number":17,"context_line":"    \"public_firewall_rules\": \"field:firewall_rules:public\u003dTrue\","},{"line_number":18,"context_line":"    \"external\": \"field:networks:router:external\u003dTrue\","}],"source_content_type":"application/json","patch_set":3,"id":"fa7ab95a_e6b90b17","line":15,"updated":"2016-09-01 00:56:05.000000000","message":"these should move, and stay close to neutron-fwaas. This is another reminiscence of the pre split. Projects can handle their own json file.","commit_id":"f3fe3ca32f0a66fdb18f14f25fcdd67674a49273"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ba1e4de920b95902624669433bdf9936dbd74873","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"shared_firewall_policies\": \"field:firewall_policies:shared\u003dTrue\","},{"line_number":13,"context_line":"    \"shared_subnetpools\": \"field:subnetpools:shared\u003dTrue\","},{"line_number":14,"context_line":"    \"shared_address_scopes\": \"field:address_scopes:shared\u003dTrue\","},{"line_number":15,"context_line":"    \"public_firewall_groups\": \"field:firewall_groups:public\u003dTrue\","},{"line_number":16,"context_line":"    \"public_firewall_policies\": \"field:firewall_policies:public\u003dTrue\","},{"line_number":17,"context_line":"    \"public_firewall_rules\": \"field:firewall_rules:public\u003dTrue\","},{"line_number":18,"context_line":"    \"external\": \"field:networks:router:external\u003dTrue\","}],"source_content_type":"application/json","patch_set":3,"id":"fa7ab95a_e83ab9e6","line":15,"in_reply_to":"fa7ab95a_e6b90b17","updated":"2016-09-01 01:45:48.000000000","message":"I\u0027ve been trying to get the \u0027policy,d\u0027 stuff that oslo.policy supports working, but I have not yet been able to get a devstack to take it.  I\u0027m not sure if there is an additional parameter that needs to be supplied in Neutron to make that happen, but I will keep looking at it tomorrow (9/1).","commit_id":"f3fe3ca32f0a66fdb18f14f25fcdd67674a49273"}],"neutron/tests/etc/policy.json":[{"author":{"_account_id":5109,"name":"chandanc","email":"chandan.dutta.chowdhury@gmail.com","username":"chandanc"},"change_message_id":"5e18e835cd49838409f6c7f113b155b05939ed61","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"update_firewall_group:public\": \"rule:admin_only\","},{"line_number":150,"context_line":"    \"delete_firewall_group\": \"rule:admin_or_owner\","},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    \"create_firewall_policy_v2\": \"\","},{"line_number":153,"context_line":"    \"get_firewall_policy_v2\": \"rule:admin_or_owner or rule:public_firewall_policies\","},{"line_number":154,"context_line":"    \"create_firewall_policy_v2:public\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"update_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":156,"context_line":"    \"delete_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    \"create_firewall_rule_v2\": \"\","},{"line_number":159,"context_line":"    \"get_firewall_rule_v2\": \"rule:admin_or_owner or rule:public_firewall_rules\","},{"line_number":160,"context_line":"    \"update_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":161,"context_line":"    \"delete_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    \"create_qos_queue\": \"rule:admin_only\","},{"line_number":164,"context_line":"    \"get_qos_queue\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":1,"id":"3ac371cc_61d7caed","line":161,"range":{"start_line":152,"start_character":0,"end_line":161,"end_character":52},"updated":"2016-08-16 08:34:53.000000000","message":"I don\u0027t think we can use the _v2 in the first string, as commented in the other file","commit_id":"469bebab811523aef1e2f1af241de19a5aca5195"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0c24c8d1d0bd0603fc3e6fb39782cebf8ced43b0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"update_firewall_group:public\": \"rule:admin_only\","},{"line_number":150,"context_line":"    \"delete_firewall_group\": \"rule:admin_or_owner\","},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    \"create_firewall_policy_v2\": \"\","},{"line_number":153,"context_line":"    \"get_firewall_policy_v2\": \"rule:admin_or_owner or rule:public_firewall_policies\","},{"line_number":154,"context_line":"    \"create_firewall_policy_v2:public\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"update_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":156,"context_line":"    \"delete_firewall_policy_v2\": \"rule:admin_or_owner\","},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    \"create_firewall_rule_v2\": \"\","},{"line_number":159,"context_line":"    \"get_firewall_rule_v2\": \"rule:admin_or_owner or rule:public_firewall_rules\","},{"line_number":160,"context_line":"    \"update_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":161,"context_line":"    \"delete_firewall_rule_v2\": \"rule:admin_or_owner\","},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    \"create_qos_queue\": \"rule:admin_only\","},{"line_number":164,"context_line":"    \"get_qos_queue\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":1,"id":"3ac371cc_423b909c","line":161,"range":{"start_line":152,"start_character":0,"end_line":161,"end_character":52},"in_reply_to":"3ac371cc_61d7caed","updated":"2016-08-16 16:45:27.000000000","message":"I\u0027ll fix it.","commit_id":"469bebab811523aef1e2f1af241de19a5aca5195"}]}