)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"62be64c47036feda45f5990a77381003a1adc2a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate Router Extra Attributes DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for Router Extra Attributes"},{"line_number":11,"context_line":"which has db models definition in same file, this patch"},{"line_number":12,"context_line":"will refactor Router Extra Attributes model."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_f321a1fc","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"updated":"2016-08-16 22:09:15.000000000","message":"Oslo-versioned Objects","commit_id":"0d46cca5203ff44326f92af4aa9d30c32016f320"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"3c9d2a2c84b978ac1f5603c89d750c6be8dd4146","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate Router Extra Attributes DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of objects for Router Extra Attributes"},{"line_number":11,"context_line":"which has db models definition in same file, this patch"},{"line_number":12,"context_line":"will refactor Router Extra Attributes model."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_9805be12","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":25},"in_reply_to":"3ac371cc_f321a1fc","updated":"2016-08-17 15:22:14.000000000","message":"Done","commit_id":"0d46cca5203ff44326f92af4aa9d30c32016f320"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate Router Extra Attributes DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of Oslo-versioned Objects for"},{"line_number":11,"context_line":"Router Extra Attributes which has db models"},{"line_number":12,"context_line":"definition in same file, this patch will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5a8bc5a2_3b3253f2","line":9,"updated":"2016-09-22 15:58:32.000000000","message":"please rewrap for 70 chars. your lines are too short.","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relocate Router Extra Attributes DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As there would be issue of cyclic imports while"},{"line_number":10,"context_line":"implementation of Oslo-versioned Objects for"},{"line_number":11,"context_line":"Router Extra Attributes which has db models"},{"line_number":12,"context_line":"definition in same file, this patch will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5a8bc5a2_922c204c","line":9,"in_reply_to":"5a8bc5a2_3b3253f2","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.common import utils as n_utils"},{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db.models \\"},{"line_number":36,"context_line":"    import router_extra_attributes as router_extra_attrs_models"},{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_fb654be1","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":24},"updated":"2016-09-22 15:58:32.000000000","message":"that\u0027s an indication of bad (\u003d\u003dlong) naming","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.common import utils as n_utils"},{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db.models \\"},{"line_number":36,"context_line":"    import router_extra_attributes as router_extra_attrs_models"},{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_1221f04d","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":24},"in_reply_to":"5a8bc5a2_fb654be1","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db.models \\"},{"line_number":36,"context_line":"    import router_extra_attributes as router_extra_attrs_models"},{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":39,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_5b747f9b","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":63},"updated":"2016-09-22 15:58:32.000000000","message":"please refrain names that are so long. it makes the code hard to read.","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db.models \\"},{"line_number":36,"context_line":"    import router_extra_attributes as router_extra_attrs_models"},{"line_number":37,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":38,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":39,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_321eec0c","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":63},"in_reply_to":"5a8bc5a2_5b747f9b","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c2ba5d19dc878dbed65189f7563cac514697c2f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.common import utils as n_utils"},{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db.models import router as l3_models"},{"line_number":36,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":37,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":38,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_abfb8746","line":35,"updated":"2016-09-28 01:04:02.000000000","message":"https://review.openstack.org/348562 introduces neutron.db.models.l3 and imports that as l3_models. I think we should avoid confusion and use router_models here.","commit_id":"f9709c65fea9b54bb6226cd42a0780f3d2d188f0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cde3660a80167e29b63e9e47110b697a8b57539","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from neutron.common import utils as n_utils"},{"line_number":33,"context_line":"from neutron.db import agents_db"},{"line_number":34,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":35,"context_line":"from neutron.db.models import router as l3_models"},{"line_number":36,"context_line":"from neutron.extensions import l3agentscheduler"},{"line_number":37,"context_line":"from neutron.extensions import router_availability_zone as router_az"},{"line_number":38,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_57e2a404","line":35,"in_reply_to":"5a8bc5a2_abfb8746","updated":"2016-09-28 18:04:47.000000000","message":"Done","commit_id":"f9709c65fea9b54bb6226cd42a0780f3d2d188f0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d40e9356e23462048cc2791e2e62c064c89f00f1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            return (context.session.query(RouterL3AgentBinding)."},{"line_number":127,"context_line":"                    join(agents_db.Agent)."},{"line_number":128,"context_line":"                    filter(agents_db.Agent.heartbeat_timestamp \u003c cutoff,"},{"line_number":129,"context_line":"                    agents_db.Agent.admin_state_up)."},{"line_number":130,"context_line":"                    outerjoin("},{"line_number":131,"context_line":"                        l3_attrs.RouterExtraAttributes,"},{"line_number":132,"context_line":"                        l3_attrs.RouterExtraAttributes.router_id \u003d\u003d"},{"line_number":133,"context_line":"                    RouterL3AgentBinding.router_id).filter("},{"line_number":134,"context_line":"                    sa.or_("},{"line_number":135,"context_line":"                        l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.false(),"},{"line_number":136,"context_line":"                        l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.null())))"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _get_agent_mode(self, agent_db):"},{"line_number":139,"context_line":"        agent_conf \u003d self.get_configuration_dict(agent_db)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_ef19e27a","line":136,"range":{"start_line":129,"start_character":0,"end_line":136,"end_character":74},"updated":"2016-09-29 14:38:27.000000000","message":"nit:\n                    agents_db.Agent.admin_state_up).outerjoin(\n                        l3_attrs.RouterExtraAttributes,\n                        l3_attrs.RouterExtraAttributes.router_id \u003d\u003d\n                        RouterL3AgentBinding.router_id).filter(sa.or_(\n                            l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.false(),\n                            l3_attrs.RouterExtraAttributes.ha \u003d\u003d sql.null())))","commit_id":"3758fcaba630c15f3162836ce9f3871759c2f996"}],"neutron/db/l3_attrs_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"62be64c47036feda45f5990a77381003a1adc2a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import _deprecate"},{"line_number":18,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":19,"context_line":"from neutron.db.models import router_extra_attributes as r_extra_attrs"},{"line_number":20,"context_line":"from neutron.extensions import l3"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f37881f4","line":19,"range":{"start_line":19,"start_character":57,"end_line":19,"end_character":70},"updated":"2016-08-16 22:09:15.000000000","message":"router_extra_attrs_models","commit_id":"0d46cca5203ff44326f92af4aa9d30c32016f320"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"3c9d2a2c84b978ac1f5603c89d750c6be8dd4146","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import _deprecate"},{"line_number":18,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":19,"context_line":"from neutron.db.models import router_extra_attributes as r_extra_attrs"},{"line_number":20,"context_line":"from neutron.extensions import l3"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_781ba273","line":19,"range":{"start_line":19,"start_character":57,"end_line":19,"end_character":70},"in_reply_to":"3ac371cc_f37881f4","updated":"2016-08-17 15:22:14.000000000","message":"Done","commit_id":"0d46cca5203ff44326f92af4aa9d30c32016f320"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f721e872934995a71ffa083014e6eb6cdd488e09","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":61,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":62,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset("},{"line_number":63,"context_line":"    globals(), router_extra_attrs_models)"},{"line_number":64,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_b2484c89","line":62,"updated":"2016-08-31 12:41:24.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"ce1b437b2bc4e2b9ba214d31aac76cbeb4797b15"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7267249f3649eac30ebcc1c8ec9e1dd4e0223f86","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":61,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":62,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset("},{"line_number":63,"context_line":"    globals(), router_extra_attrs_models)"},{"line_number":64,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_f5163054","line":62,"in_reply_to":"fa7ab95a_b2484c89","updated":"2016-08-31 15:44:40.000000000","message":"Done","commit_id":"ce1b437b2bc4e2b9ba214d31aac76cbeb4797b15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.common import _deprecate"},{"line_number":16,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":17,"context_line":"from neutron.db.models \\"},{"line_number":18,"context_line":"    import router_extra_attributes as router_extra_attrs_models"},{"line_number":19,"context_line":"from neutron.extensions import l3"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_3b8ed378","line":17,"range":{"start_line":17,"start_character":23,"end_line":17,"end_character":24},"updated":"2016-09-22 15:58:32.000000000","message":"ditto","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.common import _deprecate"},{"line_number":16,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":17,"context_line":"from neutron.db.models \\"},{"line_number":18,"context_line":"    import router_extra_attributes as router_extra_attrs_models"},{"line_number":19,"context_line":"from neutron.extensions import l3"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_92d34038","line":17,"range":{"start_line":17,"start_character":23,"end_line":17,"end_character":24},"in_reply_to":"5a8bc5a2_3b8ed378","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _get_extra_attributes(self, router, extra_attributes):"},{"line_number":39,"context_line":"        return (dict((attr[\u0027name\u0027],"},{"line_number":40,"context_line":"                      router.get(attr[\u0027name\u0027], attr[\u0027default\u0027]))"},{"line_number":41,"context_line":"                     for attr in extra_attributes))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _process_extra_attr_router_create("},{"line_number":44,"context_line":"            self, context, router_db, router_req):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_bbcf43af","line":41,"updated":"2016-09-22 15:58:32.000000000","message":"(No action required) yeah, though not exactly related to the patch...","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _get_extra_attributes(self, router, extra_attributes):"},{"line_number":39,"context_line":"        return (dict((attr[\u0027name\u0027],"},{"line_number":40,"context_line":"                      router.get(attr[\u0027name\u0027], attr[\u0027default\u0027]))"},{"line_number":41,"context_line":"                     for attr in extra_attributes))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _process_extra_attr_router_create("},{"line_number":44,"context_line":"            self, context, router_db, router_req):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_f2e2c402","line":41,"in_reply_to":"5a8bc5a2_bbcf43af","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     for attr in extra_attributes))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _process_extra_attr_router_create("},{"line_number":44,"context_line":"            self, context, router_db, router_req):"},{"line_number":45,"context_line":"        kwargs \u003d self._get_extra_attributes(router_req, self.extra_attributes)"},{"line_number":46,"context_line":"        # extra_attributes reference is populated via backref"},{"line_number":47,"context_line":"        if not router_db[\u0027extra_attributes\u0027]:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_3bbc1305","line":44,"updated":"2016-09-22 15:58:32.000000000","message":"(No action required) suggest not to touch unrelated code in the future","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                     for attr in extra_attributes))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _process_extra_attr_router_create("},{"line_number":44,"context_line":"            self, context, router_db, router_req):"},{"line_number":45,"context_line":"        kwargs \u003d self._get_extra_attributes(router_req, self.extra_attributes)"},{"line_number":46,"context_line":"        # extra_attributes reference is populated via backref"},{"line_number":47,"context_line":"        if not router_db[\u0027extra_attributes\u0027]:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_12e810e2","line":44,"in_reply_to":"5a8bc5a2_3bbc1305","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c2ba5d19dc878dbed65189f7563cac514697c2f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.common import _deprecate"},{"line_number":16,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":17,"context_line":"from neutron.db.models import router as l3_models"},{"line_number":18,"context_line":"from neutron.extensions import l3"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_deprecate._moved_global(\u0027RouterExtraAttributes\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_0b99db1f","line":17,"updated":"2016-09-28 01:04:02.000000000","message":"ditto","commit_id":"f9709c65fea9b54bb6226cd42a0780f3d2d188f0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cde3660a80167e29b63e9e47110b697a8b57539","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron.common import _deprecate"},{"line_number":16,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":17,"context_line":"from neutron.db.models import router as l3_models"},{"line_number":18,"context_line":"from neutron.extensions import l3"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_deprecate._moved_global(\u0027RouterExtraAttributes\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_d7eeb4eb","line":17,"in_reply_to":"5a8bc5a2_0b99db1f","updated":"2016-09-28 18:04:47.000000000","message":"Done","commit_id":"f9709c65fea9b54bb6226cd42a0780f3d2d188f0"}],"neutron/db/l3_hascheduler_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db import agents_db"},{"line_number":23,"context_line":"from neutron.db import l3_agentschedulers_db as l3_sch_db"},{"line_number":24,"context_line":"from neutron.db import l3_db"},{"line_number":25,"context_line":"from neutron.db.models \\"},{"line_number":26,"context_line":"            import router_extra_attributes as router_extra_attrs_models"},{"line_number":27,"context_line":"from neutron.extensions import portbindings"},{"line_number":28,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_7b63fbb1","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":24},"updated":"2016-09-22 15:58:32.000000000","message":"ditto","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db import agents_db"},{"line_number":23,"context_line":"from neutron.db import l3_agentschedulers_db as l3_sch_db"},{"line_number":24,"context_line":"from neutron.db import l3_db"},{"line_number":25,"context_line":"from neutron.db.models \\"},{"line_number":26,"context_line":"            import router_extra_attributes as router_extra_attrs_models"},{"line_number":27,"context_line":"from neutron.extensions import portbindings"},{"line_number":28,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_b2bf5ccf","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":24},"in_reply_to":"5a8bc5a2_7b63fbb1","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                 binding_model.router_id \u003d\u003d"},{"line_number":49,"context_line":"                 router_extra_attrs_models.RouterExtraAttributes.router_id)."},{"line_number":50,"context_line":"            join(l3_db.Router)."},{"line_number":51,"context_line":"            filter(router_extra_attrs_models."},{"line_number":52,"context_line":"                   RouterExtraAttributes.ha \u003d\u003d sql.true())."},{"line_number":53,"context_line":"            group_by(binding_model.router_id).subquery())"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_3b6a5381","line":51,"updated":"2016-09-22 15:58:32.000000000","message":"that is harder to read. rename the module import into something shorter","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                 binding_model.router_id \u003d\u003d"},{"line_number":49,"context_line":"                 router_extra_attrs_models.RouterExtraAttributes.router_id)."},{"line_number":50,"context_line":"            join(l3_db.Router)."},{"line_number":51,"context_line":"            filter(router_extra_attrs_models."},{"line_number":52,"context_line":"                   RouterExtraAttributes.ha \u003d\u003d sql.true())."},{"line_number":53,"context_line":"            group_by(binding_model.router_id).subquery())"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_d2b4e8f3","line":51,"in_reply_to":"5a8bc5a2_3b6a5381","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6c2ba5d19dc878dbed65189f7563cac514697c2f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db import agents_db"},{"line_number":23,"context_line":"from neutron.db import l3_agentschedulers_db as l3_sch_db"},{"line_number":24,"context_line":"from neutron.db import l3_db"},{"line_number":25,"context_line":"from neutron.db.models import router as l3_models"},{"line_number":26,"context_line":"from neutron.extensions import portbindings"},{"line_number":27,"context_line":"from neutron import manager"},{"line_number":28,"context_line":"from neutron.plugins.common import constants as service_constants"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_4ba3e34f","line":25,"updated":"2016-09-28 01:04:02.000000000","message":"ditto","commit_id":"f9709c65fea9b54bb6226cd42a0780f3d2d188f0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cde3660a80167e29b63e9e47110b697a8b57539","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db import agents_db"},{"line_number":23,"context_line":"from neutron.db import l3_agentschedulers_db as l3_sch_db"},{"line_number":24,"context_line":"from neutron.db import l3_db"},{"line_number":25,"context_line":"from neutron.db.models import router as l3_models"},{"line_number":26,"context_line":"from neutron.extensions import portbindings"},{"line_number":27,"context_line":"from neutron import manager"},{"line_number":28,"context_line":"from neutron.plugins.common import constants as service_constants"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_97f50c85","line":25,"in_reply_to":"5a8bc5a2_4ba3e34f","updated":"2016-09-28 18:04:47.000000000","message":"Done","commit_id":"f9709c65fea9b54bb6226cd42a0780f3d2d188f0"}],"neutron/db/migration/models/head.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"37a0c68e2510488224b32ba7a4c2428ac7a5554f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.db import servicetype_db  # noqa"},{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_geneve  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_f85579fa","side":"PARENT","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":57},"updated":"2016-08-18 17:57:06.000000000","message":"I missed at previous patch set. This removing is wrong.","commit_id":"58316f7a8c07a4fbe912624a3bf9e08fdc6696f2"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"1d976b5940bcdaf80d9f81feb5b93a6fc389b6d3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.db import servicetype_db  # noqa"},{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_flat  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_geneve  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_gre  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_531c6ec1","side":"PARENT","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":57},"in_reply_to":"3ac371cc_f85579fa","updated":"2016-08-18 18:31:52.000000000","message":"Done","commit_id":"58316f7a8c07a4fbe912624a3bf9e08fdc6696f2"}],"neutron/db/models/router_extra_attributes.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a08aa2b83564e4e3268a7b8b136b5252cadd95f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_bb14a3f5","line":1,"updated":"2016-09-22 15:58:32.000000000","message":"I believe this model should live in router.py, not separately.","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"80d68e24359e068bed352211d891a1799ec4e19d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_52a0d89f","line":1,"in_reply_to":"5a8bc5a2_bb14a3f5","updated":"2016-09-22 19:20:01.000000000","message":"Done","commit_id":"b676f5ae5e562b7a542974f7b46ad86f883b27d0"}]}