)]}'
{"neutron/objects/qos/net_policy_binding.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"01c4f513094b5fa5036b323ca27ab17db2b81f07","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    synthetic_fields \u003d [\u0027network\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    fields_need_translation \u003d {\u0027network_id\u0027: \u0027id\u0027,"},{"line_number":38,"context_line":"                               \u0027policy_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_d61fc5b4","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":33},"updated":"2016-08-18 13:30:57.000000000","message":"I don\u0027t think you need to declare this SQLAlchemy relationship as a synthetic field","commit_id":"b0e7e860db7320384e6edf7cc46a524e9fc4092e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fa6a2048452def55018b2ee2fb9c38167467c5b5","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    synthetic_fields \u003d [\u0027network\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    fields_need_translation \u003d {\u0027network_id\u0027: \u0027id\u0027,"},{"line_number":38,"context_line":"                               \u0027policy_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_0ce949b7","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":33},"in_reply_to":"3ac371cc_d61fc5b4","updated":"2016-08-18 15:06:29.000000000","message":"+1","commit_id":"b0e7e860db7320384e6edf7cc46a524e9fc4092e"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"7dce568e8db0ed4aab6a66ff63b848b06f533c86","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    synthetic_fields \u003d [\u0027network\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    fields_need_translation \u003d {\u0027network_id\u0027: \u0027id\u0027,"},{"line_number":38,"context_line":"                               \u0027policy_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8fc05a7e","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":33},"in_reply_to":"3ac371cc_d61fc5b4","updated":"2016-08-19 09:22:40.000000000","message":"Done","commit_id":"b0e7e860db7320384e6edf7cc46a524e9fc4092e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"01c4f513094b5fa5036b323ca27ab17db2b81f07","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    synthetic_fields \u003d [\u0027network\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    fields_need_translation \u003d {\u0027network_id\u0027: \u0027id\u0027,"},{"line_number":38,"context_line":"                               \u0027policy_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_96d1cd25","line":38,"range":{"start_line":37,"start_character":32,"end_line":38,"end_character":47},"updated":"2016-08-18 13:30:57.000000000","message":"You don\u0027t need to translate these attributes. Their names in the DB model are \u0027network_id\u0027 and \u0027policy_id\u0027, so you don\u0027t need to translate them: https://github.com/openstack/neutron/blob/master/neutron/db/qos/models.py#L35","commit_id":"b0e7e860db7320384e6edf7cc46a524e9fc4092e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fa6a2048452def55018b2ee2fb9c38167467c5b5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    synthetic_fields \u003d [\u0027network\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    fields_need_translation \u003d {\u0027network_id\u0027: \u0027id\u0027,"},{"line_number":38,"context_line":"                               \u0027policy_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_acdab514","line":38,"range":{"start_line":37,"start_character":32,"end_line":38,"end_character":47},"in_reply_to":"3ac371cc_96d1cd25","updated":"2016-08-18 15:06:29.000000000","message":"+1","commit_id":"b0e7e860db7320384e6edf7cc46a524e9fc4092e"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"7dce568e8db0ed4aab6a66ff63b848b06f533c86","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    synthetic_fields \u003d [\u0027network\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    fields_need_translation \u003d {\u0027network_id\u0027: \u0027id\u0027,"},{"line_number":38,"context_line":"                               \u0027policy_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_efbd8e03","line":38,"range":{"start_line":37,"start_character":32,"end_line":38,"end_character":47},"in_reply_to":"3ac371cc_96d1cd25","updated":"2016-08-19 09:22:40.000000000","message":"Done","commit_id":"b0e7e860db7320384e6edf7cc46a524e9fc4092e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"94c2b58b055334bf6537bb5dbff5e35e2562c963","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":29,"context_line":"        \u0027policy_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":30,"context_line":"        \u0027network\u0027: obj_fields.ObjectField(\u0027Network\u0027)"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_debe92fe","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":52},"updated":"2016-08-19 15:44:35.000000000","message":"this can be removed, it is not needed.","commit_id":"9bcd0e264dc5d3db8e6453220104fbadb2021696"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"e8d004f59f6ac05b5b24622e3846887304c82ddb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":29,"context_line":"        \u0027policy_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":30,"context_line":"        \u0027network\u0027: obj_fields.ObjectField(\u0027Network\u0027)"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_042250b9","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":52},"in_reply_to":"1ac06dbe_debe92fe","updated":"2016-08-22 12:35:44.000000000","message":"Done","commit_id":"9bcd0e264dc5d3db8e6453220104fbadb2021696"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"94c2b58b055334bf6537bb5dbff5e35e2562c963","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027network\u0027: obj_fields.ObjectField(\u0027Network\u0027)"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_3e46c623","line":33,"range":{"start_line":33,"start_character":52,"end_line":33,"end_character":60},"updated":"2016-08-19 15:44:35.000000000","message":"ditto.","commit_id":"9bcd0e264dc5d3db8e6453220104fbadb2021696"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"e8d004f59f6ac05b5b24622e3846887304c82ddb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027network\u0027: obj_fields.ObjectField(\u0027Network\u0027)"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields_no_update \u003d [\u0027policy_id\u0027, \u0027network_id\u0027, \u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_442c48ab","line":33,"range":{"start_line":33,"start_character":52,"end_line":33,"end_character":60},"in_reply_to":"1ac06dbe_3e46c623","updated":"2016-08-22 12:35:44.000000000","message":"Done","commit_id":"9bcd0e264dc5d3db8e6453220104fbadb2021696"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"d742b0af91ff381be9ae09a470cee84826296931","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    db_model \u003d qos_db_model.QosNetworkPolicyBinding"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":29,"context_line":"        \u0027policy_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_4dbfc560","line":26,"updated":"2016-09-07 21:35:35.000000000","message":"primary_keys and foreign_keys are missing. See[1],[2]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L33\n\n[2] https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L35","commit_id":"b85d68c6c287c5f654d3f66cea500a6a2278fcc8"}]}
