)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ef8529f64947a0b9235782bce56ff1a4c1a0ab35","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-Authored-By: Anindita Das \u003canindita.das@intel.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6b3114005715aa8197aa7188bd92611be886a20c"},{"line_number":15,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":16,"context_line":"Partial-Bug: #1541928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1ac06dbe_1847b11e","line":15,"updated":"2016-08-24 13:43:42.000000000","message":"Creation of OVO and models relocation needs to be handled in different patches, that allow us to merge them without dealing with their dependencies.","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7fb6b78cf5addc277bdbd033554dfffecc92b18b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-Authored-By: Anindita Das \u003canindita.das@intel.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6b3114005715aa8197aa7188bd92611be886a20c"},{"line_number":15,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":16,"context_line":"Partial-Bug: #1541928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1ac06dbe_2e4b19b2","line":15,"in_reply_to":"1ac06dbe_1847b11e","updated":"2016-08-25 03:52:50.000000000","message":"Done","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"0e754825bbeca90eff7f7b93505cbd25a405bb1c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6b3114005715aa8197aa7188bd92611be886a20c"},{"line_number":14,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":15,"context_line":"Partial-Bug: #1541928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"5a8bc5a2_1d594135","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":21},"updated":"2016-09-27 14:20:04.000000000","message":"This tag is not required","commit_id":"783a6769109e99bd88590889d79023b1a05f9b91"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"55073377f1db42919a18dde8f3456331db6b428d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6b3114005715aa8197aa7188bd92611be886a20c"},{"line_number":14,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":15,"context_line":"Partial-Bug: #1541928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"5a8bc5a2_609e1564","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":21},"in_reply_to":"5a8bc5a2_1d594135","updated":"2016-09-27 15:31:16.000000000","message":"Done","commit_id":"783a6769109e99bd88590889d79023b1a05f9b91"}],"neutron/db/l3_attrs_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ef8529f64947a0b9235782bce56ff1a4c1a0ab35","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def _get_extra_attributes(self, router, extra_attributes):"},{"line_number":38,"context_line":"        return (dict((attr[\u0027name\u0027],"},{"line_number":39,"context_line":"                      router.get(attr[\u0027name\u0027], attr[\u0027default\u0027]))"},{"line_number":40,"context_line":"                     for attr in extra_attributes))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def _process_extra_attr_router_create("},{"line_number":43,"context_line":"            self, context, router_db, router_req):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_38254d0a","line":40,"updated":"2016-08-24 13:43:42.000000000","message":"This change is not required","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"}],"neutron/objects/router.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0da3817894666ecd5313932c9d839169b3e94b7f","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":63,"context_line":"class RouterExtraAttributes(base.NeutronDbObject):"},{"line_number":64,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    db_model \u003d l3_attrs.RouterExtraAttributes"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_4b7490fc","line":64,"updated":"2016-10-18 16:32:07.000000000","message":"nit: We usually add: \"# Version 1.0: Intial version\" before the line","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"222127f303b57cf9c657140a9b5b179bed0b0a3e","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":63,"context_line":"class RouterExtraAttributes(base.NeutronDbObject):"},{"line_number":64,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    db_model \u003d l3_attrs.RouterExtraAttributes"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_2edbea1c","line":64,"in_reply_to":"fa6399be_4b7490fc","updated":"2016-10-18 16:55:32.000000000","message":"Done","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0da3817894666ecd5313932c9d839169b3e94b7f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fields \u003d {"},{"line_number":69,"context_line":"        \u0027router_id\u0027: obj_fields.UUIDField(),"},{"line_number":70,"context_line":"        \u0027distributed\u0027: obj_fields.BooleanField("},{"line_number":71,"context_line":"            default\u003dFalse),"},{"line_number":72,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField("},{"line_number":73,"context_line":"            default\u003dFalse),"},{"line_number":74,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_ab59ac90","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":27},"updated":"2016-10-18 16:32:07.000000000","message":"nit: why using two lines?","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"222127f303b57cf9c657140a9b5b179bed0b0a3e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fields \u003d {"},{"line_number":69,"context_line":"        \u0027router_id\u0027: obj_fields.UUIDField(),"},{"line_number":70,"context_line":"        \u0027distributed\u0027: obj_fields.BooleanField("},{"line_number":71,"context_line":"            default\u003dFalse),"},{"line_number":72,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField("},{"line_number":73,"context_line":"            default\u003dFalse),"},{"line_number":74,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_4ed81e1e","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":27},"in_reply_to":"fa6399be_ab59ac90","updated":"2016-10-18 16:55:32.000000000","message":"Done","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0da3817894666ecd5313932c9d839169b3e94b7f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        \u0027distributed\u0027: obj_fields.BooleanField("},{"line_number":71,"context_line":"            default\u003dFalse),"},{"line_number":72,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField("},{"line_number":73,"context_line":"            default\u003dFalse),"},{"line_number":74,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":75,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":76,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_cb5ee075","line":73,"updated":"2016-10-18 16:32:07.000000000","message":"ditto","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"222127f303b57cf9c657140a9b5b179bed0b0a3e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        \u0027distributed\u0027: obj_fields.BooleanField("},{"line_number":71,"context_line":"            default\u003dFalse),"},{"line_number":72,"context_line":"        \u0027service_router\u0027: obj_fields.BooleanField("},{"line_number":73,"context_line":"            default\u003dFalse),"},{"line_number":74,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":75,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":76,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_8e087693","line":73,"in_reply_to":"fa6399be_cb5ee075","updated":"2016-10-18 16:55:32.000000000","message":"Done","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0da3817894666ecd5313932c9d839169b3e94b7f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":85,"context_line":"        result \u003d super(RouterExtraAttributes, cls).modify_fields_from_db("},{"line_number":86,"context_line":"            db_obj)"},{"line_number":87,"context_line":"        if az_ext.AZ_HINTS in result:"},{"line_number":88,"context_line":"            result[az_ext.AZ_HINTS] \u003d ("},{"line_number":89,"context_line":"                az_ext.convert_az_string_to_list(result[az_ext.AZ_HINTS]))"},{"line_number":90,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_ab0b6c7c","line":87,"updated":"2016-10-18 16:32:07.000000000","message":"why do we use this constant here? Seems like something API extension related which is not semantically the same as object field names.","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"222127f303b57cf9c657140a9b5b179bed0b0a3e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":85,"context_line":"        result \u003d super(RouterExtraAttributes, cls).modify_fields_from_db("},{"line_number":86,"context_line":"            db_obj)"},{"line_number":87,"context_line":"        if az_ext.AZ_HINTS in result:"},{"line_number":88,"context_line":"            result[az_ext.AZ_HINTS] \u003d ("},{"line_number":89,"context_line":"                az_ext.convert_az_string_to_list(result[az_ext.AZ_HINTS]))"},{"line_number":90,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_6e1162af","line":87,"in_reply_to":"fa6399be_ab0b6c7c","updated":"2016-10-18 16:55:32.000000000","message":"I was following it as per the merged code in Network object [1]. \n\n[1] - https://github.com/openstack/neutron/blob/master/neutron/objects/network.py#L182","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"}],"neutron/objects/router_extra_attributes.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ef8529f64947a0b9235782bce56ff1a4c1a0ab35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1ac06dbe_acec622a","updated":"2016-08-24 13:43:42.000000000","message":"I would prefer to create the Oslo-Versioned Object for RouterExtraAttributes class in other patch, in that way we can manage things isolated.","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7fb6b78cf5addc277bdbd033554dfffecc92b18b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1ac06dbe_6ec071e1","in_reply_to":"1ac06dbe_acec622a","updated":"2016-08-25 03:52:50.000000000","message":"Done. This patch now only has OVO for Router Extra Attributes.","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1ac06dbe_45532f17","line":41,"updated":"2016-08-23 21:58:07.000000000","message":"There is an orm.relationship in the model right? then y no synthetic field?","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0286722a6add814c2c4e3c6daf4c66f1242ba117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1ac06dbe_2bb6b8f8","line":41,"in_reply_to":"1ac06dbe_45532f17","updated":"2016-08-24 03:48:11.000000000","message":"Thanks for looking into this. I saw the following patch [1][2] where synthetic fields were not used. So I followed it initially. I will need to change this current patch to introduce synthetic fields as the merged ones have synthetic fields in them. \n\n[1]Object - https://review.openstack.org/#/c/269658/22/neutron/objects/network.py\n[2]DB - https://review.openstack.org/#/c/269658/22/neutron/db/segments_db.py","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"103565694c95fbb93dbf7a524f4c283698e3aab3","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    primary_keys \u003d [\u0027router_id\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    foreign_keys \u003d {\u0027router_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_65f1c0cd","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":38},"updated":"2016-08-25 20:12:49.000000000","message":"hey, check this out foreign keys: https://review.openstack.org/#/c/357207/3/neutron/objects/securitygroup.py","commit_id":"5c7738b271b4231fdaba2b256443a1081bfb5d9d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"b4ad2c181782503a270aff50c50e572c157b24e3","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    primary_keys \u003d [\u0027router_id\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    foreign_keys \u003d {\u0027router_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_f362ec15","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":38},"in_reply_to":"fa7ab95a_65f1c0cd","updated":"2016-08-26 04:28:16.000000000","message":"Done","commit_id":"5c7738b271b4231fdaba2b256443a1081bfb5d9d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"e1d9d452d7a83cd73415f0063d8c1b8b53d20690","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            default\u003dFalse),"},{"line_number":32,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":33,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(),"},{"line_number":34,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.StringField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    primary_keys \u003d [\u0027router_id\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_3df4cf84","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":33},"updated":"2016-09-15 07:30:34.000000000","message":"az_hints are not list of strings. It is stored in DB as a string but in code usage, it is converted in [1] to list of strings. You can take a look how to convert string to a list of strings in [2]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/extensions/availability_zone.py\n[2] https://review.openstack.org/#/c/269658/30/neutron/objects/network.py@187","commit_id":"871fee097ec54a63df7e1743926059b99ee762e6"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7f090f75ffc5583847432e0609df74aac801ad82","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            default\u003dFalse),"},{"line_number":32,"context_line":"        \u0027ha\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":33,"context_line":"        \u0027ha_vr_id\u0027: obj_fields.IntegerField(),"},{"line_number":34,"context_line":"        \u0027availability_zone_hints\u0027: obj_fields.StringField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    primary_keys \u003d [\u0027router_id\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_9f0f6c87","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":33},"in_reply_to":"7a8ec9b2_3df4cf84","updated":"2016-09-15 20:33:03.000000000","message":"Thanks for the review. I made the changes [1] but it is seen that convert_az_string_to_list() returns a list of unicoded values. This unicode encoding cannot be read by get_objects() in test_filtering_by_fields() in test_base [1] resulting in \u0027AssertionError: Sequences differ\u0027. Because of the difference in encoding, the filters cannot be recognized in get_objects. Any idea how to go about this? \n\n[1] - https://review.openstack.org/#/c/356766/20/neutron/objects/router_extra_attributes.py@48\n[2] - https://github.com/openstack/neutron/blob/master/neutron/tests/unit/objects/test_base.py#L1217","commit_id":"871fee097ec54a63df7e1743926059b99ee762e6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"04f4492b3c2a8812c59b9ebb5f1fa36f3b1ac556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"5a8bc5a2_7aab7975","updated":"2016-09-26 11:47:26.000000000","message":"I\u0027m thinking that RouterExtraAttributes should be in neutron/objects/router.py.","commit_id":"e5e651555fc28503845a51eba6c4ad7c2708c476"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d09ee056810188dbe134b4986fe7be215b9d3556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a8bc5a2_0aa0eca4","updated":"2016-09-28 06:33:32.000000000","message":"I\u0027m wondering if this should be named neutron/objects/router.py","commit_id":"e2a5b430b286adc4b78498a19909bce1b5e6e294"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"128418fdcce218d798adea5dd994055e75cbb46b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3a98d1f4_eb7e68ad","in_reply_to":"5a8bc5a2_0aa0eca4","updated":"2016-09-28 18:47:54.000000000","message":"Done","commit_id":"e2a5b430b286adc4b78498a19909bce1b5e6e294"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"89a9494c793935b1a9ae17b6f3ae5ededa8a26ed","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1096,"context_line":"            \u0027name\u0027: \u0027test_router\u0027,"},{"line_number":1097,"context_line":"        }"},{"line_number":1098,"context_line":"        self._router \u003d obj_db_api.create_object(self.context,"},{"line_number":1099,"context_line":"                                                l3_db.Router,"},{"line_number":1100,"context_line":"                                                attrs)"},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_0af41584","line":1098,"updated":"2016-09-23 20:18:33.000000000","message":"Add a TODO/Note to replace this with router.create() once the Router object is implemented.","commit_id":"24f5fbd99c2925831ddea8b2884beaf10a88cd49"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"6b1196866a50ed247c2dbe83d3634bf72edf85c0","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1096,"context_line":"            \u0027name\u0027: \u0027test_router\u0027,"},{"line_number":1097,"context_line":"        }"},{"line_number":1098,"context_line":"        self._router \u003d obj_db_api.create_object(self.context,"},{"line_number":1099,"context_line":"                                                l3_db.Router,"},{"line_number":1100,"context_line":"                                                attrs)"},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_10e7e8b0","line":1098,"in_reply_to":"5a8bc5a2_0af41584","updated":"2016-09-23 21:26:35.000000000","message":"Done","commit_id":"24f5fbd99c2925831ddea8b2884beaf10a88cd49"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"0e754825bbeca90eff7f7b93505cbd25a405bb1c","unresolved":false,"context_lines":[{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        for field in remove_timestamps_from_fields(get_obj_db_fields(obj)):"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"            # TODO(sshank): The below may not be a good solution. It is done to"},{"line_number":1231,"context_line":"            # avoid having a list inside a list. Having list inside a list will"},{"line_number":1232,"context_line":"            # not give correct filtering in get_objects() hence the following."},{"line_number":1233,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5a8bc5a2_1d6f81fc","line":1230,"range":{"start_line":1230,"start_character":51,"end_line":1230,"end_character":64},"updated":"2016-09-27 14:20:04.000000000","message":"This looks like [1]another solution, so maybe it\u0027s the way to solve this.\n\n[1] https://review.openstack.org/#/c/351368/33/neutron/tests/unit/objects/test_base.py@1283","commit_id":"783a6769109e99bd88590889d79023b1a05f9b91"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"55073377f1db42919a18dde8f3456331db6b428d","unresolved":false,"context_lines":[{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        for field in remove_timestamps_from_fields(get_obj_db_fields(obj)):"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"            # TODO(sshank): The below may not be a good solution. It is done to"},{"line_number":1231,"context_line":"            # avoid having a list inside a list. Having list inside a list will"},{"line_number":1232,"context_line":"            # not give correct filtering in get_objects() hence the following."},{"line_number":1233,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5a8bc5a2_40703972","line":1230,"range":{"start_line":1230,"start_character":51,"end_line":1230,"end_character":64},"in_reply_to":"5a8bc5a2_1d6f81fc","updated":"2016-09-27 15:31:16.000000000","message":"Similar logic is seen from the patch [1]. It seems like a correct solution. I removed the comments in the updated patch. \n\n[1] - https://review.openstack.org/#/c/269658/35/neutron/tests/unit/objects/test_base.py@1277","commit_id":"783a6769109e99bd88590889d79023b1a05f9b91"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"0bac82e9773fa5f9a61e74099ba4b09126197bd1","unresolved":false,"context_lines":[{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    def _create_test_router(self):"},{"line_number":1100,"context_line":"        attrs \u003d {"},{"line_number":1101,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1102,"context_line":"            \u0027name\u0027: \u0027test_router\u0027,"},{"line_number":1103,"context_line":"        }"},{"line_number":1104,"context_line":"        # TODO(sshank): Replace with router.create() once router object"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a8bc5a2_10e66de8","line":1101,"updated":"2016-09-27 23:26:41.000000000","message":"The \u0027id\u0027 field is taken care by the create_object so not needed here","commit_id":"e2a5b430b286adc4b78498a19909bce1b5e6e294"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"128418fdcce218d798adea5dd994055e75cbb46b","unresolved":false,"context_lines":[{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    def _create_test_router(self):"},{"line_number":1100,"context_line":"        attrs \u003d {"},{"line_number":1101,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1102,"context_line":"            \u0027name\u0027: \u0027test_router\u0027,"},{"line_number":1103,"context_line":"        }"},{"line_number":1104,"context_line":"        # TODO(sshank): Replace with router.create() once router object"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a98d1f4_78730cb2","line":1101,"in_reply_to":"5a8bc5a2_10e66de8","updated":"2016-09-28 18:47:54.000000000","message":"Done","commit_id":"e2a5b430b286adc4b78498a19909bce1b5e6e294"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"ba0a11797bdf3285d9a678bf61a1d2d59b4fdc21","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.common import utils"},{"line_number":32,"context_line":"from neutron import context"},{"line_number":33,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":34,"context_line":"from neutron.db import l3_db"},{"line_number":35,"context_line":"from neutron.db import model_base"},{"line_number":36,"context_line":"from neutron.db import models_v2"},{"line_number":37,"context_line":"from neutron.db import segments_db"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a95cdbc_2a0b237e","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":28},"updated":"2016-10-10 11:25:02.000000000","message":"The model has been moved to db.models.l3 - if I\u0027m seeing correctly.","commit_id":"d8dfb10632c6d553abafb7a60931cf6b9e1cf3b0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"8e4c2096cf8cdc1b6241b8fc7227230c0489f76b","unresolved":false,"context_lines":[{"line_number":1285,"context_line":"        obj.create()"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"        for field in remove_timestamps_from_fields(get_obj_db_fields(obj)):"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"            if not isinstance(self.objs[0][field], list):"},{"line_number":1290,"context_line":"                filters \u003d {field: [self.objs[0][field]]}"},{"line_number":1291,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a95cdbc_c44bd085","line":1288,"updated":"2016-10-07 14:35:29.000000000","message":"nit: this change is unnecessary","commit_id":"d8dfb10632c6d553abafb7a60931cf6b9e1cf3b0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"ba0a11797bdf3285d9a678bf61a1d2d59b4fdc21","unresolved":false,"context_lines":[{"line_number":1285,"context_line":"        obj.create()"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"        for field in remove_timestamps_from_fields(get_obj_db_fields(obj)):"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"            if not isinstance(self.objs[0][field], list):"},{"line_number":1290,"context_line":"                filters \u003d {field: [self.objs[0][field]]}"},{"line_number":1291,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a95cdbc_2afde36d","line":1288,"in_reply_to":"1a95cdbc_c44bd085","updated":"2016-10-10 11:25:02.000000000","message":"Change is not related to this PS.","commit_id":"d8dfb10632c6d553abafb7a60931cf6b9e1cf3b0"}],"neutron/tests/unit/objects/test_objects.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0da3817894666ecd5313932c9d839169b3e94b7f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027QosPolicy\u0027: \u00271.3-2eb3494f990acae59cb51381e7f99443\u0027,"},{"line_number":51,"context_line":"    \u0027Route\u0027: \u00271.0-a9883a63b416126f9e345523ec09483b\u0027,"},{"line_number":52,"context_line":"    \u0027RouterRoute\u0027: \u00271.0-07fc5337c801fb8c6ccfbcc5afb45907\u0027,"},{"line_number":53,"context_line":"    \u0027RouterExtraAttributes\u0027: \u00271.0-ef8d61ae2864f0ec9af0ab7939cab318\u0027,"},{"line_number":54,"context_line":"    \u0027SecurityGroup\u0027: \u00271.0-e26b90c409b31fd2e3c6fcec402ac0b9\u0027,"},{"line_number":55,"context_line":"    \u0027SecurityGroupRule\u0027: \u00271.0-e9b8dace9d48b936c62ad40fe1f339d5\u0027,"},{"line_number":56,"context_line":"    \u0027Subnet\u0027: \u00271.0-b71e720f45fff2a39759940e010be7d1\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_8b678824","line":53,"updated":"2016-10-18 16:32:07.000000000","message":"should go before RouterRoute because the list is in alphabetic order.","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"222127f303b57cf9c657140a9b5b179bed0b0a3e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027QosPolicy\u0027: \u00271.3-2eb3494f990acae59cb51381e7f99443\u0027,"},{"line_number":51,"context_line":"    \u0027Route\u0027: \u00271.0-a9883a63b416126f9e345523ec09483b\u0027,"},{"line_number":52,"context_line":"    \u0027RouterRoute\u0027: \u00271.0-07fc5337c801fb8c6ccfbcc5afb45907\u0027,"},{"line_number":53,"context_line":"    \u0027RouterExtraAttributes\u0027: \u00271.0-ef8d61ae2864f0ec9af0ab7939cab318\u0027,"},{"line_number":54,"context_line":"    \u0027SecurityGroup\u0027: \u00271.0-e26b90c409b31fd2e3c6fcec402ac0b9\u0027,"},{"line_number":55,"context_line":"    \u0027SecurityGroupRule\u0027: \u00271.0-e9b8dace9d48b936c62ad40fe1f339d5\u0027,"},{"line_number":56,"context_line":"    \u0027Subnet\u0027: \u00271.0-b71e720f45fff2a39759940e010be7d1\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_6e7882f9","line":53,"in_reply_to":"fa6399be_8b678824","updated":"2016-10-18 16:55:32.000000000","message":"Done","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"}],"neutron/tests/unit/objects/test_router.py":[{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"58dba59080f1cba9aad93da4d1f1e675a1bfa8ee","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.objects import router"},{"line_number":17,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"},{"line_number":18,"context_line":"from neutron.tests.unit import testlib_api"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_0a95393f","line":15,"updated":"2016-10-18 14:15:21.000000000","message":"Extra blank line","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"6ec9699fcf7f8898109a466707ff28d32f1b2930","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.objects import router"},{"line_number":17,"context_line":"from neutron.tests.unit.objects import test_base as obj_test_base"},{"line_number":18,"context_line":"from neutron.tests.unit import testlib_api"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa6399be_6dd88f1e","line":15,"in_reply_to":"fa6399be_0a95393f","updated":"2016-10-18 14:44:47.000000000","message":"Merged code at [1] seemed to have those blank lines. Hence I did not change them.\n\n[1] - https://github.com/openstack/neutron/blob/master/neutron/tests/unit/objects/test_router.py#L14","commit_id":"3e23a6c6b929d2e2c9e578f6cf65eaf08d538fc5"}],"neutron/tests/unit/objects/test_router_extra_attributes.py":[{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        router_extra_attrs_obj.service_router \u003d False,"},{"line_number":43,"context_line":"        router_extra_attrs_obj.ha \u003d False,"},{"line_number":44,"context_line":"        router_extra_attrs_obj.ha_vr_id \u003d tools.get_random_integer()"},{"line_number":45,"context_line":"        router_extra_attrs_obj.availability_zone_hints \u003d tools. \\"},{"line_number":46,"context_line":"            get_random_string()"},{"line_number":47,"context_line":"        return router_extra_attrs_obj"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_457a0f89","line":45,"range":{"start_line":45,"start_character":62,"end_line":45,"end_character":65},"updated":"2016-08-23 21:58:07.000000000","message":"should be used only for import statements.","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"fca844460e7958d13177689d076757666b2a177b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        router_extra_attrs_obj.service_router \u003d False,"},{"line_number":43,"context_line":"        router_extra_attrs_obj.ha \u003d False,"},{"line_number":44,"context_line":"        router_extra_attrs_obj.ha_vr_id \u003d tools.get_random_integer()"},{"line_number":45,"context_line":"        router_extra_attrs_obj.availability_zone_hints \u003d tools. \\"},{"line_number":46,"context_line":"            get_random_string()"},{"line_number":47,"context_line":"        return router_extra_attrs_obj"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_e9611f13","line":45,"range":{"start_line":45,"start_character":62,"end_line":45,"end_character":65},"in_reply_to":"1ac06dbe_2bad189b","updated":"2016-08-24 16:32:41.000000000","message":"try:\n\nr_ext_attrs_obj \u003d self._make_object(fields)\n       ...\n\nr_ext_attrs_obj.availability_zone_hints \u003d tools.get_random_string()","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0286722a6add814c2c4e3c6daf4c66f1242ba117","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        router_extra_attrs_obj.service_router \u003d False,"},{"line_number":43,"context_line":"        router_extra_attrs_obj.ha \u003d False,"},{"line_number":44,"context_line":"        router_extra_attrs_obj.ha_vr_id \u003d tools.get_random_integer()"},{"line_number":45,"context_line":"        router_extra_attrs_obj.availability_zone_hints \u003d tools. \\"},{"line_number":46,"context_line":"            get_random_string()"},{"line_number":47,"context_line":"        return router_extra_attrs_obj"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_2bad189b","line":45,"range":{"start_line":45,"start_character":62,"end_line":45,"end_character":65},"in_reply_to":"1ac06dbe_457a0f89","updated":"2016-08-24 03:48:11.000000000","message":"I wasn\u0027t sure how to reduce line length here. Is there any other way to continue to the next line?","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        router_extra_attrs_obj.distributed \u003d True"},{"line_number":55,"context_line":"        router_extra_attrs_obj.create()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        listed_obj \u003d router_extra_attributes. \\"},{"line_number":58,"context_line":"            RouterExtraAttributes.\\"},{"line_number":59,"context_line":"            get_object(self.context,"},{"line_number":60,"context_line":"                       distributed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_a56dc3cd","line":57,"range":{"start_line":57,"start_character":44,"end_line":57,"end_character":47},"updated":"2016-08-23 21:58:07.000000000","message":"ditto","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        router_extra_attrs_obj.create()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        listed_obj \u003d router_extra_attributes. \\"},{"line_number":58,"context_line":"            RouterExtraAttributes.\\"},{"line_number":59,"context_line":"            get_object(self.context,"},{"line_number":60,"context_line":"                       distributed\u003dTrue,"},{"line_number":61,"context_line":"                       router_id\u003dself._router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_857087a5","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":35},"updated":"2016-08-23 21:58:07.000000000","message":"ditto","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        router_extra_attrs_obj.service_router \u003d True,"},{"line_number":71,"context_line":"        router_extra_attrs_obj.create()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        listed_obj \u003d router_extra_attributes. \\"},{"line_number":74,"context_line":"            RouterExtraAttributes.\\"},{"line_number":75,"context_line":"            get_object(self.context,"},{"line_number":76,"context_line":"                       service_router\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_e56b3bb5","line":73,"range":{"start_line":73,"start_character":44,"end_line":73,"end_character":47},"updated":"2016-08-23 21:58:07.000000000","message":"ditto","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        router_extra_attrs_obj.create()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        listed_obj \u003d router_extra_attributes. \\"},{"line_number":74,"context_line":"            RouterExtraAttributes.\\"},{"line_number":75,"context_line":"            get_object(self.context,"},{"line_number":76,"context_line":"                       service_router\u003dTrue,"},{"line_number":77,"context_line":"                       router_id\u003dself._router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_256273d8","line":74,"range":{"start_line":74,"start_character":33,"end_line":74,"end_character":35},"updated":"2016-08-23 21:58:07.000000000","message":"ditto","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        router_extra_attrs_obj.ha \u003d True,"},{"line_number":87,"context_line":"        router_extra_attrs_obj.create()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        listed_obj \u003d router_extra_attributes. \\"},{"line_number":90,"context_line":"            RouterExtraAttributes.\\"},{"line_number":91,"context_line":"            get_object(self.context,"},{"line_number":92,"context_line":"                       ha\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_659e2bba","line":89,"range":{"start_line":89,"start_character":44,"end_line":89,"end_character":47},"updated":"2016-08-23 21:58:07.000000000","message":"ditto","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"923d80642e86048faf838e0bba1d2f5204126e86","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        router_extra_attrs_obj.create()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        listed_obj \u003d router_extra_attributes. \\"},{"line_number":90,"context_line":"            RouterExtraAttributes.\\"},{"line_number":91,"context_line":"            get_object(self.context,"},{"line_number":92,"context_line":"                       ha\u003dTrue,"},{"line_number":93,"context_line":"                       router_id\u003dself._router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ac06dbe_a5a4a307","line":90,"range":{"start_line":90,"start_character":33,"end_line":90,"end_character":35},"updated":"2016-08-23 21:58:07.000000000","message":"ditto","commit_id":"2a706f626dac73a8e1eda3053c7a57734d3a23ab"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"e1d9d452d7a83cd73415f0063d8c1b8b53d20690","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        r_ext_attrs_obj.availability_zone_hints \u003d tools.get_random_string()"},{"line_number":47,"context_line":"        return r_ext_attrs_obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_object_filter_by_distributed(self):"},{"line_number":50,"context_line":"        self._create_test_router()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        router_extra_attrs_obj \u003d self._test_create_router_extra_attrs_obj("}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_5d2c3bab","line":49,"updated":"2016-09-15 07:30:34.000000000","message":"Those tests are not needed, filtering by fields is implemented in test_base class: test_filtering_by_fields()","commit_id":"871fee097ec54a63df7e1743926059b99ee762e6"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"2e627c5ad63a2912898eaefd254d26377de3f778","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        r_ext_attrs_obj.availability_zone_hints \u003d tools.get_random_string()"},{"line_number":47,"context_line":"        return r_ext_attrs_obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_object_filter_by_distributed(self):"},{"line_number":50,"context_line":"        self._create_test_router()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        router_extra_attrs_obj \u003d self._test_create_router_extra_attrs_obj("}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_bf97c846","line":49,"in_reply_to":"7a8ec9b2_5d2c3bab","updated":"2016-09-15 20:28:26.000000000","message":"+1","commit_id":"871fee097ec54a63df7e1743926059b99ee762e6"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7f090f75ffc5583847432e0609df74aac801ad82","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        r_ext_attrs_obj.availability_zone_hints \u003d tools.get_random_string()"},{"line_number":47,"context_line":"        return r_ext_attrs_obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_object_filter_by_distributed(self):"},{"line_number":50,"context_line":"        self._create_test_router()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        router_extra_attrs_obj \u003d self._test_create_router_extra_attrs_obj("}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_9f868cd9","line":49,"in_reply_to":"7a8ec9b2_5d2c3bab","updated":"2016-09-15 20:33:03.000000000","message":"Done","commit_id":"871fee097ec54a63df7e1743926059b99ee762e6"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7f090f75ffc5583847432e0609df74aac801ad82","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        r_ext_attrs_obj.availability_zone_hints \u003d tools.get_random_string()"},{"line_number":47,"context_line":"        return r_ext_attrs_obj"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_object_filter_by_distributed(self):"},{"line_number":50,"context_line":"        self._create_test_router()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        router_extra_attrs_obj \u003d self._test_create_router_extra_attrs_obj("}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_bf6fc829","line":49,"in_reply_to":"7a8ec9b2_bf97c846","updated":"2016-09-15 20:33:03.000000000","message":"Done","commit_id":"871fee097ec54a63df7e1743926059b99ee762e6"}]}
