)]}'
{"neutron/api/rpc/agentnotifiers/l3_rpc_agent_api.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c9a0b9f6e342edf5d6e41a135750b0881bcdf34f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":85,"context_line":"            service_constants.L3_ROUTER_NAT)"},{"line_number":86,"context_line":"        hosts \u003d plugin.get_hosts_to_notify(adminContext, router_id)"},{"line_number":87,"context_line":"        # TODO(murali): replace cast with fanout to avoid performance"},{"line_number":88,"context_line":"        # issues at greater scale."},{"line_number":89,"context_line":"        for host in hosts:"},{"line_number":90,"context_line":"            log_topic \u003d \u0027%s.%s\u0027 % (topics.L3_AGENT, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_641bcd81","side":"PARENT","line":87,"updated":"2016-08-18 09:48:51.000000000","message":"Wow, I never thought we would ever end up nailing this TODO! Nice!","commit_id":"0f3008dd3251a2b6436ebb7af240fe4c37b0cc42"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"daa870e95a2a3ea6a93e24fe992fcec5cfab7694","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                      {\u0027topic\u0027: log_topic, \u0027method\u0027: method})"},{"line_number":93,"context_line":"            dvr_arptable \u003d {\u0027router_id\u0027: router_id,"},{"line_number":94,"context_line":"                            \u0027arp_table\u0027: data}"},{"line_number":95,"context_line":"            cctxt \u003d self.client.prepare(topic\u003dtopics.L3_AGENT,"},{"line_number":96,"context_line":"                                        server\u003dhost,"},{"line_number":97,"context_line":"                                        version\u003d\u00271.2\u0027)"},{"line_number":98,"context_line":"            cctxt.cast(context, method, payload\u003ddvr_arptable)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_7b436813","side":"PARENT","line":95,"range":{"start_line":95,"start_character":40,"end_line":95,"end_character":61},"updated":"2016-08-23 23:35:40.000000000","message":"I was curious about why the topic wasn\u0027t specified in the new code. But, I think I found out why it isn\u0027t necessary. The topic seems to be already associated with the target of the RPC client [1].\n\n [1] https://github.com/openstack/neutron/blob/385d9c3f58f63d7e29653388b1163d7aa0999afd/neutron/api/rpc/agentnotifiers/l3_rpc_agent_api.py#L41-L43","commit_id":"0f3008dd3251a2b6436ebb7af240fe4c37b0cc42"}],"neutron/tests/unit/api/rpc/agentnotifiers/test_l3_rpc_agent_api.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"daa870e95a2a3ea6a93e24fe992fcec5cfab7694","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_a5c943ae","line":1,"updated":"2016-08-23 23:35:40.000000000","message":"Might want to take this out if you have another patch set.","commit_id":"4bdab5cf1da333cf4e7aaf893e14b094fc5fad61"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"daa870e95a2a3ea6a93e24fe992fcec5cfab7694","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                     \u0027mac_address\u0027: \u002722:f1:6c:9c:79:4a\u0027,"},{"line_number":33,"context_line":"                     \u0027subnet_id\u0027: \u0027subnet_id\u0027}"},{"line_number":34,"context_line":"        router_id \u003d \u0027router_id\u0027"},{"line_number":35,"context_line":"        getattr(self.l3_notifier, method)(mock.Mock(), router_id, arp_table)"},{"line_number":36,"context_line":"        self.rpc_client_mock.prepare.assert_called_once_with("},{"line_number":37,"context_line":"            fanout\u003dTrue, version\u003d\u00271.2\u0027)"},{"line_number":38,"context_line":"        cctxt \u003d self.rpc_client_mock.prepare.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_1f985f1b","line":35,"range":{"start_line":35,"start_character":42,"end_line":35,"end_character":53},"updated":"2016-08-23 23:35:40.000000000","message":"nit: mock.sentinel.context might be useful here.","commit_id":"4bdab5cf1da333cf4e7aaf893e14b094fc5fad61"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"daa870e95a2a3ea6a93e24fe992fcec5cfab7694","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            fanout\u003dTrue, version\u003d\u00271.2\u0027)"},{"line_number":38,"context_line":"        cctxt \u003d self.rpc_client_mock.prepare.return_value"},{"line_number":39,"context_line":"        cctxt.cast.assert_called_once_with("},{"line_number":40,"context_line":"            mock.ANY, method,"},{"line_number":41,"context_line":"            payload\u003d{\u0027router_id\u0027: router_id, \u0027arp_table\u0027: arp_table})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_add_arp_entry(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_9f8c4fdb","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":20},"updated":"2016-08-23 23:35:40.000000000","message":"... and here.","commit_id":"4bdab5cf1da333cf4e7aaf893e14b094fc5fad61"}]}
