)]}'
{"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6e2014eccb23baea1a5edba78124517b793c8246","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import subnet_service_type as service_type_db"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.db import segments_db"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_cc945138","line":36,"range":{"start_line":36,"start_character":53,"end_line":36,"end_character":68},"updated":"2016-08-18 15:11:04.000000000","message":"nit: s/service_type_db/subnet_service_type_models","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":20076,"name":"QunyingRan","email":"ran.qunying@zte.com.cn","username":"QunyingRan"},"change_message_id":"39ea0754ddb14a56eeba1d6c5c7e569e4599a2f2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import subnet_service_type as service_type_db"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.db import segments_db"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_e52f82a5","line":36,"range":{"start_line":36,"start_character":53,"end_line":36,"end_character":68},"in_reply_to":"3ac371cc_cc945138","updated":"2016-08-19 00:51:24.000000000","message":"I\u0027m so sorry thst I can\u0027t understand what this mean. could you please describe details?","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d78905f5b7ded489523dc1b2a1f840c7ad7fca13","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import subnet_service_type as service_type_db"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.db import segments_db"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_d7720cad","line":36,"range":{"start_line":36,"start_character":53,"end_line":36,"end_character":68},"in_reply_to":"3ac371cc_e52f82a5","updated":"2016-08-19 11:08:47.000000000","message":"No problem, basically we are using a similar alias for all of these changes. So, instead of using service_type_db as alias can you use subnet_service_type_model","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"e3ee2bca1308f172eef6cae1a23fe14c5e14942d","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        if validators.is_attr_set(service_types):"},{"line_number":525,"context_line":"            for service_type in service_types:"},{"line_number":526,"context_line":"                service_type_entry \u003d \\"},{"line_number":527,"context_line":"                    subnet_service_type_model.SubnetServiceType("},{"line_number":528,"context_line":"                        subnet_id\u003dsubnet.id,"},{"line_number":529,"context_line":"                        service_type\u003dservice_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_91aa866f","line":526,"range":{"start_line":526,"start_character":37,"end_line":526,"end_character":38},"updated":"2016-08-25 21:35:14.000000000","message":"This is used only in the import statements. If you are using PyCharm, it will add it automatically. Remove it.","commit_id":"3d839fb8024885d934aa62e79cd391f9f5220b41"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"11d1d97435d76f38fdc3ed9a20e18cf914258ae2","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        if validators.is_attr_set(service_types):"},{"line_number":525,"context_line":"            for service_type in service_types:"},{"line_number":526,"context_line":"                service_type_entry \u003d \\"},{"line_number":527,"context_line":"                    subnet_service_type_model.SubnetServiceType("},{"line_number":528,"context_line":"                        subnet_id\u003dsubnet.id,"},{"line_number":529,"context_line":"                        service_type\u003dservice_type)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_b136aab2","line":526,"range":{"start_line":526,"start_character":37,"end_line":526,"end_character":38},"updated":"2016-08-25 21:41:53.000000000","message":"You shouldn\u0027t use \"\\\" as breakline","commit_id":"3d839fb8024885d934aa62e79cd391f9f5220b41"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"941077fffbee576b1faedf79e95a64befc4f3835","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import subnet_service_type as subnet_service_type_model"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.db import segments_db"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_fb4b8cae","line":36,"updated":"2016-08-26 12:28:49.000000000","message":"the name could be shorter (sst_model)","commit_id":"c49c3b8ff20e3865615a70adf979e2b824fd1ab5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"941077fffbee576b1faedf79e95a64befc4f3835","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        if validators.is_attr_set(service_types):"},{"line_number":525,"context_line":"            for service_type in service_types:"},{"line_number":526,"context_line":"                entry \u003d subnet_service_type_model.SubnetServiceType("},{"line_number":527,"context_line":"                        subnet_id\u003dsubnet.id,"},{"line_number":528,"context_line":"                        service_type\u003dservice_type)"},{"line_number":529,"context_line":"                context.session.add(entry)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_bb510465","line":526,"updated":"2016-08-26 12:28:49.000000000","message":"rename of the variable is unneeded.","commit_id":"c49c3b8ff20e3865615a70adf979e2b824fd1ab5"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cc65eec1f645bdfad40bcbbd294188cb9b7c5009","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import subnet_service_type as sst_model"},{"line_number":37,"context_line":"from neutron.db import models_v2"},{"line_number":38,"context_line":"from neutron.db import segments_db"},{"line_number":39,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_49e1f5fd","line":36,"range":{"start_line":36,"start_character":53,"end_line":36,"end_character":62},"updated":"2016-08-26 18:58:11.000000000","message":"subnet_service_model is more clearer. If you want to change it.","commit_id":"405f8054b2749a57d857d854005df5971c873867"}],"neutron/db/models/subnet_service_type.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"83be26b3b9234709726c58b48df97b8ab301610e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 ZTE Corporation. All Rights Reserved.\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_b2f17297","line":1,"range":{"start_line":1,"start_character":34,"end_line":1,"end_character":54},"updated":"2016-08-18 13:57:47.000000000","message":"Yhis has to be in a separate line","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fe77fd66727bcc5209fe3463506a9074ca72fe3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 ZTE Corporation.\r"},{"line_number":2,"context_line":"# All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_16ecd3f1","line":1,"updated":"2016-08-23 20:19:00.000000000","message":"This doesn\u0027t match the copyright attribution in the original file, which should be preserved IMO since ZTE did not create the content here.","commit_id":"379ab359f47ee8951dba43c7415310eeb34fb3b6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b03c77e68e1900c846e8a89107502386006fd2d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 ZTE Corporation.\r"},{"line_number":2,"context_line":"# All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_827a3822","line":1,"in_reply_to":"1ac06dbe_16ecd3f1","updated":"2016-08-23 23:47:08.000000000","message":"I hadn\u0027t thought of that. Yeah, the content was created by someone else, regardless of the file that it is stored in. Good point","commit_id":"379ab359f47ee8951dba43c7415310eeb34fb3b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7675d50c09b09f67af9454c474dd21e9cd6c8334","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"},{"line_number":3,"context_line":"#    a copy of the License at\r"},{"line_number":4,"context_line":"#\r"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_7d175ea3","line":1,"updated":"2016-08-26 16:50:49.000000000","message":"This should have the original copyright statement from subnet_service_type_db_models.py as it\u0027s derivative, I\u0027ll just update in-place.","commit_id":"6f143c0afdaedbdefbb94715876dbf470f73597a"}],"neutron/db/subnet_service_type_db_models.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6e2014eccb23baea1a5edba78124517b793c8246","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.api.v2 import attributes"},{"line_number":17,"context_line":"from neutron.db import common_db_mixin"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_cc9a9113","line":15,"updated":"2016-08-18 15:11:04.000000000","message":"import sys","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6e2014eccb23baea1a5edba78124517b793c8246","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.api.v2 import attributes"},{"line_number":17,"context_line":"from neutron.db import common_db_mixin"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class SubnetServiceTypeMixin(object):"},{"line_number":21,"context_line":"    \"\"\"Mixin class to extend subnet with service type attribute\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_ac92b5f3","line":18,"updated":"2016-08-18 15:11:04.000000000","message":"from neutron.common import _deprecate\nfrom neutron.db.models import subnet_service_type as subnet_service_type_models","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6e2014eccb23baea1a5edba78124517b793c8246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ac371cc_6c055d44","line":30,"updated":"2016-08-18 15:11:04.000000000","message":"You need to add this at the end\n\n# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE\n_OLD_REF \u003d sys.modules[__name__]\nsys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(),\n                                                    subnet_service_type_models)\n# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE","commit_id":"bbc90afae95f7f6979721958cc7dc138997b8cf1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cc65eec1f645bdfad40bcbbd294188cb9b7c5009","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.api.v2 import attributes"},{"line_number":22,"context_line":"from neutron.common import _deprecate"},{"line_number":23,"context_line":"from neutron.db import common_db_mixin"},{"line_number":24,"context_line":"from neutron.db.models import subnet_service_type as sst_model"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SubnetServiceTypeMixin(object):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_69cf997f","line":24,"range":{"start_line":24,"start_character":53,"end_line":24,"end_character":62},"updated":"2016-08-26 18:58:11.000000000","message":"ditto","commit_id":"405f8054b2749a57d857d854005df5971c873867"}]}
