)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b63485f64b410be8ecb46bc8c7cd010016274abe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Artur Korzeniewski \u003cartur.korzeniewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-18 15:14:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support fro multiple foreign keys in NeutronDbObject."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibad4db8da08d9114ac7765e56fe5483434a567d9"},{"line_number":10,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_52cf5e55","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"updated":"2016-08-18 14:02:36.000000000","message":"for","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Artur Korzeniewski \u003cartur.korzeniewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-18 15:14:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support fro multiple foreign keys in NeutronDbObject."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibad4db8da08d9114ac7765e56fe5483434a567d9"},{"line_number":10,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_9157e2c9","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":15},"in_reply_to":"3ac371cc_52cf5e55","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"}],"neutron/objects/base.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b63485f64b410be8ecb46bc8c7cd010016274abe","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \"foreign key\")"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class NeutronSyntheticFieldsForeignKeysNotFound(exceptions.NeutronException):"},{"line_number":72,"context_line":"    message \u003d _(\"%(obj)s does not have foreign key for %(objclass)s\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_updatable_fields(cls, fields):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_757fe414","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":69},"updated":"2016-08-18 14:02:36.000000000","message":"If this patch adds support to multiple foreign keys, should we need to keep this exception?","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b0d09a47b553834dc3027125bddbf5894269912e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class NeutronSyntheticFieldsForeignKeysNotFound(exceptions.NeutronException):"},{"line_number":72,"context_line":"    message \u003d _(\"%(obj)s does not have foreign key for %(objclass)s\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_updatable_fields(cls, fields):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_c32d37ff","line":72,"range":{"start_line":72,"start_character":34,"end_line":72,"end_character":45},"updated":"2016-08-19 07:53:37.000000000","message":"does not define a foreign key","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \"foreign key\")"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class NeutronSyntheticFieldsForeignKeysNotFound(exceptions.NeutronException):"},{"line_number":72,"context_line":"    message \u003d _(\"%(obj)s does not have foreign key for %(objclass)s\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_updatable_fields(cls, fields):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_b1f5becc","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":69},"in_reply_to":"3ac371cc_757fe414","updated":"2016-08-19 08:09:36.000000000","message":"We discussed that with Victor offline, this comment is not valid.","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class NeutronSyntheticFieldsForeignKeysNotFound(exceptions.NeutronException):"},{"line_number":72,"context_line":"    message \u003d _(\"%(obj)s does not have foreign key for %(objclass)s\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_updatable_fields(cls, fields):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f168d689","line":72,"range":{"start_line":72,"start_character":34,"end_line":72,"end_character":45},"in_reply_to":"3ac371cc_c32d37ff","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b63485f64b410be8ecb46bc8c7cd010016274abe","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                # QosRule"},{"line_number":467,"context_line":"                continue"},{"line_number":468,"context_line":"            objclass \u003d objclasses[0]"},{"line_number":469,"context_line":"            # import pdb; pdb.set_trace()"},{"line_number":470,"context_line":"            foreign_keys \u003d objclass.foreign_keys.get(self.__class__.__name__,"},{"line_number":471,"context_line":"                                                     None)"},{"line_number":472,"context_line":"            if not foreign_keys:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_7229bae5","line":469,"range":{"start_line":469,"start_character":12,"end_line":469,"end_character":41},"updated":"2016-08-18 14:02:36.000000000","message":"remove it","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                # QosRule"},{"line_number":467,"context_line":"                continue"},{"line_number":468,"context_line":"            objclass \u003d objclasses[0]"},{"line_number":469,"context_line":"            # import pdb; pdb.set_trace()"},{"line_number":470,"context_line":"            foreign_keys \u003d objclass.foreign_keys.get(self.__class__.__name__,"},{"line_number":471,"context_line":"                                                     None)"},{"line_number":472,"context_line":"            if not foreign_keys:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_1103f2b9","line":469,"range":{"start_line":469,"start_character":12,"end_line":469,"end_character":41},"in_reply_to":"3ac371cc_7229bae5","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b0d09a47b553834dc3027125bddbf5894269912e","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            objclass \u003d objclasses[0]"},{"line_number":469,"context_line":"            # import pdb; pdb.set_trace()"},{"line_number":470,"context_line":"            foreign_keys \u003d objclass.foreign_keys.get(self.__class__.__name__,"},{"line_number":471,"context_line":"                                                     None)"},{"line_number":472,"context_line":"            if not foreign_keys:"},{"line_number":473,"context_line":"                raise NeutronSyntheticFieldsForeignKeysNotFound("},{"line_number":474,"context_line":"                    obj\u003dself.__class__.__name__, objclass\u003dobjclass.__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_03e62fe7","line":471,"range":{"start_line":471,"start_character":53,"end_line":471,"end_character":57},"updated":"2016-08-19 07:53:37.000000000","message":"get will already return None for you by default.","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            objclass \u003d objclasses[0]"},{"line_number":469,"context_line":"            # import pdb; pdb.set_trace()"},{"line_number":470,"context_line":"            foreign_keys \u003d objclass.foreign_keys.get(self.__class__.__name__,"},{"line_number":471,"context_line":"                                                     None)"},{"line_number":472,"context_line":"            if not foreign_keys:"},{"line_number":473,"context_line":"                raise NeutronSyntheticFieldsForeignKeysNotFound("},{"line_number":474,"context_line":"                    obj\u003dself.__class__.__name__, objclass\u003dobjclass.__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_51d28a35","line":471,"range":{"start_line":471,"start_character":53,"end_line":471,"end_character":57},"in_reply_to":"3ac371cc_03e62fe7","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b0d09a47b553834dc3027125bddbf5894269912e","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                                                     None)"},{"line_number":472,"context_line":"            if not foreign_keys:"},{"line_number":473,"context_line":"                raise NeutronSyntheticFieldsForeignKeysNotFound("},{"line_number":474,"context_line":"                    obj\u003dself.__class__.__name__, objclass\u003dobjclass.__name__)"},{"line_number":475,"context_line":"            if len(foreign_keys.keys()) \u003e 1:"},{"line_number":476,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_63d563e3","line":474,"updated":"2016-08-19 07:53:37.000000000","message":"nit: second time you extract it here. Probably better to calculate it once.","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                                                     None)"},{"line_number":472,"context_line":"            if not foreign_keys:"},{"line_number":473,"context_line":"                raise NeutronSyntheticFieldsForeignKeysNotFound("},{"line_number":474,"context_line":"                    obj\u003dself.__class__.__name__, objclass\u003dobjclass.__name__)"},{"line_number":475,"context_line":"            if len(foreign_keys.keys()) \u003e 1:"},{"line_number":476,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_31d70e25","line":474,"in_reply_to":"3ac371cc_63d563e3","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b63485f64b410be8ecb46bc8c7cd010016274abe","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            if not foreign_keys:"},{"line_number":473,"context_line":"                raise NeutronSyntheticFieldsForeignKeysNotFound("},{"line_number":474,"context_line":"                    obj\u003dself.__class__.__name__, objclass\u003dobjclass.__name__)"},{"line_number":475,"context_line":"            if len(foreign_keys.keys()) \u003e 1:"},{"line_number":476,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":479,"context_line":"                self.fields_need_translation.get(field, field))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_35e60ce8","line":476,"range":{"start_line":475,"start_character":0,"end_line":476,"end_character":75},"updated":"2016-08-18 14:02:36.000000000","message":"ditto: line 71","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            if not foreign_keys:"},{"line_number":473,"context_line":"                raise NeutronSyntheticFieldsForeignKeysNotFound("},{"line_number":474,"context_line":"                    obj\u003dself.__class__.__name__, objclass\u003dobjclass.__name__)"},{"line_number":475,"context_line":"            if len(foreign_keys.keys()) \u003e 1:"},{"line_number":476,"context_line":"                raise NeutronSyntheticFieldMultipleForeignKeys(field\u003dfield)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"            synthetic_field_db_name \u003d ("},{"line_number":479,"context_line":"                self.fields_need_translation.get(field, field))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_b1e3fe04","line":476,"range":{"start_line":475,"start_character":0,"end_line":476,"end_character":75},"in_reply_to":"3ac371cc_35e60ce8","updated":"2016-08-19 08:09:36.000000000","message":"I updated the commit message to make it more clear what\u0027s the goal of the patch.","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b63485f64b410be8ecb46bc8c7cd010016274abe","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                objclass.modify_fields_from_db(obj))"},{"line_number":490,"context_line":"                              for obj in synth_db_objs]"},{"line_number":491,"context_line":"            else:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"                synth_objs \u003d objclass.get_objects("},{"line_number":494,"context_line":"                    self.obj_context, **{"},{"line_number":495,"context_line":"                        k: getattr(self, v)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f21aca7b","line":492,"updated":"2016-08-18 14:02:36.000000000","message":"?","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                objclass.modify_fields_from_db(obj))"},{"line_number":490,"context_line":"                              for obj in synth_db_objs]"},{"line_number":491,"context_line":"            else:"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"                synth_objs \u003d objclass.get_objects("},{"line_number":494,"context_line":"                    self.obj_context, **{"},{"line_number":495,"context_line":"                        k: getattr(self, v)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_71b866e6","line":492,"in_reply_to":"3ac371cc_f21aca7b","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"}],"neutron/objects/securitygroup.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b63485f64b410be8ecb46bc8c7cd010016274abe","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue),"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    foreign_keys \u003d {SecurityGroup.__name__: {\u0027security_group_id\u0027: \u0027id\u0027}}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027security_group_id\u0027]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_b5bddc03","line":109,"updated":"2016-08-18 14:02:36.000000000","message":"This is different from Subnet[1]  which makes inconsistet\n\n[1] https://review.openstack.org/#/c/357207/1/neutron/objects/subnet.py@35","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03b78d6b071c5eae51fc2692bf6330c57ace352a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue),"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    foreign_keys \u003d {SecurityGroup.__name__: {\u0027security_group_id\u0027: \u0027id\u0027}}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027security_group_id\u0027]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_d1cdda87","line":109,"in_reply_to":"3ac371cc_b5bddc03","updated":"2016-08-19 08:09:36.000000000","message":"Done","commit_id":"48786f807a1b79283583e670eaf30ffa6f66c6d5"}]}
