)]}'
{"neutron/agent/ovsdb/api.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0bdea609198b8cca56921f6b9441d1bab88c2a74","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        :returns:      :class:`Command` with list of interfaces names result"},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":382,"context_line":"        \"\"\"Create a command to add a Manager to the OVS switch"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        :param connection_uri: target to which manager needs to be set"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_edf4ad88","line":381,"updated":"2016-11-14 16:26:01.000000000","message":"Every method added should be an abc.abstractmethod and implemented in both vsctl and native implementations and tested together in the existing test_ovs_lib functional tests to validate that both implementations behave in the same way.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"e5764d9dacba788b0ac32ca1d7f93170f4831500","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        :returns:      :class:`Command` with list of interfaces names result"},{"line_number":379,"context_line":"        \"\"\""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":382,"context_line":"        \"\"\"Create a command to add a Manager to the OVS switch"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        :param connection_uri: target to which manager needs to be set"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_ef263367","line":381,"in_reply_to":"9a629dbe_edf4ad88","updated":"2016-11-16 09:16:26.000000000","message":"Since this api is only required for this specific use-case, I\u0027ve added it in this manner. However, I agree that its good to implement in both native and vsctl implementations. I\u0027ll update accordingly.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"}],"neutron/agent/ovsdb/impl_vsctl.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"65bacbc7257e0c8d5c2bcc51af3e0ba70045ee3e","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":291,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":292,"context_line":"        conn_uri \u003d (\u0027target\u003d\"%s\"\u0027 % connection_uri)"},{"line_number":293,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"},{"line_number":294,"context_line":"                \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":295,"context_line":"        return BaseCommand(self.context, \u0027--id\u003d@manager\u0027, args\u003dargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_6b48a9cd","line":292,"updated":"2016-11-13 16:08:52.000000000","message":"do you need the brackets?","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"f260f80735ce0968366db6624270aa66c656f16a","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":291,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":292,"context_line":"        conn_uri \u003d (\u0027target\u003d\"%s\"\u0027 % connection_uri)"},{"line_number":293,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"},{"line_number":294,"context_line":"                \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":295,"context_line":"        return BaseCommand(self.context, \u0027--id\u003d@manager\u0027, args\u003dargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_74c0817d","line":292,"in_reply_to":"9a629dbe_6b48a9cd","updated":"2016-11-14 06:43:24.000000000","message":"Its optional. If required, we can remove it.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b933c52a72c7dd935352e1a0e97df086e50fc7a7","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def add_manager(self, connection_uri):"},{"line_number":291,"context_line":"        # This will add a new manager without overriding existing ones."},{"line_number":292,"context_line":"        conn_uri \u003d (\u0027target\u003d\"%s\"\u0027 % connection_uri)"},{"line_number":293,"context_line":"        args \u003d [\u0027create\u0027, \u0027Manager\u0027, conn_uri, \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027,"},{"line_number":294,"context_line":"                \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":295,"context_line":"        return BaseCommand(self.context, \u0027--id\u003d@manager\u0027, args\u003dargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_14fd856e","line":292,"in_reply_to":"9a629dbe_74c0817d","updated":"2016-11-14 06:57:59.000000000","message":"its ok, just wanted to know if it was kosher","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"}],"neutron/agent/ovsdb/native/helpers.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"9c3b39607469cdfd191bc2371c949c6ebe580ad2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def enable_connection_uri(conn_uri):"},{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_a607db16","line":27,"updated":"2016-08-22 22:27:17.000000000","message":"One could make the argument that this function shouldn\u0027t even really exist. Configuration of OVS\u0027s manager URIs is really the job of the deployment tool. We fix it here mainly to make it easier for the gate and running tests locally--so users don\u0027t have to do anything to run the OVS functional tests.\n\nThis kind of thing is why the sanity check framework was written--to catch issues post-deployment where configuration requirements are not met. The fact that we are causing issues for production systems (here and https://review.openstack.org/#/c/358801/ and https://review.openstack.org/#/c/355582/2) just to make running tests marginally easier may not be worth it.\n\nWithout this function, OVSDB-related tests wouldn\u0027t require sudo at all either. Maybe this is something that we should move back to tools/configure_for_func_testing.sh.\n\nThoughts?","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"905c0a6763fc1ae58918156267745d352e09c06b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def enable_connection_uri(conn_uri):"},{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_2f120ab5","line":27,"in_reply_to":"1ac06dbe_7dc3a0ed","updated":"2016-08-26 13:32:19.000000000","message":"Terry, I probably agree. We could revert the direction to require deployment tool to set up the connection. This will require some release notes, documentation changes, and a deprecation path (warning a message for a cycle). If you feel like following the path, I am with you, and will help with reviews.","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":13933,"name":"Niko Hermanns","email":"nikolas.hermanns@ericsson.com","username":"enikher"},"change_message_id":"4ee62528b523258e8455cffdc879fc1b854db717","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def enable_connection_uri(conn_uri):"},{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_7dc3a0ed","line":27,"in_reply_to":"1ac06dbe_a607db16","updated":"2016-08-23 06:57:52.000000000","message":"I follow you. However it might be that most of the users won\u0027t get it. The auto deployer like fuel would need to know. For testing I think it is good to move it to configure_for_func_testing.sh but do you know if there is something like \"ovs_setup.sh\" or \"configure_ovs.sh\". May be it would makes sense so that it does not need to be implemented for all kind of deployers. devstack/RDO/fuel/juju/... They could all use the same script.","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":13933,"name":"Niko Hermanns","email":"nikolas.hermanns@ericsson.com","username":"enikher"},"change_message_id":"1720f3cd455a2a3d6ed278bebee22d6403f323ef","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"},{"line_number":31,"context_line":"    managers.add(manager_uri)"},{"line_number":32,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":33,"context_line":"    args.extend(managers)"},{"line_number":34,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_9e1a5f6d","line":31,"updated":"2016-08-19 14:28:00.000000000","message":"should you not check if this manager is already included? Everytime enable_connection_uri is called it will add then the new uri or?","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"658cf24b93d2990d03844a5761bbe01c554f0b80","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"},{"line_number":31,"context_line":"    managers.add(manager_uri)"},{"line_number":32,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":33,"context_line":"    args.extend(managers)"},{"line_number":34,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_92792ccb","line":31,"in_reply_to":"1ac06dbe_7ef963c8","updated":"2016-08-29 10:28:52.000000000","message":"The fact that functional/fullstack tests can call this function in parallel is fine, right? We always have the same conn_uri for all tests so they can\u0027t influence each other.","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a84228826c2418c9887ff53dfff2f6d642573032","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"},{"line_number":31,"context_line":"    managers.add(manager_uri)"},{"line_number":32,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":33,"context_line":"    args.extend(managers)"},{"line_number":34,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_7ef963c8","line":31,"in_reply_to":"1ac06dbe_9e1a5f6d","updated":"2016-08-19 14:31:34.000000000","message":"This function is only called when we can\u0027t connect to the manager, so it shouldn\u0027t exist when this is called. Also, the fact that he uses a set will make sure there are no duplicates.","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"510c46507ab39caafd9f9098f7316aa1fe51c3ee","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":29,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":30,"context_line":"    managers \u003d set(managers.split())"},{"line_number":31,"context_line":"    managers.add(manager_uri)"},{"line_number":32,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":33,"context_line":"    args.extend(managers)"},{"line_number":34,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_307ae677","line":31,"in_reply_to":"fa7ab95a_92792ccb","updated":"2016-08-30 00:16:55.000000000","message":"As long as they are adding same conn_uri. That will be fine.\nIf no, we need some synchronization. Maybe with file system.","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2511e52be8379d0828658d2ecdeee991e6b58647","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@common_utils.synchronized(\u0027ovsdb.native.helpers\u0027, external\u003dTrue)"},{"line_number":29,"context_line":"def enable_connection_uri(conn_uri):"},{"line_number":30,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":31,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_ff92def4","line":28,"updated":"2016-11-03 11:27:28.000000000","message":"I believe if we make it transactional, as Terry suggested below, then we won\u0027t need to lock here.","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2511e52be8379d0828658d2ecdeee991e6b58647","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    manager_uri \u003d _connection_to_manager_uri(conn_uri)"},{"line_number":31,"context_line":"    managers \u003d utils.execute([\u0027ovs-vsctl\u0027, \u0027get-manager\u0027], run_as_root\u003dTrue)"},{"line_number":32,"context_line":"    managers \u003d set(managers.split())"},{"line_number":33,"context_line":"    managers.add(manager_uri)"},{"line_number":34,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":35,"context_line":"    args.extend(managers)"},{"line_number":36,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_e23885d5","line":33,"updated":"2016-11-03 11:27:28.000000000","message":"if manager_uri is already in the list, you could just return from the function.","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"087f3dbc4db4da4e3ec9a7b3a32ec5851d09f582","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    managers.add(manager_uri)"},{"line_number":34,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":35,"context_line":"    args.extend(managers)"},{"line_number":36,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d649b2b8","line":36,"updated":"2016-08-30 01:50:46.000000000","message":"this would still clear some configuration (connection_mode etc) for the existing managers.\nis it ok for your purpose?","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2511e52be8379d0828658d2ecdeee991e6b58647","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    managers.add(manager_uri)"},{"line_number":34,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":35,"context_line":"    args.extend(managers)"},{"line_number":36,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_9fa1e248","line":36,"in_reply_to":"fa6399be_ea73a5af","updated":"2016-11-03 11:27:28.000000000","message":"I like Terry\u0027s suggestion.","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5b98bb0d2c02f6f4719251ae39646cc23d41d440","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    managers.add(manager_uri)"},{"line_number":34,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":35,"context_line":"    args.extend(managers)"},{"line_number":36,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_ea73a5af","line":36,"in_reply_to":"fa7ab95a_744d2d99","updated":"2016-10-11 18:15:37.000000000","message":"I think could be accomplished w/o using get-manager/set-manager at all:\n\novs-vsctl --id\u003d@manager create Manager target\u003d$conn_uri -- add Open_vSwitch . manager_options @manager\n\nWe could just use that here, or a perhaps cleaner way would be for me to add an add_managers command to the OVSDB api and then specifically import the vsctl implemenation and call impl_vsctl.add_managager(conn_uri).execute(). The command should fail if a manager with the existing target already exists.","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d0cde236c27907fbbdc1d89ea09965adc845ef3f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    managers.add(manager_uri)"},{"line_number":34,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":35,"context_line":"    args.extend(managers)"},{"line_number":36,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_744d2d99","line":36,"in_reply_to":"fa7ab95a_d18e1ccf","updated":"2016-08-30 09:28:40.000000000","message":"as far as it\u0027s ok for your purpose, i guess it\u0027s reasonable.\n\nas you say, cleaner approaches are more involved and it isn\u0027t clear if it\u0027s worth the effort.  after all, i agree these belong to deployment rather than this library.","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93122f8861ec6e435518f310cbbaa62510e94901","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    managers.add(manager_uri)"},{"line_number":34,"context_line":"    args \u003d [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027]"},{"line_number":35,"context_line":"    args.extend(managers)"},{"line_number":36,"context_line":"    utils.execute(args, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d18e1ccf","line":36,"in_reply_to":"fa7ab95a_d649b2b8","updated":"2016-08-30 02:27:20.000000000","message":"Oh, you\u0027re right.\nFor my use case, it\u0027s okay because only manager is set and other related configurations aren\u0027t set.\n\nIn order to keep those configurations cleanly, add-managers needs to be added to ovs-vsctl.\nOr building transaction based on ovsdb-client (or vsctl set/get..) would be a overkill.\n\nWhat do you think?","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"914594a614676dae67713f6686c066032e468915","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSBase(object):"},{"line_number":28,"context_line":"    def __init__(self, conn_uri, vsctl_timeout):"},{"line_number":29,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self, \"vsctl\")"},{"line_number":30,"context_line":"        self.vsctl_timeout \u003d vsctl_timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_9c0fea2d","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":13},"updated":"2016-11-14 13:43:59.000000000","message":"i doubt usefulness of this class.\ni perfer to keep this simple.\nfor longer term it\u0027s better to make this a responsibility of deployer.\nhow do you think?","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"5b518d990281de3872e41052695bdd16e122c821","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSBase(object):"},{"line_number":28,"context_line":"    def __init__(self, conn_uri, vsctl_timeout):"},{"line_number":29,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self, \"vsctl\")"},{"line_number":30,"context_line":"        self.vsctl_timeout \u003d vsctl_timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_4eb41034","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":13},"in_reply_to":"7a77a97e_44644821","updated":"2016-11-18 10:51:51.000000000","message":"Thanks @Terry. Sorry for the delay in getting back, I was at the ODL India Summit. I\u0027ll take a look at the comments and will update the patch accordingly.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7bcecedd3bba45239d0ebc1c94e45bae68c0162b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSBase(object):"},{"line_number":28,"context_line":"    def __init__(self, conn_uri, vsctl_timeout):"},{"line_number":29,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self, \"vsctl\")"},{"line_number":30,"context_line":"        self.vsctl_timeout \u003d vsctl_timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_44644821","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":13},"in_reply_to":"7a77a97e_8fee9fb2","updated":"2016-11-16 19:40:05.000000000","message":"I think you could keep the class internal instead of making callers use it. Something like:\n\n class OvsdbVsctlContext(object):\n     vsctl_timeout \u003d cfg.CONF.ovs_vsctl_timeout\n \n \n def enable_connection_uri(conn_uri):\n     manager_uri \u003d connection_to_manager_uri(conn_uri)\n     api \u003d ovsdb.API.get(OvsdbVsctlContext, \u0027vsctl\u0027)\n     api.ovsdb.add_manager(manager_uri).execute(check_error\u003dFalse, log_errors\u003dTrue)","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0bdea609198b8cca56921f6b9441d1bab88c2a74","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSBase(object):"},{"line_number":28,"context_line":"    def __init__(self, conn_uri, vsctl_timeout):"},{"line_number":29,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self, \"vsctl\")"},{"line_number":30,"context_line":"        self.vsctl_timeout \u003d vsctl_timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_cdc9a95c","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":13},"in_reply_to":"9a629dbe_9c0fea2d","updated":"2016-11-14 16:26:01.000000000","message":"Agreed. No reason for a class here.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"e5764d9dacba788b0ac32ca1d7f93170f4831500","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \u0027p%s:%s\u0027 % (proto, addr)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVSBase(object):"},{"line_number":28,"context_line":"    def __init__(self, conn_uri, vsctl_timeout):"},{"line_number":29,"context_line":"        self.ovsdb \u003d ovsdb.API.get(self, \"vsctl\")"},{"line_number":30,"context_line":"        self.vsctl_timeout \u003d vsctl_timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_8fee9fb2","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":13},"in_reply_to":"9a629dbe_cdc9a95c","updated":"2016-11-16 09:16:26.000000000","message":"Without a class, how will I be able to import the vsctl implementation of add_manager? i.e., add_manager takes (self, ...). So, if I understand correctly I have to use it from a class right?\n\nIf I missing something, please let me know.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"}],"neutron/tests/functional/agent/ovsdb/native/test_helpers.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0bdea609198b8cca56921f6b9441d1bab88c2a74","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(OVSBaseTestCase, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_add_manager(self):"},{"line_number":32,"context_line":"        # Verify that enable_connection_uri does not override existing manager"},{"line_number":33,"context_line":"        expected_manager_list \u003d list()"},{"line_number":34,"context_line":"        for conn_uri, manager_uri in CONNECTION_TO_MANAGER_URI_MAP:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_6d1c1d78","line":31,"updated":"2016-11-14 16:26:01.000000000","message":"as per previous comment, I\u0027d rather see add_manager implemented for both implementations and tests of add_manager together with the other functional tests. I\u0027m willing to help out on the native side if you want.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"e5764d9dacba788b0ac32ca1d7f93170f4831500","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(OVSBaseTestCase, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_add_manager(self):"},{"line_number":32,"context_line":"        # Verify that enable_connection_uri does not override existing manager"},{"line_number":33,"context_line":"        expected_manager_list \u003d list()"},{"line_number":34,"context_line":"        for conn_uri, manager_uri in CONNECTION_TO_MANAGER_URI_MAP:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_0f87efd7","line":31,"in_reply_to":"9a629dbe_6d1c1d78","updated":"2016-11-16 09:16:26.000000000","message":"Thank you @Terry. I\u0027ll let you know if I need any help.","commit_id":"35623f65bced9e6328c9254b5e335a0600238b39"}],"neutron/tests/functional/agent/test_ovs_lib.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b48d7cb1ecf15a6a93e1a57941034d497b66d79d","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_b9988279","line":427,"updated":"2016-11-18 16:46:53.000000000","message":"I realize that I told you that this was the best place for this test. I may have been wrong (sorry!):\n\nAfter running the test once, these values won\u0027t be cleaned up. So we\u0027ll end up testing different things when running multiple times.\n\nIt\u0027s going to be complex to really clean up \"properly\" since other tests could be modifying the manager list at the same time--so we can\u0027t really trust getting the original managers and then just resetting to them.\n\nIf we added the \"destroy\" command, it seems like we should be able to clean up after ourselves, but in testing ovs-vsctl it doesn\u0027t seem to be working.\n\nThere also could be concerns running the tests with SELinux enabled on Red Hat systems since we are actually causing ovsdb-server to listen on a new port. It just depends on how the policy is set.\n\nSince I don\u0027t really know how to fix this issue, the only thing I can think of recommending aside from removing the test for this entirely is to just make a big note saying \"Don\u0027t write tests that modify the manager list anywhere else\". We\u0027ll still be running vsctl and native versions simultaneously, but \"add\" shouldn\u0027t cause the test to fail...it just won\u0027t always be testing what we think it does.\n\nAny ideas?","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"645da5b761232f56b2be71f6541e18876c4d8701","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_df687e8a","line":427,"in_reply_to":"7a77a97e_0dc017e0","updated":"2016-11-21 17:08:57.000000000","message":"Terry, do you mean that there is no ovsdb command to remove one of managers?","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"927155fb3e323870f11225983aa50f36bbf37186","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_cd68df8a","line":427,"in_reply_to":"7a77a97e_13804346","updated":"2016-11-21 14:05:31.000000000","message":"Thanks for the pointers @Ihar. I\u0027ll update the patch (which is a small change). \n\nOne pending thing is that the managers would be configured on the switch after the functional tests are run. Is it fine or should we delete the configured managers?","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f5a4e634fa0dbdf82fa4d71a40b8859619c7e715","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_13804346","line":427,"in_reply_to":"7a77a97e_8fdfdbd4","updated":"2016-11-21 10:57:36.000000000","message":"To avoid the problem of multiple test case flavours stepping on each other\u0027s managers, just have a separate set of managers per test case flavour (native/vsctl). You can distinguish them with if/else in line 427.\n\nAs for SELinux, those values you add are hard coded, so those interested in running functional tests with their MAC framework enabled can just temporarily allow those ports.","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"950b36084a30337abc7fa599fa4292047b227dc5","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_8fdfdbd4","line":427,"in_reply_to":"7a77a97e_b9988279","updated":"2016-11-20 09:10:03.000000000","message":"Honestly, I had some similar concerns when adding these functional tests. \n\nAs you mentioned, this test will not cause any failures even when vsctl and native versions are run simultaneously, but it wont always be testing what we think its doing.\nSo, we can add a note and remove this test-case or update this test-case just to validate that add_manager is setting the manager [*] to the conn_uri.\n\n@Ihar wanted to see a functional test for this use-case. It would be good to hear his views on this. \n\n[*] I had to disable (for testing) SELinux while running these functional tests on my F23 host.","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"49513115f80ebc4f320f2b149d22b0f663ba35b9","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ed9f5b63","line":427,"in_reply_to":"7a77a97e_cd68df8a","updated":"2016-11-21 14:07:52.000000000","message":"Can\u0027t we clean them with a fixture?","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5143c7134c29d5bc31ccf1ad8413e67c1bd0bc82","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_3a941de7","line":427,"in_reply_to":"7a77a97e_df687e8a","updated":"2016-11-21 18:42:51.000000000","message":"ovs-vsctl only has get, set, and del manager commands. Set allows you\nto set one or more managers, and del takes no arguments and clears\nthem all. To implement the \"add manager\", we have to get tricky and do\ntwo separate non-manager-related OVSDB commands--create Manager and add $manager_id to manager_options.\n\nEven though there is a generic \u0027destroy\u0027 db command with ovs-vsctl, it\nwon\u0027t let us just remove a specific manager (e.g. ovs-vsctl destroy\nManager ptcp:6639:127.0.0.1) most likely due to the reference in\nOpen_vSwitch.manager_options (though it doesn\u0027t error, it just does\nnothing).  If we did a separate transaction/query to store the UUID of\nthe manager we could remove it from the manager_options column and OVS would delete the Manager object due to cascading deletes--but doing\nmultiple transactions for a single operation is racy.","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"887e4325e71c2feafef7e38250cb97c0c25e3a14","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        manager_list \u003d [\"ptcp:6638:127.0.0.1\", \"ptcp:6639:127.0.0.1\"]"},{"line_number":428,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":429,"context_line":"        expected_manager_list \u003d list()"},{"line_number":430,"context_line":"        for conn_uri in manager_list:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_0dc017e0","line":427,"in_reply_to":"7a77a97e_ed9f5b63","updated":"2016-11-21 14:25:21.000000000","message":"vsctl/native isn\u0027t the only possible source of conflicts. Other manager-modifying tests could be written as well--so we\u0027d need to coordinate between tests to not use the same values. There is a method to return an available random port net_helpers.get_random_port(),, but that does present issues with SELinux (thought they are issues we are already experiencing)\n\nCleaning up doesn\u0027t work very well because you can really only set the manager or delete all of the managers--which would mess up concurrently running tests.","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4ed016b7362913511719f5a26aa054ec5d4d0d70","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        # Verify that switch is configured with both the managers"},{"line_number":436,"context_line":"        for manager_uri in expected_manager_list:"},{"line_number":437,"context_line":"            self.assertIn(manager_uri, manager_list)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def test_bridge_lifecycle_baseovs(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_961c41c3","line":436,"updated":"2016-11-21 11:28:51.000000000","message":"I don\u0027t see how this section of the test could ever fail. expected_manager_list is exactly the same as manager_list because expected_manager_list is constructed by iterating through manager_list. The only way we can make it here is if all of the assertions on 432 pass so this part of the test and \u0027expected_manager_list\u0027 can just go away.","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"645da5b761232f56b2be71f6541e18876c4d8701","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        # Verify that switch is configured with both the managers"},{"line_number":436,"context_line":"        for manager_uri in expected_manager_list:"},{"line_number":437,"context_line":"            self.assertIn(manager_uri, manager_list)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def test_bridge_lifecycle_baseovs(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ff2a9a2e","line":436,"in_reply_to":"7a77a97e_6d950b87","updated":"2016-11-21 17:08:57.000000000","message":"Sridhar, maybe you should rename the test case to make the goal of the test more clear.","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"927155fb3e323870f11225983aa50f36bbf37186","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        # Verify that switch is configured with both the managers"},{"line_number":436,"context_line":"        for manager_uri in expected_manager_list:"},{"line_number":437,"context_line":"            self.assertIn(manager_uri, manager_list)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def test_bridge_lifecycle_baseovs(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_6d950b87","line":436,"in_reply_to":"7a77a97e_961c41c3","updated":"2016-11-21 14:05:31.000000000","message":"The idea behind this test-case is to validate that add_manager is not overriding any existing managers (which is the case when using external controllers - i.e., ODL environment)\n\nWhen we iterate through the loop in L432, we are only validating that manager set in L431 is configured as a current manager.\nIn L437, we are validating that both the managers (i.e, in manager_list) configured on the switch (i.e., L431) are present on the switch.\n\nNote: In the current implementation [1], enable_connection_uri is unconditionally removing the existing managers by calling \"ovs-vsctl set-manager ....\"\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/agent/ovsdb/native/helpers.py#L29","commit_id":"642505bebf7e497c2dd856719011f3f493140402"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7b5d8c1e2e19d172109fba57b1d8399820f48868","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        super(OVSLibTestCase, self).setUp()"},{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        if (self.ovsdb_interface \u003d\u003d \u0027vsctl\u0027):"},{"line_number":428,"context_line":"            manager_list \u003d [\"ptcp:6636:127.0.0.1\", \"ptcp:6637:127.0.0.1\"]"},{"line_number":429,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_3fb3320c","line":426,"updated":"2016-11-21 17:10:18.000000000","message":"maybe rename the test case to indicate what you validate, like test_add_manager_appends","commit_id":"f9b9947f9170ef2fed46cd6e273bbf794f911ea3"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"6811cfcc432f866a7c45099058d573a65b9ace05","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        super(OVSLibTestCase, self).setUp()"},{"line_number":424,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_add_manager_baseovs(self):"},{"line_number":427,"context_line":"        if (self.ovsdb_interface \u003d\u003d \u0027vsctl\u0027):"},{"line_number":428,"context_line":"            manager_list \u003d [\"ptcp:6636:127.0.0.1\", \"ptcp:6637:127.0.0.1\"]"},{"line_number":429,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_1d090532","line":426,"in_reply_to":"7a77a97e_3fb3320c","updated":"2016-11-22 08:09:39.000000000","message":"Done","commit_id":"f9b9947f9170ef2fed46cd6e273bbf794f911ea3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7b5d8c1e2e19d172109fba57b1d8399820f48868","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":432,"context_line":"        expected_manager_list \u003d list()"},{"line_number":433,"context_line":"        for conn_uri in manager_list:"},{"line_number":434,"context_line":"            self.ovs.add_manager(conn_uri)"},{"line_number":435,"context_line":"            self.assertIn(conn_uri, self.ovs.get_manager())"},{"line_number":436,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_7fe68a17","line":434,"updated":"2016-11-21 17:10:18.000000000","message":"I wonder if there is a command we could use to clean up the managers after test complete.","commit_id":"f9b9947f9170ef2fed46cd6e273bbf794f911ea3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1cb40ae7ed2ff79d8f81aa40a13b006444639d08","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":432,"context_line":"        expected_manager_list \u003d list()"},{"line_number":433,"context_line":"        for conn_uri in manager_list:"},{"line_number":434,"context_line":"            self.ovs.add_manager(conn_uri)"},{"line_number":435,"context_line":"            self.assertIn(conn_uri, self.ovs.get_manager())"},{"line_number":436,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_e01cb215","line":434,"in_reply_to":"7a77a97e_7fe68a17","updated":"2016-11-21 19:29:57.000000000","message":"There is no built-in way in ovs-vsctl, just like there is no built-in way to do \u0027add-manager\u0027 as opposed to set-manager.\n\nI did some more investigation, and the best way to do it would probably be to implement a remove_manager Command for both implementations in addition to add_manager. Both *can* be done in a single transaction (despite my earlier claim that it couldn\u0027t. For vsctl, the command would be:\n\n    ovs-vsctl -- --id\u003d@manager get Manager ptcp:6639:127.0.0.1 -- remove Open_vSwitch . manager_options @manager","commit_id":"f9b9947f9170ef2fed46cd6e273bbf794f911ea3"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"6811cfcc432f866a7c45099058d573a65b9ace05","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":432,"context_line":"        expected_manager_list \u003d list()"},{"line_number":433,"context_line":"        for conn_uri in manager_list:"},{"line_number":434,"context_line":"            self.ovs.add_manager(conn_uri)"},{"line_number":435,"context_line":"            self.assertIn(conn_uri, self.ovs.get_manager())"},{"line_number":436,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_4fb6603e","line":434,"in_reply_to":"7a77a97e_80985e6c","updated":"2016-11-22 08:09:39.000000000","message":"Thanks @Guys for your review comments.\n\nTerry, thanks for sharing the command to delete the manager. You deserve a co-author for this patch.","commit_id":"f9b9947f9170ef2fed46cd6e273bbf794f911ea3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1d17579a9f5b3cdfa9c03aa3f0fd17437bb3f396","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # Verify that add_manager does not override the existing manager"},{"line_number":432,"context_line":"        expected_manager_list \u003d list()"},{"line_number":433,"context_line":"        for conn_uri in manager_list:"},{"line_number":434,"context_line":"            self.ovs.add_manager(conn_uri)"},{"line_number":435,"context_line":"            self.assertIn(conn_uri, self.ovs.get_manager())"},{"line_number":436,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_80985e6c","line":434,"in_reply_to":"7a77a97e_e01cb215","updated":"2016-11-21 19:33:12.000000000","message":"We\u0027d probably have to use net_helpers.get_unused_port() to ensure that multiple tests didn\u0027t step on each other...maybe with a defined start and end to make it easier to write an SELinux script to support those ports?","commit_id":"f9b9947f9170ef2fed46cd6e273bbf794f911ea3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"845466d8ef86a632117fa3c4d8216e2334775761","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_add_manager_appends(self):"},{"line_number":428,"context_line":"        port1 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":429,"context_line":"                                                    start\u003d6630, end\u003d6635)"},{"line_number":430,"context_line":"        port2 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":431,"context_line":"                                                    start\u003d6635, end\u003d6640)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_92a88679","line":428,"updated":"2016-11-22 17:10:49.000000000","message":"This is still racy since we retrieve the \"available\" port, time passes where a concurrent test process can also retrieve the same port, and then we actually make the port unavailable by using it. A bigger range could at least mitigate the issue.\n\nI\u0027m not sure how to completely fix the issue since we can\u0027t really make a registry (not easily or in this patch anyway--a db/lockfile solution would work) since multiple processes will be running simultaneously.\n\nAnother long-term (definitely not for this patch) solution would be to enable certain tests to run under a sandboxed ovs:\n\n https://github.com/horms/openvswitch/blob/a134d79dfb0efcc0095aaec03f3b001c01ba6057/tutorial/Tutorial.md\n https://github.com/openvswitch/ovs/blob/58d636ee831a248dd0b740bba38ece43d27fc995/tutorial/ovs-sandbox\n https://github.com/horms/openvswitch/blob/a134d79dfb0efcc0095aaec03f3b001c01ba6057/utilities/ovs-sim.1.xml","commit_id":"a57fed4ecfed6b75d1d5a77c13bde8ac71186b55"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ec8b51caee5d22dc2877769d1f6f8991ebdccd1","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_add_manager_appends(self):"},{"line_number":428,"context_line":"        port1 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":429,"context_line":"                                                    start\u003d6630, end\u003d6635)"},{"line_number":430,"context_line":"        port2 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":431,"context_line":"                                                    start\u003d6635, end\u003d6640)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_d3811d4f","line":428,"in_reply_to":"7a77a97e_92a88679","updated":"2016-11-22 17:21:08.000000000","message":"Should we then use neutron/tests/common/exclusive_resources to guarantee exclusive access to ports by tests?","commit_id":"a57fed4ecfed6b75d1d5a77c13bde8ac71186b55"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3ff6a8dc8b157cbdc4828757645ff0bdc62486d2","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS()"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_add_manager_appends(self):"},{"line_number":428,"context_line":"        port1 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":429,"context_line":"                                                    start\u003d6630, end\u003d6635)"},{"line_number":430,"context_line":"        port2 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":431,"context_line":"                                                    start\u003d6635, end\u003d6640)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_d32afde6","line":428,"in_reply_to":"7a77a97e_d3811d4f","updated":"2016-11-22 17:33:23.000000000","message":"I did not know that existed.  Assuming it works the way it sounds, yes it looks like something we should use. :D","commit_id":"a57fed4ecfed6b75d1d5a77c13bde8ac71186b55"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"845466d8ef86a632117fa3c4d8216e2334775761","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        port1 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":429,"context_line":"                                                    start\u003d6630, end\u003d6635)"},{"line_number":430,"context_line":"        port2 \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP,"},{"line_number":431,"context_line":"                                                    start\u003d6635, end\u003d6640)"},{"line_number":432,"context_line":"        manager_list \u003d [\"ptcp:%d:127.0.0.1\" % port1,"},{"line_number":433,"context_line":"                        \"ptcp:%d:127.0.0.1\" % port2]"},{"line_number":434,"context_line":"        # Verify that add_manager does not override the existing manager"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_52218efb","line":431,"updated":"2016-11-22 17:10:49.000000000","message":"I think end\u003d6640 will overlap with the port 6640 that already is used for the native ovsdb since get_unused_port uses range(start, end+1). Though it\u0027d never be returned since it is used. The end\u003d6635 and start\u003d6635  would overlap as well. I have no idea why they would have made the range inclusive in get_unused_port. It\u0027s super confusing.\n\nIf you wanted, you could use a defined port range, and safely use it for allocating both ports if you refactored to loop through like:\n\n for i in range(2):\n     port \u003d net_helpers.get_free_namespace_port(const.PROTO_NAME_TCP, start\u003dPORT_START, end\u003dPORT_END)\n     self.ovs.add_manager(\u0027ptcp:%d:127.0.0.1\u0027 % port)\n     ...\n\nthough just fixing the ranges to something like 6630:6634, 6635:6639 would be fine as well.","commit_id":"a57fed4ecfed6b75d1d5a77c13bde8ac71186b55"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"845466d8ef86a632117fa3c4d8216e2334775761","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        expected_manager_list \u003d list()"},{"line_number":436,"context_line":"        for conn_uri in manager_list:"},{"line_number":437,"context_line":"            self.ovs.add_manager(conn_uri)"},{"line_number":438,"context_line":"            self.addCleanup(self.ovs.remove_manager, conn_uri)"},{"line_number":439,"context_line":"            self.assertIn(conn_uri, self.ovs.get_manager())"},{"line_number":440,"context_line":"            expected_manager_list.append(conn_uri)"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_955dd017","line":438,"updated":"2016-11-22 17:10:49.000000000","message":"I guess we should probably test remove_manager as well. Sorry this patch has turned out to be way more work than originally anticipated. :/ It\u0027s good work, though!","commit_id":"a57fed4ecfed6b75d1d5a77c13bde8ac71186b55"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0382aa53f2229a0c0d74a2cbdd23cd618f5e47f6","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def test_add_manager_appends(self):"},{"line_number":429,"context_line":"        port1 \u003d self.useFixture(port.ExclusivePort("},{"line_number":430,"context_line":"            const.PROTO_NAME_TCP, start\u003d6620, end\u003d6629)).port"},{"line_number":431,"context_line":"        port2 \u003d self.useFixture(port.ExclusivePort("},{"line_number":432,"context_line":"            const.PROTO_NAME_TCP, start\u003d6630, end\u003d6639)).port"},{"line_number":433,"context_line":"        manager_list \u003d [\"ptcp:%s:127.0.0.1\" % port1,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_185bacf7","line":430,"updated":"2016-11-22 20:42:10.000000000","message":"Since we are using the exclusive resource fixtures when allocating now, can\u0027t we just define constants like MANAGER_TEST_PORT_FIRST/LAST \u003d (6610, 6639) and use them anywhere we want a manager port? It should make it easier to know what to allow via SELinux, if it is defined in a central location.","commit_id":"0f1a8ba7395183df4f512bd349a7c3a07a96103b"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"845ae45bd8fdc2d8781449d6316aa7c4c0e89dd8","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def test_add_manager_appends(self):"},{"line_number":429,"context_line":"        port1 \u003d self.useFixture(port.ExclusivePort("},{"line_number":430,"context_line":"            const.PROTO_NAME_TCP, start\u003d6620, end\u003d6629)).port"},{"line_number":431,"context_line":"        port2 \u003d self.useFixture(port.ExclusivePort("},{"line_number":432,"context_line":"            const.PROTO_NAME_TCP, start\u003d6630, end\u003d6639)).port"},{"line_number":433,"context_line":"        manager_list \u003d [\"ptcp:%s:127.0.0.1\" % port1,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_722251bb","line":430,"in_reply_to":"7a77a97e_185bacf7","updated":"2016-11-23 07:19:01.000000000","message":"Yes Terry, we can use the constants. Let me re-spin the patch. Hopefully the last one :)","commit_id":"0f1a8ba7395183df4f512bd349a7c3a07a96103b"}],"neutron/tests/unit/agent/ovsdb/native/test_helpers.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"658cf24b93d2990d03844a5761bbe01c554f0b80","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                run_as_root\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_enable_connection_uri_duplicated(self):"},{"line_number":46,"context_line":"        EXISTING_MANAGERS \u003d (\"ptcp:6640:127.0.0.1 tcp:127.0.0.1:6641 \""},{"line_number":47,"context_line":"                             \"ptcp:127.0.0.1:6642\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        def side_effect(args, run_as_root):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_95df5668","line":46,"range":{"start_line":46,"start_character":49,"end_line":46,"end_character":50},"updated":"2016-08-29 10:28:52.000000000","message":"Can you add \u0027\\n\u0027 chars here, so it reflects what is returned by calling get-manager?","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"510c46507ab39caafd9f9098f7316aa1fe51c3ee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                run_as_root\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_enable_connection_uri_duplicated(self):"},{"line_number":46,"context_line":"        EXISTING_MANAGERS \u003d (\"ptcp:6640:127.0.0.1 tcp:127.0.0.1:6641 \""},{"line_number":47,"context_line":"                             \"ptcp:127.0.0.1:6642\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        def side_effect(args, run_as_root):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_90f812c5","line":46,"range":{"start_line":46,"start_character":49,"end_line":46,"end_character":50},"in_reply_to":"fa7ab95a_95df5668","updated":"2016-08-30 00:16:55.000000000","message":"Done","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ae2fe53b0d671c18bec611023ad777f6982ce026","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            args \u003d self.execute.call_args[0][0]"},{"line_number":57,"context_line":"            self.assertEqual(\u0027ovs-vsctl\u0027, args[0])"},{"line_number":58,"context_line":"            self.assertEqual(\u0027set-manager\u0027, args[1])"},{"line_number":59,"context_line":"            self.assertLessEqual(2 + len(EXISTING_MANAGERS.split()), len(args))"},{"line_number":60,"context_line":"            expected \u003d set(EXISTING_MANAGERS.split())"},{"line_number":61,"context_line":"            expected.add(manager_uri)"},{"line_number":62,"context_line":"            self.assertSetEqual(expected, set(args[2:]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ba1c4c14","line":59,"updated":"2016-08-29 09:20:33.000000000","message":"This assertion seems redundant.","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"510c46507ab39caafd9f9098f7316aa1fe51c3ee","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            args \u003d self.execute.call_args[0][0]"},{"line_number":57,"context_line":"            self.assertEqual(\u0027ovs-vsctl\u0027, args[0])"},{"line_number":58,"context_line":"            self.assertEqual(\u0027set-manager\u0027, args[1])"},{"line_number":59,"context_line":"            self.assertLessEqual(2 + len(EXISTING_MANAGERS.split()), len(args))"},{"line_number":60,"context_line":"            expected \u003d set(EXISTING_MANAGERS.split())"},{"line_number":61,"context_line":"            expected.add(manager_uri)"},{"line_number":62,"context_line":"            self.assertSetEqual(expected, set(args[2:]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_50292a36","line":59,"in_reply_to":"fa7ab95a_ba1c4c14","updated":"2016-08-30 00:16:55.000000000","message":"Done","commit_id":"eb814b2226be0d1d67a3206593e2342ba1fc21f8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2511e52be8379d0828658d2ecdeee991e6b58647","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                [\u0027ovs-vsctl\u0027, \u0027set-manager\u0027, manager_uri],"},{"line_number":43,"context_line":"                run_as_root\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_enable_connection_uri_duplicated(self):"},{"line_number":46,"context_line":"        EXISTING_MANAGERS \u003d (\"ptcp:6640:127.0.0.1\\ntcp:127.0.0.1:6641\\n\""},{"line_number":47,"context_line":"                             \"ptcp:127.0.0.1:6642\")"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_9f3d62df","line":45,"updated":"2016-11-03 11:27:28.000000000","message":"I would appreciate if we would convert the test into a functional one, to test deeper with ovs actually in action.","commit_id":"7e681fcff03e8b9f65b59afca947742792a99086"}]}
