)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbe2cea9a0a322470a7ebeefec65a6e905f77283","unresolved":false,"context_lines":[{"line_number":13,"context_line":"trival to do on this server side."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Since the DELETE method is exposed, but it fails with 500,"},{"line_number":16,"context_line":"it is reasonable to deal with this as a bug fix, rather than"},{"line_number":17,"context_line":"having to go through yet another extension. The neutronclient"},{"line_number":18,"context_line":"side support should be added, but since the first user of this"},{"line_number":19,"context_line":"is Tempest, we can safely assume they can leverage this directly"},{"line_number":20,"context_line":"without depending on a python-neutronclient version bump."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_749ee663","line":17,"range":{"start_line":16,"start_character":49,"end_line":17,"end_character":42},"updated":"2016-08-30 17:48:23.000000000","message":"Are you going to backport this to stable/mitaka? Tempest won\u0027t care about that, but I was wondering how a client can discover from the server if this works or not, or if the 500 they get is because the DELETE method isn\u0027t implemented on the version of neutron they are running with this API. It seems that a 404 for the missing method would be more appropriate for a backport, although a 404 could also be interpreted as the network you\u0027re passing in doesn\u0027t exist.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c7d5575d898c569f6019712363921d1f981dc53a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"trival to do on this server side."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Since the DELETE method is exposed, but it fails with 500,"},{"line_number":16,"context_line":"it is reasonable to deal with this as a bug fix, rather than"},{"line_number":17,"context_line":"having to go through yet another extension. The neutronclient"},{"line_number":18,"context_line":"side support should be added, but since the first user of this"},{"line_number":19,"context_line":"is Tempest, we can safely assume they can leverage this directly"},{"line_number":20,"context_line":"without depending on a python-neutronclient version bump."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_45abdcd6","line":17,"range":{"start_line":16,"start_character":49,"end_line":17,"end_character":42},"in_reply_to":"fa7ab95a_749ee663","updated":"2016-08-30 23:19:32.000000000","message":"I attempted the backport and I needed to go pretty deep in resolving all the conflict errors and I got increasingly discouraged. I could give this another go, but since the main user of this is and has been Nova, which introduced support in Newton and does not even use the delete method, I am not sure backporting this is critical.\n\nAs for newer CLI/API clients attempting to delete and receive a 500, well...that\u0027s a bug in the version of the server they are talking to :)","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"98a54a8dabf3986938aa8bb40a2ecacb0ad15385","unresolved":false,"context_lines":[{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/327191/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1614872"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fba51bdf8c781fcc0449e1e9947de976c96eec4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_99e039fc","line":25,"updated":"2016-08-23 02:19:25.000000000","message":"I think that this needs DocImpact tag. And also release note may be needed even if it\u0027s regarded as bug.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6b58b347d0acdd6dfc92f7cae1d71a30d699d3b4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/327191/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1614872"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fba51bdf8c781fcc0449e1e9947de976c96eec4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_b17b89f4","line":25,"in_reply_to":"1ac06dbe_0e135c5c","updated":"2016-08-23 04:34:07.000000000","message":"I\u0027m OK.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5a793971eca957e61038736f4bb6cb045129d319","unresolved":false,"context_lines":[{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/327191/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1614872"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fba51bdf8c781fcc0449e1e9947de976c96eec4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_f9d32d02","line":25,"in_reply_to":"1ac06dbe_99e039fc","updated":"2016-08-23 02:24:26.000000000","message":"Release notes are reserved for critical bugs. As for the DocImpact, again if we consider this a bug fix, what exactly would we document? I\u0027d rather have the docimpact on the client patch that would expose the binding/CLI","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"46faadab673580b5012fb5373e483360cf3feab1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/327191/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1614872"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fba51bdf8c781fcc0449e1e9947de976c96eec4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_0e135c5c","line":25,"in_reply_to":"1ac06dbe_b407fc16","updated":"2016-08-23 03:34:48.000000000","message":"Don\u0027t get me wrong: I agree this needs advertisement, but I\u0027d rather take care of this when the client side comes along. I am not even sure at this point if Tempest is gonna make use of this yet.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1eba14063b21fb67a7eee458f7c848a4331afc8a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/327191/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1614872"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fba51bdf8c781fcc0449e1e9947de976c96eec4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_b407fc16","line":25,"in_reply_to":"1ac06dbe_f9d32d02","updated":"2016-08-23 03:01:25.000000000","message":"\u003e Release notes are reserved for critical bugs\n\nI agree with we deal with this fix as bug but it\u0027s almost API change. The DELETE method is not described in spec and never discuss. Who can notice the method without any announces?\n\n\u003e I\u0027d rather have the docimpact on the client patch that would expose the binding/CLI\n\nAlthough I expected networking-guide[1] and api-ref [still not exist...], I\u0027m OK.\n\n[1]: http://docs.openstack.org/draft/networking-guide/config-auto-allocation.html","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"}],"neutron/services/auto_allocate/db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"06c9fdd4b39f8b90dd96a508e698367c14e65782","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                self._cleanup("},{"line_number":152,"context_line":"                    context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":153,"context_line":"                    router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":154,"context_line":"            except n_exc.NotFound as e:"},{"line_number":155,"context_line":"                # If something goes missing while we are cleaning up"},{"line_number":156,"context_line":"                # then there is need to complain; however let\u0027s keep"},{"line_number":157,"context_line":"                # track of the potential condition for debug purposes."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e0c42d60","line":154,"updated":"2016-08-22 16:34:42.000000000","message":"I think this notfound handler would need to go around each delete operation inside of _cleanup. Otherwise we may hit a notfound on the first thing while the others would still have things to delete.","commit_id":"7a727c5c4d041b87ce98cbcf4ca3e84bccd19466"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"935622ab9fb2b03b3a66ad260e281a74ab7d744f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                self._cleanup("},{"line_number":152,"context_line":"                    context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":153,"context_line":"                    router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":154,"context_line":"            except n_exc.NotFound as e:"},{"line_number":155,"context_line":"                # If something goes missing while we are cleaning up"},{"line_number":156,"context_line":"                # then there is need to complain; however let\u0027s keep"},{"line_number":157,"context_line":"                # track of the potential condition for debug purposes."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_c373fb7e","line":154,"in_reply_to":"1ac06dbe_e0c42d60","updated":"2016-08-22 16:45:30.000000000","message":"Yes, I was coming to this conclusion myself, as there\u0027s many ways in which an attempt to delete the topology can interleave with another.","commit_id":"7a727c5c4d041b87ce98cbcf4ca3e84bccd19466"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"446535c377f138d65edcb6836edca0b1f47653db","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                    router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":154,"context_line":"            except n_exc.NotFound as e:"},{"line_number":155,"context_line":"                # If something goes missing while we are cleaning up"},{"line_number":156,"context_line":"                # then there is need to complain; however let\u0027s keep"},{"line_number":157,"context_line":"                # track of the potential condition for debug purposes."},{"line_number":158,"context_line":"                LOG.debug(\"Resource not found while attempting to delete \""},{"line_number":159,"context_line":"                          \"topology for network \u0027%s\u0027. Error reported: \u0027%s\u0027\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_ed23cb03","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":36},"updated":"2016-08-20 05:02:34.000000000","message":"no need","commit_id":"7a727c5c4d041b87ce98cbcf4ca3e84bccd19466"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"446535c377f138d65edcb6836edca0b1f47653db","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        return tenant_id"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _get_auto_allocated_network_topology(self, context, tenant_id):"},{"line_number":212,"context_line":"        \"\"\"Return the auto allocated topology record if present or None.\"\"\""},{"line_number":213,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":214,"context_line":"            return (context.session.query(models.AutoAllocatedTopology)."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_cd0c0f97","line":211,"range":{"start_line":211,"start_character":28,"end_line":211,"end_character":36},"updated":"2016-08-20 05:02:34.000000000","message":"Nit: consider removing \u0027network\u0027 from this method name.","commit_id":"7a727c5c4d041b87ce98cbcf4ca3e84bccd19466"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d700d8a09fa16e0284c31412af4ec0a4bc68a2f8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                subnets \u003d self.core_plugin.get_subnets("},{"line_number":148,"context_line":"                    context,"},{"line_number":149,"context_line":"                    filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":150,"context_line":"            except n_exc.NotFound:"},{"line_number":151,"context_line":"                subnets \u003d None"},{"line_number":152,"context_line":"                LOG.debug(\"Subnets not found while attempting to delete \""},{"line_number":153,"context_line":"                          \"topology for network \u0027%s\u0027\", topology[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_2b9baf73","line":150,"updated":"2016-08-23 00:58:23.000000000","message":"get rid of this handler","commit_id":"c09da6752d187e4c9534e094b58568f050b01d33"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b68995d7893c936f494b3edddb894b2acf7771c2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":149,"context_line":"            self._cleanup("},{"line_number":150,"context_line":"                context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":151,"context_line":"                router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _build_topology(self, context, tenant_id, default_external_network):"},{"line_number":154,"context_line":"        \"\"\"Build the network topology and returns its network UUID.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_c4eb8111","line":151,"updated":"2016-08-24 11:24:15.000000000","message":"When there is no topology for a given project, 204 is returned. It is inconsistent with the other API behaviors. Don\u0027t we want to return 404?","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f8a885b6b1b194d3dad06459046258b92d43e8ef","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":149,"context_line":"            self._cleanup("},{"line_number":150,"context_line":"                context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":151,"context_line":"                router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _build_topology(self, context, tenant_id, default_external_network):"},{"line_number":154,"context_line":"        \"\"\"Build the network topology and returns its network UUID.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_8f198b7c","line":151,"in_reply_to":"1ac06dbe_24251e5c","updated":"2016-08-24 16:57:02.000000000","message":"Thanks for the clarification.\n\nWe assume this resource always exist regardless that it actually exists in the database or not. That is, this resource is never deleted in the context of the API behavior. it completely makes sense to me to always return 204!","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7009fb64daba66413a3f64da4df33918e2edfb94","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":149,"context_line":"            self._cleanup("},{"line_number":150,"context_line":"                context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":151,"context_line":"                router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _build_topology(self, context, tenant_id, default_external_network):"},{"line_number":154,"context_line":"        \"\"\"Build the network topology and returns its network UUID.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_8feeabb2","line":151,"in_reply_to":"1ac06dbe_8f198b7c","updated":"2016-08-24 17:05:49.000000000","message":"Ok then! :)","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c9141e2efbe81e04eec976f00fb766c1f053facd","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":149,"context_line":"            self._cleanup("},{"line_number":150,"context_line":"                context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":151,"context_line":"                router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _build_topology(self, context, tenant_id, default_external_network):"},{"line_number":154,"context_line":"        \"\"\"Build the network topology and returns its network UUID.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_24251e5c","line":151,"in_reply_to":"1ac06dbe_9b8f11cc","updated":"2016-08-24 16:42:12.000000000","message":"Bottom line is: this will always return 204 because even in the absence of the topology the API layer/policy engine check will trigger a creation and hence the delete method does need to delete! This is the result of a GET with side effects.\n\nI think get_security_groups might have a similar problem [1] (get with side effects) where a tenant is always gonna see a default security group, even if the admin deletes it.\n\n[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/securitygroups_db.py#n140","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5a9dc6889291fa0bcd809f74fd0997be57493bbd","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":149,"context_line":"            self._cleanup("},{"line_number":150,"context_line":"                context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":151,"context_line":"                router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _build_topology(self, context, tenant_id, default_external_network):"},{"line_number":154,"context_line":"        \"\"\"Build the network topology and returns its network UUID.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_f5dbb61f","line":151,"in_reply_to":"1ac06dbe_c4eb8111","updated":"2016-08-24 15:30:24.000000000","message":"In reality this method will never return 404, but always 204. That\u0027s because the way our policy engine works, we\u0027re always getting before proceeding. Therefore, in the absence of a topology, a check on the policy engine will end up generating the topology first before deleting it!\n\nAt the time this was designed we were on the fence on whether to use a GET that creates, an idempotent POST, or PUT on an inexistent resource. Amongst all of the non ideal choices we went with GET, and since we never really planned on implementing a DELETE we didn\u0027t think it was a problem. However now we\u0027re coming to terms with the fact :)\n\nI have been thinking on whether to leave things as they are (assuming that users are not stupid enough to invoke a command on something that have not created) or tweak things somewhere else to avoid the needless generation. I am still mulling over.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a515eb3d7642b83bd8968bb7ca8c9df33436b41b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                filters\u003d{\u0027network_id\u0027: [topology[\u0027network_id\u0027]]})"},{"line_number":149,"context_line":"            self._cleanup("},{"line_number":150,"context_line":"                context, network_id\u003dtopology[\u0027network_id\u0027],"},{"line_number":151,"context_line":"                router_id\u003dtopology[\u0027router_id\u0027], subnets\u003dsubnets)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _build_topology(self, context, tenant_id, default_external_network):"},{"line_number":154,"context_line":"        \"\"\"Build the network topology and returns its network UUID.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_9b8f11cc","line":151,"in_reply_to":"1ac06dbe_f5dbb61f","updated":"2016-08-24 16:10:03.000000000","message":"I noticed this point and I agree 204. There are many opinios about 404 vs 204 when a resorce doesn\u0027t exist in DELETE case. I think that neutron follows two policies.\n\n * DELETE /resources/id: This returns 404 when the resource of id doesn\u0027t exist.\n * DELETE /resources: This always returns 204 even when the resources don\u0027t exit.\n\nPlease look at tag spec[1] API-WG team defined. Tag API follows the policies. A problem is which cases are fine to delete_auto_allocated_topology. Topology is one per tenant and user doesn\u0027t consider the id. Therefore, 204 is better.\n\n[1]: https://specs.openstack.org/openstack/api-wg/guidelines/tags.html","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"98a54a8dabf3986938aa8bb40a2ecacb0ad15385","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _get_auto_allocated_network(self, context, tenant_id):"},{"line_number":209,"context_line":"        \"\"\"Get the auto allocated network for the tenant.\"\"\""},{"line_number":210,"context_line":"        network \u003d self._get_auto_allocated_topology(context, tenant_id)"},{"line_number":211,"context_line":"        if network:"},{"line_number":212,"context_line":"            return network[\u0027network_id\u0027]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _response(self, network_id, tenant_id, fields\u003dNone):"},{"line_number":215,"context_line":"        \"\"\"Build response for auto-allocated network.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_9912f907","line":212,"range":{"start_line":210,"start_character":8,"end_line":212,"end_character":40},"updated":"2016-08-23 02:19:25.000000000","message":"nit\n topology \u003d self._get_auto_allocated_topology(context, tenant_id)\n if topology:\n     return topology[\u0027network_id\u0027]","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5a793971eca957e61038736f4bb6cb045129d319","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _get_auto_allocated_network(self, context, tenant_id):"},{"line_number":209,"context_line":"        \"\"\"Get the auto allocated network for the tenant.\"\"\""},{"line_number":210,"context_line":"        network \u003d self._get_auto_allocated_topology(context, tenant_id)"},{"line_number":211,"context_line":"        if network:"},{"line_number":212,"context_line":"            return network[\u0027network_id\u0027]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _response(self, network_id, tenant_id, fields\u003dNone):"},{"line_number":215,"context_line":"        \"\"\"Build response for auto-allocated network.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_590b618e","line":212,"range":{"start_line":210,"start_character":8,"end_line":212,"end_character":40},"in_reply_to":"1ac06dbe_9912f907","updated":"2016-08-23 02:24:26.000000000","message":"ack","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"}],"neutron/tests/tempest/api/test_auto_allocated_topology.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"41fc26f11199605072f7612bfa1649880b501d62","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.subnets.extend(body[\u0027subnets\u0027])"},{"line_number":79,"context_line":"        body \u003d client.list_networks(name\u003d\u0027auto_allocated_network\u0027)"},{"line_number":80,"context_line":"        self.networks.extend(body[\u0027networks\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @test.idempotent_id(\u002764bc0b02-cee4-11e5-9f3c-080027605a2b\u0027)"},{"line_number":83,"context_line":"    def test_get_allocated_net_topology_as_tenant(self):"},{"line_number":84,"context_line":"        resources_before \u003d self._count_topology_resources()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_9146a44d","line":81,"updated":"2016-08-25 08:02:01.000000000","message":"I noticed that this tests \"/v2.0/auto-allocated-topology/None\" only as URI. Well, it\u0027s confused just a bit but no problem.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"42756d188bb7af05764acca1f16b37af90be1952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_b1f17297","line":118,"updated":"2016-08-24 08:01:35.000000000","message":"Do you also want to test:\n  n1 \u003d get_auto_allocated_topology()\n  delete_auto_allocated_topology()\n  n2 \u003d get_auto_allocated_topology()\nand check that n2 !\u003d n1?","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7a57749e21cef2da232d6a1a7645488d604432af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa7ab95a_a4ac6336","line":118,"in_reply_to":"1ac06dbe_2f59778f","updated":"2016-08-26 20:28:53.000000000","message":"I meant a check that the auto-allocated network after deletion is not the same as the one before the deletion. But now I think the existing test case is sufficient.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b68995d7893c936f494b3edddb894b2acf7771c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_e9a01644","line":118,"in_reply_to":"1ac06dbe_b1f17297","updated":"2016-08-24 11:24:15.000000000","message":"What do you want to test? Do we would like to confirm a new topology is successfully created after deletion?\nHonestly I think n1 !\u003d n2 is not important.","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7009fb64daba66413a3f64da4df33918e2edfb94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_2f59778f","line":118,"in_reply_to":"1ac06dbe_e9a01644","updated":"2016-08-24 17:05:49.000000000","message":"Assume that n2 is indeed \u003d\u003d n1. This means that it is (0, 0, 0), which means for some crazy reason the topology has not been provided. Shouldn\u0027t the previous test cover that?","commit_id":"dfa702fac80312b0c5b93c78e92f9d01ea11bbd6"}]}
