)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f6f1b3979106c95f741157ae8d00bdc687006d10","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            return False"},{"line_number":125,"context_line":"        return self.__dict__ \u003d\u003d other.__dict__"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __ne__(self, other):"},{"line_number":128,"context_line":"        return not self \u003d\u003d other"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_a0ff1933","line":127,"updated":"2016-10-05 01:16:20.000000000","message":"dumb question - why here do you not take pager into account?","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aae998156c163f9cec0cf5e462263e1cc37e16c5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            return False"},{"line_number":125,"context_line":"        return self.__dict__ \u003d\u003d other.__dict__"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __ne__(self, other):"},{"line_number":128,"context_line":"        return not self \u003d\u003d other"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_14c9e678","line":127,"in_reply_to":"1a95cdbc_a0ff1933","updated":"2016-10-05 08:57:34.000000000","message":"He does on L123","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"46e6d3bba4f2fa5078d969cbeebdd9d5b8b07504","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            return False"},{"line_number":125,"context_line":"        return self.__dict__ \u003d\u003d other.__dict__"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __ne__(self, other):"},{"line_number":128,"context_line":"        return not self \u003d\u003d other"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_ed03c8b6","line":127,"in_reply_to":"1a95cdbc_a0ff1933","updated":"2016-10-05 11:22:51.000000000","message":"Not sure I got your point, but yeah, what Jakub said, line 128 will trigger __eq__.","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f6f1b3979106c95f741157ae8d00bdc687006d10","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return self.__dict__ \u003d\u003d other.__dict__"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __ne__(self, other):"},{"line_number":128,"context_line":"        return not self \u003d\u003d other"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_e0f9214f","line":128,"updated":"2016-10-05 01:16:20.000000000","message":"why not using __dict__?","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"46e6d3bba4f2fa5078d969cbeebdd9d5b8b07504","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return self.__dict__ \u003d\u003d other.__dict__"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def __ne__(self, other):"},{"line_number":128,"context_line":"        return not self \u003d\u003d other"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_8de24402","line":128,"in_reply_to":"1a95cdbc_e0f9214f","updated":"2016-10-05 11:22:51.000000000","message":"? Can you elaborate? If you mean returning (not self.__dict__ \u003d\u003d other.__dict__), yeah, we could do it, but then we would need to duplicate lines 123-124 here.","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"25adb49654a534ed8996e3cb0b55b3719d563545","unresolved":false,"context_lines":[{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"    def test_comparison_None(self):"},{"line_number":1234,"context_line":"        pager \u003d base.Pager()"},{"line_number":1235,"context_line":"        self.assertFalse(pager.__eq__(None))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_203b53ed","line":1235,"range":{"start_line":1235,"start_character":13,"end_line":1235,"end_character":24},"updated":"2016-08-19 13:17:50.000000000","message":"Nit: I think assertNotEqual simulates better the real use case as in comparisons operator is usually used.","commit_id":"f0b9b5d139275624395c8e1ca49065fa8ec9279f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9b23157dc6b66b407e18bd95516eaa0c2ab7c64f","unresolved":false,"context_lines":[{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"    def test_comparison___ne___None(self):"},{"line_number":1342,"context_line":"        pager \u003d base.Pager()"},{"line_number":1343,"context_line":"        self.assertNotEqual(None, pager)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_comparison___eq___None(self):"},{"line_number":1346,"context_line":"        pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_94627f3c","line":1343,"range":{"start_line":1343,"start_character":34,"end_line":1343,"end_character":39},"updated":"2016-09-08 18:01:23.000000000","message":"Nit: could shorten this 1 LOC by just using::\n\nself.assertNotEqual(None, pager \u003d base.Pager())","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"14a5c0e869f5240ca9b4fb9522790be23fd24934","unresolved":false,"context_lines":[{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"    def test_comparison___ne___None(self):"},{"line_number":1342,"context_line":"        pager \u003d base.Pager()"},{"line_number":1343,"context_line":"        self.assertNotEqual(None, pager)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_comparison___eq___None(self):"},{"line_number":1346,"context_line":"        pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_21724a7d","line":1343,"range":{"start_line":1343,"start_character":34,"end_line":1343,"end_character":39},"in_reply_to":"1a95cdbc_7e55cd1b","updated":"2016-10-04 14:25:52.000000000","message":"That I believe won\u0027t trigger what I need. (__eq__)","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8412e608630d1239ea8f977f7578c3402c7bed1c","unresolved":false,"context_lines":[{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"    def test_comparison___ne___None(self):"},{"line_number":1342,"context_line":"        pager \u003d base.Pager()"},{"line_number":1343,"context_line":"        self.assertNotEqual(None, pager)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_comparison___eq___None(self):"},{"line_number":1346,"context_line":"        pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_b41dc374","line":1343,"range":{"start_line":1343,"start_character":34,"end_line":1343,"end_character":39},"in_reply_to":"9a89bdaa_94627f3c","updated":"2016-09-08 18:04:53.000000000","message":"But why? :)","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"24bc1a8582c773015f8ec6935b9eaa6296269fc9","unresolved":false,"context_lines":[{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"    def test_comparison___ne___None(self):"},{"line_number":1342,"context_line":"        pager \u003d base.Pager()"},{"line_number":1343,"context_line":"        self.assertNotEqual(None, pager)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_comparison___eq___None(self):"},{"line_number":1346,"context_line":"        pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_a74bc5af","line":1343,"range":{"start_line":1343,"start_character":34,"end_line":1343,"end_character":39},"in_reply_to":"9a89bdaa_94627f3c","updated":"2016-10-04 16:14:49.000000000","message":"I think it is good as it is now, and simple to read","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"e2c9b588bd50bbd7b2b5cb9b0ad7c01e9b3b01fc","unresolved":false,"context_lines":[{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"    def test_comparison___ne___None(self):"},{"line_number":1342,"context_line":"        pager \u003d base.Pager()"},{"line_number":1343,"context_line":"        self.assertNotEqual(None, pager)"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_comparison___eq___None(self):"},{"line_number":1346,"context_line":"        pager \u003d base.Pager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_7e55cd1b","line":1343,"range":{"start_line":1343,"start_character":34,"end_line":1343,"end_character":39},"in_reply_to":"9a89bdaa_b41dc374","updated":"2016-10-04 14:24:08.000000000","message":"You could use here `assertIsNotNone`. Both Pythons support that.  [1][2]\n\n[1] https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIsNotNone\n[2] https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertIsNotNone","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9b23157dc6b66b407e18bd95516eaa0c2ab7c64f","unresolved":false,"context_lines":[{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_comparison___eq___None(self):"},{"line_number":1346,"context_line":"        pager \u003d base.Pager()"},{"line_number":1347,"context_line":"        self.assertFalse(pager.__eq__(None))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_54e477aa","line":1347,"range":{"start_line":1347,"start_character":25,"end_line":1347,"end_character":30},"updated":"2016-09-08 18:01:23.000000000","message":"ditto","commit_id":"3ba13b94c3c547e19949afc138ebca59b21988a7"}]}
