)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Linux Bridge: driver support for QoS egress minimum bandwidth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds Linux Bridge agent driver the ability to control Linux"},{"line_number":10,"context_line":"Traffic Control (TC) to set the minimum required transmission rate for"},{"line_number":11,"context_line":"an interface."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":40,"id":"ba5201f7_66095a84","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"updated":"2017-01-11 16:22:31.000000000","message":"s/adds/provides the/","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Linux Bridge: driver support for QoS egress minimum bandwidth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds Linux Bridge agent driver the ability to control Linux"},{"line_number":10,"context_line":"Traffic Control (TC) to set the minimum required transmission rate for"},{"line_number":11,"context_line":"an interface."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":40,"id":"ba5201f7_6005b70f","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"in_reply_to":"ba5201f7_66095a84","updated":"2017-01-11 17:54:03.000000000","message":"Done","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The TC library is refactored to use HTB qdiscs. This allows TC to"},{"line_number":14,"context_line":"define, for several flows in the same interface, the maximum and the"},{"line_number":15,"context_line":"minimum rate and the burst size."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To be able to do traffic shaping (instead of policing) for ingress"},{"line_number":18,"context_line":"traffic, a new element, the Intermediate Functional Block device (IFB)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":40,"id":"ba5201f7_e64b8aaf","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":12},"updated":"2017-01-11 16:22:31.000000000","message":"Maybe use \"network bandwidth\" here instead of \"rate\".\nJust to be explicit.","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The TC library is refactored to use HTB qdiscs. This allows TC to"},{"line_number":14,"context_line":"define, for several flows in the same interface, the maximum and the"},{"line_number":15,"context_line":"minimum rate and the burst size."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To be able to do traffic shaping (instead of policing) for ingress"},{"line_number":18,"context_line":"traffic, a new element, the Intermediate Functional Block device (IFB)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":40,"id":"ba5201f7_00494b60","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":12},"in_reply_to":"ba5201f7_e64b8aaf","updated":"2017-01-11 17:54:03.000000000","message":"Done","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"}],"doc/source/devref/quality_of_service.rst":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"b8a6086e7ec229fc63a94428c251e2fe49546b4f","unresolved":false,"context_lines":[{"line_number":390,"context_line":"`tc-htb \u003chttps://linux.die.net/man/8/tc-htb\u003e`_, replacing the former one used"},{"line_number":391,"context_line":"`tc-tbf \u003chttp://linux.die.net/man/8/tc-tbf\u003e`_."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Traffic shaping in executed only for interface agress traffic. Because the"},{"line_number":394,"context_line":"traffic coming from the instance is considered as ingress traffic by the"},{"line_number":395,"context_line":"interface, shaping is not possible. To solve this, a new element is introduced:"},{"line_number":396,"context_line":"`Intermediate Functional Block \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node3.html\u003e`_,"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_3111b4ad","line":393,"range":{"start_line":393,"start_character":47,"end_line":393,"end_character":53},"updated":"2017-01-13 10:25:31.000000000","message":"s/agress/egress","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"b8a6086e7ec229fc63a94428c251e2fe49546b4f","unresolved":false,"context_lines":[{"line_number":390,"context_line":"`tc-htb \u003chttps://linux.die.net/man/8/tc-htb\u003e`_, replacing the former one used"},{"line_number":391,"context_line":"`tc-tbf \u003chttp://linux.die.net/man/8/tc-tbf\u003e`_."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Traffic shaping in executed only for interface agress traffic. Because the"},{"line_number":394,"context_line":"traffic coming from the instance is considered as ingress traffic by the"},{"line_number":395,"context_line":"interface, shaping is not possible. To solve this, a new element is introduced:"},{"line_number":396,"context_line":"`Intermediate Functional Block \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node3.html\u003e`_,"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_f17d6ce8","line":393,"range":{"start_line":393,"start_character":16,"end_line":393,"end_character":18},"updated":"2017-01-13 10:25:31.000000000","message":"s/in/is","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"05005018acd444622b730fae218ca481adee9b36","unresolved":false,"context_lines":[{"line_number":390,"context_line":"`tc-htb \u003chttps://linux.die.net/man/8/tc-htb\u003e`_, replacing the former one used"},{"line_number":391,"context_line":"`tc-tbf \u003chttp://linux.die.net/man/8/tc-tbf\u003e`_."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Traffic shaping in executed only for interface agress traffic. Because the"},{"line_number":394,"context_line":"traffic coming from the instance is considered as ingress traffic by the"},{"line_number":395,"context_line":"interface, shaping is not possible. To solve this, a new element is introduced:"},{"line_number":396,"context_line":"`Intermediate Functional Block \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node3.html\u003e`_,"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_864b092b","line":393,"range":{"start_line":393,"start_character":47,"end_line":393,"end_character":53},"in_reply_to":"7a3c09a3_3111b4ad","updated":"2017-01-13 10:44:54.000000000","message":"Done","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"05005018acd444622b730fae218ca481adee9b36","unresolved":false,"context_lines":[{"line_number":390,"context_line":"`tc-htb \u003chttps://linux.die.net/man/8/tc-htb\u003e`_, replacing the former one used"},{"line_number":391,"context_line":"`tc-tbf \u003chttp://linux.die.net/man/8/tc-tbf\u003e`_."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Traffic shaping in executed only for interface agress traffic. Because the"},{"line_number":394,"context_line":"traffic coming from the instance is considered as ingress traffic by the"},{"line_number":395,"context_line":"interface, shaping is not possible. To solve this, a new element is introduced:"},{"line_number":396,"context_line":"`Intermediate Functional Block \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node3.html\u003e`_,"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_c65511c7","line":393,"range":{"start_line":393,"start_character":16,"end_line":393,"end_character":18},"in_reply_to":"7a3c09a3_f17d6ce8","updated":"2017-01-13 10:44:54.000000000","message":"Done","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"b8a6086e7ec229fc63a94428c251e2fe49546b4f","unresolved":false,"context_lines":[{"line_number":394,"context_line":"traffic coming from the instance is considered as ingress traffic by the"},{"line_number":395,"context_line":"interface, shaping is not possible. To solve this, a new element is introduced:"},{"line_number":396,"context_line":"`Intermediate Functional Block \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node3.html\u003e`_,"},{"line_number":397,"context_line":"a pseudo network interface used to redirect al the ingress traffic from the TAP"},{"line_number":398,"context_line":"port to the egress IFB queue. The QoS rules are applied on this IFB"},{"line_number":399,"context_line":"interface associated to the TAP port::"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_c34b4358","line":397,"range":{"start_line":397,"start_character":44,"end_line":397,"end_character":46},"updated":"2017-01-13 10:25:31.000000000","message":"s/al/all","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"05005018acd444622b730fae218ca481adee9b36","unresolved":false,"context_lines":[{"line_number":394,"context_line":"traffic coming from the instance is considered as ingress traffic by the"},{"line_number":395,"context_line":"interface, shaping is not possible. To solve this, a new element is introduced:"},{"line_number":396,"context_line":"`Intermediate Functional Block \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node3.html\u003e`_,"},{"line_number":397,"context_line":"a pseudo network interface used to redirect al the ingress traffic from the TAP"},{"line_number":398,"context_line":"port to the egress IFB queue. The QoS rules are applied on this IFB"},{"line_number":399,"context_line":"interface associated to the TAP port::"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_460f61e1","line":397,"range":{"start_line":397,"start_character":44,"end_line":397,"end_character":46},"in_reply_to":"7a3c09a3_c34b4358","updated":"2017-01-13 10:44:54.000000000","message":"Done","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c7247d6ede14949fdc81708d18ef52669a499494","unresolved":false,"context_lines":[{"line_number":397,"context_line":"a pseudo network interface used to redirect al the ingress traffic from the TAP"},{"line_number":398,"context_line":"port to the egress IFB queue. The QoS rules are applied on this IFB"},{"line_number":399,"context_line":"interface associated to the TAP port::"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    +-----------------+"},{"line_number":402,"context_line":"    | [Instance veth] |"},{"line_number":403,"context_line":"    +-----------------+"}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_39e8ba7c","line":400,"updated":"2017-01-13 11:45:42.000000000","message":"oh, nice graph! ;)","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"b8a6086e7ec229fc63a94428c251e2fe49546b4f","unresolved":false,"context_lines":[{"line_number":414,"context_line":"      +--------------------------------+                          | traffic"},{"line_number":415,"context_line":"                                                                 \\ /"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Traffic in the tap port is redirected (\"mirred\") to the IFB using a Traffic"},{"line_number":418,"context_line":"Control filter"},{"line_number":419,"context_line":"(`Filter Actions \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node2.html\u003e`_)."},{"line_number":420,"context_line":""}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_a3ac77ee","line":417,"range":{"start_line":417,"start_character":40,"end_line":417,"end_character":46},"updated":"2017-01-13 10:25:31.000000000","message":"Should this be mirrored?","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c7247d6ede14949fdc81708d18ef52669a499494","unresolved":false,"context_lines":[{"line_number":414,"context_line":"      +--------------------------------+                          | traffic"},{"line_number":415,"context_line":"                                                                 \\ /"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Traffic in the tap port is redirected (\"mirred\") to the IFB using a Traffic"},{"line_number":418,"context_line":"Control filter"},{"line_number":419,"context_line":"(`Filter Actions \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node2.html\u003e`_)."},{"line_number":420,"context_line":""}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_d98df67c","line":417,"updated":"2017-01-13 11:45:42.000000000","message":"mirrored","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"05005018acd444622b730fae218ca481adee9b36","unresolved":false,"context_lines":[{"line_number":414,"context_line":"      +--------------------------------+                          | traffic"},{"line_number":415,"context_line":"                                                                 \\ /"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Traffic in the tap port is redirected (\"mirred\") to the IFB using a Traffic"},{"line_number":418,"context_line":"Control filter"},{"line_number":419,"context_line":"(`Filter Actions \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node2.html\u003e`_)."},{"line_number":420,"context_line":""}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_060559c1","line":417,"range":{"start_line":417,"start_character":40,"end_line":417,"end_character":46},"in_reply_to":"7a3c09a3_a3ac77ee","updated":"2017-01-13 10:44:54.000000000","message":"This is the action name given in tc-filter, that\u0027s why I wrote it in quotes.","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d528e014795dfc9dea3ead0575a5dcb00ee355fb","unresolved":false,"context_lines":[{"line_number":414,"context_line":"      +--------------------------------+                          | traffic"},{"line_number":415,"context_line":"                                                                 \\ /"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Traffic in the tap port is redirected (\"mirred\") to the IFB using a Traffic"},{"line_number":418,"context_line":"Control filter"},{"line_number":419,"context_line":"(`Filter Actions \u003chttp://linux-ip.net/gl/tc-filters/tc-filters-node2.html\u003e`_)."},{"line_number":420,"context_line":""}],"source_content_type":"text/x-rst","patch_set":42,"id":"7a3c09a3_19885022","line":417,"in_reply_to":"7a3c09a3_d98df67c","updated":"2017-01-13 15:37:25.000000000","message":"Done","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"dd69191012c0dba214034f3aa3b230a3c24b312d","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    +-----------------+"},{"line_number":387,"context_line":"      | (egress traffic, instance point of view)"},{"line_number":388,"context_line":"      |"},{"line_number":389,"context_line":"      |                                +--------------------------+"},{"line_number":390,"context_line":"     \\ /        [tap port]             |                [IFB]    \\ /"},{"line_number":391,"context_line":"    +-------------------------------+  |  +-------------------------------+"},{"line_number":392,"context_line":"    | ingress queue | egress queue  |  |  | ingress queue | egress queue  |"}],"source_content_type":"text/x-rst","patch_set":44,"id":"5a3905b3_8cb611f7","line":389,"updated":"2017-01-24 00:31:03.000000000","message":"Have you profiled this to see if adding this intermediary IFB has a performance impact?","commit_id":"84b3ae3ae9111e241352bdccad238c9fd37b83df"}],"etc/neutron/rootwrap.d/linuxbridge-plugin.filters":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"find: RegExpFilter, find, root, find, /sys/class/net, -maxdepth, 1, -type, l, -printf, %.*"},{"line_number":20,"context_line":"ip_exec: IpNetnsExecFilter, ip, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# tc commands needed for QoS support"},{"line_number":23,"context_line":"tc_replace_tbf: RegExpFilter, tc, root, tc, qdisc, replace, dev, .+, root, tbf, rate, .+, latency, .+, burst, .+"},{"line_number":24,"context_line":"tc_add_ingress: RegExpFilter, tc, root, tc, qdisc, add, dev, .+, ingress, handle, .+"},{"line_number":25,"context_line":"tc_delete: RegExpFilter, tc, root, tc, qdisc, del, dev, .+, .+"}],"source_content_type":"application/octet-stream","patch_set":40,"id":"ba5201f7_66e5daa2","side":"PARENT","line":22,"updated":"2017-01-11 16:22:31.000000000","message":"Are these commands not needed at all anymore?","commit_id":"c08766db460ec4808ca16d6e9536c71365dc61eb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":19,"context_line":"find: RegExpFilter, find, root, find, /sys/class/net, -maxdepth, 1, -type, l, -printf, %.*"},{"line_number":20,"context_line":"ip_exec: IpNetnsExecFilter, ip, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# tc commands needed for QoS support"},{"line_number":23,"context_line":"tc_replace_tbf: RegExpFilter, tc, root, tc, qdisc, replace, dev, .+, root, tbf, rate, .+, latency, .+, burst, .+"},{"line_number":24,"context_line":"tc_add_ingress: RegExpFilter, tc, root, tc, qdisc, add, dev, .+, ingress, handle, .+"},{"line_number":25,"context_line":"tc_delete: RegExpFilter, tc, root, tc, qdisc, del, dev, .+, .+"}],"source_content_type":"application/octet-stream","patch_set":40,"id":"ba5201f7_00e5cb36","side":"PARENT","line":22,"in_reply_to":"ba5201f7_66e5daa2","updated":"2017-01-11 17:54:03.000000000","message":"No, those commands where used only in tc_lib. I left only the commands currently in use.","commit_id":"c08766db460ec4808ca16d6e9536c71365dc61eb"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return IPDevice(name, namespace\u003dself.namespace)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def del_ifb(self, name):"},{"line_number":211,"context_line":"        \"\"\"Create a Linux IFB type interface with the given name.\"\"\""},{"line_number":212,"context_line":"        self._as_root([], \u0027link\u0027, (\u0027del\u0027, name))"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def ensure_namespace(self, name):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_dc923d57","line":211,"updated":"2016-11-07 22:04:42.000000000","message":"s/Create/Delete","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        return IPDevice(name, namespace\u003dself.namespace)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def del_ifb(self, name):"},{"line_number":211,"context_line":"        \"\"\"Create a Linux IFB type interface with the given name.\"\"\""},{"line_number":212,"context_line":"        self._as_root([], \u0027link\u0027, (\u0027del\u0027, name))"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def ensure_namespace(self, name):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_b782d650","line":211,"in_reply_to":"9a629dbe_dc923d57","updated":"2016-11-09 08:57:51.000000000","message":"Done","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def del_ifb(self, name):"},{"line_number":217,"context_line":"        \"\"\"Delete a Linux IFB type interface with the given name.\"\"\""},{"line_number":218,"context_line":"        self._as_root([], \u0027link\u0027, (\u0027del\u0027, name))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def ensure_namespace(self, name):"},{"line_number":221,"context_line":"        if not self.netns.exists(name):"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_067c0eb4","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":46},"updated":"2017-01-11 16:22:31.000000000","message":"Do you not need to specify the type like above?","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def del_ifb(self, name):"},{"line_number":217,"context_line":"        \"\"\"Delete a Linux IFB type interface with the given name.\"\"\""},{"line_number":218,"context_line":"        self._as_root([], \u0027link\u0027, (\u0027del\u0027, name))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def ensure_namespace(self, name):"},{"line_number":221,"context_line":"        if not self.netns.exists(name):"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_20500fd4","line":218,"range":{"start_line":218,"start_character":35,"end_line":218,"end_character":46},"in_reply_to":"ba5201f7_067c0eb4","updated":"2017-01-11 17:54:03.000000000","message":"No, only the device name.","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"}],"neutron/agent/linux/tc_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67aa780dba55f90b972f41f308645092e5d96565","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def _cmd_policy_class(self, classid, type, rate, device, parent\u003dNone,"},{"line_number":178,"context_line":"                          ceil\u003dNone, burst\u003dNone):"},{"line_number":179,"context_line":"        if parent:"},{"line_number":180,"context_line":"            cmd \u003d [\u0027class\u0027, \u0027add\u0027, \u0027dev\u0027, device, \u0027parent\u0027, parent]"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            cmd \u003d [\u0027class\u0027, \u0027mod\u0027, \u0027dev\u0027, device]"},{"line_number":183,"context_line":"        cmd +\u003d [\u0027classid\u0027, classid, type, \u0027rate\u0027, rate]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_db3e9728","line":180,"updated":"2016-08-24 20:54:38.000000000","message":"I\u0027m not sure but maybe You can use \"replace\" instead of \"add\" - it should work for create and update as well","commit_id":"3a1b75cf8790ecf8e4ed995042ec9aef0be36237"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"837fdc1a8e497c6356ab7585ed7c6d407f792478","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def _cmd_policy_class(self, classid, type, rate, device, parent\u003dNone,"},{"line_number":178,"context_line":"                          ceil\u003dNone, burst\u003dNone):"},{"line_number":179,"context_line":"        if parent:"},{"line_number":180,"context_line":"            cmd \u003d [\u0027class\u0027, \u0027add\u0027, \u0027dev\u0027, device, \u0027parent\u0027, parent]"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            cmd \u003d [\u0027class\u0027, \u0027mod\u0027, \u0027dev\u0027, device]"},{"line_number":183,"context_line":"        cmd +\u003d [\u0027classid\u0027, classid, type, \u0027rate\u0027, rate]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_6dbfc4fc","line":180,"in_reply_to":"1ac06dbe_db3e9728","updated":"2016-08-25 10:18:58.000000000","message":"I\u0027ll check that. That could reduce the code, just using one command. Thanks!","commit_id":"3a1b75cf8790ecf8e4ed995042ec9aef0be36237"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67aa780dba55f90b972f41f308645092e5d96565","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            _class[\u0027rate\u0027] \u003d convert_to_kilobits(match.groups()[6], SI_BASE)"},{"line_number":209,"context_line":"            _class[\u0027ceil\u0027] \u003d convert_to_kilobits(match.groups()[7], SI_BASE)"},{"line_number":210,"context_line":"            _class[\u0027burst\u0027] \u003d convert_to_kilobits(match.groups()[8], IEC_BASE)"},{"line_number":211,"context_line":"            _class[\u0027cburst\u0027] \u003d convert_to_kilobits(match.groups()[9], IEC_BASE)"},{"line_number":212,"context_line":"            classes[classid] \u003d _class"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return classes"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_fb1c33c3","line":211,"updated":"2016-08-24 20:54:38.000000000","message":"please double check units here because (at least for me) tc has got strange notification of units :)","commit_id":"3a1b75cf8790ecf8e4ed995042ec9aef0be36237"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"837fdc1a8e497c6356ab7585ed7c6d407f792478","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            _class[\u0027rate\u0027] \u003d convert_to_kilobits(match.groups()[6], SI_BASE)"},{"line_number":209,"context_line":"            _class[\u0027ceil\u0027] \u003d convert_to_kilobits(match.groups()[7], SI_BASE)"},{"line_number":210,"context_line":"            _class[\u0027burst\u0027] \u003d convert_to_kilobits(match.groups()[8], IEC_BASE)"},{"line_number":211,"context_line":"            _class[\u0027cburst\u0027] \u003d convert_to_kilobits(match.groups()[9], IEC_BASE)"},{"line_number":212,"context_line":"            classes[classid] \u003d _class"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return classes"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_4d264869","line":211,"in_reply_to":"1ac06dbe_fb1c33c3","updated":"2016-08-25 10:18:58.000000000","message":"I\u0027m aware... I need to find the \"formal\" manual or I\u0027ll review the code to check this.","commit_id":"3a1b75cf8790ecf8e4ed995042ec9aef0be36237"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"ce5b0bf23c1c278da41c5f1ca34021af0a0108f3","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        else:"},{"line_number":297,"context_line":"            ifb \u003d ns_ip.add_ifb(dev_name)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        ifb.link.set_up()"},{"line_number":300,"context_line":"        return ifb"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _del_ifb(self, dev_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_f5a89722","line":299,"updated":"2016-09-15 18:36:53.000000000","message":"Could the host machine be exposed via link-local IPv6 addresses via these ifb interfaces? See bug #1534652 for background. Can we add a ifb.disable_ipv6() before .link.set_up().","commit_id":"1f46ac8b5e685cc4f955f6e64ef4ad1a9b8f1d4f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0110f4d760c429c9958910e41a4f1704d5ae9571","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        else:"},{"line_number":297,"context_line":"            ifb \u003d ns_ip.add_ifb(dev_name)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        ifb.link.set_up()"},{"line_number":300,"context_line":"        return ifb"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _del_ifb(self, dev_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_ed7ef817","line":299,"in_reply_to":"7a8ec9b2_f5a89722","updated":"2016-09-16 08:49:32.000000000","message":"Thank you!! Very good catch. This is a possible threat.","commit_id":"1f46ac8b5e685cc4f955f6e64ef4ad1a9b8f1d4f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b8e7d2ecdda860be9d4e3fb03130c877e6293ce","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            return self._set_egress_bw_limit(kilobits_to_bits(max, SI_BASE),"},{"line_number":129,"context_line":"                bits_to_bytes(kilobits_to_bits(burst, IEC_BASE)))"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            raise NotImplementedError()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def update_bw_limit(self, max, burst, direction):"},{"line_number":134,"context_line":"        self.set_bw_limit(max, burst, direction)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_398264c9","line":131,"updated":"2016-09-28 08:42:28.000000000","message":"maybe I missed something but I don\u0027t see definition of this exception Class or import. Are You sure You didn\u0027t forget it?","commit_id":"e7a50d68e49c8d46d5218045f5466f725cc68b46"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5136f128615e17b0a0c74abc28d1bac4ae75d6d9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            return self._set_egress_bw_limit(kilobits_to_bits(max, SI_BASE),"},{"line_number":129,"context_line":"                bits_to_bytes(kilobits_to_bits(burst, IEC_BASE)))"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            raise NotImplementedError()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def update_bw_limit(self, max, burst, direction):"},{"line_number":134,"context_line":"        self.set_bw_limit(max, burst, direction)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_2abbdf0f","line":131,"in_reply_to":"5a8bc5a2_398264c9","updated":"2016-09-28 09:26:21.000000000","message":"It\u0027s a built-in exception (https://docs.python.org/2/library/exceptions.html)","commit_id":"e7a50d68e49c8d46d5218045f5466f725cc68b46"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"class TcCommand(ip_lib.IPDevice):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def __init__(self, name, namespace\u003dNone):"},{"line_number":108,"context_line":"        super(TcCommand, self).__init__(name, namespace\u003dnamespace)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _execute_tc_cmd(self, cmd, **kwargs):"},{"line_number":111,"context_line":"        cmd \u003d [\u0027tc\u0027] + cmd"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_1c74b533","line":108,"updated":"2016-11-07 22:04:42.000000000","message":"is this __init__ method really neccessary now?","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"class TcCommand(ip_lib.IPDevice):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def __init__(self, name, namespace\u003dNone):"},{"line_number":108,"context_line":"        super(TcCommand, self).__init__(name, namespace\u003dnamespace)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _execute_tc_cmd(self, cmd, **kwargs):"},{"line_number":111,"context_line":"        cmd \u003d [\u0027tc\u0027] + cmd"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_78901444","line":108,"in_reply_to":"9a629dbe_1c74b533","updated":"2016-11-09 08:57:51.000000000","message":"You are right: this definition is inherited from IPDevice","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1086a46beafe999ab361fc785662cae5f5ffa7d5","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        ifb \u003d self._find_mirrored_ifb(INGRESS_QDISC_HANDLE)"},{"line_number":379,"context_line":"        if ifb:"},{"line_number":380,"context_line":"            policy \u003d self._show_policy_class(\"1:1\", dev\u003difb)"},{"line_number":381,"context_line":"            return policy[\u0027ceil\u0027], policy[\u0027burst\u0027], policy[\u0027rate\u0027]"},{"line_number":382,"context_line":"        return None, None, None"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a6eadb0_e6d035fa","line":381,"updated":"2016-12-19 21:24:44.000000000","message":"Still it looks like something is wrong here because fullstack is failing: http://logs.openstack.org/65/357865/25/check/gate-neutron-dsvm-fullstack-ubuntu-xenial/c97a822/testr_results.html.gz\nPlease check it once again why policy is None in this fullstack test.","commit_id":"22415b078a44aee08acaddfa097a5554084ce0e8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"53ba8202aba9278e9a1c827c05b64a40bbcf6c80","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        ifb \u003d self._find_mirrored_ifb(INGRESS_QDISC_HANDLE)"},{"line_number":379,"context_line":"        if ifb:"},{"line_number":380,"context_line":"            policy \u003d self._show_policy_class(\"1:1\", dev\u003difb)"},{"line_number":381,"context_line":"            return policy[\u0027ceil\u0027], policy[\u0027burst\u0027], policy[\u0027rate\u0027]"},{"line_number":382,"context_line":"        return None, None, None"}],"source_content_type":"text/x-python","patch_set":25,"id":"da4df55a_453ca193","line":381,"in_reply_to":"1a6eadb0_e6d035fa","updated":"2016-12-22 16:08:28.000000000","message":"Yes, you are right and I see where is the error: the way I\u0027m finding the IFB is wrong. I\u0027ll change that","commit_id":"22415b078a44aee08acaddfa097a5554084ce0e8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6027bcd3ae7648502a109b8868772aba5075e945","unresolved":false,"context_lines":[{"line_number":38,"context_line":"SI_BASE \u003d 1000"},{"line_number":39,"context_line":"IEC_BASE \u003d 1024"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LATENCY_UNIT \u003d \"ms\""},{"line_number":42,"context_line":"BW_LIMIT_UNIT \u003d \"kbit\"  # kilobits per second in tc\u0027s notation"},{"line_number":43,"context_line":"BURST_UNIT \u003d \"kbit\"  # kilobits in tc\u0027s notation"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_0c52d3dd","line":41,"updated":"2017-01-09 21:04:04.000000000","message":"this is probably not used anymore","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76063088c7a64d93c186291b22421f450ac49ed5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"SI_BASE \u003d 1000"},{"line_number":39,"context_line":"IEC_BASE \u003d 1024"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LATENCY_UNIT \u003d \"ms\""},{"line_number":42,"context_line":"BW_LIMIT_UNIT \u003d \"kbit\"  # kilobits per second in tc\u0027s notation"},{"line_number":43,"context_line":"BURST_UNIT \u003d \"kbit\"  # kilobits in tc\u0027s notation"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_889f76b3","line":41,"in_reply_to":"ba5201f7_0c52d3dd","updated":"2017-01-10 10:47:15.000000000","message":"Done","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        burst \u003d (bits_to_bytes(kilobits_to_bits(burst, IEC_BASE)) if burst"},{"line_number":125,"context_line":"                 else burst)"},{"line_number":126,"context_line":"        min \u003d kilobits_to_bits(min, SI_BASE) if min else min"},{"line_number":127,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":128,"context_line":"            return self._set_ingress_bw(max, burst, min)"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_a9c5d58e","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":50},"updated":"2017-01-11 16:22:31.000000000","message":"I\u0027ve seen multiple of these checks, would 1 check in LB driver file not be better?","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        burst \u003d (bits_to_bytes(kilobits_to_bits(burst, IEC_BASE)) if burst"},{"line_number":125,"context_line":"                 else burst)"},{"line_number":126,"context_line":"        min \u003d kilobits_to_bits(min, SI_BASE) if min else min"},{"line_number":127,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":128,"context_line":"            return self._set_ingress_bw(max, burst, min)"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_9b3e8c89","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":50},"in_reply_to":"ba5201f7_a9c5d58e","updated":"2017-01-11 17:54:03.000000000","message":"Is a way to expose only one function, instead of make public two, one per direction. I can expose two functions, but I think is better in this way.","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            raise NotImplementedError()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def delete_bw(self, direction):"},{"line_number":133,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":134,"context_line":"            return self._delete_ingress()"},{"line_number":135,"context_line":"        else:"},{"line_number":136,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_c9c21985","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":50},"updated":"2017-01-11 16:22:31.000000000","message":"ditto","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            raise NotImplementedError()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def delete_bw(self, direction):"},{"line_number":133,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":134,"context_line":"            return self._delete_ingress()"},{"line_number":135,"context_line":"        else:"},{"line_number":136,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_b659a537","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":50},"in_reply_to":"ba5201f7_c9c21985","updated":"2017-01-11 17:54:03.000000000","message":"ditto","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            raise NotImplementedError()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def get_limits(self, direction):"},{"line_number":139,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":140,"context_line":"            return self._get_ingress_limits()"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_293805a0","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":51},"updated":"2017-01-11 16:22:31.000000000","message":"ditto","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            raise NotImplementedError()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def get_limits(self, direction):"},{"line_number":139,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":140,"context_line":"            return self._get_ingress_limits()"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_16499160","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":51},"in_reply_to":"ba5201f7_293805a0","updated":"2017-01-11 17:54:03.000000000","message":"ditto","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c7247d6ede14949fdc81708d18ef52669a499494","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":128,"context_line":"            return self._set_ingress_bw(max, burst, min)"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            raise NotImplementedError()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def delete_bw(self, direction):"},{"line_number":133,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_7c7cf020","line":130,"updated":"2017-01-13 11:45:42.000000000","message":"why not just avoiding the direction argument of function?","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d528e014795dfc9dea3ead0575a5dcb00ee355fb","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":128,"context_line":"            return self._set_ingress_bw(max, burst, min)"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            raise NotImplementedError()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def delete_bw(self, direction):"},{"line_number":133,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_b951fc64","line":130,"in_reply_to":"7a3c09a3_7c7cf020","updated":"2017-01-13 15:37:25.000000000","message":"I wanted to leave everything ready to enable, in the future, the ingress direction feature.","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c7247d6ede14949fdc81708d18ef52669a499494","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":134,"context_line":"            return self._delete_ingress()"},{"line_number":135,"context_line":"        else:"},{"line_number":136,"context_line":"            raise NotImplementedError()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def get_limits(self, direction):"},{"line_number":139,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_9c799c32","line":136,"updated":"2017-01-13 11:45:42.000000000","message":"ditto.","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d528e014795dfc9dea3ead0575a5dcb00ee355fb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":134,"context_line":"            return self._delete_ingress()"},{"line_number":135,"context_line":"        else:"},{"line_number":136,"context_line":"            raise NotImplementedError()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def get_limits(self, direction):"},{"line_number":139,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_791154ac","line":136,"in_reply_to":"7a3c09a3_9c799c32","updated":"2017-01-13 15:37:25.000000000","message":"ditto","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c7247d6ede14949fdc81708d18ef52669a499494","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":140,"context_line":"            return self._get_ingress_limits()"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            raise NotImplementedError()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _set_ingress_bw(self, max, burst, min):"},{"line_number":145,"context_line":"        self._add_policy_qdisc(INGRESS_QDISC, INGRESS_QDISC_HANDLE)"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_fc8e2026","line":142,"updated":"2017-01-13 11:45:42.000000000","message":"ditto.","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d528e014795dfc9dea3ead0575a5dcb00ee355fb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if direction \u003d\u003d constants.EGRESS_DIRECTION:"},{"line_number":140,"context_line":"            return self._get_ingress_limits()"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            raise NotImplementedError()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _set_ingress_bw(self, max, burst, min):"},{"line_number":145,"context_line":"        self._add_policy_qdisc(INGRESS_QDISC, INGRESS_QDISC_HANDLE)"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_99260015","line":142,"in_reply_to":"7a3c09a3_fc8e2026","updated":"2017-01-13 15:37:25.000000000","message":"ditto","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c7247d6ede14949fdc81708d18ef52669a499494","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        self._del_policy_qdisc(INGRESS_QDISC)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _add_policy_qdisc(self, parent, handle, qdisc_type\u003dNone, dev\u003dNone):"},{"line_number":155,"context_line":"        def check_qdisc(qdisc, type, handle, parent, device):"},{"line_number":156,"context_line":"            if not qdisc or qdisc.get(\u0027type\u0027) \u003d\u003d QDISC_TYPE_DEFAULT:"},{"line_number":157,"context_line":"                return False"},{"line_number":158,"context_line":"            elif ((type and (qdisc.get(\u0027type\u0027) !\u003d type or"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_5cec94c7","line":155,"updated":"2017-01-13 11:45:42.000000000","message":"type is a reserved keyword, may be qdisc_type ?","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d528e014795dfc9dea3ead0575a5dcb00ee355fb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        self._del_policy_qdisc(INGRESS_QDISC)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _add_policy_qdisc(self, parent, handle, qdisc_type\u003dNone, dev\u003dNone):"},{"line_number":155,"context_line":"        def check_qdisc(qdisc, type, handle, parent, device):"},{"line_number":156,"context_line":"            if not qdisc or qdisc.get(\u0027type\u0027) \u003d\u003d QDISC_TYPE_DEFAULT:"},{"line_number":157,"context_line":"                return False"},{"line_number":158,"context_line":"            elif ((type and (qdisc.get(\u0027type\u0027) !\u003d type or"}],"source_content_type":"text/x-python","patch_set":42,"id":"7a3c09a3_595ad884","line":155,"in_reply_to":"7a3c09a3_5cec94c7","updated":"2017-01-13 15:37:25.000000000","message":"Yes, qdisc_type is better","commit_id":"10a2d6f74e8f7f97734f6d8d4ebea0194fc7177b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"995deee594532f65163940395a6c89afee652071","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            elif ((qdisc_type and (qdisc.get(\u0027type\u0027) !\u003d qdisc_type or"},{"line_number":159,"context_line":"                    qdisc.get(\u0027handle\u0027) !\u003d handle)) or"},{"line_number":160,"context_line":"                    (not qdisc_type and qdisc.get(\u0027handle\u0027) !\u003d handle)):"},{"line_number":161,"context_line":"                self._del_policy_qdisc(parent, dev\u003ddevice)"},{"line_number":162,"context_line":"                return False"},{"line_number":163,"context_line":"            return True"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"5a3905b3_4e65a643","line":161,"updated":"2017-01-19 17:30:01.000000000","message":"Nice, so you clean the old config for max_bw, and set the new settings using htb instead of tbf :)\n\ngreat :)","commit_id":"84b3ae3ae9111e241352bdccad238c9fd37b83df"}],"neutron/common/utils.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":689,"context_line":""},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"def wait_until_true(predicate, timeout\u003d60, sleep\u003d1, exception\u003dNone,"},{"line_number":692,"context_line":"                    initial_sleep\u003dNone):"},{"line_number":693,"context_line":"    \"\"\""},{"line_number":694,"context_line":"    Wait until callable predicate is evaluated as True"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_49bc69bb","line":692,"range":{"start_line":692,"start_character":20,"end_line":692,"end_character":38},"updated":"2017-01-11 16:22:31.000000000","message":"If you default initial_sleep to 0 would you need the if statement?","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":689,"context_line":""},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"def wait_until_true(predicate, timeout\u003d60, sleep\u003d1, exception\u003dNone,"},{"line_number":692,"context_line":"                    initial_sleep\u003dNone):"},{"line_number":693,"context_line":"    \"\"\""},{"line_number":694,"context_line":"    Wait until callable predicate is evaluated as True"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_bba7d009","line":692,"range":{"start_line":692,"start_character":20,"end_line":692,"end_character":38},"in_reply_to":"ba5201f7_49bc69bb","updated":"2017-01-11 17:54:03.000000000","message":"eventlet.sleep(0) triggers an eventlet context switch, but I think is irrelevant in this case. I\u0027ll change it.","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"}],"neutron/conf/plugins/ml2/drivers/linuxbridge.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"qos_options \u003d ["},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027kernel_hz\u0027, default\u003dDEFAULT_KERNEL_HZ_VALUE,"},{"line_number":81,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":82,"context_line":"               help\u003d_(\"Value of host kernel tick rate (hz) for calculating \""},{"line_number":83,"context_line":"                      \"minimum burst value in bandwidth limit rules for \""},{"line_number":84,"context_line":"                      \"a port with QoS. See kernel configuration file for \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_47881a23","line":81,"updated":"2016-11-07 22:04:42.000000000","message":"this option is not used anywhere now so is it necessary to deprecate it first?","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"qos_options \u003d ["},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027kernel_hz\u0027, default\u003dDEFAULT_KERNEL_HZ_VALUE,"},{"line_number":81,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":82,"context_line":"               help\u003d_(\"Value of host kernel tick rate (hz) for calculating \""},{"line_number":83,"context_line":"                      \"minimum burst value in bandwidth limit rules for \""},{"line_number":84,"context_line":"                      \"a port with QoS. See kernel configuration file for \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_533173eb","line":81,"in_reply_to":"9a629dbe_47881a23","updated":"2016-11-09 08:57:51.000000000","message":"Done","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \"a port with QoS. See kernel configuration file for \""},{"line_number":85,"context_line":"                      \"HZ value and tc-tbf manual for more information.\")),"},{"line_number":86,"context_line":"    cfg.IntOpt(\u0027tbf_latency\u0027, default\u003dDEFAULT_TC_TBF_LATENCY,"},{"line_number":87,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":88,"context_line":"               help\u003d_(\"Value of latency (ms) for calculating size of queue \""},{"line_number":89,"context_line":"                      \"for a port with QoS. See tc-tbf manual for more \""},{"line_number":90,"context_line":"                      \"information.\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_a787360e","line":87,"updated":"2016-11-07 22:04:42.000000000","message":"same here","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \"a port with QoS. See kernel configuration file for \""},{"line_number":85,"context_line":"                      \"HZ value and tc-tbf manual for more information.\")),"},{"line_number":86,"context_line":"    cfg.IntOpt(\u0027tbf_latency\u0027, default\u003dDEFAULT_TC_TBF_LATENCY,"},{"line_number":87,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":88,"context_line":"               help\u003d_(\"Value of latency (ms) for calculating size of queue \""},{"line_number":89,"context_line":"                      \"for a port with QoS. See tc-tbf manual for more \""},{"line_number":90,"context_line":"                      \"information.\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_93514b11","line":87,"in_reply_to":"9a629dbe_a787360e","updated":"2016-11-09 08:57:51.000000000","message":"Done","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67aa780dba55f90b972f41f308645092e5d96565","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def _get_tc_wrapper(self, port):"},{"line_number":103,"context_line":"        return tc_lib.TcCommand("},{"line_number":104,"context_line":"            port[\u0027device\u0027],"},{"line_number":105,"context_line":"            cfg.CONF.QOS.kernel_hz,"},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_db94d745","line":105,"updated":"2016-08-24 20:54:38.000000000","message":"I think that kernel_hz is not neccessary anymore so You should remove it from here and from config options also.\nSame for latency.","commit_id":"3a1b75cf8790ecf8e4ed995042ec9aef0be36237"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"837fdc1a8e497c6356ab7585ed7c6d407f792478","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    def _get_tc_wrapper(self, port):"},{"line_number":103,"context_line":"        return tc_lib.TcCommand("},{"line_number":104,"context_line":"            port[\u0027device\u0027],"},{"line_number":105,"context_line":"            cfg.CONF.QOS.kernel_hz,"},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_2de02cfa","line":105,"in_reply_to":"1ac06dbe_db94d745","updated":"2016-08-25 10:18:58.000000000","message":"You are right. I\u0027\u0027 remove it in the next patch.","commit_id":"3a1b75cf8790ecf8e4ed995042ec9aef0be36237"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2593c3374b3b6a24ee2dbc4fcf2f59cc9d1315e3","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":50,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":51,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":52,"context_line":"            LOG.debug(\"\u0027create_bandwidth_limit\u0027 was received for port %s but \""},{"line_number":53,"context_line":"                      \"vif_port was not found. It seems that port is already \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_1ff735d4","line":50,"updated":"2016-11-08 09:49:50.000000000","message":"I checked it locally on my devstack and bandwidth limit rule was not applied properly (not miniumum bw but max bw) because in port dict there is no \"vif_port\" key. There is \"device\" with name of port in bridge and I thonk that it is what You wanted to check","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":50,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":51,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":52,"context_line":"            LOG.debug(\"\u0027create_bandwidth_limit\u0027 was received for port %s but \""},{"line_number":53,"context_line":"                      \"vif_port was not found. It seems that port is already \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_3364ffe2","line":50,"in_reply_to":"9a629dbe_1ff735d4","updated":"2016-11-09 08:57:51.000000000","message":"Done","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":50,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":51,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":52,"context_line":"            LOG.debug(\"\u0027create_bandwidth_limit\u0027 was received for port %s but \""},{"line_number":53,"context_line":"                      \"vif_port was not found. It seems that port is already \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_38505c5d","line":50,"in_reply_to":"9a629dbe_1ff735d4","updated":"2016-11-09 08:57:51.000000000","message":"This is the error you found. I wrote this condition in the last moment and I didn\u0027t check it... big mistake, sorry.","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe4c6f53c2a7b8846d34ca6cb4031514da8bdfbf","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":50,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":51,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":52,"context_line":"            LOG.debug(\"\u0027create_bandwidth_limit\u0027 was received for port %s but \""},{"line_number":53,"context_line":"                      \"vif_port was not found. It seems that port is already \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_4790c843","line":50,"in_reply_to":"9a629dbe_38505c5d","updated":"2016-11-09 12:15:56.000000000","message":"I\u0027m not sure if removing this \"if\" is good idea. I remember that I added such check in openvswitch qos extension driver because there was some bug reported for that. Check https://review.openstack.org/#/c/300679/\nSo maybe it should be here but checked should be not \"vif_port\" but \"device\"?","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d85eb63ee60cd690848661f28572a0553153bcad","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":50,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":51,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":52,"context_line":"            LOG.debug(\"\u0027create_bandwidth_limit\u0027 was received for port %s but \""},{"line_number":53,"context_line":"                      \"vif_port was not found. It seems that port is already \""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_27f58a56","line":50,"in_reply_to":"9a629dbe_4790c843","updated":"2016-11-09 16:07:48.000000000","message":"You are right, I need to make this check. Anyway I paid attention to make all tc_lib functions secure, that means, if you setup again the same limit (max or min), there is no problem. Even the delete function is secure (at least that\u0027s what I think).","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @log_helpers.log_method_call"},{"line_number":82,"context_line":"    def create_minimum_bandwidth(self, port, rule):"},{"line_number":83,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":84,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":85,"context_line":"            LOG.debug(\"\u0027create_minimum_bandwidth\u0027 was received for port %s \""},{"line_number":86,"context_line":"                      \"but vif_port was not found. It seems that port is \""},{"line_number":87,"context_line":"                      \"already deleted\", port_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_47049a7d","line":84,"updated":"2016-11-07 22:04:42.000000000","message":"None is default so there is no need to write it here","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @log_helpers.log_method_call"},{"line_number":82,"context_line":"    def create_minimum_bandwidth(self, port, rule):"},{"line_number":83,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":84,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":85,"context_line":"            LOG.debug(\"\u0027create_minimum_bandwidth\u0027 was received for port %s \""},{"line_number":86,"context_line":"                      \"but vif_port was not found. It seems that port is \""},{"line_number":87,"context_line":"                      \"already deleted\", port_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_58e270a0","line":84,"in_reply_to":"9a629dbe_47049a7d","updated":"2016-11-09 08:57:51.000000000","message":"Done, sorry","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @log_helpers.log_method_call"},{"line_number":93,"context_line":"    def update_minimum_bandwidth(self, port, rule):"},{"line_number":94,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":95,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":96,"context_line":"            LOG.debug(\"\u0027update_minimum_bandwidth\u0027 was received for port %s \""},{"line_number":97,"context_line":"                      \"but vif_port was not found. It seems that port is \""},{"line_number":98,"context_line":"                      \"already deleted\", port_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_e7ce8e59","line":95,"updated":"2016-11-07 22:04:42.000000000","message":"None is default so there is no need to write it here","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @log_helpers.log_method_call"},{"line_number":93,"context_line":"    def update_minimum_bandwidth(self, port, rule):"},{"line_number":94,"context_line":"        if not port.get(\u0027vif_port\u0027):"},{"line_number":95,"context_line":"            port_id \u003d port.get(\u0027port_id\u0027, None)"},{"line_number":96,"context_line":"            LOG.debug(\"\u0027update_minimum_bandwidth\u0027 was received for port %s \""},{"line_number":97,"context_line":"                      \"but vif_port was not found. It seems that port is \""},{"line_number":98,"context_line":"                      \"already deleted\", port_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_78ef3487","line":95,"in_reply_to":"9a629dbe_e7ce8e59","updated":"2016-11-09 08:57:51.000000000","message":"Done","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        tc_wrapper.delete_min_bw(constants.EGRESS_DIRECTION)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _get_tc_wrapper(self, port):"},{"line_number":109,"context_line":"        return tc_lib.TcCommand(port[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_472bbaeb","line":109,"updated":"2016-11-07 22:04:42.000000000","message":"I\u0027m not sure if this helper method is still necessary.","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        tc_wrapper.delete_min_bw(constants.EGRESS_DIRECTION)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _get_tc_wrapper(self, port):"},{"line_number":109,"context_line":"        return tc_lib.TcCommand(port[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_188638b9","line":109,"in_reply_to":"9a629dbe_472bbaeb","updated":"2016-11-09 08:57:51.000000000","message":"Yes, I think so: it\u0027s unnecesary.","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return \"dscp-%s\" % device"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @log_helpers.log_method_call"},{"line_number":71,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":72,"context_line":"        device \u003d port.get(\u0027device\u0027)"},{"line_number":73,"context_line":"        port_id \u003d port.get(\u0027port_id\u0027)"},{"line_number":74,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_497f09e0","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":30},"updated":"2017-01-11 16:22:31.000000000","message":"This function seems to be identical to update_bandwidth_limit, it would be better to have create call update_bandwidth_limit to avoid code duplication(similar to the ovs driver).","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return \"dscp-%s\" % device"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @log_helpers.log_method_call"},{"line_number":71,"context_line":"    def create_bandwidth_limit(self, port, rule):"},{"line_number":72,"context_line":"        device \u003d port.get(\u0027device\u0027)"},{"line_number":73,"context_line":"        port_id \u003d port.get(\u0027port_id\u0027)"},{"line_number":74,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_36b93516","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":30},"in_reply_to":"ba5201f7_497f09e0","updated":"2017-01-11 17:54:03.000000000","message":"You are right!","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"427ff587693ff280dd20a7856ba640e9b1611ff0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return len(rules_in_chain) \u003d\u003d 0"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @log_helpers.log_method_call"},{"line_number":188,"context_line":"    def create_minimum_bandwidth(self, port, rule):"},{"line_number":189,"context_line":"        device \u003d port.get(\u0027device\u0027)"},{"line_number":190,"context_line":"        port_id \u003d port.get(\u0027port_id\u0027)"},{"line_number":191,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_542cfc98","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":32},"updated":"2017-01-11 16:22:31.000000000","message":"Ditto on this rule, just call update from create to avoid code duplication.","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b93e6e68addfb52b22d9f1bb7d9469c7a0da4926","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return len(rules_in_chain) \u003d\u003d 0"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @log_helpers.log_method_call"},{"line_number":188,"context_line":"    def create_minimum_bandwidth(self, port, rule):"},{"line_number":189,"context_line":"        device \u003d port.get(\u0027device\u0027)"},{"line_number":190,"context_line":"        port_id \u003d port.get(\u0027port_id\u0027)"},{"line_number":191,"context_line":"        if not device:"}],"source_content_type":"text/x-python","patch_set":40,"id":"ba5201f7_965581c3","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":32},"in_reply_to":"ba5201f7_542cfc98","updated":"2017-01-11 17:54:03.000000000","message":"Done","commit_id":"07d45816f6cb0ce7f4f8590a4b6dc6166f512e59"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6027bcd3ae7648502a109b8868772aba5075e945","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        utils.wait_until_true("},{"line_number":226,"context_line":"            lambda: vm.bridge.get_egress_bw_limit_for_port("},{"line_number":227,"context_line":"                vm.port.name) \u003d\u003d (limit, burst),"},{"line_number":228,"context_line":"            initial_sleep\u003d2)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class TestBwLimitQoSLinuxbridge(_TestBwLimitQoS, base.BaseFullStackTestCase):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_4c785b90","line":228,"updated":"2017-01-09 21:04:04.000000000","message":"sorry for question but how this change is related to current patch?","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76063088c7a64d93c186291b22421f450ac49ed5","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        utils.wait_until_true("},{"line_number":226,"context_line":"            lambda: vm.bridge.get_egress_bw_limit_for_port("},{"line_number":227,"context_line":"                vm.port.name) \u003d\u003d (limit, burst),"},{"line_number":228,"context_line":"            initial_sleep\u003d2)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class TestBwLimitQoSLinuxbridge(_TestBwLimitQoS, base.BaseFullStackTestCase):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_a857dac8","line":228,"in_reply_to":"ba5201f7_4c785b90","updated":"2017-01-10 10:47:15.000000000","message":"It is related. I found a race condition in those tests when the interface was deleted. Just adding a bit of time at the beginning of the wait loop it\u0027s enough to stabilize the test, allowing the OS to delete the interface.","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a94e3c97b70eb4161f59d1950e9dd381ffa94800","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        utils.wait_until_true("},{"line_number":226,"context_line":"            lambda: vm.bridge.get_egress_bw_limit_for_port("},{"line_number":227,"context_line":"                vm.port.name) \u003d\u003d (limit, burst),"},{"line_number":228,"context_line":"            initial_sleep\u003d2)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"class TestBwLimitQoSLinuxbridge(_TestBwLimitQoS, base.BaseFullStackTestCase):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_7e0928dd","line":228,"in_reply_to":"ba5201f7_a857dac8","updated":"2017-01-10 10:59:53.000000000","message":"Ok, thanks for explanation :)","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"}],"neutron/tests/unit/agent/linux/test_tc_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    QDISC_INGRESS_HANDLE \u003d \u0027ffff:\u0027"},{"line_number":150,"context_line":"    FILTER_PARENT \u003d CLASS_PARENT"},{"line_number":151,"context_line":"    FILTER_PROTOCOL \u003d [\u0027all\u0027, \u0027u32\u0027, \u0027match\u0027, \u0027u32\u0027, \u00270\u0027, \u00270\u0027]"},{"line_number":152,"context_line":"    FILTER_ACTION \u003d [\u0027mirred\u0027, \u0027egress\u0027, \u0027redirect\u0027, \u0027dev\u0027, \u0027%s\u0027 % IFB_NAME]"},{"line_number":153,"context_line":"    TYPE_HTB \u003d \u0027htb\u0027"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_876dd206","line":152,"updated":"2016-11-07 22:04:42.000000000","message":"isn\u0027t only \"IFB_NAME\" enough in last element?","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    QDISC_INGRESS_HANDLE \u003d \u0027ffff:\u0027"},{"line_number":150,"context_line":"    FILTER_PARENT \u003d CLASS_PARENT"},{"line_number":151,"context_line":"    FILTER_PROTOCOL \u003d [\u0027all\u0027, \u0027u32\u0027, \u0027match\u0027, \u0027u32\u0027, \u00270\u0027, \u00270\u0027]"},{"line_number":152,"context_line":"    FILTER_ACTION \u003d [\u0027mirred\u0027, \u0027egress\u0027, \u0027redirect\u0027, \u0027dev\u0027, \u0027%s\u0027 % IFB_NAME]"},{"line_number":153,"context_line":"    TYPE_HTB \u003d \u0027htb\u0027"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_f80d043f","line":152,"in_reply_to":"9a629dbe_876dd206","updated":"2016-11-09 08:57:51.000000000","message":"Pffff. I \"translated\" this from a string to a list.","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6027bcd3ae7648502a109b8868772aba5075e945","unresolved":false,"context_lines":[{"line_number":25,"context_line":"DEVICE_NAME \u003d \"tap_device\""},{"line_number":26,"context_line":"BW_LIMIT \u003d 2000  # [kbps]"},{"line_number":27,"context_line":"BURST \u003d 100  # [kbit]"},{"line_number":28,"context_line":"LATENCY \u003d 50  # [ms]"},{"line_number":29,"context_line":"SI_BASE \u003d 1000"},{"line_number":30,"context_line":"IEC_BASE \u003d 1024"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_acf8e7c5","line":28,"updated":"2017-01-09 21:04:04.000000000","message":"this is probably not used anymore","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76063088c7a64d93c186291b22421f450ac49ed5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"DEVICE_NAME \u003d \"tap_device\""},{"line_number":26,"context_line":"BW_LIMIT \u003d 2000  # [kbps]"},{"line_number":27,"context_line":"BURST \u003d 100  # [kbit]"},{"line_number":28,"context_line":"LATENCY \u003d 50  # [ms]"},{"line_number":29,"context_line":"SI_BASE \u003d 1000"},{"line_number":30,"context_line":"IEC_BASE \u003d 1024"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_08e4660b","line":28,"in_reply_to":"ba5201f7_acf8e7c5","updated":"2017-01-10 10:47:15.000000000","message":"Done","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6027bcd3ae7648502a109b8868772aba5075e945","unresolved":false,"context_lines":[{"line_number":27,"context_line":"BURST \u003d 100  # [kbit]"},{"line_number":28,"context_line":"LATENCY \u003d 50  # [ms]"},{"line_number":29,"context_line":"SI_BASE \u003d 1000"},{"line_number":30,"context_line":"IEC_BASE \u003d 1024"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class BaseUnitConversionTest(object):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_6c251f5b","line":30,"updated":"2017-01-09 21:04:04.000000000","message":"can\u0027t You use SI_BASE and IEC_BASE constants from tc_lib.py module here?","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76063088c7a64d93c186291b22421f450ac49ed5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"BURST \u003d 100  # [kbit]"},{"line_number":28,"context_line":"LATENCY \u003d 50  # [ms]"},{"line_number":29,"context_line":"SI_BASE \u003d 1000"},{"line_number":30,"context_line":"IEC_BASE \u003d 1024"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class BaseUnitConversionTest(object):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_880936e0","line":30,"in_reply_to":"ba5201f7_6c251f5b","updated":"2017-01-10 10:47:15.000000000","message":"Yes, you are right.","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/extension_drivers/test_qos_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6027bcd3ae7648502a109b8868772aba5075e945","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.tests import base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"TEST_LATENCY_VALUE \u003d 100"},{"line_number":31,"context_line":"DSCP_VALUE \u003d 32"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_ecc74f62","line":30,"updated":"2017-01-09 21:04:04.000000000","message":"probably not necessary anymore","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76063088c7a64d93c186291b22421f450ac49ed5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.tests import base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"TEST_LATENCY_VALUE \u003d 100"},{"line_number":31,"context_line":"DSCP_VALUE \u003d 32"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_c8b89ee8","line":30,"in_reply_to":"ba5201f7_ecc74f62","updated":"2017-01-10 10:47:15.000000000","message":"Done","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6027bcd3ae7648502a109b8868772aba5075e945","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return {\u0027qos_policy_id\u0027: policy_id,"},{"line_number":90,"context_line":"                \u0027network_qos_policy_id\u0027: None,"},{"line_number":91,"context_line":"                \u0027device\u0027: self.DEVICE_NAME,"},{"line_number":92,"context_line":"                \u0027port_id\u0027: uuid.uuid4().hex,"},{"line_number":93,"context_line":"                \u0027vif_port\u0027: FakeVifPort()}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _dscp_mark_chain_name(self, device):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_4c8cdb35","line":92,"updated":"2017-01-09 21:04:04.000000000","message":"just for curiosity: why port id is hex from uuid4 here?","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76063088c7a64d93c186291b22421f450ac49ed5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return {\u0027qos_policy_id\u0027: policy_id,"},{"line_number":90,"context_line":"                \u0027network_qos_policy_id\u0027: None,"},{"line_number":91,"context_line":"                \u0027device\u0027: self.DEVICE_NAME,"},{"line_number":92,"context_line":"                \u0027port_id\u0027: uuid.uuid4().hex,"},{"line_number":93,"context_line":"                \u0027vif_port\u0027: FakeVifPort()}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _dscp_mark_chain_name(self, device):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_a898ba6b","line":92,"in_reply_to":"ba5201f7_4c8cdb35","updated":"2017-01-10 10:47:15.000000000","message":"hehehe because I made a mistake! Thank you.","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a94e3c97b70eb4161f59d1950e9dd381ffa94800","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return {\u0027qos_policy_id\u0027: policy_id,"},{"line_number":90,"context_line":"                \u0027network_qos_policy_id\u0027: None,"},{"line_number":91,"context_line":"                \u0027device\u0027: self.DEVICE_NAME,"},{"line_number":92,"context_line":"                \u0027port_id\u0027: uuid.uuid4().hex,"},{"line_number":93,"context_line":"                \u0027vif_port\u0027: FakeVifPort()}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _dscp_mark_chain_name(self, device):"}],"source_content_type":"text/x-python","patch_set":37,"id":"ba5201f7_de4a1427","line":92,"in_reply_to":"ba5201f7_a898ba6b","updated":"2017-01-10 10:59:53.000000000","message":"You welcome :)","commit_id":"07bf06148da14b36453a5b98001f82eea16ef593"}],"releasenotes/notes/add-minimum-bandwidth-support-linuxbridge-9dc9d4458d8affef.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1396047342fa95502c2e0dcd878a3b7879c8f1b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Linux Bridge now supports egress minimum bandwidth configuration."},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - Configuration parameters ``kernel_hz`` and ``tbf_latency`` in ``QoS``"},{"line_number":6,"context_line":"    section will be removed in Pike release, because tc-tbf is no longer used."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9a629dbe_47181a85","line":6,"updated":"2016-11-07 22:04:42.000000000","message":"Again same question: why waits to Pike release to remove those config options? It has now any effect even if user will configure it","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba06825ec1b0f33fd65cf57e419049b5229285e6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Linux Bridge now supports egress minimum bandwidth configuration."},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - Configuration parameters ``kernel_hz`` and ``tbf_latency`` in ``QoS``"},{"line_number":6,"context_line":"    section will be removed in Pike release, because tc-tbf is no longer used."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9a629dbe_732757b6","line":6,"in_reply_to":"9a629dbe_47181a85","updated":"2016-11-09 08:57:51.000000000","message":"You are right: I\u0027ll remove it now","commit_id":"e4f7e34f10765301812608bc51989a7ea9c8f636"}]}
