)]}'
{"neutron/db/models/README":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"fe06177e80bd160430e46e769b89e839fbf45b53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron. The expected directory structure is flat, meaning there should be no"},{"line_number":3,"context_line":"subdirectories. Module names should use singular forms for nouns (port.py, not"},{"line_number":4,"context_line":"ports.py)."},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ac06dbe_e4edc68f","line":2,"range":{"start_line":2,"start_character":8,"end_line":2,"end_character":9},"updated":"2016-08-19 15:00:33.000000000","message":"IMHO after this dot, it\u0027d list all the considerations for this folder, like:\n* Directory structure is flat, except ML2 because...\n* Modules names must be in singular form, e. g.","commit_id":"97fa27db88500b83c30f576ac0fe44620adcc6d4"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"ced62693fa9d29eaa7468e68286ae0677844617a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron. The expected directory structure is flat, meaning there should be no"},{"line_number":3,"context_line":"subdirectories. Module names should use singular forms for nouns (port.py, not"},{"line_number":4,"context_line":"ports.py)."},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ac06dbe_ea03cd74","line":2,"range":{"start_line":2,"start_character":8,"end_line":2,"end_character":9},"in_reply_to":"1ac06dbe_e4edc68f","updated":"2016-08-19 15:23:33.000000000","message":"Done","commit_id":"97fa27db88500b83c30f576ac0fe44620adcc6d4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"fe06177e80bd160430e46e769b89e839fbf45b53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron. The expected directory structure is flat, meaning there should be no"},{"line_number":3,"context_line":"subdirectories. Module names should use singular forms for nouns (port.py, not"},{"line_number":4,"context_line":"ports.py)."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The exception for the flat directory structure are ML2 plugins. All ML2"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ac06dbe_049e2256","line":3,"range":{"start_line":2,"start_character":51,"end_line":3,"end_character":14},"updated":"2016-08-19 15:00:33.000000000","message":"not sure if this line still makes sense or it\u0027s better to include the exception here.","commit_id":"97fa27db88500b83c30f576ac0fe44620adcc6d4"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"ced62693fa9d29eaa7468e68286ae0677844617a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron. The expected directory structure is flat, meaning there should be no"},{"line_number":3,"context_line":"subdirectories. Module names should use singular forms for nouns (port.py, not"},{"line_number":4,"context_line":"ports.py)."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The exception for the flat directory structure are ML2 plugins. All ML2"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ac06dbe_2afe856b","line":3,"range":{"start_line":2,"start_character":51,"end_line":3,"end_character":14},"in_reply_to":"1ac06dbe_049e2256","updated":"2016-08-19 15:23:33.000000000","message":"Done","commit_id":"97fa27db88500b83c30f576ac0fe44620adcc6d4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"380ff66d487125ee32d82e9adae809eea252b796","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"The exception for the flat directory structure are ML2 plugins. All ML2"},{"line_number":7,"context_line":"plugins should fall under the ml2 subdirectory and the module should"},{"line_number":8,"context_line":"match the corresponding table name (i.e. ml2_gre_allocations)."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ac06dbe_24ca3ea2","line":8,"updated":"2016-08-19 14:53:15.000000000","message":"No case to squash any of them?","commit_id":"97fa27db88500b83c30f576ac0fe44620adcc6d4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3e25a49f894c356ed7f2c191b0c3857432d0a799","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugins should fall under the ml2 subdirectory (i.e. ml2/gre_allocations)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_3e2526ab","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":70},"updated":"2016-08-19 15:28:11.000000000","message":"plugin","commit_id":"eab2aab92570b091e4b32af4c629e7b37620605e"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"cf45643d8c07d87989c64212c761429bc2317898","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugins should fall under the ml2 subdirectory (i.e. ml2/gre_allocations)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_fe9f0eb2","line":4,"range":{"start_line":4,"start_character":63,"end_line":4,"end_character":70},"in_reply_to":"1ac06dbe_3e2526ab","updated":"2016-08-19 15:29:34.000000000","message":"Ml2 plugins I think, since there will be multiple","commit_id":"eab2aab92570b091e4b32af4c629e7b37620605e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff856cd4e78f7be590f6046012d992740eb6488e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugins should fall under the ml2 subdirectory (i.e. ml2/gre_allocations)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_ea946de9","line":5,"range":{"start_line":4,"start_character":72,"end_line":5,"end_character":9},"updated":"2016-08-19 15:26:34.000000000","message":"-\u003e All ML2 plugin models ?","commit_id":"eab2aab92570b091e4b32af4c629e7b37620605e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff856cd4e78f7be590f6046012d992740eb6488e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugins should fall under the ml2 subdirectory (i.e. ml2/gre_allocations)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_8ae2199e","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":74},"updated":"2016-08-19 15:26:34.000000000","message":"According to the next line, it should be ml2/gre_allocation.","commit_id":"eab2aab92570b091e4b32af4c629e7b37620605e"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"cf45643d8c07d87989c64212c761429bc2317898","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugins should fall under the ml2 subdirectory (i.e. ml2/gre_allocations)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_1e266aba","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":74},"in_reply_to":"1ac06dbe_8ae2199e","updated":"2016-08-19 15:29:34.000000000","message":"Indeed. Wow I should really drink my morning coffee","commit_id":"eab2aab92570b091e4b32af4c629e7b37620605e"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"cf45643d8c07d87989c64212c761429bc2317898","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugins should fall under the ml2 subdirectory (i.e. ml2/gre_allocations)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ac06dbe_7e3e7eb9","line":5,"range":{"start_line":4,"start_character":72,"end_line":5,"end_character":9},"in_reply_to":"1ac06dbe_ea946de9","updated":"2016-08-19 15:29:34.000000000","message":"Yes I think so. Thank you","commit_id":"eab2aab92570b091e4b32af4c629e7b37620605e"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a041ab346913912ece765153a7fbf1e0e11a2857","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugin models should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ac06dbe_746e3b02","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":93},"updated":"2016-08-22 17:23:33.000000000","message":"It make sense to have those models fall under plugins/ml2/models, or db.models (I don\u0027t see any reason to not have a common dir dedicated to all models in neutron) is fine as well, I have no objection to this, but will wait for other reviewers\u0027 reviews.","commit_id":"d6adffa59b7118b9c820d8380ed456dfd913b282"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8e747087926bdf114ad4539a8c0f32bf3ff8baf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugin models should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ac06dbe_a8bf7ca8","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":93},"in_reply_to":"1ac06dbe_746e3b02","updated":"2016-08-23 14:18:20.000000000","message":"It was in response to Akihiro\u0027s comments in https://review.openstack.org/#/c/355643/ \n\nAll ml2 plugin type models reflect this tree","commit_id":"d6adffa59b7118b9c820d8380ed456dfd913b282"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"241e577ccb06d7ff2c35c4600d08091524e649fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugin models should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa7ab95a_a85e1843","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":93},"in_reply_to":"1ac06dbe_a8bf7ca8","updated":"2016-08-26 12:15:23.000000000","message":"Should we use neutron.db.models.ml2 instead of neutron.db.models.plugins.ml2 as suggested here? We should not have more directories than just ml2, so it\u0027s not clear why additional layer.","commit_id":"d6adffa59b7118b9c820d8380ed456dfd913b282"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"48913bebf10ce30bfecf1155950b3c1d03601255","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugin models should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa7ab95a_d4c77543","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":93},"in_reply_to":"fa7ab95a_a85e1843","updated":"2016-08-26 13:09:50.000000000","message":"UPD: I see we landed some models in plugins/ml2 already. Sigh. I guess we will follow the path...","commit_id":"d6adffa59b7118b9c820d8380ed456dfd913b282"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c5a563186a3d225ff683e663f7ce4705f63abdbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugin models should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa7ab95a_089a7263","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":93},"in_reply_to":"fa7ab95a_c92b502f","updated":"2016-08-27 11:33:55.000000000","message":"Honestly I have no strong opinion on ml2 vs plugins.ml2.\nWhen I reviewed a patch relocating ML2 GRE model, I didn\u0027t mind this much because either one does not hit the line length of 80 chars.","commit_id":"d6adffa59b7118b9c820d8380ed456dfd913b282"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"41a7398652750fae46f5d3234d13fe2ccac1151d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"* The expected directory structure is flat, except for the ML2 plugins. All ML2"},{"line_number":5,"context_line":"  plugin models should fall under the plugins subdirectory (i.e. plugins/ml2/gre_allocation)."},{"line_number":6,"context_line":"* Module names should use singular forms for nouns (port.py, not ports.py)."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa7ab95a_c92b502f","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":93},"in_reply_to":"fa7ab95a_d4c77543","updated":"2016-08-26 15:41:34.000000000","message":"i have no issues as long as they work well and solve cyclic import","commit_id":"d6adffa59b7118b9c820d8380ed456dfd913b282"}]}
