)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"48b1e6a67b38d33e09601a622093cb96e5f9a77d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 9c3c19f07ce52e139d431aec54341c38a183f0b7."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now that \u003chopefully\u003e all the current race conditions have been found and"},{"line_number":12,"context_line":"fixed, the ALLOCATING status is no longer needed and can be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1609738"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_2b6ac51a","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":19},"updated":"2016-08-28 11:37:18.000000000","message":"this is not that convincing","commit_id":"7740d2fa384116a759edbfb6521b78e041b42bb5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb7390c92a48942af5a307626589d2767a6b8d94","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This reverts commit 9c3c19f07ce52e139d431aec54341c38a183f0b7."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now that all the current race conditions have been found and fixed, the"},{"line_number":12,"context_line":"ALLOCATING status is no longer needed and can be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1609738"},{"line_number":15,"context_line":"Change-Id: Ib04e08df13ef4e6b94bd588854a5795163e2a617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_b9dc61e5","line":12,"updated":"2016-08-29 07:43:23.000000000","message":"Hi John,\nHow we can ensure that all the current race conditions have been found and fixed ?\nCould you add some fixed bugs or feedbacks for this revert?\nAnd, its better to add some test results.","commit_id":"7835d0d057f23a4683e4f7eb11561bcbf919ea62"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"07478734b946171b9073c8f318bbc75bd06a9f36","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This reverts commit 9c3c19f07ce52e139d431aec54341c38a183f0b7."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now that all the current race conditions have been found and fixed, the"},{"line_number":12,"context_line":"ALLOCATING status is no longer needed and can be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1609738"},{"line_number":15,"context_line":"Change-Id: Ib04e08df13ef4e6b94bd588854a5795163e2a617"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_b5f8dac4","line":12,"in_reply_to":"fa7ab95a_b9dc61e5","updated":"2016-08-29 10:25:14.000000000","message":"The tests are covered in the depending patch [1] - that patch simply makes schedule() concurrently safe so this isn\u0027t needed anymore.\n\nIs there a specific test you had in mind?\n\n[1]: https://review.openstack.org/#/c/357965/","commit_id":"7835d0d057f23a4683e4f7eb11561bcbf919ea62"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b49ae10ba8362f50af3db6d19d2230f4738f11ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 9c3c19f07ce52e139d431aec54341c38a183f0b7."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now that all the current race conditions have been found and fixed, the"},{"line_number":12,"context_line":"ALLOCATING status is no longer needed and can be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1609738"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ba5201f7_15cee481","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"updated":"2017-01-05 03:28:58.000000000","message":"A mere statement could not convince me. Maybe a rally test report or a release note for such conclusion is better.","commit_id":"26f64a853c196ac54ea733dfa0a54eaa0de5e195"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9258650c4472e6c221a0b5c93e4f9b6ced02ca9d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 9c3c19f07ce52e139d431aec54341c38a183f0b7."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now that all the current race conditions have been found and fixed, the"},{"line_number":12,"context_line":"ALLOCATING status is no longer needed and can be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1609738"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ba5201f7_ccbe3964","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"in_reply_to":"ba5201f7_15cee481","updated":"2017-01-08 14:16:58.000000000","message":"A rally test report doesn\u0027t indicate lack of issues (as if it didn\u0027t catch a specific race it doesn\u0027t tell us that no races exist), and a release note is also a few words scribbled on a file and not different from a commit message.\n\nAlas, I\u0027ll ask that you look at https://review.openstack.org/#/c/317949/, which changed the way the scheduler works. I\u0027ll also reword things a bit.","commit_id":"26f64a853c196ac54ea733dfa0a54eaa0de5e195"}],"neutron/common/constants.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0e7f180166b53167256eb81a07f58672018354b2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ROUTER_PORT_OWNERS \u003d lib_constants.ROUTER_INTERFACE_OWNERS_SNAT + \\"},{"line_number":20,"context_line":"    (lib_constants.DEVICE_OWNER_ROUTER_GW,)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ROUTER_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":23,"context_line":"# NOTE(kevinbenton): a BUILD status for routers could be added in the future"},{"line_number":24,"context_line":"# for agents to indicate when they are wiring up the ports. The following is"},{"line_number":25,"context_line":"# to indicate when the server is busy building sub-components of a router"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_2f5a57f2","side":"PARENT","line":22,"updated":"2017-01-08 14:51:41.000000000","message":"Don\u0027t get rid of ACTIVE. We should keep it around and use it instead of the string literal since it\u0027s here.","commit_id":"d0a2c1650a35ba720027811432a12d4575615737"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"566688f784032b3d6074d80a772934723073c269","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ROUTER_PORT_OWNERS \u003d lib_constants.ROUTER_INTERFACE_OWNERS_SNAT + \\"},{"line_number":20,"context_line":"    (lib_constants.DEVICE_OWNER_ROUTER_GW,)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ROUTER_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":23,"context_line":"# NOTE(kevinbenton): a BUILD status for routers could be added in the future"},{"line_number":24,"context_line":"# for agents to indicate when they are wiring up the ports. The following is"},{"line_number":25,"context_line":"# to indicate when the server is busy building sub-components of a router"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_4ffcfbb7","side":"PARENT","line":22,"in_reply_to":"ba5201f7_2f5a57f2","updated":"2017-01-08 14:56:50.000000000","message":"Done","commit_id":"d0a2c1650a35ba720027811432a12d4575615737"}],"neutron/db/l3_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bf18120d7d1aa76bb7dcdc53ac7e51ebead11c5a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                tenant_id\u003drouter[\u0027tenant_id\u0027],"},{"line_number":210,"context_line":"                name\u003drouter[\u0027name\u0027],"},{"line_number":211,"context_line":"                admin_state_up\u003drouter[\u0027admin_state_up\u0027],"},{"line_number":212,"context_line":"                status\u003d\"ACTIVE\","},{"line_number":213,"context_line":"                description\u003drouter.get(\u0027description\u0027))"},{"line_number":214,"context_line":"            context.session.add(router_db)"},{"line_number":215,"context_line":"            registry.notify(resources.ROUTER, events.PRECOMMIT_CREATE,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba5201f7_857306e7","line":212,"updated":"2017-01-09 15:54:15.000000000","message":"should use n_const.ROUTER_STATUS_ACTIVE","commit_id":"2aefda8a4322463d990f811f86d08b154521f670"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d47d38fb200de75e7a3f93b9ebbc89bb3aed2083","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            if router_db.admin_state_up:"},{"line_number":479,"context_line":"                msg \u003d _(\u0027Cannot change HA attribute of active routers. Please \u0027"},{"line_number":480,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":481,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"            ha_network \u003d self.get_ha_network(context,"},{"line_number":484,"context_line":"                                             router_db.tenant_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_af8b15c2","line":481,"updated":"2017-01-04 20:24:49.000000000","message":"Why is this check required after L459 already did it?","commit_id":"26f64a853c196ac54ea733dfa0a54eaa0de5e195"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9258650c4472e6c221a0b5c93e4f9b6ced02ca9d","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            if router_db.admin_state_up:"},{"line_number":479,"context_line":"                msg \u003d _(\u0027Cannot change HA attribute of active routers. Please \u0027"},{"line_number":480,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":481,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"            ha_network \u003d self.get_ha_network(context,"},{"line_number":484,"context_line":"                                             router_db.tenant_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_0c43e16c","line":481,"in_reply_to":"ba5201f7_af8b15c2","updated":"2017-01-08 14:16:58.000000000","message":"I have no idea. Will remove :)","commit_id":"26f64a853c196ac54ea733dfa0a54eaa0de5e195"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"edc81f853d044e5840a0a93ca288aa5ed78a45a7","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    def _notify_router_updated(self, context, router_id,"},{"line_number":356,"context_line":"                               schedule_routers\u003dTrue):"},{"line_number":357,"context_line":"        self.l3_rpc_notifier.routers_updated("},{"line_number":358,"context_line":"            context, [router_id], shuffle_agents\u003dTrue,"},{"line_number":359,"context_line":"            schedule_routers\u003dschedule_routers)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_8f4a6353","side":"PARENT","line":358,"updated":"2017-01-08 14:27:06.000000000","message":"how is this change related?","commit_id":"d0a2c1650a35ba720027811432a12d4575615737"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"82424779936378177b53c7c07ba148cb9c4032c4","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    def _notify_router_updated(self, context, router_id,"},{"line_number":356,"context_line":"                               schedule_routers\u003dTrue):"},{"line_number":357,"context_line":"        self.l3_rpc_notifier.routers_updated("},{"line_number":358,"context_line":"            context, [router_id], shuffle_agents\u003dTrue,"},{"line_number":359,"context_line":"            schedule_routers\u003dschedule_routers)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_6f945f8a","side":"PARENT","line":358,"in_reply_to":"ba5201f7_8f4a6353","updated":"2017-01-08 14:35:05.000000000","message":"https://review.openstack.org/#/c/257059/40/neutron/db/l3_hamode_db.py modified this but the diff isn\u0027t complete - the argument should also be removed.","commit_id":"d0a2c1650a35ba720027811432a12d4575615737"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"edc81f853d044e5840a0a93ca288aa5ed78a45a7","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            except Exception:"},{"line_number":418,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":419,"context_line":"                    self.delete_router(context, router_dict[\u0027id\u0027])"},{"line_number":420,"context_line":"            router_dict[\u0027ha_vr_id\u0027] \u003d router_db.extra_attributes.ha_vr_id"},{"line_number":421,"context_line":"        return router_dict"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_af2e4789","line":420,"updated":"2017-01-08 14:27:06.000000000","message":"dup of L415","commit_id":"dbd7ac5748498b83b014fa5eb883aa7b0ab50230"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"82424779936378177b53c7c07ba148cb9c4032c4","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            except Exception:"},{"line_number":418,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":419,"context_line":"                    self.delete_router(context, router_dict[\u0027id\u0027])"},{"line_number":420,"context_line":"            router_dict[\u0027ha_vr_id\u0027] \u003d router_db.extra_attributes.ha_vr_id"},{"line_number":421,"context_line":"        return router_dict"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_cfeb8b11","line":420,"in_reply_to":"ba5201f7_af2e4789","updated":"2017-01-08 14:35:05.000000000","message":"Done","commit_id":"dbd7ac5748498b83b014fa5eb883aa7b0ab50230"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0e7f180166b53167256eb81a07f58672018354b2","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # handle this HA router"},{"line_number":402,"context_line":"            self.get_number_of_agents_for_scheduling(context)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        router[\u0027router\u0027][\u0027ha\u0027] \u003d is_ha"},{"line_number":405,"context_line":"        router_dict \u003d super(L3_HA_NAT_db_mixin,"},{"line_number":406,"context_line":"                            self).create_router(context, router)"},{"line_number":407,"context_line":"        if is_ha:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_6f70df72","line":404,"updated":"2017-01-08 14:51:41.000000000","message":"unrelated?","commit_id":"38e4703ac4016f1a23cf441bf5ba8a1d7fccc382"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"566688f784032b3d6074d80a772934723073c269","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # handle this HA router"},{"line_number":402,"context_line":"            self.get_number_of_agents_for_scheduling(context)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        router[\u0027router\u0027][\u0027ha\u0027] \u003d is_ha"},{"line_number":405,"context_line":"        router_dict \u003d super(L3_HA_NAT_db_mixin,"},{"line_number":406,"context_line":"                            self).create_router(context, router)"},{"line_number":407,"context_line":"        if is_ha:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_affd67b2","line":404,"in_reply_to":"ba5201f7_6f70df72","updated":"2017-01-08 14:56:50.000000000","message":"Yes.","commit_id":"38e4703ac4016f1a23cf441bf5ba8a1d7fccc382"}]}
