)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"252f5cc4ef0c11d55c35daf52fbb32cdb2f36731","unresolved":false,"context_lines":[{"line_number":9,"context_line":"IPv6 utils is_enabled() doesn\u0027t actually determine if IPv6 is enabled on"},{"line_number":10,"context_line":"the host. It checks if /proc/sys/net/ipv6/conf/default/disable_ipv6 is"},{"line_number":11,"context_line":"present and is set to 0. This kernel configuration option controls if"},{"line_number":12,"context_line":"the kernel with automatically assign IPv6 link-local addresses to newly"},{"line_number":13,"context_line":"created network interfaces when their link state changes to up. The"},{"line_number":14,"context_line":"existence of this /proc files does indicate that the Linux kernel has"},{"line_number":15,"context_line":"the ipv6 module loaded or ipv6 was compiled in. Having this /proc file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_ca5af54f","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":15},"updated":"2016-08-22 15:16:46.000000000","message":"will ?","commit_id":"ecefdb85b64b79a6694095b8b92430ab57d78929"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"7b29b799b758f60e895d3d69be077984dd21517b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"IPv6 utils is_enabled() doesn\u0027t actually determine if IPv6 is enabled on"},{"line_number":10,"context_line":"the host. It checks if /proc/sys/net/ipv6/conf/default/disable_ipv6 is"},{"line_number":11,"context_line":"present and is set to 0. This kernel configuration option controls if"},{"line_number":12,"context_line":"the kernel with automatically assign IPv6 link-local addresses to newly"},{"line_number":13,"context_line":"created network interfaces when their link state changes to up. The"},{"line_number":14,"context_line":"existence of this /proc files does indicate that the Linux kernel has"},{"line_number":15,"context_line":"the ipv6 module loaded or ipv6 was compiled in. Having this /proc file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_f37b0ebc","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":15},"in_reply_to":"1ac06dbe_ca5af54f","updated":"2016-08-23 20:01:03.000000000","message":"Fixed","commit_id":"ecefdb85b64b79a6694095b8b92430ab57d78929"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"252f5cc4ef0c11d55c35daf52fbb32cdb2f36731","unresolved":false,"context_lines":[{"line_number":33,"context_line":"administrator explicitly configures them to be active in that address"},{"line_number":34,"context_line":"family. This practice does not currently work as expected with the"},{"line_number":35,"context_line":"Neutron, since setting /proc/sys/net/ipv6/conf/default/disable_ipv6 to 1"},{"line_number":36,"context_line":"unexpectedly disables creating IPv6 security group rules leaving"},{"line_number":37,"context_line":"instances completely exposed via IPv6 regardless of security group"},{"line_number":38,"context_line":"rules."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_351cca76","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":64},"updated":"2016-08-22 15:16:46.000000000","message":"So you think we should better check default and $IFACE/disable_ipv6 per interface and then decide whether to call ip6tables?","commit_id":"ecefdb85b64b79a6694095b8b92430ab57d78929"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"7b29b799b758f60e895d3d69be077984dd21517b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"administrator explicitly configures them to be active in that address"},{"line_number":34,"context_line":"family. This practice does not currently work as expected with the"},{"line_number":35,"context_line":"Neutron, since setting /proc/sys/net/ipv6/conf/default/disable_ipv6 to 1"},{"line_number":36,"context_line":"unexpectedly disables creating IPv6 security group rules leaving"},{"line_number":37,"context_line":"instances completely exposed via IPv6 regardless of security group"},{"line_number":38,"context_line":"rules."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_a2949e8a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":64},"in_reply_to":"1ac06dbe_351cca76","updated":"2016-08-23 20:01:03.000000000","message":"In my option there should be a configuration option to select between blocking all IPv6 traffic and enforcing security group policies for IPv6. The pass all IPv6 behavior should be eliminated, but changing this now would be a breaking change for some deployments.\n\nThere is also some L3 agent behavior keyed of this sysctl setting, which I haven\u0027t looked into yet.\n\nThe goal of this patch is simply to discourage further consumption of this method by conveying the actual meaning of the condition tested for.","commit_id":"ecefdb85b64b79a6694095b8b92430ab57d78929"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"dc0002ff7bf0c52765e1a22d4e6f57ccc8c081d1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"attempting to make IPv6 specific configurations in the iptables firewall"},{"line_number":25,"context_line":"driver and the l3 agent. Removing it would break existing deployments."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Renaming this function to clarity complex condition tested by this"},{"line_number":28,"context_line":"function. In fact it is a good security practice to set this default"},{"line_number":29,"context_line":"disable_ipv6 option to 1, and explicitly enable IPv6 by setting"},{"line_number":30,"context_line":"disable_ipv6\u003d0 on individual interfaces which the administrator intends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a98d1f4_c51aa97c","line":27,"range":{"start_line":27,"start_character":26,"end_line":27,"end_character":51},"updated":"2016-10-03 22:06:05.000000000","message":"nit: provide clarity for complex conditions","commit_id":"720f11e57a87e59ad2b606ad06a848dd67c63b36"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"4736f62d5c1ce01b651fdb21afc6f4fa90c15ea4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"attempting to make IPv6 specific configurations in the iptables firewall"},{"line_number":25,"context_line":"driver and the l3 agent. Removing it would break existing deployments."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Renaming this function to clarity complex condition tested by this"},{"line_number":28,"context_line":"function. In fact it is a good security practice to set this default"},{"line_number":29,"context_line":"disable_ipv6 option to 1, and explicitly enable IPv6 by setting"},{"line_number":30,"context_line":"disable_ipv6\u003d0 on individual interfaces which the administrator intends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da6895a0_66279bb6","line":27,"range":{"start_line":27,"start_character":26,"end_line":27,"end_character":51},"in_reply_to":"3a98d1f4_c51aa97c","updated":"2016-10-25 13:00:26.000000000","message":"Fixed","commit_id":"720f11e57a87e59ad2b606ad06a848dd67c63b36"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"00f12636ac7b2ab93e8ff9e812fcdf4f8382c9a1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"configuration."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This check was added to Neutron so it could operate with distributions"},{"line_number":23,"context_line":"which didn\u0027t load the ipv6 kernel module. Preventing errors when"},{"line_number":24,"context_line":"attempting to make IPv6 specific configurations in the iptables firewall"},{"line_number":25,"context_line":"driver and the l3 agent. Removing it would break existing deployments."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba5da102_38a0c990","line":23,"range":{"start_line":23,"start_character":40,"end_line":23,"end_character":41},"updated":"2016-10-26 06:30:04.000000000","message":"Nit: was this meant to be a comma?","commit_id":"6d94cf204c5b7a31108f64bb9b6ada29eea48acb"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"84b6a002cde84374d101d65802e5a0a9e69c336b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"configuration."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This check was added to Neutron so it could operate with distributions"},{"line_number":23,"context_line":"which didn\u0027t load the ipv6 kernel module. Preventing errors when"},{"line_number":24,"context_line":"attempting to make IPv6 specific configurations in the iptables firewall"},{"line_number":25,"context_line":"driver and the l3 agent. Removing it would break existing deployments."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba5da102_ccbaafc0","line":23,"range":{"start_line":23,"start_character":40,"end_line":23,"end_character":41},"in_reply_to":"ba5da102_38a0c990","updated":"2016-10-26 09:04:10.000000000","message":"Fixed","commit_id":"6d94cf204c5b7a31108f64bb9b6ada29eea48acb"}],"neutron/common/ipv6_utils.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"252f5cc4ef0c11d55c35daf52fbb32cdb2f36731","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"is_enabled \u003d moves.moved_function(is_enabled_and_bind_by_default,"},{"line_number":72,"context_line":"                                  \u0027is_enabled\u0027, __name__)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def is_auto_address_subnet(subnet):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_aa42190e","line":72,"updated":"2016-08-22 15:16:46.000000000","message":"You can add \"version\u003d\u0027Newton\u0027, removal_version\u003d\u0027Ocata\u0027\" or something like that which generates additional information in deprecation message.","commit_id":"ecefdb85b64b79a6694095b8b92430ab57d78929"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"7b29b799b758f60e895d3d69be077984dd21517b","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"is_enabled \u003d moves.moved_function(is_enabled_and_bind_by_default,"},{"line_number":72,"context_line":"                                  \u0027is_enabled\u0027, __name__)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def is_auto_address_subnet(subnet):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_13818a8f","line":72,"in_reply_to":"1ac06dbe_aa42190e","updated":"2016-08-23 20:01:03.000000000","message":"Fixed","commit_id":"ecefdb85b64b79a6694095b8b92430ab57d78929"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"930086d459d59986a6b265f07ba0dea49c08bdbd","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"is_enabled \u003d moves.moved_function(is_enabled_and_bind_by_default,"},{"line_number":77,"context_line":"                                  \u0027is_enabled\u0027, __name__, version\u003d\u0027Newton\u0027,"},{"line_number":78,"context_line":"                                  removal_version\u003d\u0027Ocata\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def is_auto_address_subnet(subnet):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_b85a924e","line":78,"updated":"2016-09-06 20:51:23.000000000","message":"It\u0027s Ocata now. I think this needs to be P.","commit_id":"dcecc995be8acdc56a314fe7ef5d9209b4da6cc0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57553a0d84e71032f51495826bc9044081be5dde","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            _IS_IPV6_ENABLED \u003d False"},{"line_number":71,"context_line":"        if not _IS_IPV6_ENABLED:"},{"line_number":72,"context_line":"            LOG.info(_LI(\"IPv6 is not enabled on this system.\"))"},{"line_number":73,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_2cafabe4","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":60},"updated":"2016-10-26 08:50:31.000000000","message":"Should we have a more informative message here? Maybe a message tailored to whether ipv6 is not enabled or if it is enabled but not binding addresses by default.","commit_id":"6d94cf204c5b7a31108f64bb9b6ada29eea48acb"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"84b6a002cde84374d101d65802e5a0a9e69c336b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            _IS_IPV6_ENABLED \u003d False"},{"line_number":71,"context_line":"        if not _IS_IPV6_ENABLED:"},{"line_number":72,"context_line":"            LOG.info(_LI(\"IPv6 is not enabled on this system.\"))"},{"line_number":73,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_6cad2388","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":60},"in_reply_to":"ba5da102_2cafabe4","updated":"2016-10-26 09:04:10.000000000","message":"Fixed","commit_id":"6d94cf204c5b7a31108f64bb9b6ada29eea48acb"}]}