)]}'
{"neutron/api/v2/base.py":[{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"fdcd1a46e855b51e0f068c8c50b700e7dfb65c82","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        if res_dict is None:"},{"line_number":669,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":670,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":671,"context_line":"        msg \u003d attributes._validate_dict(res_dict)"},{"line_number":672,"context_line":"        if msg:"},{"line_number":673,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_7e44ec48","line":671,"updated":"2016-08-24 04:19:44.000000000","message":"This works correctly. But just a suggestion, can this dictionary validation be done after line 649? This would avoid all the unnecessary operations on an invalid dictionary.","commit_id":"bed5b953391b84fd6b8a8930689b3c6604b1c8d2"},{"author":{"_account_id":17133,"name":"Kengo Hobo","email":"hobo.kengo@jp.fujitsu.com","username":"hobo.kengo"},"change_message_id":"28a61ca0cd9412a08f245179bfc4aa0ecd544c1d","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        if res_dict is None:"},{"line_number":669,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":670,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":671,"context_line":"        msg \u003d attributes._validate_dict(res_dict)"},{"line_number":672,"context_line":"        if msg:"},{"line_number":673,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_99cb8172","line":671,"in_reply_to":"1ac06dbe_1722f6a2","updated":"2016-08-26 05:36:06.000000000","message":"Yes, we cannot judge whether the request is bulk or not in line 649.\nThus, I think these lines should be added in this position.","commit_id":"bed5b953391b84fd6b8a8930689b3c6604b1c8d2"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c1d08912f064b0c044a3a76a2c5a53b11506071e","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        if res_dict is None:"},{"line_number":669,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":670,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":671,"context_line":"        msg \u003d attributes._validate_dict(res_dict)"},{"line_number":672,"context_line":"        if msg:"},{"line_number":673,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1722f6a2","line":671,"in_reply_to":"1ac06dbe_4dfd046d","updated":"2016-08-24 08:02:02.000000000","message":"+1","commit_id":"bed5b953391b84fd6b8a8930689b3c6604b1c8d2"},{"author":{"_account_id":13933,"name":"Niko Hermanns","email":"nikolas.hermanns@ericsson.com","username":"enikher"},"change_message_id":"0acd7828eeb1d965bb7bc12898b7e8c44d351689","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        if res_dict is None:"},{"line_number":669,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":670,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":671,"context_line":"        msg \u003d attributes._validate_dict(res_dict)"},{"line_number":672,"context_line":"        if msg:"},{"line_number":673,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_4dfd046d","line":671,"in_reply_to":"1ac06dbe_7e44ec48","updated":"2016-08-24 07:20:54.000000000","message":"Aren\u0027t the lines in between the one which generate res_dict?","commit_id":"bed5b953391b84fd6b8a8930689b3c6604b1c8d2"},{"author":{"_account_id":17133,"name":"Kengo Hobo","email":"hobo.kengo@jp.fujitsu.com","username":"hobo.kengo"},"change_message_id":"d61a14a42f6f9524009b28294f04ba6f81f91b90","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        if res_dict is None:"},{"line_number":669,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":670,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":671,"context_line":"        msg \u003d attributes._validate_dict(res_dict)"},{"line_number":672,"context_line":"        if msg:"},{"line_number":673,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_4621f8fa","line":671,"in_reply_to":"5a8bc5a2_ff58f28c","updated":"2016-09-29 08:19:59.000000000","message":"Your notification is right.\nI will consume this method from neutron_lib.","commit_id":"bed5b953391b84fd6b8a8930689b3c6604b1c8d2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6d48460b7ead7f69fc66fa2717183efbf2b9ba8c","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        if res_dict is None:"},{"line_number":669,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":670,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":671,"context_line":"        msg \u003d attributes._validate_dict(res_dict)"},{"line_number":672,"context_line":"        if msg:"},{"line_number":673,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ff58f28c","line":671,"in_reply_to":"fa7ab95a_99cb8172","updated":"2016-09-27 21:43:33.000000000","message":"can\u0027t use a private method without fear of breaking.","commit_id":"bed5b953391b84fd6b8a8930689b3c6604b1c8d2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"57a374a7dbbb3d742720e85c070d678a6421bc86","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron_lib.api import validators"},{"line_number":21,"context_line":"from neutron_lib import exceptions"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_policy import policy as oslo_policy"},{"line_number":25,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_c09345f9","line":22,"updated":"2016-10-05 01:17:17.000000000","message":"why the extra new line here?","commit_id":"47a6d06c209ff0cb583cf125e452c9f917080494"},{"author":{"_account_id":17133,"name":"Kengo Hobo","email":"hobo.kengo@jp.fujitsu.com","username":"hobo.kengo"},"change_message_id":"6b086c3ed7351aa225e03329349dae3f35c8f6ae","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron_lib.api import validators"},{"line_number":21,"context_line":"from neutron_lib import exceptions"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_policy import policy as oslo_policy"},{"line_number":25,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_93a51006","line":22,"in_reply_to":"1a95cdbc_c09345f9","updated":"2016-10-05 07:08:38.000000000","message":"Ah, thanks. I\u0027ll remove it.","commit_id":"47a6d06c209ff0cb583cf125e452c9f917080494"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ee60c118f48cf487a3b3e45451f35db01dc4b3c9","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        if res_dict is None:"},{"line_number":705,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":706,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":707,"context_line":"        msg \u003d validators.validate_dict(res_dict)"},{"line_number":708,"context_line":"        if msg:"},{"line_number":709,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_d6801549","line":707,"updated":"2016-12-03 00:06:11.000000000","message":"This extra validation is only catching a corner case where you\u0027re not passing a dict body as part of the request. It doesn\u0027t solve the case where the body is either empty or the body structure contains invalid data that\u0027s not immediately caught by the validator. In any case, it would be great to avoid calling the validator entirely. You could simply do:\n\n  if res_dict is None or not isinstance(res_dict, dict):\n\nin line 704","commit_id":"1249c64ec6df0175cf9f6aa3e6b6d2e54dfcda0f"},{"author":{"_account_id":17133,"name":"Kengo Hobo","email":"hobo.kengo@jp.fujitsu.com","username":"hobo.kengo"},"change_message_id":"6d82faa92a7f2bbf273aebd70455b3b31bc605d5","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        if res_dict is None:"},{"line_number":705,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":706,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":707,"context_line":"        msg \u003d validators.validate_dict(res_dict)"},{"line_number":708,"context_line":"        if msg:"},{"line_number":709,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_66b39398","line":707,"in_reply_to":"3a71b18c_d6801549","updated":"2016-12-07 02:48:50.000000000","message":"Thanks, your point that avoid calling validator is reasonable.\nI think that error messages should be separated to clarify the problem.  \nHow about fixing as follows?\n* Avoid calling validator and check data type of value in this file.\n* Separate error messages by cause of error.","commit_id":"1249c64ec6df0175cf9f6aa3e6b6d2e54dfcda0f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5ca656a97bd8dd4352b9832ee983f28de5c68403","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        if res_dict is None:"},{"line_number":712,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":713,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":714,"context_line":"        if not isinstance(res_dict, dict):"},{"line_number":715,"context_line":"            msg \u003d _(\"\u0027%s\u0027 is not a dictionary\") % res_dict"},{"line_number":716,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_ebd8b220","line":714,"updated":"2016-12-09 23:17:25.000000000","message":"Please, avoid the duplication in logic and test, there\u0027s no need to discern on the error in my view. The client knows what is submitting, and sending a wrong type ([] vs {}) is a pretty glaring mistake.","commit_id":"06cf572282d3dd1352bd3f28458385892705473f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"4543d8bd926699af7a3486b442bb39cdd8f46ff5","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        if res_dict is None:"},{"line_number":712,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":713,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":714,"context_line":"        if not isinstance(res_dict, dict):"},{"line_number":715,"context_line":"            msg \u003d _(\"\u0027%s\u0027 is not a dictionary\") % res_dict"},{"line_number":716,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_34f58c56","line":714,"in_reply_to":"3a71b18c_ebd8b220","updated":"2016-12-28 09:40:21.000000000","message":"How about changing this validation which Armando said as follows?\n\n\u003e if res_dict is None or not isinstance(res_dict, dict):\n\nIn addition, how about changing error message via res_dict?  I think current message is wrong in case of [] or [\u0027hoge\u0027].","commit_id":"06cf572282d3dd1352bd3f28458385892705473f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3db9cc86d47779e9b39d27e61514b3d919cbcf55","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        if res_dict is None:"},{"line_number":710,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":711,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":712,"context_line":"        if res_dict is None or not isinstance(res_dict, dict):"},{"line_number":713,"context_line":"            msg \u003d _(\"\u0027%s\u0027 is not a dictionary\") % res_dict"},{"line_number":714,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_ffbc7fbc","line":712,"range":{"start_line":712,"start_character":23,"end_line":712,"end_character":27},"updated":"2017-04-06 05:34:44.000000000","message":"Why do we need to check for res_dict is None, the same is already checked in Line #709","commit_id":"63a8c4848a1f55e95331221c1d51231ec044e78d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"54edff146c273da24a00bcd9437131a6e2dbceb7","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        if res_dict is None:"},{"line_number":710,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":711,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":712,"context_line":"        if res_dict is not isinstance(res_dict, dict):"},{"line_number":713,"context_line":"            msg \u003d _(\"\u0027%s\u0027 is not a dictionary\") % res_dict"},{"line_number":714,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ffa3b31_563238f3","line":712,"updated":"2017-04-16 03:31:46.000000000","message":"\u0027is not\u0027 isn\u0027t what you want because it\u0027s checking if \u0027res_dict\u0027 \u0027is\u0027 the result of isinstance (a.k.a it\u0027s checking if it\u0027s True or False).","commit_id":"da4c2ca0a85977c126d8044c701f0a8e74012fce"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"eafc06cd54426c46ab6bbe68dcae6ae8b4830da8","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        if res_dict is None:"},{"line_number":710,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":711,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":712,"context_line":"        if res_dict is not isinstance(res_dict, dict):"},{"line_number":713,"context_line":"            msg \u003d _(\"\u0027%s\u0027 is not a dictionary\") % res_dict"},{"line_number":714,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ffa3b31_379b26ca","line":712,"in_reply_to":"7ffa3b31_563238f3","updated":"2017-04-16 14:54:28.000000000","message":"Done","commit_id":"da4c2ca0a85977c126d8044c701f0a8e74012fce"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"dae74caf119c274190db0a0e0c9b2fbb9c49af7c","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        except (AttributeError, TypeError):"},{"line_number":707,"context_line":"            msg \u003d _(\"Body contains invalid data\")"},{"line_number":708,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":709,"context_line":"        if res_dict is None:"},{"line_number":710,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":711,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":712,"context_line":"        if not isinstance(res_dict, dict):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_18061688","line":709,"updated":"2017-04-17 05:57:02.000000000","message":"You could probably get rid of this check now completely.","commit_id":"fbc650e0779d9f635a161d7545a2340728ccb177"}]}
