)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6bcc8fe57ba3d64503add6b5648a87d72f4958a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Edan David \u003cedand@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-22 11:25:13 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reduce rpc calls in sriov agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use one update_port_list rpc call instead of"},{"line_number":10,"context_line":"update_port_up/update_port_down for each device separately."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_4e571926","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":25},"updated":"2016-08-23 01:55:23.000000000","message":"s/sriov/SR-IOV","commit_id":"a88b3059f0921a290245703cdd88f962d81b3ef0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"34f61b86d00fa180e11a4b8908fd8fa9f48f368c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use one update_port_list rpc call instead of"},{"line_number":10,"context_line":"update_port_up/update_port_down for each device separately."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0a367712ff9410c2376b5b70c76806391bed3707"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfeb2761_bf06d785","line":11,"updated":"2017-04-02 08:38:08.000000000","message":"Please file a bug with launchpad to reduce the number of calls and reference it here so we can track this.","commit_id":"3160e8dedcaf4fb96ded81575620cf58b9e74ed6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"967b4963905ddb2f1175a718cc4e403dfce2e0f1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use one update_port_list rpc call instead of"},{"line_number":10,"context_line":"update_port_up/update_port_down for each device separately."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0a367712ff9410c2376b5b70c76806391bed3707"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ffa3b31_6212155b","line":11,"in_reply_to":"dfeb2761_bf06d785","updated":"2017-04-15 01:24:32.000000000","message":"Done","commit_id":"3160e8dedcaf4fb96ded81575620cf58b9e74ed6"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6bcc8fe57ba3d64503add6b5648a87d72f4958a4","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                        devices_up.add(device)"},{"line_number":306,"context_line":"                    else:"},{"line_number":307,"context_line":"                        devices_down.add(device)"},{"line_number":308,"context_line":"                self._update_network_ports(device_details[\u0027network_id\u0027],"},{"line_number":309,"context_line":"                                           port_id,"},{"line_number":310,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":311,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":312,"context_line":"                self.plugin_rpc.update_device_list(self.context,"},{"line_number":313,"context_line":"                                                   devices_up,"},{"line_number":314,"context_line":"                                                   devices_down,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_0e57e158","line":311,"range":{"start_line":308,"start_character":0,"end_line":311,"end_character":74},"updated":"2016-08-23 01:55:23.000000000","message":"I think it is better to move this to be under the if","commit_id":"a88b3059f0921a290245703cdd88f962d81b3ef0"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6bcc8fe57ba3d64503add6b5648a87d72f4958a4","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                           port_id,"},{"line_number":310,"context_line":"                                           (device, profile.get(\u0027pci_slot\u0027)))"},{"line_number":311,"context_line":"                self.ext_manager.handle_port(self.context, device_details)"},{"line_number":312,"context_line":"                self.plugin_rpc.update_device_list(self.context,"},{"line_number":313,"context_line":"                                                   devices_up,"},{"line_number":314,"context_line":"                                                   devices_down,"},{"line_number":315,"context_line":"                                                   self.agent_id,"},{"line_number":316,"context_line":"                                                   self.conf.host)"},{"line_number":317,"context_line":"            else:"},{"line_number":318,"context_line":"                LOG.info(_LI(\"Device with MAC %s not defined on plugin\"),"},{"line_number":319,"context_line":"                         device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_ee252509","line":316,"range":{"start_line":312,"start_character":0,"end_line":316,"end_character":66},"updated":"2016-08-23 01:55:23.000000000","message":"this is in the for loop so you don\u0027t save nothing","commit_id":"a88b3059f0921a290245703cdd88f962d81b3ef0"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_sriov_nic_agent.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6bcc8fe57ba3d64503add6b5648a87d72f4958a4","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        resync_needed \u003d agent.treat_devices_added_updated("},{"line_number":332,"context_line":"                            set([\u0027aa:bb:cc:dd:ee:ff\u0027]))"},{"line_number":333,"context_line":"        self.assertFalse(resync_needed)"},{"line_number":334,"context_line":"        agent.plugin_rpc.update_device_list.assert_called_once_with("},{"line_number":335,"context_line":"                mock.ANY,"},{"line_number":336,"context_line":"                set(),"},{"line_number":337,"context_line":"                set([\u0027aa:bb:cc:dd:ee:ff\u0027]),"},{"line_number":338,"context_line":"                mock.ANY,"},{"line_number":339,"context_line":"                mock.ANY)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_update_and_clean_network_ports(self):"},{"line_number":342,"context_line":"        network_id1 \u003d \u0027network_id1\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_6e513536","line":339,"range":{"start_line":334,"start_character":0,"end_line":339,"end_character":25},"updated":"2016-08-23 01:55:23.000000000","message":"you are missing test for 2 port admin_up and\n1 port admin up 1 port admin down","commit_id":"a88b3059f0921a290245703cdd88f962d81b3ef0"}]}