)]}'
{"neutron/agent/ovsdb/native/connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"f05b51bf42ff1e98299e4571f5158e718b8369df","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_87a90693","line":87,"updated":"2016-08-22 19:05:35.000000000","message":"There is an argument to be made that we shouldn\u0027t try to correct the managers issue at runtime at all since this is a configuration issue which should be caught by a sanity check after deployment as opposed to checking each time we start.\n\nThere is another patch up for fixing where calling set-manager erases existing managers as well. I think the primary reason we have it is because it makes the gate jobs/running tests locally easier (nothing has to be configured). One downside is that the OVSDB functional tests have to have sudo enabled even though they wouldn\u0027t need it if it wasn\u0027t for this call.","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a18383395f890adc487f48bdb41f746ce829af1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_8a7224e4","line":87,"in_reply_to":"1ac06dbe_693f5387","updated":"2016-08-26 13:39:29.000000000","message":"We have a script that prepares functional env in tree already. I will support anyone who is willing to send patches to move it to deployment tools. But that\u0027s not that simple, since we will need to deprecate the current behaviour for a cycle.","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0bb306acb72b0b913929ad4f2cac1d2f746676cc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_cd567d5b","line":87,"in_reply_to":"1ac06dbe_826c54d1","updated":"2016-08-22 20:01:28.000000000","message":"Maybe it would be better to just throw a specific exception in idlutils.get_schema_helper. Then, let users of the code decide what they want to do with it? Something like:\n\n class OvsdbIdl(object):\n def __init__(...):\n     try:\n         connection.start()\n     except OVSConnectionError:\n         helpers.enable_connection_uri(coonection.connection)\n         connection.start()\n\nI\u0027d like to be able to have OVN not have to basically copy Connection.start() at some point. Thoughts?","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b5ee429438ef97787ea24bc43c26915e480b71cf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_693f5387","line":87,"in_reply_to":"1ac06dbe_87a90693","updated":"2016-08-23 11:59:47.000000000","message":"\u003e One downside is that the OVSDB functional tests have to have sudo enabled even though they wouldn\u0027t need it if it wasn\u0027t for this call.\n\nCan\u0027t we set it in tox.ini ?","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1dcb02788dc3ed50e61baab7fc34591dd72bd729","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_826c54d1","line":87,"in_reply_to":"1ac06dbe_87a90693","updated":"2016-08-22 19:20:34.000000000","message":"Thanks for the pointer to the patch.  We\u0027ll see what other reviewers have to say about this helper.","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":13933,"name":"Niko Hermanns","email":"nikolas.hermanns@ericsson.com","username":"enikher"},"change_message_id":"c19b1f2cd7bca72333c4d284e07f146044b4f66a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_f8dcbe74","line":87,"in_reply_to":"1ac06dbe_cd567d5b","updated":"2016-08-23 07:03:46.000000000","message":"I think the function should be removed and go to an own setup script, which can be used by deployers as well.","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"21351052aae33175d8461eb1e1a526cc69750342","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_89213dff","line":87,"in_reply_to":"1ac06dbe_cd567d5b","updated":"2016-08-31 20:31:27.000000000","message":"I would also like to have OVN avoid copying code here.  I haven\u0027t thought much about it but it is on my todo list as part of the neutron-lib transition for OVN.","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"bec8c30e975306e6e07a0d6d6f12d12130912fe4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            except Exception:"},{"line_number":85,"context_line":"                try:"},{"line_number":86,"context_line":"                    # We may have failed do to set-manager not being called"},{"line_number":87,"context_line":"                    helpers.enable_connection_uri(self.connection)"},{"line_number":88,"context_line":"                except Exception:"},{"line_number":89,"context_line":"                    # Do not allow an exception to prevent a retry."},{"line_number":90,"context_line":"                    LOG.exception(_LE(\u0027Failed to set OVS connection URI\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e9ed698f","line":87,"in_reply_to":"fa7ab95a_89213dff","updated":"2016-08-31 20:34:57.000000000","message":"Maybe a reasonable first step is to let callers determine whether or not this additional connection configuration should be done.","commit_id":"09f572f28d3b6907710e6ca63d5d0f2727ceee99"}],"neutron/tests/unit/agent/ovsdb/native/test_connection.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a4c67d568987c766a9f255e6cd9d871261e52246","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":74,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":75,"context_line":"    def _test_start_retry(self, wfc, idl, ecu, tq, set_manager_target\u003dTrue):"},{"line_number":76,"context_line":"        test_connection \u003d mock.Mock()"},{"line_number":77,"context_line":"        helper \u003d mock.Mock()"},{"line_number":78,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":79,"context_line":"            test_connection, mock.Mock(), mock.Mock())"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_85b89a2b","line":76,"range":{"start_line":76,"start_character":26,"end_line":76,"end_character":37},"updated":"2016-10-17 09:11:29.000000000","message":"Nit: This can be mock.sentinel.connection","commit_id":"55edfc7358de63d41eca5e5c8c414554cb1ec346"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5ae7266fdfa41d126441bb1576fb704720b4cde6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    @mock.patch.object(idl, \u0027Idl\u0027)"},{"line_number":74,"context_line":"    @mock.patch.object(idlutils, \u0027wait_for_change\u0027)"},{"line_number":75,"context_line":"    def _test_start_retry(self, wfc, idl, ecu, tq, set_manager_target\u003dTrue):"},{"line_number":76,"context_line":"        test_connection \u003d mock.Mock()"},{"line_number":77,"context_line":"        helper \u003d mock.Mock()"},{"line_number":78,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":79,"context_line":"            test_connection, mock.Mock(), mock.Mock())"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_5a80158c","line":76,"range":{"start_line":76,"start_character":26,"end_line":76,"end_character":37},"in_reply_to":"fa6399be_85b89a2b","updated":"2016-10-17 14:26:01.000000000","message":"Done","commit_id":"55edfc7358de63d41eca5e5c8c414554cb1ec346"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a4c67d568987c766a9f255e6cd9d871261e52246","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        test_connection \u003d mock.Mock()"},{"line_number":77,"context_line":"        helper \u003d mock.Mock()"},{"line_number":78,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":79,"context_line":"            test_connection, mock.Mock(), mock.Mock())"},{"line_number":80,"context_line":"        with mock.patch.object(idlutils, \u0027get_schema_helper\u0027,"},{"line_number":81,"context_line":"                               side_effect\u003d[Exception, helper]),\\"},{"line_number":82,"context_line":"                mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_a5b83e12","line":79,"range":{"start_line":79,"start_character":29,"end_line":79,"end_character":53},"updated":"2016-10-17 09:11:29.000000000","message":"Nit: These can be sentinels - see L66","commit_id":"55edfc7358de63d41eca5e5c8c414554cb1ec346"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5ae7266fdfa41d126441bb1576fb704720b4cde6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        test_connection \u003d mock.Mock()"},{"line_number":77,"context_line":"        helper \u003d mock.Mock()"},{"line_number":78,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":79,"context_line":"            test_connection, mock.Mock(), mock.Mock())"},{"line_number":80,"context_line":"        with mock.patch.object(idlutils, \u0027get_schema_helper\u0027,"},{"line_number":81,"context_line":"                               side_effect\u003d[Exception, helper]),\\"},{"line_number":82,"context_line":"                mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_7a7dd9b0","line":79,"range":{"start_line":79,"start_character":29,"end_line":79,"end_character":53},"in_reply_to":"fa6399be_a5b83e12","updated":"2016-10-17 14:26:01.000000000","message":"Done","commit_id":"55edfc7358de63d41eca5e5c8c414554cb1ec346"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a4c67d568987c766a9f255e6cd9d871261e52246","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                               side_effect\u003d[Exception, helper]),\\"},{"line_number":82,"context_line":"                mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":83,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":84,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":85,"context_line":"            self.connection.start(set_manager_target\u003dset_manager_target)"},{"line_number":86,"context_line":"        if set_manager_target:"},{"line_number":87,"context_line":"            ecu.assert_called_once_with(test_connection)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_e5a076f6","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":71},"updated":"2016-10-17 09:11:29.000000000","message":"Is it necessary to mock out poller? As threading.Thread is mock, it seems connection.run() is never executed.","commit_id":"55edfc7358de63d41eca5e5c8c414554cb1ec346"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5ae7266fdfa41d126441bb1576fb704720b4cde6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                               side_effect\u003d[Exception, helper]),\\"},{"line_number":82,"context_line":"                mock.patch.object(poller, \u0027Poller\u0027) as poller_mock,\\"},{"line_number":83,"context_line":"                mock.patch(\u0027threading.Thread\u0027):"},{"line_number":84,"context_line":"            poller_mock.return_value.block.side_effect \u003d eventlet.sleep"},{"line_number":85,"context_line":"            self.connection.start(set_manager_target\u003dset_manager_target)"},{"line_number":86,"context_line":"        if set_manager_target:"},{"line_number":87,"context_line":"            ecu.assert_called_once_with(test_connection)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_dd3fbf85","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":71},"in_reply_to":"fa6399be_e5a076f6","updated":"2016-10-17 14:26:01.000000000","message":"It isn\u0027t necessary to mock poller.  I will fix.","commit_id":"55edfc7358de63d41eca5e5c8c414554cb1ec346"}]}
