)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"fbfb28b1f7ebdae3ae9d279f112987ac9e9add86","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVO for FlatAllocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces and implements OVO for"},{"line_number":10,"context_line":"flat allocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5324d5a911f151c6ebaf35c0af58db96ee2e0344"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a8bc5a2_b5a666bf","line":9,"updated":"2016-09-22 19:53:25.000000000","message":"This patch is only introducing the OVO class and not integrating it.","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"22d997e8a0b64a297491aaa1361b4c9cda7f3d2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVO for FlatAllocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces and implements OVO for"},{"line_number":10,"context_line":"flat allocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5324d5a911f151c6ebaf35c0af58db96ee2e0344"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a98d1f4_d9f2746f","line":9,"in_reply_to":"5a8bc5a2_58b71239","updated":"2016-09-28 15:18:09.000000000","message":"Done","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ddf9458c842e726d8ff3ad8e8b69c9fda795bbc5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVO for FlatAllocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces and implements OVO for"},{"line_number":10,"context_line":"flat allocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5324d5a911f151c6ebaf35c0af58db96ee2e0344"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a8bc5a2_58b71239","line":9,"in_reply_to":"5a8bc5a2_b5a666bf","updated":"2016-09-22 21:53:42.000000000","message":"+1","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"22d997e8a0b64a297491aaa1361b4c9cda7f3d2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVO for FlatAllocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces and implements OVO for"},{"line_number":10,"context_line":"flat allocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5324d5a911f151c6ebaf35c0af58db96ee2e0344"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a98d1f4_79e5e0a6","line":9,"in_reply_to":"5a8bc5a2_b5a666bf","updated":"2016-09-28 15:18:09.000000000","message":"Done","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"15e4251884607c351b786fb71d857044a038c2c8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5324d5a911f151c6ebaf35c0af58db96ee2e0344"},{"line_number":12,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":13,"context_line":"Partial-Bug: #1541928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a98d1f4_9cc1ba31","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"updated":"2016-09-28 15:12:54.000000000","message":"This tag is not needed","commit_id":"d6eeae3a63786ad42962e3538d16947a6096c458"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3dfbea580c3931616a68ebd81f7f85e5055b891a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5324d5a911f151c6ebaf35c0af58db96ee2e0344"},{"line_number":12,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":13,"context_line":"Partial-Bug: #1541928"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a98d1f4_5768ebba","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":21},"in_reply_to":"3a98d1f4_9cc1ba31","updated":"2016-09-28 15:22:00.000000000","message":"Done","commit_id":"d6eeae3a63786ad42962e3538d16947a6096c458"}],"neutron/objects/plugins/ml2/flatallocation.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"2f7f7f7155e6bfd86aa4d1274fbeaa010529fdf7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    db_model \u003d flatallocation.FlatAllocation"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027physical_network\u0027: obj_fields.StringField(nullable\u003dFalse)"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_55665fbb","line":29,"updated":"2016-09-13 16:55:49.000000000","message":"\u0027nullable\u003dFalse\u0027 is not needed here as it is set to False by default in Oslo fields.\n\nSee: https://review.openstack.org/#/c/336518/8/doc/source/devref/objects_usage.rst\nLine:157\n\nAn example can be found here:\n1)https://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L77-L78\n2)https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L112-L113","commit_id":"4d72fb2d26f4b98431baad1553f613c8c7dbd0de"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3e3596e856f30ad024e6b0063fd3577ae100b38e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    db_model \u003d flatallocation.FlatAllocation"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027physical_network\u0027: obj_fields.StringField(nullable\u003dFalse)"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_8387790e","line":29,"in_reply_to":"9a89bdaa_55665fbb","updated":"2016-09-22 17:36:27.000000000","message":"Done","commit_id":"4d72fb2d26f4b98431baad1553f613c8c7dbd0de"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"98cff3f1bceb1032ffc88da20eadf70e3d3ce3a2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    db_model \u003d flatallocation.FlatAllocation"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027physical_network\u0027: obj_fields.StringField(nullable\u003dFalse)"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    primary_keys \u003d [\u0027physical_network\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_37e4cadf","line":29,"in_reply_to":"9a89bdaa_55665fbb","updated":"2016-09-15 17:03:50.000000000","message":"Example is:\n1)https://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L43-L44\n2)https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L114-L115","commit_id":"4d72fb2d26f4b98431baad1553f613c8c7dbd0de"}],"neutron/plugins/ml2/drivers/type_flat.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"210852c31a7e6913a968021e8c5f11dfec435218","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        count \u003d flat_obj.FlatAllocation.get_object("},{"line_number":121,"context_line":"            context1,"},{"line_number":122,"context_line":"            physical_network\u003dphysical_network)"},{"line_number":123,"context_line":"        count.delete()"},{"line_number":124,"context_line":"        if count:"},{"line_number":125,"context_line":"            LOG.debug(\"Releasing flat network on physical network %s\","},{"line_number":126,"context_line":"                      physical_network)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_df5f9e0c","line":123,"updated":"2016-11-15 09:05:21.000000000","message":"In case FlatAllocation is not found, this line would generate an error.\nShouldn\u0027t this line go under the following if block?","commit_id":"b17230e80f53f17e4bf90a7b681d5a588b6e3fc2"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"189a2fa207ece701b4aab60b12019b609197e368","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        count \u003d flat_obj.FlatAllocation.get_object("},{"line_number":121,"context_line":"            context1,"},{"line_number":122,"context_line":"            physical_network\u003dphysical_network)"},{"line_number":123,"context_line":"        count.delete()"},{"line_number":124,"context_line":"        if count:"},{"line_number":125,"context_line":"            LOG.debug(\"Releasing flat network on physical network %s\","},{"line_number":126,"context_line":"                      physical_network)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_f83db48f","line":123,"in_reply_to":"7a77a97e_df5f9e0c","updated":"2016-11-18 01:51:25.000000000","message":"Done","commit_id":"b17230e80f53f17e4bf90a7b681d5a588b6e3fc2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"fc0c3cf7084870f6043bf62b7889dee0530dafe0","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def reserve_provider_segment(self, session, segment):"},{"line_number":96,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":97,"context_line":"        context1 \u003d context.Context()"},{"line_number":98,"context_line":"        context1._session \u003d session"},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            LOG.debug(\"Reserving flat network on physical \""}],"source_content_type":"text/x-python","patch_set":15,"id":"7a77a97e_2457b0cb","line":97,"updated":"2016-11-21 13:09:21.000000000","message":"can you please make this depend on 398873 instead since it will give you a real context object?\nOtherwise I think our log statement is going to lose the right request_id.","commit_id":"ab0ad5ac4d63ca13e0034871dcf79ae7c92c1e83"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"defdefda63218a2f801ce14b10ec35e98c0907f7","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":116,"context_line":"            context,"},{"line_number":117,"context_line":"            physical_network\u003dphysical_network)"},{"line_number":118,"context_line":"        if obj:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_811a4bc4","line":115,"updated":"2016-11-29 14:41:41.000000000","message":"we need a transaction here because otherwise you will get an exception in line 119 if the object is deleted in between line 115 and 119.","commit_id":"53d8a292c3b37d301500d6b854beea0c46e97ce4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5db51da0f0d1c0d06959ae6cad93a1826c2cefd2","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":116,"context_line":"            context,"},{"line_number":117,"context_line":"            physical_network\u003dphysical_network)"},{"line_number":118,"context_line":"        if obj:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_bfeba0af","line":115,"in_reply_to":"5a74a57a_472f30a1","updated":"2016-11-30 16:20:06.000000000","message":"Done","commit_id":"53d8a292c3b37d301500d6b854beea0c46e97ce4"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"40abc210f8eaaf8605c217338c4ba896e9c74383","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":116,"context_line":"            context,"},{"line_number":117,"context_line":"            physical_network\u003dphysical_network)"},{"line_number":118,"context_line":"        if obj:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_472f30a1","line":115,"in_reply_to":"5a74a57a_811a4bc4","updated":"2016-11-30 13:14:18.000000000","message":"Agree.","commit_id":"53d8a292c3b37d301500d6b854beea0c46e97ce4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5db51da0f0d1c0d06959ae6cad93a1826c2cefd2","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":116,"context_line":"            context,"},{"line_number":117,"context_line":"            physical_network\u003dphysical_network)"},{"line_number":118,"context_line":"        if obj:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_7fe108d0","line":115,"in_reply_to":"5a74a57a_811a4bc4","updated":"2016-11-30 16:20:06.000000000","message":"Done","commit_id":"53d8a292c3b37d301500d6b854beea0c46e97ce4"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"913938960138d10434b7f2b7d14370888c7b09bf","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":116,"context_line":"            obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":117,"context_line":"                context,"},{"line_number":118,"context_line":"                physical_network\u003dphysical_network)"},{"line_number":119,"context_line":"            if obj:"},{"line_number":120,"context_line":"                obj.delete()"},{"line_number":121,"context_line":"                LOG.debug(\"Releasing flat network on physical network %s\","},{"line_number":122,"context_line":"                          physical_network)"},{"line_number":123,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_e02574ae","line":120,"range":{"start_line":116,"start_character":12,"end_line":120,"end_character":28},"updated":"2016-11-30 17:10:28.000000000","message":"I\u0027m thinking if this can be replaced by delete_objects, when delete_objects would return count of deleted objects...","commit_id":"dc49ed4fce31a49311cbcc8ac3dc7ffabe959f6a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5a1d227bcba2a9257bdb683fa044c03bd4b2ba6a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":116,"context_line":"            obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":117,"context_line":"                context,"},{"line_number":118,"context_line":"                physical_network\u003dphysical_network)"},{"line_number":119,"context_line":"            if obj:"},{"line_number":120,"context_line":"                obj.delete()"},{"line_number":121,"context_line":"                LOG.debug(\"Releasing flat network on physical network %s\","},{"line_number":122,"context_line":"                          physical_network)"},{"line_number":123,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a71b18c_67ea3511","line":120,"range":{"start_line":116,"start_character":12,"end_line":120,"end_character":28},"in_reply_to":"5a74a57a_e02574ae","updated":"2016-12-02 20:44:41.000000000","message":"Yes, I think so too.","commit_id":"dc49ed4fce31a49311cbcc8ac3dc7ffabe959f6a"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"da19b8750103a47cde918da371af95c7f6e67a48","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                LOG.debug(\"Releasing flat network on physical network %s\","},{"line_number":122,"context_line":"                          physical_network)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                LOG.warning(_LW(\"No flat network found on\""},{"line_number":125,"context_line":"                    \"physical network %s\"), physical_network)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def get_mtu(self, physical_network):"},{"line_number":128,"context_line":"        seg_mtu \u003d super(FlatTypeDriver, self).get_mtu()"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a71b18c_84a1a448","line":125,"range":{"start_line":124,"start_character":32,"end_line":125,"end_character":41},"updated":"2016-12-06 14:54:57.000000000","message":"There\u0027s no space before the closing quotes on L124, so this message will output as: \"No flat network found onphysical network...\"\n\nI would just remove this change anyway as it\u0027s unnecessary.","commit_id":"4c9b3cca8d978d43ce0bc7dbcf837fa02a588325"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"994543e224592145d071f8828efe9aa7cff06261","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                LOG.debug(\"Releasing flat network on physical network %s\","},{"line_number":122,"context_line":"                          physical_network)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                LOG.warning(_LW(\"No flat network found on\""},{"line_number":125,"context_line":"                    \"physical network %s\"), physical_network)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def get_mtu(self, physical_network):"},{"line_number":128,"context_line":"        seg_mtu \u003d super(FlatTypeDriver, self).get_mtu()"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a71b18c_8f9b7465","line":125,"range":{"start_line":124,"start_character":32,"end_line":125,"end_character":41},"in_reply_to":"3a71b18c_84a1a448","updated":"2016-12-06 18:44:31.000000000","message":"Done","commit_id":"4c9b3cca8d978d43ce0bc7dbcf837fa02a588325"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d180545c981496eafdd663a470285a04ed64d3e8","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def release_segment(self, context, segment):"},{"line_number":114,"context_line":"        physical_network \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":115,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":116,"context_line":"            obj \u003d flat_obj.FlatAllocation.get_object("},{"line_number":117,"context_line":"                context,"},{"line_number":118,"context_line":"                physical_network\u003dphysical_network)"}],"source_content_type":"text/x-python","patch_set":24,"id":"da4df55a_65309302","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":56},"updated":"2016-12-23 18:11:02.000000000","message":"i think this is not needed","commit_id":"2b16cb82d809cb522fac588cd9ad848f436c94a5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d180545c981496eafdd663a470285a04ed64d3e8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                          physical_network)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                LOG.warning(_LW("},{"line_number":125,"context_line":"                    \"No flat network found on physical network %s\"),"},{"line_number":126,"context_line":"                    physical_network)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def get_mtu(self, physical_network):"},{"line_number":129,"context_line":"        seg_mtu \u003d super(FlatTypeDriver, self).get_mtu()"}],"source_content_type":"text/x-python","patch_set":24,"id":"da4df55a_85549721","line":126,"range":{"start_line":125,"start_character":20,"end_line":126,"end_character":37},"updated":"2016-12-23 18:11:02.000000000","message":"this wasn\u0027t required","commit_id":"2b16cb82d809cb522fac588cd9ad848f436c94a5"}],"neutron/tests/unit/objects/plugins/ml2/test_flatallocation.py":[{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ddf9458c842e726d8ff3ad8e8b69c9fda795bbc5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FlatAllocationIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _test_class \u003d flatallocation.FlatAllocation"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FlatAllocationDbObjTestCase(test_base.BaseDbObjectTestCase,"},{"line_number":27,"context_line":"                                 testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_b8a57605","line":24,"updated":"2016-09-22 21:53:42.000000000","message":"Isn\u0027t setUp() function necessary? \nExample: https://review.openstack.org/#/c/356660/18/neutron/tests/unit/objects/plugins/ml2/test_vlanallocation.py@33","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"22d997e8a0b64a297491aaa1361b4c9cda7f3d2f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FlatAllocationIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _test_class \u003d flatallocation.FlatAllocation"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FlatAllocationDbObjTestCase(test_base.BaseDbObjectTestCase,"},{"line_number":27,"context_line":"                                 testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_5cad7230","line":24,"in_reply_to":"5a8bc5a2_4e5dfa13","updated":"2016-09-28 15:18:09.000000000","message":"+1","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"5289373a6aa04bbf188a956f2b6f7cadf753a217","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FlatAllocationIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _test_class \u003d flatallocation.FlatAllocation"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FlatAllocationDbObjTestCase(test_base.BaseDbObjectTestCase,"},{"line_number":27,"context_line":"                                 testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_c680d34c","line":24,"in_reply_to":"5a8bc5a2_4e5dfa13","updated":"2016-09-27 20:25:52.000000000","message":"Something similar to:\n\ndef setUp(self):\n        super(FlatAllocationDbObjTestCase, self).setUp()\n        self._create_test_network()\n        for obj in itertools.chain(self.db_objs, self.obj_fields):\n            obj[\u0027physical_network\u0027] \u003d self._network[\u0027name\u0027]","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"2586f0aa2b1490099693fb15aa7a724179df0cbb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FlatAllocationIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _test_class \u003d flatallocation.FlatAllocation"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FlatAllocationDbObjTestCase(test_base.BaseDbObjectTestCase,"},{"line_number":27,"context_line":"                                 testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_4e5dfa13","line":24,"in_reply_to":"5a8bc5a2_b8a57605","updated":"2016-09-27 19:58:09.000000000","message":"If setUp() doesn\u0027t change/modify/update anything, it\u0027s not needed.","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"22d997e8a0b64a297491aaa1361b4c9cda7f3d2f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class FlatAllocationIfaceObjTestCase(test_base.BaseObjectIfaceTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _test_class \u003d flatallocation.FlatAllocation"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FlatAllocationDbObjTestCase(test_base.BaseDbObjectTestCase,"},{"line_number":27,"context_line":"                                 testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_1cbbea73","line":24,"in_reply_to":"5a8bc5a2_c680d34c","updated":"2016-09-28 15:18:09.000000000","message":"Hey Shashank, I am not updating anything nor do I have any unit tests which needs anything initialized in the setUp function. So I don\u0027t think its needed here.","commit_id":"d2e428417ab44cd8361a9027f5e545c3139ac0c4"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"15e4251884607c351b786fb71d857044a038c2c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import itertools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.objects.plugins.ml2 import flatallocation"},{"line_number":19,"context_line":"from neutron.tests.unit.objects import test_base"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a98d1f4_5ca01291","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":16},"updated":"2016-09-28 15:12:54.000000000","message":"Do you need to import this?","commit_id":"d6eeae3a63786ad42962e3538d16947a6096c458"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3dfbea580c3931616a68ebd81f7f85e5055b891a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import itertools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.objects.plugins.ml2 import flatallocation"},{"line_number":19,"context_line":"from neutron.tests.unit.objects import test_base"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a98d1f4_f7865764","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":16},"in_reply_to":"3a98d1f4_5ca01291","updated":"2016-09-28 15:22:00.000000000","message":"Hey Victor, sorry leftover.","commit_id":"d6eeae3a63786ad42962e3538d16947a6096c458"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"564ec723f5ed71096c7412c6f306821157df0048","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FlatAllocationDbObjTestCase(test_base.BaseDbObjectTestCase,"},{"line_number":27,"context_line":"                                 testlib_api.SqlTestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    _test_class \u003d flatallocation.FlatAllocation"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_426a5182","line":27,"range":{"start_line":27,"start_character":30,"end_line":27,"end_character":33},"updated":"2016-10-20 16:50:24.000000000","message":"nit: wrong identation","commit_id":"87de10e9b274cdff41256f5350d0e9925077c308"}],"neutron/tests/unit/plugins/ml2/drivers/test_type_flat.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2d17af9c935f1c6047d18341c8eef3f01ed4e5ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FlatTypeTest(testlib_api.SqlTestCase):"},{"line_number":33,"context_line":"    CORE_PLUGIN \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(FlatTypeTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_1f2f263f","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":66},"updated":"2016-11-30 21:25:08.000000000","message":"i believe this shouldn\u0027t be hard coded, i guess you can import directory from neutron lib and try using that for plugin load","commit_id":"dc49ed4fce31a49311cbcc8ac3dc7ffabe959f6a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"5a1d227bcba2a9257bdb683fa044c03bd4b2ba6a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class FlatTypeTest(testlib_api.SqlTestCase):"},{"line_number":33,"context_line":"    CORE_PLUGIN \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(FlatTypeTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a71b18c_673875a1","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":66},"in_reply_to":"5a74a57a_1f2f263f","updated":"2016-12-02 20:44:41.000000000","message":"Done","commit_id":"dc49ed4fce31a49311cbcc8ac3dc7ffabe959f6a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"3d2e8c14780b08a7ec1cf743eea4df9d8439eff5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.driver.physnet_mtus \u003d []"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _get_allocation(self, context, segment):"},{"line_number":45,"context_line":"        return context.session.query(type_flat_model.FlatAllocation).filter_by("},{"line_number":46,"context_line":"            physical_network\u003dsegment[api.PHYSICAL_NETWORK]).first()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_is_partial_segment(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_5253f5e1","line":45,"range":{"start_line":45,"start_character":53,"end_line":45,"end_character":67},"updated":"2016-12-05 19:14:58.000000000","message":"You should consider to replace this as well.","commit_id":"24bddc8a5821b32ed53c294eb85fb781af300773"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6ff452561fee1fdd4eaca0b9812d643040378461","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.driver.physnet_mtus \u003d []"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _get_allocation(self, context, segment):"},{"line_number":45,"context_line":"        return context.session.query(type_flat_model.FlatAllocation).filter_by("},{"line_number":46,"context_line":"            physical_network\u003dsegment[api.PHYSICAL_NETWORK]).first()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_is_partial_segment(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_d20f0537","line":45,"range":{"start_line":45,"start_character":53,"end_line":45,"end_character":67},"in_reply_to":"3a71b18c_5253f5e1","updated":"2016-12-05 19:37:32.000000000","message":"Done","commit_id":"24bddc8a5821b32ed53c294eb85fb781af300773"}]}