)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e5b66b50e7f8510a8c41026391e026fec8c46dbf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"needs scheduling and flavors that don\u0027t."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I17a64c59eaf5d8605ff8ec2a29e491673be960e7"},{"line_number":20,"context_line":"Partially-Implements: blueprint multi-l3-backends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_68235206","line":20,"updated":"2016-09-03 02:00:33.000000000","message":"Is this the last of the series for Newton? So should this say Implements- instead? Or do you want to follow up with a devref patch that shows developers how to implement a dummy driver?","commit_id":"3d70cd45e2bc0108be717f2170200bcf5385cd79"}],"neutron/extensions/l3agentscheduler.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c69e198bc1e72eb4f0e9541e144e0bbd64c34c9d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def list_l3_agents_hosting_router(self, context, router_id):"},{"line_number":212,"context_line":"        pass"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def router_supports_scheduling(self, context, router_id):"},{"line_number":215,"context_line":"        \"\"\"Override this method to conditionally schedule routers.\"\"\""},{"line_number":216,"context_line":"        return True"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da7fb54a_7b931ffb","line":214,"updated":"2016-09-02 17:11:44.000000000","message":"How do envision this method be implemented? You pass the router_id, but do you expect implementers to go fetch the router object to make a decision? If so, passing router might be a better choice to avoid the extra query which is already made elsewhere?","commit_id":"3d70cd45e2bc0108be717f2170200bcf5385cd79"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"54db5eea1366fe8698589a426725c3ceb4a12080","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def list_l3_agents_hosting_router(self, context, router_id):"},{"line_number":212,"context_line":"        pass"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def router_supports_scheduling(self, context, router_id):"},{"line_number":215,"context_line":"        \"\"\"Override this method to conditionally schedule routers.\"\"\""},{"line_number":216,"context_line":"        return True"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_d4a5dab5","line":214,"in_reply_to":"da7fb54a_7b931ffb","updated":"2016-09-03 00:09:47.000000000","message":"Most L3 plugins will just return True or False all of the time.\n\nOur L3 plugin does a lookup of the service provider just based on the router id to determine the flavor so the additional overhead of looking up the router to pass into this function probably isn\u0027t worth it right now.","commit_id":"3d70cd45e2bc0108be717f2170200bcf5385cd79"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"920c12b18391c3d52d8b5fc243b23eda37174ce4","unresolved":false,"context_lines":[{"line_number":3454,"context_line":"                s2[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":3455,"context_line":"            self._assert_router_on_agent(r[\u0027router\u0027][\u0027id\u0027], \u0027host2\u0027)"},{"line_number":3456,"context_line":""},{"line_number":3457,"context_line":"    def test_router_update_gateway_scheduling_not_supported(self):"},{"line_number":3458,"context_line":"        plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":3459,"context_line":"            service_constants.L3_ROUTER_NAT)"},{"line_number":3460,"context_line":"        mock.patch.object(plugin, \u0027router_supports_scheduling\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_6bceec5b","line":3457,"updated":"2016-09-03 03:14:39.000000000","message":"would be nice to add an api test that validates router creation with flavor ID. Is that difficult?","commit_id":"3d70cd45e2bc0108be717f2170200bcf5385cd79"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d0df91e7db7d311da14d5821270a273dbeb6a035","unresolved":false,"context_lines":[{"line_number":3458,"context_line":"        plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":3459,"context_line":"            service_constants.L3_ROUTER_NAT)"},{"line_number":3460,"context_line":"        mock.patch.object(plugin, \u0027router_supports_scheduling\u0027,"},{"line_number":3461,"context_line":"                          return_value\u003dFalse).start()"},{"line_number":3462,"context_line":"        with self.router() as r:"},{"line_number":3463,"context_line":"            with self.subnet() as s1:"},{"line_number":3464,"context_line":"                with self.subnet() as s2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_692806e3","line":3461,"range":{"start_line":3461,"start_character":45,"end_line":3461,"end_character":53},"updated":"2016-09-07 17:58:32.000000000","message":"Don\u0027t we need a stop? I\u0027ve always followed the caution in the docs [1]. I guess this kind of thing is all over in this file so it must not be doing too much harm.\n\n [1] https://docs.python.org/3/library/unittest.mock.html#patch-methods-start-and-stop","commit_id":"b5fe13afa8a8f77d8bc05a7f244fb9d2fae02ae8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eba7cec5014c2a1ed020a115c89c59aba3086a2f","unresolved":false,"context_lines":[{"line_number":3458,"context_line":"        plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":3459,"context_line":"            service_constants.L3_ROUTER_NAT)"},{"line_number":3460,"context_line":"        mock.patch.object(plugin, \u0027router_supports_scheduling\u0027,"},{"line_number":3461,"context_line":"                          return_value\u003dFalse).start()"},{"line_number":3462,"context_line":"        with self.router() as r:"},{"line_number":3463,"context_line":"            with self.subnet() as s1:"},{"line_number":3464,"context_line":"                with self.subnet() as s2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_5c43fe41","line":3461,"range":{"start_line":3461,"start_character":45,"end_line":3461,"end_character":53},"in_reply_to":"9a89bdaa_692806e3","updated":"2016-09-07 18:00:41.000000000","message":"there\u0027s a stopall in the base class.","commit_id":"b5fe13afa8a8f77d8bc05a7f244fb9d2fae02ae8"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d0df91e7db7d311da14d5821270a273dbeb6a035","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def test__schedule_router_skips_unschedulable_routers(self):"},{"line_number":418,"context_line":"        mock.patch.object(self.plugin, \u0027router_supports_scheduling\u0027,"},{"line_number":419,"context_line":"                          return_value\u003dFalse).start()"},{"line_number":420,"context_line":"        scheduler \u003d l3_agent_scheduler.ChanceScheduler()"},{"line_number":421,"context_line":"        self.assertIsNone(scheduler._schedule_router(self.plugin,"},{"line_number":422,"context_line":"                                                     self.adminContext,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_6979e6c7","line":419,"range":{"start_line":419,"start_character":45,"end_line":419,"end_character":51},"updated":"2016-09-07 17:58:32.000000000","message":"stop?","commit_id":"b5fe13afa8a8f77d8bc05a7f244fb9d2fae02ae8"}]}
