)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31fabb198e42f8196a76bd3d7ec9a1d56ba32100","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def ensure_namespace(self, name):"},{"line_number":195,"context_line":"        if self.netns.exists(name):"},{"line_number":196,"context_line":"            if self.execute_namespace(name):"},{"line_number":197,"context_line":"                ip \u003d IPWrapper(namespace\u003dname)"},{"line_number":198,"context_line":"            else:"},{"line_number":199,"context_line":"                self.netns.delete(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_b3499633","line":196,"updated":"2016-08-23 18:46:48.000000000","message":"An extra check like this should be a private method and live up in the IpNetnsCommand class, or just in exists() itself, since it is checking for the namespace existence.  That way you don\u0027t even have to change this code.","commit_id":"29f525b2bb022817229f874a91b740e8d03475cb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31fabb198e42f8196a76bd3d7ec9a1d56ba32100","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def execute_namespace(self, name):"},{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            utils.execute([\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, name, \u0027ip\u0027, \u0027addr\u0027],"},{"line_number":214,"context_line":"                          run_as_root\u003dTrue,"},{"line_number":215,"context_line":"                          log_fail_as_error\u003dself.log_fail_as_error)"},{"line_number":216,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_53d66228","line":213,"updated":"2016-08-23 18:46:48.000000000","message":"Use self._as_root(...) for this.","commit_id":"29f525b2bb022817229f874a91b740e8d03475cb"}]}
