)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"functional: Make trunk tests more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_057fedaa","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":53},"updated":"2016-08-26 12:08:41.000000000","message":"compare","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"functional: Make trunk tests more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_656d1904","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2016-08-26 12:08:41.000000000","message":"send","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":7,"context_line":"functional: Make trunk tests more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_08a8e41e","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":53},"in_reply_to":"fa7ab95a_057fedaa","updated":"2016-08-26 12:21:36.000000000","message":"Done","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":7,"context_line":"functional: Make trunk tests more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_2831280c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"fa7ab95a_656d1904","updated":"2016-08-26 12:21:36.000000000","message":"Done","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"},{"line_number":14,"context_line":"case where we test connectivity while resources are not wired yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_65443974","line":11,"range":{"start_line":11,"start_character":65,"end_line":11,"end_character":72},"updated":"2016-08-26 12:08:41.000000000","message":"ditto","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"},{"line_number":14,"context_line":"case where we test connectivity while resources are not wired yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_454f3592","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2016-08-26 12:08:41.000000000","message":"succeed","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"},{"line_number":14,"context_line":"case where we test connectivity while resources are not wired yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_3bd5f442","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"fa7ab95a_454f3592","updated":"2016-08-26 12:21:36.000000000","message":"Done","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New methods for connection tester are introduced in this patch. They"},{"line_number":10,"context_line":"sent certain amount of icmp packets and then compares the results, so we"},{"line_number":11,"context_line":"success in positive tests only when all packets were replied. We success"},{"line_number":12,"context_line":"in negative tests only when all packets were lost. Both approaches are"},{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"},{"line_number":14,"context_line":"case where we test connectivity while resources are not wired yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_7bcf7cb0","line":11,"range":{"start_line":11,"start_character":65,"end_line":11,"end_character":72},"in_reply_to":"fa7ab95a_65443974","updated":"2016-08-26 12:21:36.000000000","message":"Done","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"},{"line_number":14,"context_line":"case where we test connectivity while resources are not wired yet."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I907ebd790f4ba3b4ecb0dce711c9f7d2c5244765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_e5584959","line":16,"updated":"2016-08-26 12:08:41.000000000","message":"Bug number?","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":13,"context_line":"wrapped by actively waiting for successful result so we don\u0027t fail in"},{"line_number":14,"context_line":"case where we test connectivity while resources are not wired yet."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I907ebd790f4ba3b4ecb0dce711c9f7d2c5244765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_7b14dcf4","line":16,"in_reply_to":"fa7ab95a_e5584959","updated":"2016-08-26 12:21:36.000000000","message":"There was no bug reported as this patch was sent as a followup of while https://review.openstack.org/#/c/335536/23 hasn\u0027t been merged yet.","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"}],"neutron/tests/common/conn_testers.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        try:"},{"line_number":160,"context_line":"            net_helpers.assert_ping(src_namespace, ip_address,"},{"line_number":161,"context_line":"                                    timeout\u003dicmp_timeout,"},{"line_number":162,"context_line":"                                    count\u003dself.ICMP_COUNT)"},{"line_number":163,"context_line":"        except RuntimeError:"},{"line_number":164,"context_line":"            raise ConnectionTesterException("},{"line_number":165,"context_line":"                \"ICMP packets can\u0027t get from %s namespace to %s address\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_882b1430","side":"PARENT","line":162,"updated":"2016-08-26 12:08:41.000000000","message":"is the change relevant? It changes the number of packets sent by assert_ping from 3 to 1.","commit_id":"e2f96d7b587bd552d0f02b908683ac5d4a0db559"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        try:"},{"line_number":160,"context_line":"            net_helpers.assert_ping(src_namespace, ip_address,"},{"line_number":161,"context_line":"                                    timeout\u003dicmp_timeout,"},{"line_number":162,"context_line":"                                    count\u003dself.ICMP_COUNT)"},{"line_number":163,"context_line":"        except RuntimeError:"},{"line_number":164,"context_line":"            raise ConnectionTesterException("},{"line_number":165,"context_line":"                \"ICMP packets can\u0027t get from %s namespace to %s address\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fb31cced","side":"PARENT","line":162,"in_reply_to":"fa7ab95a_882b1430","updated":"2016-08-26 12:21:36.000000000","message":"It is, it changes back the workaround for random failures when packets were still flowing through while patch ports were being removed: https://review.openstack.org/#/c/335536/23/neutron/tests/common/conn_testers.py@162","commit_id":"e2f96d7b587bd552d0f02b908683ac5d4a0db559"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"99fcaa0e3667deb6ec93ab1c77d16307b9b43c9d","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        common_utils.wait_until_true("},{"line_number":356,"context_line":"            all_lost_predicate, timeout\u003dself.connectivity_timeout,"},{"line_number":357,"context_line":"            exception\u003dConnectionTesterException("},{"line_number":358,"context_line":"                \"All packets still got reply from %s namespace to %s \""},{"line_number":359,"context_line":"                \"address.\" % self._get_namespace_and_address(direction)))"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_885dd4eb","line":358,"updated":"2016-08-26 12:08:41.000000000","message":"Is the message correct? I was thinking the predicate will return False when at least one of packets got a reply, not necessarily all.","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2028a30f022c195f6eec5c11d34f99e70514fc38","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        common_utils.wait_until_true("},{"line_number":356,"context_line":"            all_lost_predicate, timeout\u003dself.connectivity_timeout,"},{"line_number":357,"context_line":"            exception\u003dConnectionTesterException("},{"line_number":358,"context_line":"                \"All packets still got reply from %s namespace to %s \""},{"line_number":359,"context_line":"                \"address.\" % self._get_namespace_and_address(direction)))"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_db4b2858","line":358,"in_reply_to":"fa7ab95a_885dd4eb","updated":"2016-08-26 12:21:36.000000000","message":"You\u0027re right","commit_id":"ff475bc888c8abf828b32eb89cd69ffd0f6f5c6d"}]}
