)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c94901e67fcd7ca0281a8ea7061c54c4d9e71b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set L3 agent standby if admin_state_up\u003dFalse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If admin_state_up set to False L3 agent is still show as \u0027active\u0027"},{"line_number":10,"context_line":"in the HA router states on that agent. Current change adds check for such"},{"line_number":11,"context_line":"case and updates HA router state from \u0027active\u0027 to \u0027standby\u0027 if"},{"line_number":12,"context_line":"agent\u0027s admin_state_up is False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_caa2479a","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"updated":"2016-08-24 20:03:25.000000000","message":"still shows","commit_id":"194047040d4993ae8f3e2b3b096afbdc5f79518c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d16a4c53f057c69d5bc57cebbd5ba6d2da60fd03","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set L3 agent standby if admin_state_up\u003dFalse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If admin_state_up set to False L3 agent is still show as \u0027active\u0027"},{"line_number":10,"context_line":"in the HA router states on that agent. Current change adds check for such"},{"line_number":11,"context_line":"case and updates HA router state from \u0027active\u0027 to \u0027standby\u0027 if"},{"line_number":12,"context_line":"agent\u0027s admin_state_up is False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_32207c49","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":53},"in_reply_to":"1ac06dbe_caa2479a","updated":"2016-08-25 13:13:27.000000000","message":"Done","commit_id":"194047040d4993ae8f3e2b3b096afbdc5f79518c"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"2af72f4599a30f79f888d65334c2ea192ee2925c","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            dead_agents \u003d ["},{"line_number":656,"context_line":"                binding.agent for binding in bindings"},{"line_number":657,"context_line":"                if binding.state \u003d\u003d n_const.HA_ROUTER_STATE_ACTIVE and"},{"line_number":658,"context_line":"                not (binding.agent.is_active and binding.agent.admin_state_up)]"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"            for dead_agent in dead_agents:"},{"line_number":661,"context_line":"                self.update_routers_states("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_5c92d558","line":658,"range":{"start_line":658,"start_character":49,"end_line":658,"end_character":77},"updated":"2016-08-25 21:50:09.000000000","message":"Is context.is_admin a requirement for using admin_state_up? admin_state_up by default is True.","commit_id":"938937b94415bb79accb026a7bcc2d2a9d1dcf13"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"3aea7a696e9324004c72c40cdb3cdcce1a9dd661","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            dead_agents \u003d ["},{"line_number":656,"context_line":"                binding.agent for binding in bindings"},{"line_number":657,"context_line":"                if binding.state \u003d\u003d n_const.HA_ROUTER_STATE_ACTIVE and"},{"line_number":658,"context_line":"                not (binding.agent.is_active and binding.agent.admin_state_up)]"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"            for dead_agent in dead_agents:"},{"line_number":661,"context_line":"                self.update_routers_states("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_32019caf","line":658,"range":{"start_line":658,"start_character":49,"end_line":658,"end_character":77},"in_reply_to":"fa7ab95a_5c92d558","updated":"2016-08-26 11:03:01.000000000","message":"Only admin is able to change admin_state_up parameter. Here parameter is not changed, it is just checked here.","commit_id":"938937b94415bb79accb026a7bcc2d2a9d1dcf13"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"013918bb70a51097d5dd95adddde8a3a249329a7","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            self.admin_ctx, router[\u0027id\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _test_get_l3_bindings_hosting_router_with_ha_states(self, property):"},{"line_number":191,"context_line":"        router \u003d self._create_router()"},{"line_number":192,"context_line":"        with mock.patch.object(agents_db.Agent, property,"},{"line_number":193,"context_line":"                               new_callable\u003dmock.PropertyMock,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_d7195524","line":190,"updated":"2016-08-24 18:19:40.000000000","message":"We should have a test that changes the admin state of the agent, then gets the router states and asserts that it\u0027s standby. Same for the other direction.","commit_id":"194047040d4993ae8f3e2b3b096afbdc5f79518c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d16a4c53f057c69d5bc57cebbd5ba6d2da60fd03","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            self.admin_ctx, router[\u0027id\u0027])"},{"line_number":188,"context_line":"        self.assertEqual([], bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _test_get_l3_bindings_hosting_router_with_ha_states(self, property):"},{"line_number":191,"context_line":"        router \u003d self._create_router()"},{"line_number":192,"context_line":"        with mock.patch.object(agents_db.Agent, property,"},{"line_number":193,"context_line":"                               new_callable\u003dmock.PropertyMock,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_f225445c","line":190,"in_reply_to":"1ac06dbe_d7195524","updated":"2016-08-25 13:13:27.000000000","message":"Done","commit_id":"194047040d4993ae8f3e2b3b096afbdc5f79518c"}]}