)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"97d055d0967aadef899d091b20cdefd3d72bed41","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Edan David \u003cedand@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-31 09:31:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate SR-IOV \u0027physical_device_mappings\u0027 config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_6bb6893e","line":7,"updated":"2016-10-31 14:15:45.000000000","message":"Can you please add more context in the commit message as to why we are deprecating this ?","commit_id":"878a05e80e18796ff2fb48b3b0527ad9f341450c"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"61148e093248fd74e1bc40b75dbe0f9d71da74ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Edan David \u003cedand@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-31 09:31:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate SR-IOV \u0027physical_device_mappings\u0027 config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_7ae1d8fd","line":7,"in_reply_to":"ba5da102_6bb6893e","updated":"2016-11-01 11:17:15.000000000","message":"Done","commit_id":"878a05e80e18796ff2fb48b3b0527ad9f341450c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate SR-IOV \u0027physical_device_mappings\u0027 config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The device to physnet validation is made in Nova by pci_whitelist config option."},{"line_number":10,"context_line":"Therefor it is redundant to validate it in Neutron with physical_device_mappings"},{"line_number":11,"context_line":"config option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_f348f52f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":8},"updated":"2016-11-08 12:48:53.000000000","message":"therefore","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate SR-IOV \u0027physical_device_mappings\u0027 config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The device to physnet validation is made in Nova by pci_whitelist config option."},{"line_number":10,"context_line":"Therefor it is redundant to validate it in Neutron with physical_device_mappings"},{"line_number":11,"context_line":"config option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_34840ed3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":8},"in_reply_to":"9a629dbe_f348f52f","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The device to physnet validation is made in Nova by pci_whitelist config option."},{"line_number":10,"context_line":"Therefor it is redundant to validate it in Neutron with physical_device_mappings"},{"line_number":11,"context_line":"config option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_9fbfbbfa","line":12,"updated":"2016-11-08 12:48:53.000000000","message":"It does seem that the change does two independent things. 1) handle empty mappings; 2) deprecate the mappings option.\n\nI think we should split concerns here and have two patches.","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The device to physnet validation is made in Nova by pci_whitelist config option."},{"line_number":10,"context_line":"Therefor it is redundant to validate it in Neutron with physical_device_mappings"},{"line_number":11,"context_line":"config option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_de020c0b","line":12,"in_reply_to":"9a629dbe_9fbfbbfa","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4b0fafb2e2a76316356062d35698e2bd5b40a77b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The device to physnet validation is made in Nova by pci_whitelist config option."},{"line_number":10,"context_line":"Therefor it is redundant to validate it in Neutron with physical_device_mappings"},{"line_number":11,"context_line":"config option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_617245af","line":12,"in_reply_to":"9a629dbe_de020c0b","updated":"2016-11-08 15:41:52.000000000","message":"Where is it done exactly?","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_733145a2","line":15,"updated":"2016-11-08 12:48:53.000000000","message":"please include release note for the deprecation explaining the rationale for the change, as well as when the option will become deprecated.","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1616442"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1b1e67d2813b746337b6b13ad593fbba6d4798b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a629dbe_28ed9225","line":15,"in_reply_to":"9a629dbe_733145a2","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/common/config.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"d958ee7064eaf97070f41d36f9a29d5d5cda32ad","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Q release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":77,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":78,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_37c66e9a","line":75,"updated":"2016-08-29 18:17:04.000000000","message":"s/Q/Queens/","commit_id":"448df677ac7cb071af7165dcafd3179f45dcda25"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"3e6c5b30d290089efb497a4aa8ff064dc9f05ed5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Q release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":77,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":78,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_6dc3ac89","line":75,"in_reply_to":"fa7ab95a_37c66e9a","updated":"2016-08-30 07:06:00.000000000","message":"Done","commit_id":"448df677ac7cb071af7165dcafd3179f45dcda25"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                       \"function to be used for VLAN networks. All physical \""},{"line_number":71,"context_line":"                       \"networks listed in network_vlan_ranges on the server \""},{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Queens release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_730a25d4","line":73,"range":{"start_line":73,"start_character":35,"end_line":73,"end_character":36},"updated":"2016-11-08 12:48:53.000000000","message":"no space after the dot","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                       \"function to be used for VLAN networks. All physical \""},{"line_number":71,"context_line":"                       \"networks listed in network_vlan_ranges on the server \""},{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Queens release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_e8163af0","line":73,"range":{"start_line":73,"start_character":35,"end_line":73,"end_character":36},"in_reply_to":"9a629dbe_730a25d4","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Queens release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":77,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":78,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_136d6998","line":75,"range":{"start_line":75,"start_character":74,"end_line":75,"end_character":75},"updated":"2016-11-08 12:48:53.000000000","message":"redundant space","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Queens release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":77,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":78,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_935899fc","line":75,"updated":"2016-11-08 12:48:53.000000000","message":"why not Pike","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Queens release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":77,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":78,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_28d75224","line":75,"range":{"start_line":75,"start_character":74,"end_line":75,"end_character":75},"in_reply_to":"9a629dbe_136d6998","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \"should have mappings to appropriate interfaces on \""},{"line_number":73,"context_line":"                       \"each agent.\""},{"line_number":74,"context_line":"                       \"DEPRECATED: This option is deprecated in the Ocata \""},{"line_number":75,"context_line":"                       \"release and will be removed in the Queens release. \"),"},{"line_number":76,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":77,"context_line":"    cfg.ListOpt(\u0027exclude_devices\u0027,"},{"line_number":78,"context_line":"                default\u003dDEFAULT_EXCLUDE_DEVICES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_88e85ee4","line":75,"in_reply_to":"9a629dbe_935899fc","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/eswitch_manager.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"d958ee7064eaf97070f41d36f9a29d5d5cda32ad","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                self._create_emb_switch(phys_net, dev_name,"},{"line_number":345,"context_line":"                                        exclude_devices.get(dev_name, set()))"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def _create_emb_switch(self, phys_net, dev_name, exclude_devices):"},{"line_number":348,"context_line":"        embedded_switch \u003d EmbSwitch(phys_net, dev_name, exclude_devices)"},{"line_number":349,"context_line":"        self.emb_switches_map.setdefault(phys_net, []).append(embedded_switch)"},{"line_number":350,"context_line":"        for pci_slot in embedded_switch.get_pci_slot_list():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_f70c06ee","side":"PARENT","line":347,"updated":"2016-08-29 18:17:04.000000000","message":"Does the _ was removed by mistake ?","commit_id":"1b19d06e7be5cd8a84fb7d0d834ed9bb04234103"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"3e6c5b30d290089efb497a4aa8ff064dc9f05ed5","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                self._create_emb_switch(phys_net, dev_name,"},{"line_number":345,"context_line":"                                        exclude_devices.get(dev_name, set()))"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def _create_emb_switch(self, phys_net, dev_name, exclude_devices):"},{"line_number":348,"context_line":"        embedded_switch \u003d EmbSwitch(phys_net, dev_name, exclude_devices)"},{"line_number":349,"context_line":"        self.emb_switches_map.setdefault(phys_net, []).append(embedded_switch)"},{"line_number":350,"context_line":"        for pci_slot in embedded_switch.get_pci_slot_list():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_522767c9","side":"PARENT","line":347,"in_reply_to":"fa7ab95a_f70c06ee","updated":"2016-08-30 07:06:00.000000000","message":"No, we\u0027re considering this as public now, after we\u0027ll remove the device mapping config the discover device method will be removed as well, and then we\u0027ll only use create_emb_switch.","commit_id":"1b19d06e7be5cd8a84fb7d0d834ed9bb04234103"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"97d055d0967aadef899d091b20cdefd3d72bed41","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        for pci_slot in embedded_switch.get_pci_slot_list():"},{"line_number":371,"context_line":"            self.pci_slot_map[pci_slot] \u003d embedded_switch"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def destroy_emb_switch(self, device_mac, pci_slot):"},{"line_number":374,"context_line":"        \"\"\"Destroy embedded switch."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        @param device_mac: device mac"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_0bc6ed99","line":373,"updated":"2016-10-31 14:15:45.000000000","message":"Why is this method introduced in this patch ?  Seems unrelated.","commit_id":"878a05e80e18796ff2fb48b3b0527ad9f341450c"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"61148e093248fd74e1bc40b75dbe0f9d71da74ac","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        for pci_slot in embedded_switch.get_pci_slot_list():"},{"line_number":371,"context_line":"            self.pci_slot_map[pci_slot] \u003d embedded_switch"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def destroy_emb_switch(self, device_mac, pci_slot):"},{"line_number":374,"context_line":"        \"\"\"Destroy embedded switch."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        @param device_mac: device mac"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_faede8ef","line":373,"in_reply_to":"ba5da102_0bc6ed99","updated":"2016-11-01 11:17:15.000000000","message":"Done","commit_id":"878a05e80e18796ff2fb48b3b0527ad9f341450c"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a7f13e25d9a9b3efc9e09f0feef241f88ac38b98","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                                  enabled)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    # Note(edan): discover_devices method will be removed"},{"line_number":346,"context_line":"    #             with \u0027physical_device_mappings\u0027"},{"line_number":347,"context_line":"    def discover_devices(self, device_mappings, exclude_devices):"},{"line_number":348,"context_line":"        \"\"\"Discover which Virtual functions to manage."},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_3d1913d8","line":346,"updated":"2016-11-01 14:23:13.000000000","message":"Nit: No need to have all those white spaces here.  Actually, it doesn\u0027t seem consistent with any block comments I\u0027ve seen.","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"0a0754123da084e76d7543ba0a2e8c3b7c7bc84a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                                  enabled)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    # Note(edan): discover_devices method will be removed"},{"line_number":346,"context_line":"    #             with \u0027physical_device_mappings\u0027"},{"line_number":347,"context_line":"    def discover_devices(self, device_mappings, exclude_devices):"},{"line_number":348,"context_line":"        \"\"\"Discover which Virtual functions to manage."},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_fd015b07","line":346,"in_reply_to":"ba5da102_3d1913d8","updated":"2016-11-01 14:33:08.000000000","message":"Done","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a7f13e25d9a9b3efc9e09f0feef241f88ac38b98","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                                       exclude_devices.get(dev_name, set()))"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    # Note(edan): physnet param will be removed with \u0027physical_device_mappings\u0027"},{"line_number":362,"context_line":"    #             config option."},{"line_number":363,"context_line":"    def create_emb_switch(self, phys_net, dev_name, exclude_devices):"},{"line_number":364,"context_line":"        \"\"\"Create embedded switch."},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_5d0a477a","line":362,"updated":"2016-11-01 14:23:13.000000000","message":"ditto","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"0a0754123da084e76d7543ba0a2e8c3b7c7bc84a","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                                       exclude_devices.get(dev_name, set()))"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    # Note(edan): physnet param will be removed with \u0027physical_device_mappings\u0027"},{"line_number":362,"context_line":"    #             config option."},{"line_number":363,"context_line":"    def create_emb_switch(self, phys_net, dev_name, exclude_devices):"},{"line_number":364,"context_line":"        \"\"\"Create embedded switch."},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_2f01da05","line":362,"in_reply_to":"ba5da102_5d0a477a","updated":"2016-11-01 14:33:08.000000000","message":"Done","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        @param pci_addr: VF PCI address"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return os.listdir(cls.PF_INTERFACE_PATH % pci_addr).pop()"},{"line_number":102,"context_line":"        except OSError:"},{"line_number":103,"context_line":"            raise exc.InvalidPciSlotError(pci_slot\u003dpci_addr)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_3f86af13","line":101,"updated":"2016-11-08 12:48:53.000000000","message":"what if the directory is empty? It would raise IndexError. Is it expected?","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        @param pci_addr: VF PCI address"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return os.listdir(cls.PF_INTERFACE_PATH % pci_addr).pop()"},{"line_number":102,"context_line":"        except OSError:"},{"line_number":103,"context_line":"            raise exc.InvalidPciSlotError(pci_slot\u003dpci_addr)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_08efee87","line":101,"in_reply_to":"9a629dbe_3f86af13","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"8e03ae57d95d3f6bdbab39a418324fb62e72f3cb","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.eswitch_mgr.discover_devices(device_mappings, exclude_devices)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def scan_devices(self, registered_devices, updated_devices):"},{"line_number":207,"context_line":"        self._create_eswitches(updated_devices - registered_devices)"},{"line_number":208,"context_line":"        curr_devices \u003d self.eswitch_mgr.get_assigned_devices_info()"},{"line_number":209,"context_line":"        device_info \u003d {}"},{"line_number":210,"context_line":"        device_info[\u0027current\u0027] \u003d curr_devices"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_ab25e509","line":207,"updated":"2016-11-01 12:22:04.000000000","message":"I\u0027m not an expert in this area, can you please tell me why we have do create the eswitch here ?  How this is related to deprecating the physical_device_mapping ?  Maybe add a comment so that\u0027s it clear to the reader.","commit_id":"985452b94e53558d1b3b5eb3d7f44fbf34df7996"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"92d642bf5b736f36a595f5b9b4c8527a8c7dff6f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.eswitch_mgr.discover_devices(device_mappings, exclude_devices)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def scan_devices(self, registered_devices, updated_devices):"},{"line_number":207,"context_line":"        self._create_eswitches(updated_devices - registered_devices)"},{"line_number":208,"context_line":"        curr_devices \u003d self.eswitch_mgr.get_assigned_devices_info()"},{"line_number":209,"context_line":"        device_info \u003d {}"},{"line_number":210,"context_line":"        device_info[\u0027current\u0027] \u003d curr_devices"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_7c38f13d","line":207,"in_reply_to":"ba5da102_ab25e509","updated":"2016-11-01 14:18:59.000000000","message":"Currently the eswitches are created when setup_eswitch_mg (the method above) calls discover devices with the device_mapping parameter which is the parameter we\u0027re deprecating.\nthe \"_create_eswitches\" is called here in order to create the eswitches \"dynamically\" from the RPC messages Nova sends us.","commit_id":"985452b94e53558d1b3b5eb3d7f44fbf34df7996"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a7f13e25d9a9b3efc9e09f0feef241f88ac38b98","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def scan_devices(self, registered_devices, updated_devices):"},{"line_number":207,"context_line":"        # Create eswitch to all new devices"},{"line_number":208,"context_line":"        self._create_eswitches(updated_devices - registered_devices)"},{"line_number":209,"context_line":"        curr_devices \u003d self.eswitch_mgr.get_assigned_devices_info()"},{"line_number":210,"context_line":"        device_info \u003d {}"},{"line_number":211,"context_line":"        device_info[\u0027current\u0027] \u003d curr_devices"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_7d5d4b78","line":208,"updated":"2016-11-01 14:23:13.000000000","message":"Ok, let me ask differently, why do we need to do this if we are deprecating the option ?","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"2839de3e19b69ba78ca36f08710e4232ab25c53d","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def scan_devices(self, registered_devices, updated_devices):"},{"line_number":207,"context_line":"        # Create eswitch to all new devices"},{"line_number":208,"context_line":"        self._create_eswitches(updated_devices - registered_devices)"},{"line_number":209,"context_line":"        curr_devices \u003d self.eswitch_mgr.get_assigned_devices_info()"},{"line_number":210,"context_line":"        device_info \u003d {}"},{"line_number":211,"context_line":"        device_info[\u0027current\u0027] \u003d curr_devices"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_cf4a1e26","line":208,"in_reply_to":"ba5da102_0f8c167e","updated":"2016-11-01 14:34:32.000000000","message":"Ok got it, maybe add a comment explaining this please.","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"0a0754123da084e76d7543ba0a2e8c3b7c7bc84a","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def scan_devices(self, registered_devices, updated_devices):"},{"line_number":207,"context_line":"        # Create eswitch to all new devices"},{"line_number":208,"context_line":"        self._create_eswitches(updated_devices - registered_devices)"},{"line_number":209,"context_line":"        curr_devices \u003d self.eswitch_mgr.get_assigned_devices_info()"},{"line_number":210,"context_line":"        device_info \u003d {}"},{"line_number":211,"context_line":"        device_info[\u0027current\u0027] \u003d curr_devices"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_0f8c167e","line":208,"in_reply_to":"ba5da102_7d5d4b78","updated":"2016-11-01 14:33:08.000000000","message":"We still need to create the eswitch for each device,\nwhen we remove the config option we don\u0027t have a list of available devices, so here we create the eswitch once we get an update message.","commit_id":"c352a13043a44a68a6f7e13089199eff38104721"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7490a8b86f12d21eb7d9528bdd1c7f76c8b5413","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        for mac, pci_slot in devices:"},{"line_number":198,"context_line":"            dev_name \u003d esm.PciOsWrapper.get_pf_interface(pci_slot)"},{"line_number":199,"context_line":"            if not self.eswitch_mgr.device_exists(mac, pci_slot):"},{"line_number":200,"context_line":"                self.eswitch_mgr.create_emb_switch(\u0027\u0027, dev_name, {})"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # Note(edan): setup_eswitch_mgr method will be removed"},{"line_number":203,"context_line":"    # with \u0027physical_device_mappings\u0027 config option"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_1f7d6b6e","line":200,"range":{"start_line":200,"start_character":65,"end_line":200,"end_character":67},"updated":"2016-11-08 12:48:53.000000000","message":"I understand it will work in the end, but wouldn\u0027t it make sense to pass an empty set here instead of a dict, as we do in other places, to keep API usage consistent?","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"b31c7b2efb27300e73801b36d375d811872d331e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        for mac, pci_slot in devices:"},{"line_number":198,"context_line":"            dev_name \u003d esm.PciOsWrapper.get_pf_interface(pci_slot)"},{"line_number":199,"context_line":"            if not self.eswitch_mgr.device_exists(mac, pci_slot):"},{"line_number":200,"context_line":"                self.eswitch_mgr.create_emb_switch(\u0027\u0027, dev_name, {})"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # Note(edan): setup_eswitch_mgr method will be removed"},{"line_number":203,"context_line":"    # with \u0027physical_device_mappings\u0027 config option"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_eb9b9470","line":200,"range":{"start_line":200,"start_character":65,"end_line":200,"end_character":67},"in_reply_to":"9a629dbe_1f7d6b6e","updated":"2016-11-08 15:39:03.000000000","message":"Done","commit_id":"e2e6d84bcb9e03b9a0f61cb6aec0f67ca84b17bd"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"8e03ae57d95d3f6bdbab39a418324fb62e72f3cb","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                         segments_host_db[segment[\u0027id\u0027]][\u0027segment_id\u0027])"},{"line_number":467,"context_line":"        self.assertEqual(host2, segments_host_db[segment[\u0027id\u0027]][\u0027host\u0027])"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        # TODO(edan): fix this test for SR-IOV agent,"},{"line_number":470,"context_line":"        #             check if shared_device_mappings should be removed"},{"line_number":471,"context_line":"        #             or include allowed physnet only"},{"line_number":472,"context_line":"    def test_update_agent_only_change_agent_host_mapping(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_4b81a9c2","line":469,"updated":"2016-11-01 12:22:04.000000000","message":"The indentation is wrong here.","commit_id":"985452b94e53558d1b3b5eb3d7f44fbf34df7996"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"92d642bf5b736f36a595f5b9b4c8527a8c7dff6f","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                         segments_host_db[segment[\u0027id\u0027]][\u0027segment_id\u0027])"},{"line_number":467,"context_line":"        self.assertEqual(host2, segments_host_db[segment[\u0027id\u0027]][\u0027host\u0027])"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        # TODO(edan): fix this test for SR-IOV agent,"},{"line_number":470,"context_line":"        #             check if shared_device_mappings should be removed"},{"line_number":471,"context_line":"        #             or include allowed physnet only"},{"line_number":472,"context_line":"    def test_update_agent_only_change_agent_host_mapping(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_6e5afb2b","line":469,"in_reply_to":"ba5da102_4b81a9c2","updated":"2016-11-01 14:18:59.000000000","message":"Actually this can be removed now, my bad.","commit_id":"985452b94e53558d1b3b5eb3d7f44fbf34df7996"}],"releasenotes/notes/deprecate-SRIOV-physical_deivce_mappings-67dd3317181eb513.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"926158f4d467d49be623ad3116add4e55544fbed","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027physical_device_mappings\u0027 option is deprecated"},{"line_number":4,"context_line":"    and will be removed in Pike."},{"line_number":5,"context_line":"    The device to physnet validation is made in Nova by "},{"line_number":6,"context_line":"    \u0027pci_whitelist\u0027 config option."},{"line_number":7,"context_line":"    Therefor it is redundant to validate it in Neutron"},{"line_number":8,"context_line":"    with physical_device_mappings."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a629dbe_8197598f","line":5,"range":{"start_line":5,"start_character":55,"end_line":5,"end_character":56},"updated":"2016-11-08 15:41:40.000000000","message":"?","commit_id":"adec6ad4bcc6b649895af7b7339898ed87a1674e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"926158f4d467d49be623ad3116add4e55544fbed","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027physical_device_mappings\u0027 option is deprecated"},{"line_number":4,"context_line":"    and will be removed in Pike."},{"line_number":5,"context_line":"    The device to physnet validation is made in Nova by "},{"line_number":6,"context_line":"    \u0027pci_whitelist\u0027 config option."},{"line_number":7,"context_line":"    Therefor it is redundant to validate it in Neutron"},{"line_number":8,"context_line":"    with physical_device_mappings."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a629dbe_e18c9581","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":36},"updated":"2016-11-08 15:41:40.000000000","message":"PCI device validation","commit_id":"adec6ad4bcc6b649895af7b7339898ed87a1674e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"926158f4d467d49be623ad3116add4e55544fbed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    and will be removed in Pike."},{"line_number":5,"context_line":"    The device to physnet validation is made in Nova by "},{"line_number":6,"context_line":"    \u0027pci_whitelist\u0027 config option."},{"line_number":7,"context_line":"    Therefor it is redundant to validate it in Neutron"},{"line_number":8,"context_line":"    with physical_device_mappings."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a629dbe_21edad25","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":12},"updated":"2016-11-08 15:41:40.000000000","message":"Therefore","commit_id":"adec6ad4bcc6b649895af7b7339898ed87a1674e"}]}
