)]}'
{"neutron/tests/unit/test_neutron_manager.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5f1b18e08a05b5e0a84ac6c35bc55de984f984ec","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def test_post_plugin_validation(self):"},{"line_number":109,"context_line":"        if \u0027dhcp_agents_per_network\u0027 not in cfg.CONF:"},{"line_number":110,"context_line":"            cfg.CONF.register_opt(cfg.IntOpt(\u0027dhcp_agents_per_network\u0027,"},{"line_number":111,"context_line":"                                             default\u003d1))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.assertIsNone(validate_post_plugin_load())"},{"line_number":114,"context_line":"        cfg.CONF.set_override(\u0027dhcp_agents_per_network\u0027, 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F95w%3D","line":111,"updated":"2013-07-08 12:38:30.000000000","message":"This change introduces the possibility of double registration for this option.\nThis did not happen in jenkins\u0027 test run, but test parallelization might cause this case to be run before the one that registers dhcp_agents_per_network, triggering a failure.\n\nI think cfg.import_opt can be safely used here.","commit_id":"bf687132c39fd38e3cc997ebaa66db8ffe9544a2"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"31a2974d54cdc43e98ac954ef73d4b13fd1d9fb7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def test_post_plugin_validation(self):"},{"line_number":109,"context_line":"        if \u0027dhcp_agents_per_network\u0027 not in cfg.CONF:"},{"line_number":110,"context_line":"            cfg.CONF.register_opt(cfg.IntOpt(\u0027dhcp_agents_per_network\u0027,"},{"line_number":111,"context_line":"                                             default\u003d1))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.assertIsNone(validate_post_plugin_load())"},{"line_number":114,"context_line":"        cfg.CONF.set_override(\u0027dhcp_agents_per_network\u0027, 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F8wA%3D","line":111,"in_reply_to":"AAAAP3%2F%2F95w%3D","updated":"2013-07-08 17:59:13.000000000","message":"I agree this is too late to be adding this option and the behavior is largely dependent on the whims of oslo.config.  I think the real question is why a manager test needs to work around an optional extension.","commit_id":"bf687132c39fd38e3cc997ebaa66db8ffe9544a2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"01cdf3349b6272881ef46af830153df044ad7839","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def test_post_plugin_validation(self):"},{"line_number":109,"context_line":"        if \u0027dhcp_agents_per_network\u0027 not in cfg.CONF:"},{"line_number":110,"context_line":"            cfg.CONF.register_opt(cfg.IntOpt(\u0027dhcp_agents_per_network\u0027,"},{"line_number":111,"context_line":"                                             default\u003d1))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.assertIsNone(validate_post_plugin_load())"},{"line_number":114,"context_line":"        cfg.CONF.set_override(\u0027dhcp_agents_per_network\u0027, 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F9xc%3D","line":111,"in_reply_to":"AAAAP3%2F%2F95w%3D","updated":"2013-07-08 13:19:42.000000000","message":"The problem with using import_opt() is that it relies that an opt was registered in the module where it was defined which is not true for scheduler opts","commit_id":"bf687132c39fd38e3cc997ebaa66db8ffe9544a2"}]}