)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"23559a69eed5b734067f90a022adff518ea04b5f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Change-Id: I3463921dec415dd073503ab9470588193d08ce87"},{"line_number":13,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":14,"context_line":"Partial-Bug: #1541928"},{"line_number":15,"context_line":"Depends-On: I44e638fb4c19a2bdd513b67baeb7e6a2acc72d2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_4110e901","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"updated":"2016-08-26 20:02:32.000000000","message":"Please remove this. It\u0027s not required, and even considered as incorrect.\nYou should use this [1] to build patch on top of other patch\n\n[1] http://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"826f3fb3cf30a3d27f1128469c3149e138344f8d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0a791a4d016ee54df22666eb074a0cae001e40ac","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Change-Id: I3463921dec415dd073503ab9470588193d08ce87"},{"line_number":13,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":14,"context_line":"Partial-Bug: #1541928"},{"line_number":15,"context_line":"Depends-On: I44e638fb4c19a2bdd513b67baeb7e6a2acc72d2f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_7d7ff7aa","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"in_reply_to":"fa7ab95a_4110e901","updated":"2016-08-29 19:01:22.000000000","message":"Done","commit_id":"826f3fb3cf30a3d27f1128469c3149e138344f8d"}],"neutron/common/constants.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":34,"context_line":"HA_PORT_NAME \u003d \u0027HA port tenant %s\u0027"},{"line_number":35,"context_line":"HA_ROUTER_STATE_ACTIVE \u003d \u0027active\u0027"},{"line_number":36,"context_line":"HA_ROUTER_STATE_STANDBY \u003d \u0027standby\u0027"},{"line_number":37,"context_line":"VALID_HA_STATES \u003d (HA_ROUTER_STATE_ACTIVE, HA_ROUTER_STATE_STANDBY)"},{"line_number":38,"context_line":"PAGINATION_INFINITE \u003d \u0027infinite\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"SORT_DIRECTION_ASC \u003d \u0027asc\u0027"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_6637314f","line":37,"updated":"2017-03-28 22:08:49.000000000","message":"nit: can you add a space before and after this line?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":186,"context_line":"    def _delete_vr_id_allocation(self, context, ha_network, vr_id):"},{"line_number":187,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":188,"context_line":"            vr_id_allocation \u003d l3_obj.L3HARouterVRIdAllocation.get_object("},{"line_number":189,"context_line":"                context, network_id\u003dha_network.network_id, vr_id\u003dvr_id)"},{"line_number":190,"context_line":"            if vr_id_allocation:"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_3e2b31ed","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":57},"updated":"2016-10-21 15:30:40.000000000","message":"nit: AFAIK the explicit creation of a session is not need it","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # we need to check if someone else just inserted at exactly the"},{"line_number":214,"context_line":"        # same time as us because there is no constrain in L3HARouterNetwork"},{"line_number":215,"context_line":"        # that prevents multiple networks per tenant"},{"line_number":216,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":217,"context_line":"            items \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":218,"context_line":"                context, project_id\u003dtenant_id)"},{"line_number":219,"context_line":"            if len(items) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_3e1251b5","line":216,"range":{"start_line":216,"start_character":8,"end_line":216,"end_character":57},"updated":"2016-10-21 15:30:40.000000000","message":"ditto: line 187","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        except Exception:"},{"line_number":254,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":255,"context_line":"                self._core_plugin.delete_network(admin_ctx, network[\u0027id\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        return ha_network"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def get_number_of_agents_for_scheduling(self, context):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_0bc71613","side":"PARENT","line":256,"updated":"2016-11-07 17:55:48.000000000","message":"nit: this change is not required","commit_id":"e4e56faaa33f711bcf0f46f032e26c13220b7685"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        except Exception:"},{"line_number":254,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":255,"context_line":"                self._core_plugin.delete_network(admin_ctx, network[\u0027id\u0027])"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        return ha_network"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def get_number_of_agents_for_scheduling(self, context):"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_b0ce8581","side":"PARENT","line":256,"in_reply_to":"9a629dbe_0bc71613","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"e4e56faaa33f711bcf0f46f032e26c13220b7685"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @staticmethod"},{"line_number":603,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":604,"context_line":"        obj \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":605,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":606,"context_line":"        if obj:"},{"line_number":607,"context_line":"            return obj.pop()"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_ab862ab7","line":604,"range":{"start_line":604,"start_character":8,"end_line":604,"end_character":11},"updated":"2016-11-07 17:55:48.000000000","message":"nit: this variable contains a list of objects, shouldn\u0027t be better to name it as objs?","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @staticmethod"},{"line_number":603,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":604,"context_line":"        obj \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":605,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":606,"context_line":"        if obj:"},{"line_number":607,"context_line":"            return obj.pop()"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_f0c8fd76","line":604,"range":{"start_line":604,"start_character":8,"end_line":604,"end_character":11},"in_reply_to":"9a629dbe_ab862ab7","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b4d0b8a7f66c0ea3bc1105226e30b3583a04b881","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            return result.pop()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"},{"line_number":143,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":144,"context_line":"            vr_id_obj \u003d l3_obj.L3HARouterVRIdAllocation.get_objects("},{"line_number":145,"context_line":"                context, network_id\u003dnetwork_id)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_6d346049","line":143,"range":{"start_line":143,"start_character":1,"end_line":143,"end_character":57},"updated":"2016-11-18 20:49:52.000000000","message":"this is not needed","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dbb71695cbdd27ecde995fd0d56a5b88954144ca","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            return result.pop()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"},{"line_number":143,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":144,"context_line":"            vr_id_obj \u003d l3_obj.L3HARouterVRIdAllocation.get_objects("},{"line_number":145,"context_line":"                context, network_id\u003dnetwork_id)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_b5acc18d","line":143,"range":{"start_line":143,"start_character":1,"end_line":143,"end_character":57},"in_reply_to":"7a77a97e_6d346049","updated":"2016-11-21 17:54:15.000000000","message":"Done","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b4d0b8a7f66c0ea3bc1105226e30b3583a04b881","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    if not available_vr_ids:"},{"line_number":164,"context_line":"                        raise l3_ha.NoVRIDAvailable(router_id\u003drouter_id)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"                    allocation \u003d l3_obj.L3HARouterVRIdAllocation("},{"line_number":167,"context_line":"                        context,"},{"line_number":168,"context_line":"                        network_id\u003dnetwork_id,"},{"line_number":169,"context_line":"                        vr_id\u003davailable_vr_ids.pop())"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"                    allocation.create()"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_48ef921d","line":169,"range":{"start_line":166,"start_character":0,"end_line":169,"end_character":53},"updated":"2016-11-18 20:49:52.000000000","message":"how about?\n                    allocation \u003d l3_obj.L3HARouterVRIdAllocation(\n                        context, network_id\u003dnetwork_id,\n                        vr_id\u003davailable_vr_ids.pop())","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dbb71695cbdd27ecde995fd0d56a5b88954144ca","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    if not available_vr_ids:"},{"line_number":164,"context_line":"                        raise l3_ha.NoVRIDAvailable(router_id\u003drouter_id)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"                    allocation \u003d l3_obj.L3HARouterVRIdAllocation("},{"line_number":167,"context_line":"                        context,"},{"line_number":168,"context_line":"                        network_id\u003dnetwork_id,"},{"line_number":169,"context_line":"                        vr_id\u003davailable_vr_ids.pop())"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"                    allocation.create()"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_d5a93d7d","line":169,"range":{"start_line":166,"start_character":0,"end_line":169,"end_character":53},"in_reply_to":"7a77a97e_48ef921d","updated":"2016-11-21 17:54:15.000000000","message":"Done","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b4d0b8a7f66c0ea3bc1105226e30b3583a04b881","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":605,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":606,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":607,"context_line":"        if objs:"},{"line_number":608,"context_line":"            return objs.pop()"},{"line_number":609,"context_line":"        return None"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    def _get_bindings_and_update_router_state_for_dead_agents(self, context,"},{"line_number":612,"context_line":"                                                              router_id):"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_483dd28d","line":609,"range":{"start_line":607,"start_character":0,"end_line":609,"end_character":19},"updated":"2016-11-18 20:49:52.000000000","message":"return objs.pop() if objs else None","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dbb71695cbdd27ecde995fd0d56a5b88954144ca","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":605,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":606,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":607,"context_line":"        if objs:"},{"line_number":608,"context_line":"            return objs.pop()"},{"line_number":609,"context_line":"        return None"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    def _get_bindings_and_update_router_state_for_dead_agents(self, context,"},{"line_number":612,"context_line":"                                                              router_id):"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_15bad5c0","line":609,"range":{"start_line":607,"start_character":0,"end_line":609,"end_character":19},"in_reply_to":"7a77a97e_483dd28d","updated":"2016-11-21 17:54:15.000000000","message":"Done","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        super(L3_HA_NAT_db_mixin, self).__init__()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def get_ha_network(self, context, tenant_id):"},{"line_number":137,"context_line":"        result \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":138,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":139,"context_line":"        if result:"},{"line_number":140,"context_line":"            return result.pop()"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_e86c8238","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":14},"updated":"2016-11-22 10:16:50.000000000","message":"It should be called results.","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        super(L3_HA_NAT_db_mixin, self).__init__()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def get_ha_network(self, context, tenant_id):"},{"line_number":137,"context_line":"        result \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":138,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":139,"context_line":"        if result:"},{"line_number":140,"context_line":"            return result.pop()"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_b8af55e2","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":14},"in_reply_to":"7a77a97e_e86c8238","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def get_ha_network(self, context, tenant_id):"},{"line_number":137,"context_line":"        result \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":138,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":139,"context_line":"        if result:"},{"line_number":140,"context_line":"            return result.pop()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"},{"line_number":143,"context_line":"        vr_id_obj \u003d l3_obj.L3HARouterVRIdAllocation.get_objects("}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_9e6c280a","line":140,"range":{"start_line":139,"start_character":8,"end_line":140,"end_character":31},"updated":"2016-11-22 10:16:50.000000000","message":"you can do it like this:\n\nreturn results.pop() if result else None","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def get_ha_network(self, context, tenant_id):"},{"line_number":137,"context_line":"        result \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":138,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":139,"context_line":"        if result:"},{"line_number":140,"context_line":"            return result.pop()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"},{"line_number":143,"context_line":"        vr_id_obj \u003d l3_obj.L3HARouterVRIdAllocation.get_objects("}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_b8967592","line":140,"range":{"start_line":139,"start_character":8,"end_line":140,"end_character":31},"in_reply_to":"7a77a97e_9e6c280a","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41d191399c6b782f8f5f7dc7ac2f88c2691f8ce4","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # we need to check if someone else just inserted at exactly the"},{"line_number":211,"context_line":"        # same time as us because there is no constrain in L3HARouterNetwork"},{"line_number":212,"context_line":"        # that prevents multiple networks per tenant"},{"line_number":213,"context_line":"        items \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":214,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":215,"context_line":"        if len(items) \u003e 1:"},{"line_number":216,"context_line":"            # we need to throw an error so our network is deleted"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_9c64374a","line":213,"range":{"start_line":213,"start_character":41,"end_line":213,"end_character":52},"updated":"2016-11-30 15:22:55.000000000","message":"You can use count method here","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # we need to check if someone else just inserted at exactly the"},{"line_number":211,"context_line":"        # same time as us because there is no constrain in L3HARouterNetwork"},{"line_number":212,"context_line":"        # that prevents multiple networks per tenant"},{"line_number":213,"context_line":"        items \u003d l3_obj.L3HARouterNetwork.get_objects("},{"line_number":214,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":215,"context_line":"        if len(items) \u003e 1:"},{"line_number":216,"context_line":"            # we need to throw an error so our network is deleted"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_38e9851b","line":213,"range":{"start_line":213,"start_character":41,"end_line":213,"end_character":52},"in_reply_to":"5a74a57a_9c64374a","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    def get_ha_router_port_bindings(self, context, router_ids, host\u003dNone):"},{"line_number":587,"context_line":"        if not router_ids:"},{"line_number":588,"context_line":"            return []"},{"line_number":589,"context_line":"        # TODO(sindhu) Need to implement this query once Agent OVO is ready"},{"line_number":590,"context_line":"        query \u003d context.session.query(l3ha_model.L3HARouterAgentPortBinding)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if host:"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_1ee578a7","line":589,"range":{"start_line":589,"start_character":57,"end_line":589,"end_character":75},"updated":"2016-11-22 10:16:50.000000000","message":"Agent OVO is ready now.","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    def get_ha_router_port_bindings(self, context, router_ids, host\u003dNone):"},{"line_number":587,"context_line":"        if not router_ids:"},{"line_number":588,"context_line":"            return []"},{"line_number":589,"context_line":"        # TODO(sindhu) Need to implement this query once Agent OVO is ready"},{"line_number":590,"context_line":"        query \u003d context.session.query(l3ha_model.L3HARouterAgentPortBinding)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if host:"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_18e5a936","line":589,"range":{"start_line":589,"start_character":57,"end_line":589,"end_character":75},"in_reply_to":"7a77a97e_1ee578a7","updated":"2016-12-01 16:58:01.000000000","message":"Working on this query, next PS will have it.","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":603,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":604,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":605,"context_line":"        return objs.pop() if objs else None"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def _get_bindings_and_update_router_state_for_dead_agents(self, context,"},{"line_number":608,"context_line":"                                                              router_id):"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_798cc635","line":605,"range":{"start_line":605,"start_character":15,"end_line":605,"end_character":43},"updated":"2016-11-22 10:16:50.000000000","message":"This should return boolean value, you can use objects_exist when ready:\n\nreturn bool(objs)","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":603,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":604,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":605,"context_line":"        return objs.pop() if objs else None"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def _get_bindings_and_update_router_state_for_dead_agents(self, context,"},{"line_number":608,"context_line":"                                                              router_id):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_78ca1da3","line":605,"range":{"start_line":605,"start_character":15,"end_line":605,"end_character":43},"in_reply_to":"5a74a57a_3cfc033e","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":603,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":604,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":605,"context_line":"        return objs.pop() if objs else None"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def _get_bindings_and_update_router_state_for_dead_agents(self, context,"},{"line_number":608,"context_line":"                                                              router_id):"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_38d0a553","line":605,"range":{"start_line":605,"start_character":15,"end_line":605,"end_character":43},"in_reply_to":"7a77a97e_798cc635","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41d191399c6b782f8f5f7dc7ac2f88c2691f8ce4","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def _check_router_agent_ha_binding(context, router_id, agent_id):"},{"line_number":603,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":604,"context_line":"            context, router_id\u003drouter_id, l3_agent_id\u003dagent_id)"},{"line_number":605,"context_line":"        return objs.pop() if objs else None"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def _get_bindings_and_update_router_state_for_dead_agents(self, context,"},{"line_number":608,"context_line":"                                                              router_id):"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_3cfc033e","line":605,"range":{"start_line":605,"start_character":15,"end_line":605,"end_character":43},"in_reply_to":"7a77a97e_798cc635","updated":"2016-11-30 15:22:55.000000000","message":"Now, it\u0027s ready :)","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4ae36c9565d56a9790440480d808261260c059c3","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":188,"context_line":"    def _delete_vr_id_allocation(self, context, ha_network, vr_id):"},{"line_number":189,"context_line":"        vr_id_allocation \u003d l3_obj.L3HARouterVRIdAllocation.get_object("},{"line_number":190,"context_line":"            context, network_id\u003dha_network.network_id, vr_id\u003dvr_id)"},{"line_number":191,"context_line":"        if vr_id_allocation:"},{"line_number":192,"context_line":"            vr_id_allocation.delete()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def _create_ha_subnet(self, context, network_id, tenant_id):"},{"line_number":195,"context_line":"        args \u003d {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a3905b3_3fc5e53b","line":192,"range":{"start_line":189,"start_character":0,"end_line":192,"end_character":37},"updated":"2017-01-19 18:23:30.000000000","message":"You can use delete_objects here.","commit_id":"10e7076d493dd0faec31b56a5fbdf7f794ee906f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"85710e97656c432ccc0ec61006b5192b43a47a0d","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # we need to check if someone else just inserted at exactly the"},{"line_number":211,"context_line":"        # same time as us because there is no constrain in L3HARouterNetwork"},{"line_number":212,"context_line":"        # that prevents multiple networks per tenant"},{"line_number":213,"context_line":"        items \u003d l3_obj.L3HARouterNetwork.count("},{"line_number":214,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":215,"context_line":"        if items \u003e 1:"},{"line_number":216,"context_line":"            # we need to throw an error so our network is deleted"},{"line_number":217,"context_line":"            # and the process is started over where the existing"},{"line_number":218,"context_line":"            # network will be selected."}],"source_content_type":"text/x-python","patch_set":35,"id":"5a3905b3_5ba87cdb","line":215,"range":{"start_line":213,"start_character":0,"end_line":215,"end_character":21},"updated":"2017-01-23 15:33:56.000000000","message":"This can be implemented using:\n\n        if l3_obj.L3HARouterNetwork.objects_exist(\n                context, project_id\u003dtenant_id):","commit_id":"10e7076d493dd0faec31b56a5fbdf7f794ee906f"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"37caeeed2d24bf9d3f28a614c014e85d37585677","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    def _create_ha_port_binding(self, context, router_id, port_id):"},{"line_number":280,"context_line":"        try:"},{"line_number":281,"context_line":"            with context.session.begin():"},{"line_number":282,"context_line":"                routerportbinding \u003d l3_models.RouterPort("},{"line_number":283,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":284,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":285,"context_line":"                context.session.add(routerportbinding)"},{"line_number":286,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":287,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":288,"context_line":"                context.session.add(portbinding)"}],"source_content_type":"text/x-python","patch_set":37,"id":"5a3905b3_c457cd24","line":285,"range":{"start_line":282,"start_character":0,"end_line":285,"end_character":54},"updated":"2017-01-25 04:13:17.000000000","message":"If the integration of RouterPort is not being handled in this patch a TODO needs to be added specifying that it will be taken care of in the RouterPort integration patch","commit_id":"b2ff7ab49c919e662e0936a0d635a58368491eb9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cc91012adbe69d42c0c388ffc9cdb01ad1f20139","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    def _create_ha_port_binding(self, context, router_id, port_id):"},{"line_number":280,"context_line":"        try:"},{"line_number":281,"context_line":"            with context.session.begin():"},{"line_number":282,"context_line":"                routerportbinding \u003d l3_models.RouterPort("},{"line_number":283,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":284,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":285,"context_line":"                context.session.add(routerportbinding)"},{"line_number":286,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":287,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":288,"context_line":"                context.session.add(portbinding)"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa31d9ce_00aac884","line":285,"range":{"start_line":282,"start_character":0,"end_line":285,"end_character":54},"in_reply_to":"5a3905b3_c457cd24","updated":"2017-02-16 01:08:23.000000000","message":"RouterPort object is not being implemented in this patch. Hence it\u0027s integration is not related to this patch.","commit_id":"b2ff7ab49c919e662e0936a0d635a58368491eb9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"37caeeed2d24bf9d3f28a614c014e85d37585677","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":284,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":285,"context_line":"                context.session.add(routerportbinding)"},{"line_number":286,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":287,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":288,"context_line":"                context.session.add(portbinding)"},{"line_number":289,"context_line":"                # portbinding \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":290,"context_line":"                #     context, port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":291,"context_line":"                # portbinding.create()"}],"source_content_type":"text/x-python","patch_set":37,"id":"5a3905b3_a473a1e6","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":48},"updated":"2017-01-25 04:13:17.000000000","message":"Need to be replaced by the lines of code that are commented (289-291)","commit_id":"b2ff7ab49c919e662e0936a0d635a58368491eb9"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"cc91012adbe69d42c0c388ffc9cdb01ad1f20139","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":284,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":285,"context_line":"                context.session.add(routerportbinding)"},{"line_number":286,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":287,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":288,"context_line":"                context.session.add(portbinding)"},{"line_number":289,"context_line":"                # portbinding \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":290,"context_line":"                #     context, port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":291,"context_line":"                # portbinding.create()"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa31d9ce_40984078","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":48},"in_reply_to":"5a3905b3_a473a1e6","updated":"2017-02-16 01:08:23.000000000","message":"Replacement of these lines with the commented lines is causing issues. Will uncomment once the issue is resolved.","commit_id":"b2ff7ab49c919e662e0936a0d635a58368491eb9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"338efb8de78a063e1a61c0f224e077d1b8a6b4fb","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":284,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":285,"context_line":"                context.session.add(routerportbinding)"},{"line_number":286,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":287,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":288,"context_line":"                context.session.add(portbinding)"},{"line_number":289,"context_line":"                # portbinding \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":290,"context_line":"                #     context, port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":291,"context_line":"                # portbinding.create()"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa31d9ce_e31ca9c3","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":48},"in_reply_to":"fa31d9ce_40984078","updated":"2017-02-17 02:39:47.000000000","message":"@Sindhu, does it mean, this patch is still WIP? If yes, maybe you could add -W to this?","commit_id":"b2ff7ab49c919e662e0936a0d635a58368491eb9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1eb4b7170aea47f6a0204071dc3101afe7b7a6ee","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":177,"context_line":"    def _delete_vr_id_allocation(self, context, ha_network, vr_id):"},{"line_number":178,"context_line":"        l3_obj.L3HARouterVRIdAllocation.delete_objects("},{"line_number":179,"context_line":"            context, network_id\u003dha_network.network_id, vr_id\u003dvr_id)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _create_ha_subnet(self, context, network_id, tenant_id):"},{"line_number":182,"context_line":"        args \u003d {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_5ed7e6c0","line":179,"range":{"start_line":178,"start_character":7,"end_line":179,"end_character":67},"updated":"2017-03-24 16:57:25.000000000","message":"nit: as network_id and vr_id make a primary key, even though this will work, i believe code can make use normal delete here.","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":177,"context_line":"    def _delete_vr_id_allocation(self, context, ha_network, vr_id):"},{"line_number":178,"context_line":"        l3_obj.L3HARouterVRIdAllocation.delete_objects("},{"line_number":179,"context_line":"            context, network_id\u003dha_network.network_id, vr_id\u003dvr_id)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def _create_ha_subnet(self, context, network_id, tenant_id):"},{"line_number":182,"context_line":"        args \u003d {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_d944a249","line":179,"range":{"start_line":178,"start_character":7,"end_line":179,"end_character":67},"in_reply_to":"ffe62b97_5ed7e6c0","updated":"2017-03-28 22:08:49.000000000","message":"I don\u0027t know, in terms of performance both approaches are doing two calls to the db, the main difference could be that the approach to get the object to later destroy it can do some  unnecessary parsing.","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1eb4b7170aea47f6a0204071dc3101afe7b7a6ee","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            # we need to throw an error so our network is deleted"},{"line_number":203,"context_line":"            # and the process is started over where the existing"},{"line_number":204,"context_line":"            # network will be selected."},{"line_number":205,"context_line":"            raise db_exc.DBDuplicateEntry(columns\u003d[\u0027tenant_id\u0027])"},{"line_number":206,"context_line":"        return ha_network"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _add_ha_network_settings(self, network):"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_79ae442f","line":205,"range":{"start_line":205,"start_character":18,"end_line":205,"end_character":64},"updated":"2017-03-24 16:57:25.000000000","message":"might want to replace this with object exception ?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            # we need to throw an error so our network is deleted"},{"line_number":203,"context_line":"            # and the process is started over where the existing"},{"line_number":204,"context_line":"            # network will be selected."},{"line_number":205,"context_line":"            raise db_exc.DBDuplicateEntry(columns\u003d[\u0027tenant_id\u0027])"},{"line_number":206,"context_line":"        return ha_network"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def _add_ha_network_settings(self, network):"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_d7710946","line":205,"range":{"start_line":205,"start_character":18,"end_line":205,"end_character":64},"in_reply_to":"ffe62b97_79ae442f","updated":"2017-03-28 22:08:49.000000000","message":"This change is related with this other -\u003e https://review.openstack.org/#/c/361443/40/neutron/tests/unit/db/test_l3_hamode_db.py@691","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1eb4b7170aea47f6a0204071dc3101afe7b7a6ee","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":265,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":266,"context_line":"                context.session.add(routerportbinding)"},{"line_number":267,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":268,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":269,"context_line":"                context.session.add(portbinding)"},{"line_number":270,"context_line":"                # portbinding \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":271,"context_line":"                #     context, port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":272,"context_line":"                # portbinding.create()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_59594058","line":269,"range":{"start_line":267,"start_character":16,"end_line":269,"end_character":48},"updated":"2017-03-24 16:57:25.000000000","message":"this needs to converted as well ?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id,"},{"line_number":265,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":266,"context_line":"                context.session.add(routerportbinding)"},{"line_number":267,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":268,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":269,"context_line":"                context.session.add(portbinding)"},{"line_number":270,"context_line":"                # portbinding \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":271,"context_line":"                #     context, port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":272,"context_line":"                # portbinding.create()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_3975ce64","line":269,"range":{"start_line":267,"start_character":16,"end_line":269,"end_character":48},"in_reply_to":"ffe62b97_59594058","updated":"2017-03-28 22:08:49.000000000","message":"Agree, but we previously found that this replacement was causing some gate failures. In other words, any help is welcome.","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"a2194cf634140e5713e162110906cff4bdb16ea1","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":268,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":269,"context_line":"                context.session.add(portbinding)"},{"line_number":270,"context_line":"                # portbinding \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":271,"context_line":"                #     context, port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":272,"context_line":"                # portbinding.create()"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"            return portbinding"},{"line_number":275,"context_line":"        except db_exc.DBReferenceError as e:"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_f90a5488","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":38},"updated":"2017-03-24 16:59:03.000000000","message":"Is this still causing failure?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1eb4b7170aea47f6a0204071dc3101afe7b7a6ee","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                                transaction\u003dFalse)"},{"line_number":310,"context_line":"        return bindings"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _create_ha_interfaces(self, context, router, ha_network):"},{"line_number":313,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_14601da5","line":312,"range":{"start_line":312,"start_character":4,"end_line":312,"end_character":65},"updated":"2017-03-24 16:57:25.000000000","message":"where is this getting used ?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                                transaction\u003dFalse)"},{"line_number":310,"context_line":"        return bindings"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _create_ha_interfaces(self, context, router, ha_network):"},{"line_number":313,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        num_agents \u003d self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_d9a5c248","line":312,"range":{"start_line":312,"start_character":4,"end_line":312,"end_character":65},"in_reply_to":"ffe62b97_14601da5","updated":"2017-03-28 22:08:49.000000000","message":"+1","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"a2194cf634140e5713e162110906cff4bdb16ea1","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            return []"},{"line_number":561,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_l3ha_filter_host_router("},{"line_number":562,"context_line":"            context, router_ids, host)"},{"line_number":563,"context_line":"        # query \u003d context.session.query(l3ha_model.L3HARouterAgentPortBinding)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        # if host:"},{"line_number":566,"context_line":"        #     query \u003d query.join(agent_model.Agent).filter("},{"line_number":567,"context_line":"        #         agent_model.Agent.host \u003d\u003d host)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # query \u003d query.filter("},{"line_number":570,"context_line":"        #     l3ha_model.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return objs"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_54b8e528","line":570,"range":{"start_line":563,"start_character":0,"end_line":570,"end_character":78},"updated":"2017-03-24 16:59:03.000000000","message":"ditto","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1eb4b7170aea47f6a0204071dc3101afe7b7a6ee","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            return []"},{"line_number":561,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_l3ha_filter_host_router("},{"line_number":562,"context_line":"            context, router_ids, host)"},{"line_number":563,"context_line":"        # query \u003d context.session.query(l3ha_model.L3HARouterAgentPortBinding)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        # if host:"},{"line_number":566,"context_line":"        #     query \u003d query.join(agent_model.Agent).filter("},{"line_number":567,"context_line":"        #         agent_model.Agent.host \u003d\u003d host)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # query \u003d query.filter("},{"line_number":570,"context_line":"        #     l3ha_model.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return objs"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_343201f3","line":570,"range":{"start_line":563,"start_character":7,"end_line":570,"end_character":78},"updated":"2017-03-24 16:57:25.000000000","message":"these should be removed","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            return []"},{"line_number":561,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_l3ha_filter_host_router("},{"line_number":562,"context_line":"            context, router_ids, host)"},{"line_number":563,"context_line":"        # query \u003d context.session.query(l3ha_model.L3HARouterAgentPortBinding)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        # if host:"},{"line_number":566,"context_line":"        #     query \u003d query.join(agent_model.Agent).filter("},{"line_number":567,"context_line":"        #         agent_model.Agent.host \u003d\u003d host)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        # query \u003d query.filter("},{"line_number":570,"context_line":"        #     l3ha_model.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        return objs"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_1c3af8ca","line":570,"range":{"start_line":563,"start_character":0,"end_line":570,"end_character":78},"in_reply_to":"ffe62b97_54b8e528","updated":"2017-03-28 22:08:49.000000000","message":"+1","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def get_ha_network(self, context, tenant_id):"},{"line_number":114,"context_line":"        results \u003d l3_hamode.L3HARouterNetwork.get_objects("},{"line_number":115,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":116,"context_line":"        return results.pop() if results else None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_50125eb3","line":115,"updated":"2017-08-22 20:41:01.000000000","message":"no need to fetch all objects; use Pager with limit\u003d1 to get a single result","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def get_ha_network(self, context, tenant_id):"},{"line_number":114,"context_line":"        results \u003d l3_hamode.L3HARouterNetwork.get_objects("},{"line_number":115,"context_line":"            context, project_id\u003dtenant_id)"},{"line_number":116,"context_line":"        return results.pop() if results else None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_f53b6e99","line":115,"in_reply_to":"7f287b81_50125eb3","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return results.pop() if results else None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"},{"line_number":119,"context_line":"        vr_id_obj \u003d l3_hamode.L3HARouterVRIdAllocation.get_objects("},{"line_number":120,"context_line":"            context, network_id\u003dnetwork_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        allocated_vr_ids \u003d set(a.vr_id for a in vr_id_obj) - set([0])"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_9050c634","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":17},"updated":"2017-08-22 20:41:01.000000000","message":"-\u003e vr_id_objs","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return results.pop() if results else None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_allocated_vr_id(self, context, network_id):"},{"line_number":119,"context_line":"        vr_id_obj \u003d l3_hamode.L3HARouterVRIdAllocation.get_objects("},{"line_number":120,"context_line":"            context, network_id\u003dnetwork_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        allocated_vr_ids \u003d set(a.vr_id for a in vr_id_obj) - set([0])"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_d540720a","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":17},"in_reply_to":"7f287b81_9050c634","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def get_number_of_agents_for_scheduling(self, context):"},{"line_number":242,"context_line":"        \"\"\"Return number of agents on which the router will be scheduled.\"\"\""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        num_agents \u003d len(self.get_l3_agents("},{"line_number":245,"context_line":"            context, active\u003dTrue,"},{"line_number":246,"context_line":"            filters\u003d{\u0027agent_modes\u0027: [constants.L3_AGENT_MODE_LEGACY,"},{"line_number":247,"context_line":"                                     constants.L3_AGENT_MODE_DVR_SNAT]}))"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_b0198289","line":244,"updated":"2017-08-22 20:41:01.000000000","message":"this change is not needed","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def get_number_of_agents_for_scheduling(self, context):"},{"line_number":242,"context_line":"        \"\"\"Return number of agents on which the router will be scheduled.\"\"\""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        num_agents \u003d len(self.get_l3_agents("},{"line_number":245,"context_line":"            context, active\u003dTrue,"},{"line_number":246,"context_line":"            filters\u003d{\u0027agent_modes\u0027: [constants.L3_AGENT_MODE_LEGACY,"},{"line_number":247,"context_line":"                                     constants.L3_AGENT_MODE_DVR_SNAT]}))"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_75477e1f","line":244,"in_reply_to":"7f287b81_b0198289","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    def get_ha_router_port_bindings(self, context, router_ids, host\u003dNone):"},{"line_number":539,"context_line":"        if not router_ids:"},{"line_number":540,"context_line":"            return []"},{"line_number":541,"context_line":"        objs \u003d ("},{"line_number":542,"context_line":"            l3_hamode.L3HARouterAgentPortBinding.get_l3ha_filter_host_router("},{"line_number":543,"context_line":"                context, router_ids, host)"},{"line_number":544,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_cbb45f38","line":541,"updated":"2017-08-22 20:41:01.000000000","message":"nit: could return result right away without an interim variable","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    def get_ha_router_port_bindings(self, context, router_ids, host\u003dNone):"},{"line_number":539,"context_line":"        if not router_ids:"},{"line_number":540,"context_line":"            return []"},{"line_number":541,"context_line":"        objs \u003d ("},{"line_number":542,"context_line":"            l3_hamode.L3HARouterAgentPortBinding.get_l3ha_filter_host_router("},{"line_number":543,"context_line":"                context, router_ids, host)"},{"line_number":544,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_3551f6d9","line":541,"in_reply_to":"7f287b81_cbb45f38","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65416f0b8411290cfd30b66dff34ac5311fb0c65","unresolved":false,"context_lines":[{"line_number":539,"context_line":"    def get_ha_router_port_bindings(self, context, router_ids, host\u003dNone):"},{"line_number":540,"context_line":"        if not router_ids:"},{"line_number":541,"context_line":"            return []"},{"line_number":542,"context_line":"        return l3_hamode.L3HARouterAgentPortBinding\\"},{"line_number":543,"context_line":"            .get_l3ha_filter_host_router("},{"line_number":544,"context_line":"                context, router_ids, host)"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"7f287b81_f4cb4250","line":542,"updated":"2017-08-24 14:57:35.000000000","message":"that\u0027s a bit ugly, I will respin","commit_id":"f1ee307055d86f917008feb227ae4fc3b39c7c0f"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"1b7e91e3b79b7c34b1e1180bd2c0994f53f6d881","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                    port_id\u003dport_id,"},{"line_number":267,"context_line":"                    router_id\u003drouter_id,"},{"line_number":268,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF).create()"},{"line_number":269,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":270,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":271,"context_line":"                context.session.add(portbinding)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"            return portbinding"},{"line_number":274,"context_line":"        except db_exc.DBReferenceError as e:"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_d242563e","line":271,"range":{"start_line":269,"start_character":0,"end_line":271,"end_character":48},"updated":"2017-08-28 07:33:03.000000000","message":"Can we convert this to .create()?","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e47770930f5401d9638f25dfda4a15561a286f94","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                    port_id\u003dport_id,"},{"line_number":267,"context_line":"                    router_id\u003drouter_id,"},{"line_number":268,"context_line":"                    port_type\u003dconstants.DEVICE_OWNER_ROUTER_HA_INTF).create()"},{"line_number":269,"context_line":"                portbinding \u003d l3ha_model.L3HARouterAgentPortBinding("},{"line_number":270,"context_line":"                    port_id\u003dport_id, router_id\u003drouter_id)"},{"line_number":271,"context_line":"                context.session.add(portbinding)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"            return portbinding"},{"line_number":274,"context_line":"        except db_exc.DBReferenceError as e:"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_7bc37d39","line":271,"range":{"start_line":269,"start_character":0,"end_line":271,"end_character":48},"in_reply_to":"7f287b81_d242563e","updated":"2017-08-29 06:45:54.000000000","message":"Yes, we\u0027ve already tried that.\nBut as Victor Morales mentioned, it\u0027ll cause lots of gate failures.","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"}],"neutron/objects/common_types.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4e1d2a5ecdedfda62c613160455cea3291c24b3b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d("},{"line_number":33,"context_line":"                                constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":34,"context_line":"                                constants.HA_ROUTER_STATE_STANDBY)"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPV6ModeEnumField(obj_fields.AutoTypedField):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_d3fb2546","line":35,"range":{"start_line":32,"start_character":30,"end_line":35,"end_character":33},"updated":"2016-09-19 18:30:36.000000000","message":"also default is missing","commit_id":"692fef99b39d793d05bc61b68120a7605536a178"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4e1d2a5ecdedfda62c613160455cea3291c24b3b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \"start \u003d %(start)s, end \u003d %(end)s\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d("},{"line_number":33,"context_line":"                                constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":34,"context_line":"                                constants.HA_ROUTER_STATE_STANDBY)"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPV6ModeEnumField(obj_fields.AutoTypedField):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_f3c0212d","line":35,"range":{"start_line":31,"start_character":0,"end_line":35,"end_character":33},"updated":"2016-09-19 18:30:36.000000000","message":"can\u0027t you use obj_fields.Enum directly in object why a wraper on top that is needed ?","commit_id":"692fef99b39d793d05bc61b68120a7605536a178"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f59e5bd662ec2ddcb4ca42412485386b3a966061","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d("},{"line_number":33,"context_line":"                                constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":34,"context_line":"                                constants.HA_ROUTER_STATE_STANDBY)"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPV6ModeEnumField(obj_fields.AutoTypedField):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_5820d7f7","line":35,"range":{"start_line":32,"start_character":30,"end_line":35,"end_character":33},"in_reply_to":"7a8ec9b2_d3fb2546","updated":"2016-09-20 16:03:20.000000000","message":"Done","commit_id":"692fef99b39d793d05bc61b68120a7605536a178"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f59e5bd662ec2ddcb4ca42412485386b3a966061","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \"start \u003d %(start)s, end \u003d %(end)s\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d("},{"line_number":33,"context_line":"                                constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":34,"context_line":"                                constants.HA_ROUTER_STATE_STANDBY)"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPV6ModeEnumField(obj_fields.AutoTypedField):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_d89ea706","line":35,"range":{"start_line":31,"start_character":0,"end_line":35,"end_character":33},"in_reply_to":"7a8ec9b2_f3c0212d","updated":"2016-09-20 16:03:20.000000000","message":"In order to send nullable, default parameters, we need AutoTypedField which in turn inherits from Field [1]\n\n[1]https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L139","commit_id":"692fef99b39d793d05bc61b68120a7605536a178"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"0fcd9050a14af6ee1106a41866475dee9f1d87f9","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d("},{"line_number":33,"context_line":"                                constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":34,"context_line":"                                constants.HA_ROUTER_STATE_STANDBY)"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8ec9b2_f0709a74","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":65},"updated":"2016-09-21 14:31:56.000000000","message":"This should fit on L32, then the second value can be indented in line with the second set of parenthesis. Alternatively, just indent these further.","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"282c899bfeda27255541e163ecbed5124571cc6b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d("},{"line_number":33,"context_line":"                                constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":34,"context_line":"                                constants.HA_ROUTER_STATE_STANDBY)"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_c54a3783","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":65},"in_reply_to":"7a8ec9b2_f0709a74","updated":"2016-09-23 13:32:49.000000000","message":"Done","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"532b169dc0985dcef264d761644f46a0f5eaa810","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d(constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":33,"context_line":"                                              constants.HA_ROUTER_STATE_STANDBY"},{"line_number":34,"context_line":"                                              )"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPV6ModeEnumField(obj_fields.AutoTypedField):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_c4b4bd83","line":35,"range":{"start_line":34,"start_character":45,"end_line":35,"end_character":33},"updated":"2016-09-26 08:59:22.000000000","message":"I don\u0027t see a need to have this extra lines here. You can end the Enum field in line 33 with \u0027))\u0027.","commit_id":"e84554cf0a40834eade47f44078a37d44f3665ed"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9fdae92aa6efc396b8214bb1742ba1cc914100e9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d(constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":33,"context_line":"                                              constants.HA_ROUTER_STATE_STANDBY"},{"line_number":34,"context_line":"                                              )"},{"line_number":35,"context_line":"                                )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class IPV6ModeEnumField(obj_fields.AutoTypedField):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_ff3daedd","line":35,"range":{"start_line":34,"start_character":45,"end_line":35,"end_character":33},"in_reply_to":"5a8bc5a2_c4b4bd83","updated":"2016-09-26 14:49:03.000000000","message":"Done","commit_id":"e84554cf0a40834eade47f44078a37d44f3665ed"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d(constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":33,"context_line":"                                              constants.HA_ROUTER_STATE_STANDBY"},{"line_number":34,"context_line":"                                              ))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_89b89c2c","line":33,"range":{"start_line":32,"start_character":46,"end_line":33,"end_character":79},"updated":"2016-09-27 21:01:05.000000000","message":"You can reuse, newly introduced `VALID_HA_STATES`","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HARouterEnumField(obj_fields.AutoTypedField):"},{"line_number":32,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d(constants.HA_ROUTER_STATE_ACTIVE,"},{"line_number":33,"context_line":"                                              constants.HA_ROUTER_STATE_STANDBY"},{"line_number":34,"context_line":"                                              ))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_1fccaa34","line":33,"range":{"start_line":32,"start_character":46,"end_line":33,"end_character":79},"in_reply_to":"5a8bc5a2_89b89c2c","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"}],"neutron/objects/l3_hamode.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"23559a69eed5b734067f90a022adff518ea04b5f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":53,"context_line":"    foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    fields_need_translation \u003d {"},{"line_number":56,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_41270964","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":5},"updated":"2016-08-26 20:02:32.000000000","message":"This one is no longer required. We have tenant/project translation on sqlalchemy level.","commit_id":"826f3fb3cf30a3d27f1128469c3149e138344f8d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0a791a4d016ee54df22666eb074a0cae001e40ac","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":53,"context_line":"    foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    fields_need_translation \u003d {"},{"line_number":56,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_1d47cb77","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":5},"in_reply_to":"fa7ab95a_41270964","updated":"2016-08-29 19:01:22.000000000","message":"Done","commit_id":"826f3fb3cf30a3d27f1128469c3149e138344f8d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3f00975ecc63eb864cc08ac2ccc359b7bae06ea3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":55,"context_line":"    foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_e35a93f1","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":39},"updated":"2016-09-12 23:59:59.000000000","message":"this need a update","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3f0648f52b2eebec6592393790c8952764a9970c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":55,"context_line":"    foreign_keys \u003d {\u0027network_id\u0027: \u0027id\u0027}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_2bb1ad8f","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":39},"in_reply_to":"9a89bdaa_e35a93f1","updated":"2016-09-14 04:48:32.000000000","message":"Done","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9a3b94671663190e668ee45bd11e610f81220ba7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":33,"context_line":"        \u0027router_id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027l3_agent_id\u0027: obj_fields.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField(default\u003dconstants.HA_ROUTER_STATE_STANDBY, nullable\u003dTrue)"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8ec9b2_df7d711d","line":35,"updated":"2016-09-21 14:01:39.000000000","message":"Line is too long.","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"282c899bfeda27255541e163ecbed5124571cc6b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":33,"context_line":"        \u0027router_id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027l3_agent_id\u0027: obj_fields.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField(default\u003dconstants.HA_ROUTER_STATE_STANDBY, nullable\u003dTrue)"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_655a4352","line":35,"in_reply_to":"7a8ec9b2_df7d711d","updated":"2016-09-23 13:32:49.000000000","message":"Done","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9a3b94671663190e668ee45bd11e610f81220ba7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    db_model \u003d l3_hamode.L3HARouterVRIdAllocation"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    fields \u003d {"},{"line_number":67,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":68,"context_line":"        \u0027vr_id\u0027: obj_fields.IntegerField(nullable\u003dFalse)"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8ec9b2_3f01f506","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":57},"updated":"2016-09-21 14:01:39.000000000","message":"you can skip this, nullable is False by default in OVO.\nThe same next line.","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"282c899bfeda27255541e163ecbed5124571cc6b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    db_model \u003d l3_hamode.L3HARouterVRIdAllocation"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    fields \u003d {"},{"line_number":67,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(nullable\u003dFalse),"},{"line_number":68,"context_line":"        \u0027vr_id\u0027: obj_fields.IntegerField(nullable\u003dFalse)"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_85590f5d","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":57},"in_reply_to":"7a8ec9b2_3f01f506","updated":"2016-09-23 13:32:49.000000000","message":"Done","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"3b7cb0d2db03d68d9715111a166d19997cd5b062","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class L3HARouterAgentPortBinding(base.NeutronDbObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_ce858acf","line":25,"updated":"2016-09-26 20:57:26.000000000","message":"synthetic_field \u0027agent\u0027 ?","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class L3HARouterAgentPortBinding(base.NeutronDbObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_dfe2429f","line":25,"in_reply_to":"5a8bc5a2_49d054f8","updated":"2016-09-28 20:56:57.000000000","message":"Hey Darek, \"Port\" relation is not being used so have not added as `synthetic_field`.","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b42213390aecd187e12439d018fea25f1fe251e3","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class L3HARouterAgentPortBinding(base.NeutronDbObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_ca1c446d","line":25,"in_reply_to":"5a8bc5a2_49d054f8","updated":"2016-09-28 06:24:46.000000000","message":"I would like to see how this object is going to be used. If this relationship is going to be used, then we should have agent and port relationship here.","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class L3HARouterAgentPortBinding(base.NeutronDbObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_1fc10ae5","line":25,"in_reply_to":"5a8bc5a2_ca1c446d","updated":"2016-09-28 20:56:57.000000000","message":"Hey Artur, only \"Agent\" relationship is being used [1] so have added only that as `synthetic_fields` \n\n[1]https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L654","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class L3HARouterAgentPortBinding(base.NeutronDbObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_3fd166ce","line":25,"in_reply_to":"5a8bc5a2_ce858acf","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class L3HARouterAgentPortBinding(base.NeutronDbObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_49d054f8","line":25,"in_reply_to":"5a8bc5a2_ce858acf","updated":"2016-09-27 21:01:05.000000000","message":"We also have \"port\" in db model. Shouldn\u0027t it also be included as `synthetic_field`?","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"3b7cb0d2db03d68d9715111a166d19997cd5b062","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":46,"context_line":"class L3HARouterNetwork(base.NeutronDbObject):"},{"line_number":47,"context_line":"    # Version 1.0: Initial version"},{"line_number":48,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_2e498ed0","line":46,"updated":"2016-09-26 20:57:26.000000000","message":"do you need synthetic_field \u0027network\u0027 as per the network \u003d orm.relationship(models_v2.Network) in the db model.","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":46,"context_line":"class L3HARouterNetwork(base.NeutronDbObject):"},{"line_number":47,"context_line":"    # Version 1.0: Initial version"},{"line_number":48,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_fabb8c73","line":46,"in_reply_to":"5a8bc5a2_2e498ed0","updated":"2016-09-28 20:56:57.000000000","message":"Hey Mohit, \"Network\" relation is not used. So haven\u0027t added.","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b42213390aecd187e12439d018fea25f1fe251e3","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":46,"context_line":"class L3HARouterNetwork(base.NeutronDbObject):"},{"line_number":47,"context_line":"    # Version 1.0: Initial version"},{"line_number":48,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_4a1f545b","line":46,"in_reply_to":"5a8bc5a2_2e498ed0","updated":"2016-09-28 06:24:46.000000000","message":"ditto line 25.","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":46,"context_line":"class L3HARouterNetwork(base.NeutronDbObject):"},{"line_number":47,"context_line":"    # Version 1.0: Initial version"},{"line_number":48,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_1ac118e5","line":46,"in_reply_to":"5a8bc5a2_4a1f545b","updated":"2016-09-28 20:56:57.000000000","message":"ditto","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9f81236ff584f7c4db0d7834264d1ae1a9413433","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_29b0798b","line":38,"range":{"start_line":38,"start_character":17,"end_line":38,"end_character":48},"updated":"2016-10-10 21:48:14.000000000","message":"The relationship between ha_router_agent_port_bindings and agents is one to many. So shouldn\u0027t this be obj_fields.ListOfObjectsField(\u0027Agent\u0027)","commit_id":"8fdaec42686a1cdedfeb082044d425b5d015c399"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"192724fa71c612302b583f30441172c1ee57139a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa6399be_25e5dc36","line":38,"range":{"start_line":38,"start_character":17,"end_line":38,"end_character":48},"in_reply_to":"fa6399be_29b0798b","updated":"2016-10-11 13:54:37.000000000","message":"Actually it\u0027s not need it at all. Foreign keys in OVO are used to populate synthetic fields, they don\u0027t represent the foreign keys of the DB schema.","commit_id":"8fdaec42686a1cdedfeb082044d425b5d015c399"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":42,"context_line":"    foreign_keys \u003d {\u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027}, \u0027Router\u0027: {\u0027router_id\u0027: \u0027id\u0027},"},{"line_number":43,"context_line":"                    \u0027Agent\u0027: {\u0027l3_agent_id\u0027: \u0027id\u0027}}"},{"line_number":44,"context_line":"    synthetic_fields \u003d [\u0027agent\u0027]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_fe81b990","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":45},"updated":"2016-10-21 15:30:40.000000000","message":"The current definition of Port OVO class doesn\u0027t contain a synthetic field that use this class, in other words, this foreign_key is not need it for now.  The other ones, they OVO classes are in progress.","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":60,"context_line":"    foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_fe06191f","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":52},"updated":"2016-10-21 15:30:40.000000000","message":"Same thing, the current definition of Network OVO doesn\u0027t include a synthetic field for this class. So it\u0027s not required now.","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027vr_id\u0027]"},{"line_number":76,"context_line":"    foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_49ff4d01","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":52},"updated":"2016-10-21 15:30:40.000000000","message":"ditto: line 60","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_4b44ae73","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":48},"updated":"2016-11-07 17:55:48.000000000","message":"Can you confirm that this synthetic field is required?","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3d23c2e4d994520e641998843bf8c48172b98239","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a77a97e_1599f51f","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":48},"in_reply_to":"7a77a97e_f3865c64","updated":"2016-11-21 17:57:10.000000000","message":"Synthetic field is not required here. Have removed it.","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_909ee154","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":48},"in_reply_to":"9a629dbe_4b44ae73","updated":"2016-11-08 04:26:45.000000000","message":"We need `Agent` as a synthetic field to handle the join query in [1].\n\n\n[1]https://review.openstack.org/#/c/361443/26/neutron/db/l3_hamode_db.py@595","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d79b0dcc74859a7195e8cb6f6b27f2dfc92e53fe","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a77a97e_f3865c64","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":48},"in_reply_to":"9a629dbe_909ee154","updated":"2016-11-15 04:49:56.000000000","message":"This looks like inner join for that method, and maybe that method will end in a class method for this class.","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":42,"context_line":"    # foreign_keys \u003d {\u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027}, \u0027Router\u0027: {\u0027router_id\u0027: \u0027id\u0027},"},{"line_number":43,"context_line":"    #                \u0027Agent\u0027: {\u0027l3_agent_id\u0027: \u0027id\u0027}}"},{"line_number":44,"context_line":"    synthetic_fields \u003d [\u0027agent\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_8b25e6c3","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":52},"updated":"2016-11-07 17:55:48.000000000","message":"This lines can be removed","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":42,"context_line":"    # foreign_keys \u003d {\u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027}, \u0027Router\u0027: {\u0027router_id\u0027: \u0027id\u0027},"},{"line_number":43,"context_line":"    #                \u0027Agent\u0027: {\u0027l3_agent_id\u0027: \u0027id\u0027}}"},{"line_number":44,"context_line":"    synthetic_fields \u003d [\u0027agent\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_10c65167","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":52},"in_reply_to":"9a629dbe_8b25e6c3","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":60,"context_line":"    # foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_0b18f683","line":60,"updated":"2016-11-07 17:55:48.000000000","message":"ditto: line 42","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"},{"line_number":60,"context_line":"    # foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_30a195aa","line":60,"in_reply_to":"9a629dbe_0b18f683","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027vr_id\u0027]"},{"line_number":76,"context_line":"    # foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_8b0c0644","line":76,"updated":"2016-11-07 17:55:48.000000000","message":"ditto: line 42","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027vr_id\u0027]"},{"line_number":76,"context_line":"    # foreign_keys \u003d {\u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_50a609c2","line":76,"in_reply_to":"9a629dbe_8b0c0644","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"ca06b3dac71a8b259a898b94612b412491cf2f42","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_c25d8a7a","line":38,"updated":"2016-11-09 23:37:53.000000000","message":"Not sure if this Synthetic field is needed","commit_id":"41f3c9de1e4c098c7488358236c4d332a812da26"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"fdc054b6a0c3042823acc326a23cbbf68ae92277","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027agent\u0027: obj_fields.ObjectField(\u0027Agent\u0027)"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_34a70d0c","line":38,"in_reply_to":"9a629dbe_c25d8a7a","updated":"2016-11-11 16:54:52.000000000","message":"Yes, its not needed.","commit_id":"41f3c9de1e4c098c7488358236c4d332a812da26"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"ca06b3dac71a8b259a898b94612b412491cf2f42","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":42,"context_line":"    foreign_keys \u003d {\u0027Agent\u0027: {\u0027l3_agent_id\u0027: \u0027id\u0027}}"},{"line_number":43,"context_line":"    synthetic_fields \u003d [\u0027agent\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_a2cfb627","line":42,"updated":"2016-11-09 23:37:53.000000000","message":"If the Synthetic Field is needed then the foreign key should be in the Agent OVO.","commit_id":"41f3c9de1e4c098c7488358236c4d332a812da26"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    fields \u003d {"},{"line_number":51,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":52,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_854e9794","line":52,"range":{"start_line":52,"start_character":33,"end_line":52,"end_character":42},"updated":"2016-11-22 10:16:50.000000000","message":"It should be string.","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    fields \u003d {"},{"line_number":51,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":52,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    primary_keys \u003d [\u0027network_id\u0027, \u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_f8c46d41","line":52,"range":{"start_line":52,"start_character":33,"end_line":52,"end_character":42},"in_reply_to":"7a77a97e_854e9794","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"85710e97656c432ccc0ec61006b5192b43a47a0d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    fields \u003d {"},{"line_number":32,"context_line":"        \u0027port_id\u0027: common_types.UUIDField(),"},{"line_number":33,"context_line":"        \u0027router_id\u0027: obj_fields.StringField(),"},{"line_number":34,"context_line":"        \u0027l3_agent_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a3905b3_fb13e8b5","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":46},"updated":"2017-01-23 15:33:56.000000000","message":"Shouldn\u0027t this a common_types.UUIDField()?","commit_id":"10e7076d493dd0faec31b56a5fbdf7f794ee906f"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4ae36c9565d56a9790440480d808261260c059c3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027l3_agent_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027state\u0027: common_types.HARouterEnumField("},{"line_number":36,"context_line":"            default\u003dconstants.HA_ROUTER_STATE_STANDBY,"},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a3905b3_bf0c7595","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":25},"updated":"2017-01-19 18:23:30.000000000","message":"Why do we need nullable\u003dTrue here?","commit_id":"10e7076d493dd0faec31b56a5fbdf7f794ee906f"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"a2194cf634140e5713e162110906cff4bdb16ea1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            query \u003d query.join(agent_model.Agent).filter("},{"line_number":48,"context_line":"                agent_model.Agent.host \u003d\u003d host)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        query \u003d query.filter("},{"line_number":51,"context_line":"            l3ha.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":52,"context_line":"        return query.all()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_54bfc5fa","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":26},"updated":"2017-03-24 16:59:03.000000000","message":"IIUC, we need to return the object here instead of the L3HARouterAgentPortBinding Model","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1eb4b7170aea47f6a0204071dc3101afe7b7a6ee","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        query \u003d query.filter("},{"line_number":51,"context_line":"            l3ha.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":52,"context_line":"        return query.all()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_b482914e","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":26},"updated":"2017-03-24 16:57:25.000000000","message":"need to load ovo from query objects and return?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            query \u003d query.join(agent_model.Agent).filter("},{"line_number":48,"context_line":"                agent_model.Agent.host \u003d\u003d host)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        query \u003d query.filter("},{"line_number":51,"context_line":"            l3ha.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":52,"context_line":"        return query.all()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_d72fc985","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":26},"in_reply_to":"ffe62b97_54bfc5fa","updated":"2017-03-28 22:08:49.000000000","message":"The result of this is returned to get_ha_router_port_bindings method which is consumed by several methods of L3_HA_NAT_db_mixin.  For _get_bindings_and_update_router_state_for_dead_agents method in particular, it uses \u0027agent\u0027 field to filter some information[1]. As consequence you\u0027ll need to know how to deal with that requirement.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L580-L582","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        query \u003d query.filter("},{"line_number":52,"context_line":"            l3ha.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":53,"context_line":"        return query.all()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_6b568b09","line":53,"updated":"2017-08-22 20:41:01.000000000","message":"this method should return objects, not sqlalchemy models, to stay consistent with general objects API","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        query \u003d query.filter("},{"line_number":52,"context_line":"            l3ha.L3HARouterAgentPortBinding.router_id.in_(router_ids))"},{"line_number":53,"context_line":"        return query.all()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_356a1680","line":53,"in_reply_to":"7f287b81_6b568b09","updated":"2017-08-23 08:25:16.000000000","message":"As Victor Morales mentioned, the result of this is returned to get_ha_router_port_bindings method which is consumed by several methods of L3_HA_NAT_db_mixin. \nFor _get_bindings_and_update_router_state_for_dead_agents method in particular, it uses \u0027agent\u0027 field to filter some information[1]. As consequence we\u0027ll need to know how to deal with that requirement.\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L580-L582","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _add_port_from_net(self, plugin, ctxt, router_id, tenant_id, ha_net):"},{"line_number":284,"context_line":"        \"\"\"small wrapper function to unpack network id from ha_network\"\"\""},{"line_number":285,"context_line":"        return plugin.add_ha_port(ctxt, router_id, ha_net.network_id,"},{"line_number":286,"context_line":"                                  tenant_id)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_ha_port_and_bind(self, plugin, context, router_id,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_19067220","line":285,"range":{"start_line":285,"start_character":58,"end_line":285,"end_character":68},"updated":"2016-11-22 10:16:50.000000000","message":"I\u0027m wondering about this change.\nOriginally it means that L3HARouterNetwork is using the relationship with Network in this place. Since we are using only the network id here, it can be changed to network_id property. \n\nIs L3HARouterNetwork using the network relationship somewhere else?","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _add_port_from_net(self, plugin, ctxt, router_id, tenant_id, ha_net):"},{"line_number":284,"context_line":"        \"\"\"small wrapper function to unpack network id from ha_network\"\"\""},{"line_number":285,"context_line":"        return plugin.add_ha_port(ctxt, router_id, ha_net.network_id,"},{"line_number":286,"context_line":"                                  tenant_id)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def create_ha_port_and_bind(self, plugin, context, router_id,"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_90b0b78d","line":285,"range":{"start_line":285,"start_character":58,"end_line":285,"end_character":68},"in_reply_to":"7a77a97e_19067220","updated":"2016-12-01 16:58:01.000000000","message":"I couldn\u0027t find any other usage.","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        return plugin.add_ha_port(ctxt, router_db.id, ha_net.network_id,"},{"line_number":272,"context_line":"                                  tenant_id)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def _add_port_from_net(self, plugin, ctxt, router_id, tenant_id, ha_net):"},{"line_number":275,"context_line":"        \"\"\"small wrapper function to unpack network id from ha_network\"\"\""},{"line_number":276,"context_line":"        return plugin.add_ha_port(ctxt, router_id, ha_net.network_id,"},{"line_number":277,"context_line":"                                  tenant_id)"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_ebe5db39","line":274,"updated":"2017-08-22 20:41:01.000000000","message":"what\u0027s this method? I don\u0027t think it\u0027s used anywhere","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        return plugin.add_ha_port(ctxt, router_db.id, ha_net.network_id,"},{"line_number":272,"context_line":"                                  tenant_id)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def _add_port_from_net(self, plugin, ctxt, router_id, tenant_id, ha_net):"},{"line_number":275,"context_line":"        \"\"\"small wrapper function to unpack network id from ha_network\"\"\""},{"line_number":276,"context_line":"        return plugin.add_ha_port(ctxt, router_id, ha_net.network_id,"},{"line_number":277,"context_line":"                                  tenant_id)"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_f5092edd","line":274,"in_reply_to":"7f287b81_ebe5db39","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"1b7e91e3b79b7c34b1e1180bd2c0994f53f6d881","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    def test_get_l3_bindings_hosting_router_with_ha_states_not_scheduled(self):"},{"line_number":172,"context_line":"        router \u003d self._create_router(ha\u003dFalse)"},{"line_number":173,"context_line":"        # Check that there no L3 agents scheduled for this router"},{"line_number":174,"context_line":"        res \u003d self.admin_ctx.session.query("},{"line_number":175,"context_line":"            l3ha_model.L3HARouterAgentPortBinding).filter("},{"line_number":176,"context_line":"            l3ha_model.L3HARouterAgentPortBinding.router_id \u003d\u003d router[\u0027id\u0027]"},{"line_number":177,"context_line":"        ).all()"},{"line_number":178,"context_line":"        self.assertEqual([], [r.agent for r in res])"},{"line_number":179,"context_line":"        bindings \u003d self.plugin.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":180,"context_line":"            self.admin_ctx, router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_d2b01646","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":15},"updated":"2017-08-28 07:33:03.000000000","message":"Can we use get_objects() here?","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e47770930f5401d9638f25dfda4a15561a286f94","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    def test_get_l3_bindings_hosting_router_with_ha_states_not_scheduled(self):"},{"line_number":172,"context_line":"        router \u003d self._create_router(ha\u003dFalse)"},{"line_number":173,"context_line":"        # Check that there no L3 agents scheduled for this router"},{"line_number":174,"context_line":"        res \u003d self.admin_ctx.session.query("},{"line_number":175,"context_line":"            l3ha_model.L3HARouterAgentPortBinding).filter("},{"line_number":176,"context_line":"            l3ha_model.L3HARouterAgentPortBinding.router_id \u003d\u003d router[\u0027id\u0027]"},{"line_number":177,"context_line":"        ).all()"},{"line_number":178,"context_line":"        self.assertEqual([], [r.agent for r in res])"},{"line_number":179,"context_line":"        bindings \u003d self.plugin.get_l3_bindings_hosting_router_with_ha_states("},{"line_number":180,"context_line":"            self.admin_ctx, router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_a693085b","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":15},"in_reply_to":"7f287b81_d2b01646","updated":"2017-08-29 06:45:54.000000000","message":"Done","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"1b7e91e3b79b7c34b1e1180bd2c0994f53f6d881","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        network \u003d self.plugin.get_ha_network(self.admin_ctx,"},{"line_number":578,"context_line":"                                             router[\u0027tenant_id\u0027])"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        with mock.patch.object(l3ha_model, \u0027L3HARouterAgentPortBinding\u0027,"},{"line_number":581,"context_line":"                               side_effect\u003dValueError):"},{"line_number":582,"context_line":"            self.assertRaises(ValueError, self.plugin.add_ha_port,"},{"line_number":583,"context_line":"                              self.admin_ctx, router[\u0027id\u0027], network.network_id,"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_72b3a24e","line":580,"range":{"start_line":580,"start_character":31,"end_line":580,"end_character":41},"updated":"2017-08-28 07:33:03.000000000","message":"\"l3_hamode\"?","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e47770930f5401d9638f25dfda4a15561a286f94","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        network \u003d self.plugin.get_ha_network(self.admin_ctx,"},{"line_number":578,"context_line":"                                             router[\u0027tenant_id\u0027])"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        with mock.patch.object(l3ha_model, \u0027L3HARouterAgentPortBinding\u0027,"},{"line_number":581,"context_line":"                               side_effect\u003dValueError):"},{"line_number":582,"context_line":"            self.assertRaises(ValueError, self.plugin.add_ha_port,"},{"line_number":583,"context_line":"                              self.admin_ctx, router[\u0027id\u0027], network.network_id,"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_33ee20ed","line":580,"range":{"start_line":580,"start_character":31,"end_line":580,"end_character":41},"in_reply_to":"7f287b81_72b3a24e","updated":"2017-08-29 06:45:54.000000000","message":"In order to do this, we\u0027ll need to convert l3_hamode_db.py (line 271) to .create() which will cause lots of gate failures.","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"1b7e91e3b79b7c34b1e1180bd2c0994f53f6d881","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        router1 \u003d self._create_router()"},{"line_number":951,"context_line":"        states \u003d {router1[\u0027id\u0027]: \u0027active\u0027}"},{"line_number":952,"context_line":"        with mock.patch.object(self.plugin, \u0027get_ha_router_port_bindings\u0027):"},{"line_number":953,"context_line":"            (self.admin_ctx.session.query("},{"line_number":954,"context_line":"                 l3ha_model.L3HARouterAgentPortBinding)."},{"line_number":955,"context_line":"             filter_by(router_id\u003drouter1[\u0027id\u0027]).delete())"},{"line_number":956,"context_line":"            self.plugin.update_routers_states("},{"line_number":957,"context_line":"                self.admin_ctx, states, self.agent1[\u0027host\u0027])"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_328bda6e","line":955,"range":{"start_line":953,"start_character":0,"end_line":955,"end_character":57},"updated":"2017-08-28 07:33:03.000000000","message":"can we convert to delete_object()?","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e47770930f5401d9638f25dfda4a15561a286f94","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        router1 \u003d self._create_router()"},{"line_number":951,"context_line":"        states \u003d {router1[\u0027id\u0027]: \u0027active\u0027}"},{"line_number":952,"context_line":"        with mock.patch.object(self.plugin, \u0027get_ha_router_port_bindings\u0027):"},{"line_number":953,"context_line":"            (self.admin_ctx.session.query("},{"line_number":954,"context_line":"                 l3ha_model.L3HARouterAgentPortBinding)."},{"line_number":955,"context_line":"             filter_by(router_id\u003drouter1[\u0027id\u0027]).delete())"},{"line_number":956,"context_line":"            self.plugin.update_routers_states("},{"line_number":957,"context_line":"                self.admin_ctx, states, self.agent1[\u0027host\u0027])"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_86d80c1e","line":955,"range":{"start_line":953,"start_character":0,"end_line":955,"end_character":57},"in_reply_to":"7f287b81_328bda6e","updated":"2017-08-29 06:45:54.000000000","message":"Done","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4e1d2a5ecdedfda62c613160455cea3291c24b3b","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"            \u0027heartbeat_timestamp\u0027: datetime.date.today(),"},{"line_number":1110,"context_line":"            \u0027configurations\u0027: \u0027test_configurations\u0027,"},{"line_number":1111,"context_line":"        }"},{"line_number":1112,"context_line":"        self._agent \u003d obj_db_api.create_object(self.context,"},{"line_number":1113,"context_line":"                                               agents_db.Agent,"},{"line_number":1114,"context_line":"                                               attrs)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    def _create_test_router(self):"},{"line_number":1117,"context_line":"        attrs \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_f302e10a","line":1114,"range":{"start_line":1112,"start_character":8,"end_line":1114,"end_character":53},"updated":"2016-09-19 18:30:36.000000000","message":"add a note of replacement with actual object once its completed","commit_id":"692fef99b39d793d05bc61b68120a7605536a178"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f59e5bd662ec2ddcb4ca42412485386b3a966061","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"            \u0027heartbeat_timestamp\u0027: datetime.date.today(),"},{"line_number":1110,"context_line":"            \u0027configurations\u0027: \u0027test_configurations\u0027,"},{"line_number":1111,"context_line":"        }"},{"line_number":1112,"context_line":"        self._agent \u003d obj_db_api.create_object(self.context,"},{"line_number":1113,"context_line":"                                               agents_db.Agent,"},{"line_number":1114,"context_line":"                                               attrs)"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    def _create_test_router(self):"},{"line_number":1117,"context_line":"        attrs \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_b8be3b62","line":1114,"range":{"start_line":1112,"start_character":8,"end_line":1114,"end_character":53},"in_reply_to":"7a8ec9b2_f302e10a","updated":"2016-09-20 16:03:20.000000000","message":"Done","commit_id":"692fef99b39d793d05bc61b68120a7605536a178"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"dfb98db10afb2dc1bb440be048b72eb64f48bd51","unresolved":false,"context_lines":[{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def _create_test_router(self):"},{"line_number":1118,"context_line":"        attrs \u003d {"},{"line_number":1119,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":1120,"context_line":"            \u0027name\u0027: \u0027test_router\u0027,"},{"line_number":1121,"context_line":"        }"},{"line_number":1122,"context_line":"        self._router \u003d obj_db_api.create_object(self.context,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_5a8814c7","line":1119,"updated":"2016-09-27 22:14:11.000000000","message":"\u0027id\u0027 field is not required. It\u0027s taken care of by create_object()","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"503f6661fa53f5e008db6d4ba4d529decdb98634","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    obj_fields.ListOfStringsField: tools.get_random_string_list,"},{"line_number":413,"context_line":"    common_types.DomainNameField: get_random_domain_name,"},{"line_number":414,"context_line":"    common_types.DscpMarkField: get_random_dscp_mark,"},{"line_number":415,"context_line":"    common_types.FlowDirectionEnumField: get_random_direction,"},{"line_number":416,"context_line":"    common_types.HARouterEnumField: get_random_ha_states,"},{"line_number":417,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":418,"context_line":"    common_types.IPNetworkField: tools.get_random_ip_network,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_647c97ec","line":415,"range":{"start_line":415,"start_character":4,"end_line":415,"end_character":39},"updated":"2016-10-03 11:17:16.000000000","message":"this type is covered in line 426.","commit_id":"60436e099794ee32e9f742e91145ffc489c0302f"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"161e64d14d81ee4e1d14bbf555e0006fb839dd3a","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    obj_fields.ListOfStringsField: tools.get_random_string_list,"},{"line_number":413,"context_line":"    common_types.DomainNameField: get_random_domain_name,"},{"line_number":414,"context_line":"    common_types.DscpMarkField: get_random_dscp_mark,"},{"line_number":415,"context_line":"    common_types.FlowDirectionEnumField: get_random_direction,"},{"line_number":416,"context_line":"    common_types.HARouterEnumField: get_random_ha_states,"},{"line_number":417,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":418,"context_line":"    common_types.IPNetworkField: tools.get_random_ip_network,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_e25405cb","line":415,"range":{"start_line":415,"start_character":4,"end_line":415,"end_character":39},"in_reply_to":"3a98d1f4_647c97ec","updated":"2016-10-03 17:04:34.000000000","message":"Removed.","commit_id":"60436e099794ee32e9f742e91145ffc489c0302f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41d191399c6b782f8f5f7dc7ac2f88c2691f8ce4","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import collections"},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import datetime"},{"line_number":16,"context_line":"import itertools"},{"line_number":17,"context_line":"import os.path"},{"line_number":18,"context_line":"import random"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_902fbbf5","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"updated":"2016-11-30 15:22:55.000000000","message":"You won\u0027t need this if you use the snippet provided later","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import collections"},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import datetime"},{"line_number":16,"context_line":"import itertools"},{"line_number":17,"context_line":"import os.path"},{"line_number":18,"context_line":"import random"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_e1467fbe","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"in_reply_to":"5a74a57a_902fbbf5","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            \u0027heartbeat_timestamp\u0027: datetime.date.today(),"},{"line_number":1227,"context_line":"            \u0027configurations\u0027: \u0027test_configurations\u0027,"},{"line_number":1228,"context_line":"        }"},{"line_number":1229,"context_line":"        # TODO(sindhu): Replace with agent object once it\u0027s ready"},{"line_number":1230,"context_line":"        self._agent \u003d obj_db_api.create_object(self.context,"},{"line_number":1231,"context_line":"                                               agents_db.Agent,"},{"line_number":1232,"context_line":"                                               attrs)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"    def _create_test_port(self, network):"},{"line_number":1235,"context_line":"        self._port \u003d self._create_port(network_id\u003dnetwork[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_94a40709","line":1232,"range":{"start_line":1229,"start_character":7,"end_line":1232,"end_character":53},"updated":"2016-11-22 10:16:50.000000000","message":"Agent OVO is ready, use it here.","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            \u0027heartbeat_timestamp\u0027: datetime.date.today(),"},{"line_number":1227,"context_line":"            \u0027configurations\u0027: \u0027test_configurations\u0027,"},{"line_number":1228,"context_line":"        }"},{"line_number":1229,"context_line":"        # TODO(sindhu): Replace with agent object once it\u0027s ready"},{"line_number":1230,"context_line":"        self._agent \u003d obj_db_api.create_object(self.context,"},{"line_number":1231,"context_line":"                                               agents_db.Agent,"},{"line_number":1232,"context_line":"                                               attrs)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"    def _create_test_port(self, network):"},{"line_number":1235,"context_line":"        self._port \u003d self._create_port(network_id\u003dnetwork[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_813f8b24","line":1232,"range":{"start_line":1229,"start_character":7,"end_line":1232,"end_character":53},"in_reply_to":"5a74a57a_b0af577c","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            \u0027heartbeat_timestamp\u0027: datetime.date.today(),"},{"line_number":1227,"context_line":"            \u0027configurations\u0027: \u0027test_configurations\u0027,"},{"line_number":1228,"context_line":"        }"},{"line_number":1229,"context_line":"        # TODO(sindhu): Replace with agent object once it\u0027s ready"},{"line_number":1230,"context_line":"        self._agent \u003d obj_db_api.create_object(self.context,"},{"line_number":1231,"context_line":"                                               agents_db.Agent,"},{"line_number":1232,"context_line":"                                               attrs)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"    def _create_test_port(self, network):"},{"line_number":1235,"context_line":"        self._port \u003d self._create_port(network_id\u003dnetwork[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_c14983d2","line":1232,"range":{"start_line":1229,"start_character":7,"end_line":1232,"end_character":53},"in_reply_to":"7a77a97e_94a40709","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41d191399c6b782f8f5f7dc7ac2f88c2691f8ce4","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"            \u0027heartbeat_timestamp\u0027: datetime.date.today(),"},{"line_number":1227,"context_line":"            \u0027configurations\u0027: \u0027test_configurations\u0027,"},{"line_number":1228,"context_line":"        }"},{"line_number":1229,"context_line":"        # TODO(sindhu): Replace with agent object once it\u0027s ready"},{"line_number":1230,"context_line":"        self._agent \u003d obj_db_api.create_object(self.context,"},{"line_number":1231,"context_line":"                                               agents_db.Agent,"},{"line_number":1232,"context_line":"                                               attrs)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"    def _create_test_port(self, network):"},{"line_number":1235,"context_line":"        self._port \u003d self._create_port(network_id\u003dnetwork[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_b0af577c","line":1232,"range":{"start_line":1229,"start_character":7,"end_line":1232,"end_character":53},"in_reply_to":"7a77a97e_94a40709","updated":"2016-11-30 15:22:55.000000000","message":"In addition to Artur\u0027s comment, you can use the following snippet\n\n    def _create_test_agent(self):\n        attrs \u003d self.get_random_fields(obj_cls\u003dagent.Agent)\n        self._agent \u003d agent.Agent(self.context, **attrs)\n        self._agent.create()","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4ae36c9565d56a9790440480d808261260c059c3","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    return random.choice(constants.VALID_DSCP_MARKS)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"def get_random_ha_states():"},{"line_number":383,"context_line":"    return random.choice(constants.VALID_HA_STATES)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"def get_list_of_random_networks(num\u003d10):"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a3905b3_3ffde53a","line":383,"range":{"start_line":382,"start_character":0,"end_line":383,"end_character":51},"updated":"2017-01-19 18:23:30.000000000","message":"Can you please put this in the test.tools instead of here?","commit_id":"10e7076d493dd0faec31b56a5fbdf7f794ee906f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"668f26b2dc5093628c60c3aa678c1b7dd82d3d63","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.db.models import l3 as l3_model"},{"line_number":34,"context_line":"from neutron.db import standard_attr"},{"line_number":35,"context_line":"from neutron import objects"},{"line_number":36,"context_line":"from neutron.objects import agent as agent_obj"},{"line_number":37,"context_line":"from neutron.objects import base"},{"line_number":38,"context_line":"from neutron.objects import common_types"},{"line_number":39,"context_line":"from neutron.objects.db import api as obj_db_api"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_17f89178","line":36,"updated":"2017-03-28 22:08:49.000000000","message":"Any reason behind this renaming change?","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.db.models import l3 as l3_model"},{"line_number":35,"context_line":"from neutron.db import standard_attr"},{"line_number":36,"context_line":"from neutron import objects"},{"line_number":37,"context_line":"from neutron.objects import agent as agent_obj"},{"line_number":38,"context_line":"from neutron.objects import base"},{"line_number":39,"context_line":"from neutron.objects import common_types"},{"line_number":40,"context_line":"from neutron.objects.db import api as obj_db_api"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_ebbefbfd","line":37,"updated":"2017-08-22 20:41:01.000000000","message":"unneeded change","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.db.models import l3 as l3_model"},{"line_number":35,"context_line":"from neutron.db import standard_attr"},{"line_number":36,"context_line":"from neutron import objects"},{"line_number":37,"context_line":"from neutron.objects import agent as agent_obj"},{"line_number":38,"context_line":"from neutron.objects import base"},{"line_number":39,"context_line":"from neutron.objects import common_types"},{"line_number":40,"context_line":"from neutron.objects.db import api as obj_db_api"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_d50e32e4","line":37,"in_reply_to":"7f287b81_ebbefbfd","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"        return _securitygroup.id"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"    def _create_test_agent_id(self):"},{"line_number":1508,"context_line":"        attrs \u003d self.get_random_object_fields(obj_cls\u003dagent_obj.Agent)"},{"line_number":1509,"context_line":"        _agent \u003d agent_obj.Agent(self.context, **attrs)"},{"line_number":1510,"context_line":"        _agent.create()"},{"line_number":1511,"context_line":"        return _agent[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_4b450f17","line":1508,"updated":"2017-08-22 20:41:01.000000000","message":"unneeded change","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"        return _securitygroup.id"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"    def _create_test_agent_id(self):"},{"line_number":1508,"context_line":"        attrs \u003d self.get_random_object_fields(obj_cls\u003dagent_obj.Agent)"},{"line_number":1509,"context_line":"        _agent \u003d agent_obj.Agent(self.context, **attrs)"},{"line_number":1510,"context_line":"        _agent.create()"},{"line_number":1511,"context_line":"        return _agent[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_b513a60d","line":1508,"in_reply_to":"7f287b81_4b450f17","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"}],"neutron/tests/unit/objects/test_l3_hamode.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3f00975ecc63eb864cc08ac2ccc359b7bae06ea3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        super(L3HARouterNetworkDbObjectTestCase, self).setUp()"},{"line_number":58,"context_line":"        network \u003d self._create_network()"},{"line_number":59,"context_line":"        print(\u0027networkid:\u0027, network.id)"},{"line_number":60,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields, self.objs):"},{"line_number":61,"context_line":"            obj[\u0027network_id\u0027] \u003d network.id"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_63fe83af","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":77},"updated":"2016-09-12 23:59:59.000000000","message":"i doubt this may lead to some unit tests failure","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3f0648f52b2eebec6592393790c8952764a9970c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        super(L3HARouterNetworkDbObjectTestCase, self).setUp()"},{"line_number":58,"context_line":"        network \u003d self._create_network()"},{"line_number":59,"context_line":"        print(\u0027networkid:\u0027, network.id)"},{"line_number":60,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields, self.objs):"},{"line_number":61,"context_line":"            obj[\u0027network_id\u0027] \u003d network.id"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_01529613","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":77},"in_reply_to":"9a89bdaa_63fe83af","updated":"2016-09-14 04:48:32.000000000","message":"If self.objs is not overwritten, then [1] fails right? \n\n[1]https://github.com/openstack/neutron/blob/master/neutron/tests/unit/objects/test_base.py#L1205","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3f00975ecc63eb864cc08ac2ccc359b7bae06ea3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def setUp(self):"},{"line_number":77,"context_line":"        super(L3HARouterVRIdAllocationDbObjectTestCase, self).setUp()"},{"line_number":78,"context_line":"        network \u003d self._create_network()"},{"line_number":79,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields, self.objs):"},{"line_number":80,"context_line":"            obj[\u0027network_id\u0027] \u003d network.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_a3324ba5","line":79,"range":{"start_line":79,"start_character":9,"end_line":79,"end_character":77},"updated":"2016-09-12 23:59:59.000000000","message":"same here","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3f0648f52b2eebec6592393790c8952764a9970c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def setUp(self):"},{"line_number":77,"context_line":"        super(L3HARouterVRIdAllocationDbObjectTestCase, self).setUp()"},{"line_number":78,"context_line":"        network \u003d self._create_network()"},{"line_number":79,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields, self.objs):"},{"line_number":80,"context_line":"            obj[\u0027network_id\u0027] \u003d network.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_415c9e25","line":79,"range":{"start_line":79,"start_character":9,"end_line":79,"end_character":77},"in_reply_to":"9a89bdaa_a3324ba5","updated":"2016-09-14 04:48:32.000000000","message":"ditto","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class L3HARouterAgentPortBindingIfaceObjectTestCase("},{"line_number":23,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    _test_class \u003d l3_hamode.L3HARouterAgentPortBinding"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_a9ff18a9","line":23,"updated":"2016-09-27 21:01:05.000000000","message":"This should be more indented","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class L3HARouterAgentPortBindingIfaceObjectTestCase("},{"line_number":23,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    _test_class \u003d l3_hamode.L3HARouterAgentPortBinding"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_5f49d28a","line":23,"in_reply_to":"5a8bc5a2_a9ff18a9","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class L3HARouterAgentPortBindingDbObjectTestCase("},{"line_number":29,"context_line":"    obj_test_base.BaseDbObjectTestCase,"},{"line_number":30,"context_line":"    testlib_api.SqlTestCase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _test_class \u003d l3_hamode.L3HARouterAgentPortBinding"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_e92f603c","line":29,"updated":"2016-09-27 21:01:05.000000000","message":"ditto","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class L3HARouterAgentPortBindingDbObjectTestCase("},{"line_number":29,"context_line":"    obj_test_base.BaseDbObjectTestCase,"},{"line_number":30,"context_line":"    testlib_api.SqlTestCase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _test_class \u003d l3_hamode.L3HARouterAgentPortBinding"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_9f5b5a54","line":29,"in_reply_to":"5a8bc5a2_e92f603c","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"dfb98db10afb2dc1bb440be048b72eb64f48bd51","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(L3HARouterAgentPortBindingDbObjectTestCase,"},{"line_number":36,"context_line":"              self).setUp()"},{"line_number":37,"context_line":"        self._create_test_network()"},{"line_number":38,"context_line":"        for db_obj, obj_field, obj in zip("},{"line_number":39,"context_line":"            self.db_objs, self.obj_fields, self.objs):"},{"line_number":40,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":41,"context_line":"            self._create_test_router()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_da48a48d","line":38,"updated":"2016-09-27 22:14:11.000000000","message":"use itertools.chain(*iterables) instead of zip() ??","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(L3HARouterAgentPortBindingDbObjectTestCase,"},{"line_number":36,"context_line":"              self).setUp()"},{"line_number":37,"context_line":"        self._create_test_network()"},{"line_number":38,"context_line":"        for db_obj, obj_field, obj in zip("},{"line_number":39,"context_line":"            self.db_objs, self.obj_fields, self.objs):"},{"line_number":40,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":41,"context_line":"            self._create_test_router()"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_1accb834","line":38,"in_reply_to":"5a8bc5a2_da48a48d","updated":"2016-09-28 20:56:57.000000000","message":"itertools doesn\u0027t work here.","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class L3HARouterNetworkIfaceObjectTestCase("},{"line_number":55,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    _test_class \u003d l3_hamode.L3HARouterNetwork"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_292a282d","line":55,"updated":"2016-09-27 21:01:05.000000000","message":"ditto","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class L3HARouterNetworkIfaceObjectTestCase("},{"line_number":55,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    _test_class \u003d l3_hamode.L3HARouterNetwork"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_ff30de09","line":55,"in_reply_to":"5a8bc5a2_292a282d","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class L3HARouterNetworkDbObjectTestCase("},{"line_number":61,"context_line":"    obj_test_base.BaseDbObjectTestCase,"},{"line_number":62,"context_line":"    testlib_api.SqlTestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    _test_class \u003d l3_hamode.L3HARouterNetwork"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_c9d1c431","line":61,"updated":"2016-09-27 21:01:05.000000000","message":"ditto","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class L3HARouterNetworkDbObjectTestCase("},{"line_number":61,"context_line":"    obj_test_base.BaseDbObjectTestCase,"},{"line_number":62,"context_line":"    testlib_api.SqlTestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    _test_class \u003d l3_hamode.L3HARouterNetwork"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_1f366a03","line":61,"in_reply_to":"5a8bc5a2_c9d1c431","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class L3HARouterVRIdAllocationIfaceObjectTestCase("},{"line_number":74,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    _test_class \u003d l3_hamode.L3HARouterVRIdAllocation"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_09dc8c45","line":74,"updated":"2016-09-27 21:01:05.000000000","message":"ditto","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class L3HARouterVRIdAllocationIfaceObjectTestCase("},{"line_number":74,"context_line":"    obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    _test_class \u003d l3_hamode.L3HARouterVRIdAllocation"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_3f3b26ed","line":74,"in_reply_to":"5a8bc5a2_09dc8c45","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"01d74a65f267617fac5e1451cbf3883e39b2cb09","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class L3HARouterVRIdAllocationDbObjectTestCase("},{"line_number":80,"context_line":"    obj_test_base.BaseDbObjectTestCase,"},{"line_number":81,"context_line":"    testlib_api.SqlTestCase):"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    _test_class \u003d l3_hamode.L3HARouterVRIdAllocation"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_89f09ccb","line":80,"updated":"2016-09-27 21:01:05.000000000","message":"ditto","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9418ef2efe9ba20566d8d56d9c3b3cf6caf54d4a","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class L3HARouterVRIdAllocationDbObjectTestCase("},{"line_number":80,"context_line":"    obj_test_base.BaseDbObjectTestCase,"},{"line_number":81,"context_line":"    testlib_api.SqlTestCase):"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    _test_class \u003d l3_hamode.L3HARouterVRIdAllocation"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a98d1f4_5f40f256","line":80,"in_reply_to":"5a8bc5a2_89f09ccb","updated":"2016-09-28 20:56:57.000000000","message":"Done","commit_id":"d6e5f0f00539e319bed96a28e1491e40062ef073"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class L3HARouterAgentPortBindingIfaceObjectTestCase("},{"line_number":23,"context_line":"        base.BaseObjectIfaceTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    _test_class \u003d l3_hamode.L3HARouterAgentPortBinding"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_096d5598","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":8},"updated":"2016-10-21 15:30:40.000000000","message":"nit: wrong identation","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2cd6a2e2ae72ca454c85182f8f460676a27a9c64","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class L3HARouterVRIdAllocationIfaceObjectTestCase("},{"line_number":80,"context_line":"        base.BaseObjectIfaceTestCase):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    _test_class \u003d l3_hamode.L3HARouterVRIdAllocation"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_e9c74143","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":8},"updated":"2016-10-21 15:30:40.000000000","message":"nit: wrong identation","commit_id":"3909257e75fe6c53e3ba759eceb6ca0e8014811a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"41d191399c6b782f8f5f7dc7ac2f88c2691f8ce4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"              self).setUp()"},{"line_number":36,"context_line":"        self._create_test_network()"},{"line_number":37,"context_line":"        for db_obj, obj_field, obj in zip("},{"line_number":38,"context_line":"            self.db_objs, self.obj_fields, self.objs):"},{"line_number":39,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":40,"context_line":"            self._create_test_router()"},{"line_number":41,"context_line":"            self._create_test_agent()"},{"line_number":42,"context_line":"            db_obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":43,"context_line":"            obj_field[\u0027port_id\u0027] \u003d port.id"},{"line_number":44,"context_line":"            obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":45,"context_line":"            db_obj[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]"},{"line_number":46,"context_line":"            obj_field[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]"},{"line_number":47,"context_line":"            obj[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]"},{"line_number":48,"context_line":"            db_obj[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]"},{"line_number":49,"context_line":"            obj_field[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]"},{"line_number":50,"context_line":"            obj[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":53,"context_line":"        # TODO(sindhu): L3HARouterAgentPortBinding is using Agent"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_30aa671a","line":50,"range":{"start_line":38,"start_character":0,"end_line":50,"end_character":50},"updated":"2016-11-30 15:22:55.000000000","message":"nit: I\u0027d change this format to group the instructions like\n\n            self.db_objs, self.obj_fields, self.objs):\n            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])\n            db_obj[\u0027port_id\u0027] \u003d port.id\n            obj_field[\u0027port_id\u0027] \u003d port.id\n            obj[\u0027port_id\u0027] \u003d port.id\n\n            self._create_test_router()\n            db_obj[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]\n            obj_field[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]\n            obj[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]\n\n            self._create_test_agent()\n            db_obj[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]\n            obj_field[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]\n            obj[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bccde360ec6c6439a5465d4d30b8060be00187d9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"              self).setUp()"},{"line_number":36,"context_line":"        self._create_test_network()"},{"line_number":37,"context_line":"        for db_obj, obj_field, obj in zip("},{"line_number":38,"context_line":"            self.db_objs, self.obj_fields, self.objs):"},{"line_number":39,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":40,"context_line":"            self._create_test_router()"},{"line_number":41,"context_line":"            self._create_test_agent()"},{"line_number":42,"context_line":"            db_obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":43,"context_line":"            obj_field[\u0027port_id\u0027] \u003d port.id"},{"line_number":44,"context_line":"            obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":45,"context_line":"            db_obj[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]"},{"line_number":46,"context_line":"            obj_field[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]"},{"line_number":47,"context_line":"            obj[\u0027router_id\u0027] \u003d self._router[\u0027id\u0027]"},{"line_number":48,"context_line":"            db_obj[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]"},{"line_number":49,"context_line":"            obj_field[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]"},{"line_number":50,"context_line":"            obj[\u0027l3_agent_id\u0027] \u003d self._agent[\u0027id\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":53,"context_line":"        # TODO(sindhu): L3HARouterAgentPortBinding is using Agent"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a74a57a_b3592191","line":50,"range":{"start_line":38,"start_character":0,"end_line":50,"end_character":50},"in_reply_to":"5a74a57a_30aa671a","updated":"2016-11-30 15:35:32.000000000","message":"Helper method to solve the problem in going to be merge, you should rebase, when it\u0027ll merge:\nhttps://review.openstack.org/#/c/404259/","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"a2194cf634140e5713e162110906cff4bdb16ea1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                \u0027router_id\u0027: get_router,"},{"line_number":50,"context_line":"                                \u0027l3_agent_id\u0027: get_agent})"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":53,"context_line":"        # TODO(sindhu): L3HARouterAgentPortBinding is using Agent"},{"line_number":54,"context_line":"        # object as a synthetic field, which costs extra SQL query each time"},{"line_number":55,"context_line":"        # agent field is loaded as part of get_object(s)."},{"line_number":56,"context_line":"        # L3HARouterAgentPortBinding has defined relationship for"},{"line_number":57,"context_line":"        # Agent, so it should be possible to reuse side loaded"},{"line_number":58,"context_line":"        # values for this. To be reworked in follow-up patch."},{"line_number":59,"context_line":"        pass"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class L3HARouterNetworkIfaceObjectTestCase(base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":40,"id":"ffe62b97_14d37d3a","line":59,"range":{"start_line":52,"start_character":0,"end_line":59,"end_character":12},"updated":"2017-03-24 16:59:03.000000000","message":"Is this test case still needed? I do not see any synthetic fields in the objects.","commit_id":"760849074b4cb7399564389576bf5610e45dc209"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def get_port():"},{"line_number":37,"context_line":"            return self._create_test_port_id(network_id\u003d_network_id)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_router():"},{"line_number":40,"context_line":"            return self._create_test_router_id()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def get_agent():"},{"line_number":43,"context_line":"            return self._create_test_agent_id()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.update_obj_fields({\u0027port_id\u0027: get_port,"},{"line_number":46,"context_line":"                                \u0027router_id\u0027: get_router,"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_eb6cbb9d","line":43,"range":{"start_line":39,"start_character":8,"end_line":43,"end_character":47},"updated":"2017-08-22 20:41:01.000000000","message":"why not pointing to them directly in lines 45-47?","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def get_port():"},{"line_number":37,"context_line":"            return self._create_test_port_id(network_id\u003d_network_id)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_router():"},{"line_number":40,"context_line":"            return self._create_test_router_id()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def get_agent():"},{"line_number":43,"context_line":"            return self._create_test_agent_id()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.update_obj_fields({\u0027port_id\u0027: get_port,"},{"line_number":46,"context_line":"                                \u0027router_id\u0027: get_router,"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_75f53ecb","line":43,"range":{"start_line":39,"start_character":8,"end_line":43,"end_character":47},"in_reply_to":"7f287b81_eb6cbb9d","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65416f0b8411290cfd30b66dff34ac5311fb0c65","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        def get_port():"},{"line_number":37,"context_line":"            return self._create_test_port_id(network_id\u003d_network_id)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def get_router():"},{"line_number":40,"context_line":"            return self._create_test_router_id()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        def get_agent():"},{"line_number":43,"context_line":"            return self._create_test_agent_id()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.update_obj_fields({\u0027port_id\u0027: get_port,"},{"line_number":46,"context_line":"                                \u0027router_id\u0027: lambda:"}],"source_content_type":"text/x-python","patch_set":47,"id":"7f287b81_34e78ae7","line":43,"range":{"start_line":39,"start_character":7,"end_line":43,"end_character":47},"updated":"2017-08-24 14:57:35.000000000","message":"those are not used now","commit_id":"f1ee307055d86f917008feb227ae4fc3b39c7c0f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"65416f0b8411290cfd30b66dff34ac5311fb0c65","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return self._create_test_agent_id()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.update_obj_fields({\u0027port_id\u0027: get_port,"},{"line_number":46,"context_line":"                                \u0027router_id\u0027: lambda:"},{"line_number":47,"context_line":"                                self._create_test_router_id(),"},{"line_number":48,"context_line":"                                \u0027l3_agent_id\u0027: lambda:"},{"line_number":49,"context_line":"                                self._create_test_agent_id()})"}],"source_content_type":"text/x-python","patch_set":47,"id":"7f287b81_5409f692","line":46,"range":{"start_line":46,"start_character":49,"end_line":46,"end_character":52},"updated":"2017-08-24 14:57:35.000000000","message":"no need for lambdas, we can just point to methods directly","commit_id":"f1ee307055d86f917008feb227ae4fc3b39c7c0f"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"1b7e91e3b79b7c34b1e1180bd2c0994f53f6d881","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                \u0027router_id\u0027: self._create_test_router_id,"},{"line_number":41,"context_line":"                                \u0027l3_agent_id\u0027: self._create_test_agent_id})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":44,"context_line":"        # TODO(sindhu): L3HARouterAgentPortBinding is using Agent"},{"line_number":45,"context_line":"        # object as a synthetic field, which costs extra SQL query each time"},{"line_number":46,"context_line":"        # agent field is loaded as part of get_object(s)."},{"line_number":47,"context_line":"        # L3HARouterAgentPortBinding has defined relationship for"},{"line_number":48,"context_line":"        # Agent, so it should be possible to reuse side loaded"},{"line_number":49,"context_line":"        # values for this. To be reworked in follow-up patch."},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class L3HARouterNetworkIfaceObjectTestCase(base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_1207be1a","line":50,"range":{"start_line":43,"start_character":0,"end_line":50,"end_character":12},"updated":"2017-08-28 07:33:03.000000000","message":"We are no longer using \"Agent\" as a synthetic field of L3HARouterAgentPortBinding. Do we still need this test?","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e47770930f5401d9638f25dfda4a15561a286f94","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                \u0027router_id\u0027: self._create_test_router_id,"},{"line_number":41,"context_line":"                                \u0027l3_agent_id\u0027: self._create_test_agent_id})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":44,"context_line":"        # TODO(sindhu): L3HARouterAgentPortBinding is using Agent"},{"line_number":45,"context_line":"        # object as a synthetic field, which costs extra SQL query each time"},{"line_number":46,"context_line":"        # agent field is loaded as part of get_object(s)."},{"line_number":47,"context_line":"        # L3HARouterAgentPortBinding has defined relationship for"},{"line_number":48,"context_line":"        # Agent, so it should be possible to reuse side loaded"},{"line_number":49,"context_line":"        # values for this. To be reworked in follow-up patch."},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class L3HARouterNetworkIfaceObjectTestCase(base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f287b81_c6fbb476","line":50,"range":{"start_line":43,"start_character":0,"end_line":50,"end_character":12},"in_reply_to":"7f287b81_1207be1a","updated":"2017-08-29 06:45:54.000000000","message":"Done","commit_id":"22e4f67e022a93b0296fff842e47b0d938458a95"}],"neutron/tests/unit/objects/test_objects.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3f00975ecc63eb864cc08ac2ccc359b7bae06ea3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u0027DNSNameServer\u0027: \u00271.0-bf87a85327e2d812d1666ede99d9918b\u0027,"},{"line_number":32,"context_line":"    \u0027ExtraDhcpOpt\u0027: \u00271.0-632f689cbeb36328995a7aed1d0a78d3\u0027,"},{"line_number":33,"context_line":"    \u0027IPAllocationPool\u0027: \u00271.0-371016a6480ed0b4299319cb46d9215d\u0027,"},{"line_number":34,"context_line":"    #\u0027L3HARouterAgentPortBinding\u0027: \u00271.0-b1995dab440361392cf3d8804d0f2706\u0027,"},{"line_number":35,"context_line":"    \u0027L3HARouterNetwork\u0027: \u00271.0-87acea732853f699580179a94d2baf91\u0027,"},{"line_number":36,"context_line":"    \u0027L3HARouterVRIdAllocation\u0027: \u00271.0-a5b913e2fa6a4ad3b5bdca4de59e9af6\u0027,"},{"line_number":37,"context_line":"    \u0027NetworkPortSecurity\u0027: \u00271.0-b30802391a87945ee9c07582b4ff95e3\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_639a0370","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":74},"updated":"2016-09-12 23:59:59.000000000","message":"commented line ?","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3f0648f52b2eebec6592393790c8952764a9970c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u0027DNSNameServer\u0027: \u00271.0-bf87a85327e2d812d1666ede99d9918b\u0027,"},{"line_number":32,"context_line":"    \u0027ExtraDhcpOpt\u0027: \u00271.0-632f689cbeb36328995a7aed1d0a78d3\u0027,"},{"line_number":33,"context_line":"    \u0027IPAllocationPool\u0027: \u00271.0-371016a6480ed0b4299319cb46d9215d\u0027,"},{"line_number":34,"context_line":"    #\u0027L3HARouterAgentPortBinding\u0027: \u00271.0-b1995dab440361392cf3d8804d0f2706\u0027,"},{"line_number":35,"context_line":"    \u0027L3HARouterNetwork\u0027: \u00271.0-87acea732853f699580179a94d2baf91\u0027,"},{"line_number":36,"context_line":"    \u0027L3HARouterVRIdAllocation\u0027: \u00271.0-a5b913e2fa6a4ad3b5bdca4de59e9af6\u0027,"},{"line_number":37,"context_line":"    \u0027NetworkPortSecurity\u0027: \u00271.0-b30802391a87945ee9c07582b4ff95e3\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_a162c2d6","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":74},"in_reply_to":"9a89bdaa_639a0370","updated":"2016-09-14 04:48:32.000000000","message":"This was for the other object that needs to be implemented \nL3HARouterAgentPortBinding in the same review but in the following PS. Have removed it for now.","commit_id":"e90c959b55c31232f6fc1d97495d7b6714a72b16"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9a3b94671663190e668ee45bd11e610f81220ba7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027ExtraDhcpOpt\u0027: \u00271.0-632f689cbeb36328995a7aed1d0a78d3\u0027,"},{"line_number":33,"context_line":"    \u0027IPAllocationPool\u0027: \u00271.0-371016a6480ed0b4299319cb46d9215d\u0027,"},{"line_number":34,"context_line":"    \u0027L3HARouterAgentPortBinding\u0027: \u00271.0-b40e3eaf2f5a36bc67546f188ea91197\u0027,"},{"line_number":35,"context_line":"    \u0027L3HARouterNetwork\u0027: \u00271.0-87acea732853f699580179a94d2baf91\u0027,"},{"line_number":36,"context_line":"    \u0027L3HARouterVRIdAllocation\u0027: \u00271.0-37502aebdbeadc4f9e3bd5e9da714ab9\u0027,"},{"line_number":37,"context_line":"    \u0027NetworkPortSecurity\u0027: \u00271.0-b30802391a87945ee9c07582b4ff95e3\u0027,"},{"line_number":38,"context_line":"    \u0027NetworkSegment\u0027: \u00271.0-40707ef6bd9a0bf095038158d995cc7d\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8ec9b2_e2de106c","line":35,"updated":"2016-09-21 14:01:39.000000000","message":"You need to update he object hashes, per UT failure.","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"282c899bfeda27255541e163ecbed5124571cc6b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027ExtraDhcpOpt\u0027: \u00271.0-632f689cbeb36328995a7aed1d0a78d3\u0027,"},{"line_number":33,"context_line":"    \u0027IPAllocationPool\u0027: \u00271.0-371016a6480ed0b4299319cb46d9215d\u0027,"},{"line_number":34,"context_line":"    \u0027L3HARouterAgentPortBinding\u0027: \u00271.0-b40e3eaf2f5a36bc67546f188ea91197\u0027,"},{"line_number":35,"context_line":"    \u0027L3HARouterNetwork\u0027: \u00271.0-87acea732853f699580179a94d2baf91\u0027,"},{"line_number":36,"context_line":"    \u0027L3HARouterVRIdAllocation\u0027: \u00271.0-37502aebdbeadc4f9e3bd5e9da714ab9\u0027,"},{"line_number":37,"context_line":"    \u0027NetworkPortSecurity\u0027: \u00271.0-b30802391a87945ee9c07582b4ff95e3\u0027,"},{"line_number":38,"context_line":"    \u0027NetworkSegment\u0027: \u00271.0-40707ef6bd9a0bf095038158d995cc7d\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_a52b6b93","line":35,"in_reply_to":"7a8ec9b2_e2de106c","updated":"2016-09-23 13:32:49.000000000","message":"Done","commit_id":"74b68bb91894215a3855b63878df79d9882a87b0"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if network_id \u003d\u003d TEST_HA_NETWORK_ID:"},{"line_number":125,"context_line":"                agent \u003d self.get_l3_agent_by_host(host)"},{"line_number":126,"context_line":"                haport_bindings \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":127,"context_line":"                    self.ctx,"},{"line_number":128,"context_line":"                    port_id\u003dport_id,"},{"line_number":129,"context_line":"                    router_id\u003ddevice_id,"},{"line_number":130,"context_line":"                    l3_agent_id\u003dagent[\u0027id\u0027],"},{"line_number":131,"context_line":"                    state\u003dkwargs.get(\u0027host_state\u0027,"},{"line_number":132,"context_line":"                        n_const.HA_ROUTER_STATE_ACTIVE)"},{"line_number":133,"context_line":"                )"},{"line_number":134,"context_line":"                haport_bindings.create()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_get_distributed_active_network_ports(self):"},{"line_number":137,"context_line":"        self._setup_port_binding("}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_0682ad52","line":134,"range":{"start_line":126,"start_character":16,"end_line":134,"end_character":40},"updated":"2016-11-07 17:55:48.000000000","message":"It\u0027s not necessary to have a variable for the creation of this object\n\n    l3_obj.L3HARouterAgentPortBinding(\n                    self.ctx,\n                    port_id\u003dport_id,\n                    router_id\u003ddevice_id,\n                    l3_agent_id\u003dagent[\u0027id\u0027],\n                    state\u003dkwargs.get(\u0027host_state\u0027,\n                        n_const.HA_ROUTER_STATE_ACTIVE)\n                ).create()","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if network_id \u003d\u003d TEST_HA_NETWORK_ID:"},{"line_number":125,"context_line":"                agent \u003d self.get_l3_agent_by_host(host)"},{"line_number":126,"context_line":"                haport_bindings \u003d l3_obj.L3HARouterAgentPortBinding("},{"line_number":127,"context_line":"                    self.ctx,"},{"line_number":128,"context_line":"                    port_id\u003dport_id,"},{"line_number":129,"context_line":"                    router_id\u003ddevice_id,"},{"line_number":130,"context_line":"                    l3_agent_id\u003dagent[\u0027id\u0027],"},{"line_number":131,"context_line":"                    state\u003dkwargs.get(\u0027host_state\u0027,"},{"line_number":132,"context_line":"                        n_const.HA_ROUTER_STATE_ACTIVE)"},{"line_number":133,"context_line":"                )"},{"line_number":134,"context_line":"                haport_bindings.create()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_get_distributed_active_network_ports(self):"},{"line_number":137,"context_line":"        self._setup_port_binding("}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_90b0a1f6","line":134,"range":{"start_line":126,"start_character":16,"end_line":134,"end_character":40},"in_reply_to":"9a629dbe_0682ad52","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b4d0b8a7f66c0ea3bc1105226e30b3583a04b881","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if network_id \u003d\u003d TEST_HA_NETWORK_ID:"},{"line_number":125,"context_line":"                agent \u003d self.get_l3_agent_by_host(host)"},{"line_number":126,"context_line":"                l3_obj.L3HARouterAgentPortBinding("},{"line_number":127,"context_line":"                    self.ctx,"},{"line_number":128,"context_line":"                    port_id\u003dport_id,"},{"line_number":129,"context_line":"                    router_id\u003ddevice_id,"},{"line_number":130,"context_line":"                    l3_agent_id\u003dagent[\u0027id\u0027],"},{"line_number":131,"context_line":"                    state\u003dkwargs.get(\u0027host_state\u0027,"},{"line_number":132,"context_line":"                        n_const.HA_ROUTER_STATE_ACTIVE)"},{"line_number":133,"context_line":"                ).create()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_get_distributed_active_network_ports(self):"},{"line_number":136,"context_line":"        self._setup_port_binding("}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_350e2ee5","line":133,"range":{"start_line":126,"start_character":0,"end_line":133,"end_character":26},"updated":"2016-11-18 20:49:52.000000000","message":"how about?\n                l3_obj.L3HARouterAgentPortBinding(\n                    self.ctx, port_id\u003dport_id, outer_id\u003ddevice_id,\n                    l3_agent_id\u003dagent[\u0027id\u0027],\n                    state\u003dkwargs.get(\u0027host_state\u0027,\n                                     n_const.HA_ROUTER_STATE_ACTIVE)\n                ).create()","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dbb71695cbdd27ecde995fd0d56a5b88954144ca","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if network_id \u003d\u003d TEST_HA_NETWORK_ID:"},{"line_number":125,"context_line":"                agent \u003d self.get_l3_agent_by_host(host)"},{"line_number":126,"context_line":"                l3_obj.L3HARouterAgentPortBinding("},{"line_number":127,"context_line":"                    self.ctx,"},{"line_number":128,"context_line":"                    port_id\u003dport_id,"},{"line_number":129,"context_line":"                    router_id\u003ddevice_id,"},{"line_number":130,"context_line":"                    l3_agent_id\u003dagent[\u0027id\u0027],"},{"line_number":131,"context_line":"                    state\u003dkwargs.get(\u0027host_state\u0027,"},{"line_number":132,"context_line":"                        n_const.HA_ROUTER_STATE_ACTIVE)"},{"line_number":133,"context_line":"                ).create()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_get_distributed_active_network_ports(self):"},{"line_number":136,"context_line":"        self._setup_port_binding("}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_75c9495a","line":133,"range":{"start_line":126,"start_character":0,"end_line":133,"end_character":26},"in_reply_to":"7a77a97e_350e2ee5","updated":"2016-11-21 17:54:15.000000000","message":"Done","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"38d4eb4a2ae5d66918941e7b6c5d18033b042c2e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if network_id \u003d\u003d TEST_HA_NETWORK_ID:"},{"line_number":125,"context_line":"                agent \u003d self.get_l3_agent_by_host(host)"},{"line_number":126,"context_line":"                l3_obj.L3HARouterAgentPortBinding("},{"line_number":127,"context_line":"                    self.ctx, port_id\u003dport_id, router_id\u003ddevice_id,"},{"line_number":128,"context_line":"                    l3_agent_id\u003dagent[\u0027id\u0027],"},{"line_number":129,"context_line":"                    state\u003dkwargs.get(\u0027host_state\u0027,"},{"line_number":130,"context_line":"                                     n_const.HA_ROUTER_STATE_ACTIVE)"},{"line_number":131,"context_line":"                ).create()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_get_distributed_active_network_ports(self):"},{"line_number":134,"context_line":"        self._setup_port_binding("}],"source_content_type":"text/x-python","patch_set":30,"id":"7a77a97e_f41c5b15","line":131,"range":{"start_line":126,"start_character":16,"end_line":131,"end_character":26},"updated":"2016-11-22 10:16:50.000000000","message":"It would be more readable when every parameter is in new line:\n    l3_obj.L3HARouterAgentPortBinding(\n        self.ctx, \n        port_id\u003dport_id, \n        router_id\u003ddevice_id,\n        l3_agent_id\u003dagent[\u0027id\u0027],\n        state\u003dkwargs.get(\u0027host_state\u0027,\n            n_const.HA_ROUTER_STATE_ACTIVE)\n    ).create()","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"344692278c69c61f7fc7e7baa943841ad8c48f65","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            if network_id \u003d\u003d TEST_HA_NETWORK_ID:"},{"line_number":125,"context_line":"                agent \u003d self.get_l3_agent_by_host(host)"},{"line_number":126,"context_line":"                l3_obj.L3HARouterAgentPortBinding("},{"line_number":127,"context_line":"                    self.ctx, port_id\u003dport_id, router_id\u003ddevice_id,"},{"line_number":128,"context_line":"                    l3_agent_id\u003dagent[\u0027id\u0027],"},{"line_number":129,"context_line":"                    state\u003dkwargs.get(\u0027host_state\u0027,"},{"line_number":130,"context_line":"                                     n_const.HA_ROUTER_STATE_ACTIVE)"},{"line_number":131,"context_line":"                ).create()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_get_distributed_active_network_ports(self):"},{"line_number":134,"context_line":"        self._setup_port_binding("}],"source_content_type":"text/x-python","patch_set":30,"id":"3a71b18c_b84bd52a","line":131,"range":{"start_line":126,"start_character":16,"end_line":131,"end_character":26},"in_reply_to":"7a77a97e_f41c5b15","updated":"2016-12-01 16:58:01.000000000","message":"Done","commit_id":"c4a913d185f9a2203121cbad9b9c1bfb1aa9d739"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"1f53a6c30d7e6a3223154e16b46900603380a3ad","unresolved":false,"context_lines":[{"line_number":35,"context_line":"HOST_3 \u003d \u0027HOST_3\u0027"},{"line_number":36,"context_line":"HOST_2_TUNNELING_IP \u003d \u002720.0.0.2\u0027"},{"line_number":37,"context_line":"HOST_3_TUNNELING_IP \u003d \u002720.0.0.3\u0027"},{"line_number":38,"context_line":"# TEST_ROUTER_ID \u003d \u0027router_id\u0027"},{"line_number":39,"context_line":"TEST_ROUTER_ID \u003d uuidutils.generate_uuid()"},{"line_number":40,"context_line":"TEST_NETWORK_ID \u003d uuidutils.generate_uuid()"},{"line_number":41,"context_line":"TEST_HA_NETWORK_ID \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":39,"id":"ffe62b97_b312ae57","line":38,"updated":"2017-03-24 14:56:54.000000000","message":"Please remove this :)","commit_id":"1661879e5aecb219f257a1dbe7591d67cbdce3ee"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"89e789b939d58a120a0996bf8572ed04386fa946","unresolved":false,"context_lines":[{"line_number":35,"context_line":"HOST_3 \u003d \u0027HOST_3\u0027"},{"line_number":36,"context_line":"HOST_2_TUNNELING_IP \u003d \u002720.0.0.2\u0027"},{"line_number":37,"context_line":"HOST_3_TUNNELING_IP \u003d \u002720.0.0.3\u0027"},{"line_number":38,"context_line":"# TEST_ROUTER_ID \u003d \u0027router_id\u0027"},{"line_number":39,"context_line":"TEST_ROUTER_ID \u003d uuidutils.generate_uuid()"},{"line_number":40,"context_line":"TEST_NETWORK_ID \u003d uuidutils.generate_uuid()"},{"line_number":41,"context_line":"TEST_HA_NETWORK_ID \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":39,"id":"ffe62b97_33d21e5e","line":38,"in_reply_to":"ffe62b97_b312ae57","updated":"2017-03-24 14:59:26.000000000","message":"Done","commit_id":"1661879e5aecb219f257a1dbe7591d67cbdce3ee"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.db import models_v2"},{"line_number":24,"context_line":"from neutron.objects import l3_hamode"},{"line_number":25,"context_line":"from neutron.objects import network as network_obj"},{"line_number":26,"context_line":"from neutron.objects import router as l3_obj"},{"line_number":27,"context_line":"from neutron.plugins.ml2.drivers.l2pop import db as l2pop_db"},{"line_number":28,"context_line":"from neutron.plugins.ml2 import models"},{"line_number":29,"context_line":"from neutron.tests.common import helpers"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_8b32d7a6","line":26,"updated":"2017-08-22 20:41:01.000000000","message":"nit: unneeded change","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.db import models_v2"},{"line_number":24,"context_line":"from neutron.objects import l3_hamode"},{"line_number":25,"context_line":"from neutron.objects import network as network_obj"},{"line_number":26,"context_line":"from neutron.objects import router as l3_obj"},{"line_number":27,"context_line":"from neutron.plugins.ml2.drivers.l2pop import db as l2pop_db"},{"line_number":28,"context_line":"from neutron.plugins.ml2 import models"},{"line_number":29,"context_line":"from neutron.tests.common import helpers"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_35ffb6ab","line":26,"in_reply_to":"7f287b81_8b32d7a6","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"651bea24e5c7d6355c918ab0971d4354ad6db08d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def _create_router(self, distributed\u003dTrue, ha\u003dFalse):"},{"line_number":56,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":57,"context_line":"            self.ctx.session.add(l3_models.Router(id\u003dTEST_ROUTER_ID))"},{"line_number":58,"context_line":"            l3_obj.RouterExtraAttributes("},{"line_number":59,"context_line":"                self.ctx,"},{"line_number":60,"context_line":"                router_id\u003dTEST_ROUTER_ID,"},{"line_number":61,"context_line":"                distributed\u003ddistributed, ha\u003dha).create()"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_2b21a34e","line":58,"updated":"2017-08-22 20:41:01.000000000","message":"ditto","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"e60a3c7fbb644443d83349f11b90536145a5fe87","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def _create_router(self, distributed\u003dTrue, ha\u003dFalse):"},{"line_number":56,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":57,"context_line":"            self.ctx.session.add(l3_models.Router(id\u003dTEST_ROUTER_ID))"},{"line_number":58,"context_line":"            l3_obj.RouterExtraAttributes("},{"line_number":59,"context_line":"                self.ctx,"},{"line_number":60,"context_line":"                router_id\u003dTEST_ROUTER_ID,"},{"line_number":61,"context_line":"                distributed\u003ddistributed, ha\u003dha).create()"}],"source_content_type":"text/x-python","patch_set":46,"id":"7f287b81_152efa42","line":58,"in_reply_to":"7f287b81_2b21a34e","updated":"2017-08-23 08:25:16.000000000","message":"Done","commit_id":"2abc33c13b88eac46bd43abc8326f6d95cda2783"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4da083536a314530b95e4cce61f9f0bcb17e275a","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        agent \u003d agents.pop()"},{"line_number":1735,"context_line":"        self.plugin.remove_router_from_l3_agent("},{"line_number":1736,"context_line":"            self.adminContext, agent.id, router[\u0027id\u0027])"},{"line_number":1737,"context_line":"        obj \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":1738,"context_line":"            self.adminContext, router_id\u003drouter[\u0027id\u0027])"},{"line_number":1739,"context_line":"        results \u003d [binding.l3_agent_id for binding in obj]"},{"line_number":1740,"context_line":"        self.assertNotIn(agent.id, results)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_06e9cd1a","line":1737,"range":{"start_line":1737,"start_character":8,"end_line":1737,"end_character":11},"updated":"2016-11-07 17:55:48.000000000","message":"nit: s/obj/objs","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"682c04624c1ba9128d7b79d5a10db1bdd715f3bf","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        agent \u003d agents.pop()"},{"line_number":1735,"context_line":"        self.plugin.remove_router_from_l3_agent("},{"line_number":1736,"context_line":"            self.adminContext, agent.id, router[\u0027id\u0027])"},{"line_number":1737,"context_line":"        obj \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":1738,"context_line":"            self.adminContext, router_id\u003drouter[\u0027id\u0027])"},{"line_number":1739,"context_line":"        results \u003d [binding.l3_agent_id for binding in obj]"},{"line_number":1740,"context_line":"        self.assertNotIn(agent.id, results)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a629dbe_b095a541","line":1737,"range":{"start_line":1737,"start_character":8,"end_line":1737,"end_character":11},"in_reply_to":"9a629dbe_06e9cd1a","updated":"2016-11-08 04:26:45.000000000","message":"Done","commit_id":"cdc8f41fed7ec6bd2f2968d1b1df8e96d64615e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b4d0b8a7f66c0ea3bc1105226e30b3583a04b881","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        agent \u003d agents.pop()"},{"line_number":1735,"context_line":"        self.plugin.remove_router_from_l3_agent("},{"line_number":1736,"context_line":"            self.adminContext, agent.id, router[\u0027id\u0027])"},{"line_number":1737,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":1738,"context_line":"            self.adminContext, router_id\u003drouter[\u0027id\u0027])"},{"line_number":1739,"context_line":"        results \u003d [binding.l3_agent_id for binding in objs]"},{"line_number":1740,"context_line":"        self.assertNotIn(agent.id, results)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def test_add_ha_interface_to_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_d22353bb","line":1739,"range":{"start_line":1737,"start_character":0,"end_line":1739,"end_character":59},"updated":"2016-11-18 20:49:52.000000000","message":"how about?\n        results \u003d [binding.l3_agent_id for binding in\n            l3_obj.L3HARouterAgentPortBinding.get_objects(\n            self.adminContext, router_id\u003drouter[\u0027id\u0027])]","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dbb71695cbdd27ecde995fd0d56a5b88954144ca","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        agent \u003d agents.pop()"},{"line_number":1735,"context_line":"        self.plugin.remove_router_from_l3_agent("},{"line_number":1736,"context_line":"            self.adminContext, agent.id, router[\u0027id\u0027])"},{"line_number":1737,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":1738,"context_line":"            self.adminContext, router_id\u003drouter[\u0027id\u0027])"},{"line_number":1739,"context_line":"        results \u003d [binding.l3_agent_id for binding in objs]"},{"line_number":1740,"context_line":"        self.assertNotIn(agent.id, results)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def test_add_ha_interface_to_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a77a97e_953b4538","line":1739,"range":{"start_line":1737,"start_character":0,"end_line":1739,"end_character":59},"in_reply_to":"7a77a97e_d22353bb","updated":"2016-11-21 17:54:15.000000000","message":"I would like to keep it the way it is, as I feel it\u0027s easier/clearer to understand.","commit_id":"6e1619e6f839d2f9101c7b434ae55792d84d7f0d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"85710e97656c432ccc0ec61006b5192b43a47a0d","unresolved":false,"context_lines":[{"line_number":1730,"context_line":"        agent \u003d agents.pop()"},{"line_number":1731,"context_line":"        self.plugin.remove_router_from_l3_agent("},{"line_number":1732,"context_line":"            self.adminContext, agent.id, router[\u0027id\u0027])"},{"line_number":1733,"context_line":"        objs \u003d l3_obj.L3HARouterAgentPortBinding.get_objects("},{"line_number":1734,"context_line":"            self.adminContext, router_id\u003drouter[\u0027id\u0027])"},{"line_number":1735,"context_line":"        results \u003d [binding.l3_agent_id for binding in objs]"},{"line_number":1736,"context_line":"        self.assertNotIn(agent.id, results)"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"    def test_add_ha_interface_to_l3_agent(self):"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a3905b3_4c9c405d","line":1735,"range":{"start_line":1733,"start_character":8,"end_line":1735,"end_character":59},"updated":"2017-01-23 15:33:56.000000000","message":"Shouldn\u0027t be better to filter this by agent.id and check that it\u0027s an empty list?","commit_id":"10e7076d493dd0faec31b56a5fbdf7f794ee906f"}]}
