)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ae32dcaed872688d5707f7e35b67dbb7c0205018","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate SegmentHostMapping DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch relocates SegmentHostMapping db model to neutron/db/models"},{"line_number":10,"context_line":"Partial-Bug: #1597913"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I630e5c42f9ab781ba6565cdf0f780bf78c2b5dc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a8ec9b2_cfe02d2c","line":10,"updated":"2016-09-16 17:56:45.000000000","message":"nit: it\u0027d be better if you separate the description from the Partial-Bug tag.","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b2ea0478457f10d34e8dc830a852acff7a201e9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate SegmentHostMapping DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch relocates SegmentHostMapping db model to neutron/db/models"},{"line_number":10,"context_line":"Partial-Bug: #1597913"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I630e5c42f9ab781ba6565cdf0f780bf78c2b5dc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5a8bc5a2_db77afd2","line":10,"in_reply_to":"5a8bc5a2_55e9b019","updated":"2016-09-22 21:15:35.000000000","message":"Done","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9ee435c9106d6927499d8a9be7a3597deb0a722","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate SegmentHostMapping DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch relocates SegmentHostMapping db model to neutron/db/models"},{"line_number":10,"context_line":"Partial-Bug: #1597913"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I630e5c42f9ab781ba6565cdf0f780bf78c2b5dc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5a8bc5a2_55e9b019","line":10,"in_reply_to":"7a8ec9b2_cfe02d2c","updated":"2016-09-22 15:38:33.000000000","message":"+1. Also dot at the end of line 9 missing.","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b2ea0478457f10d34e8dc830a852acff7a201e9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Relocate SegmentHostMapping DB model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch relocates SegmentHostMapping db model to neutron/db/models"},{"line_number":10,"context_line":"Partial-Bug: #1597913"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I630e5c42f9ab781ba6565cdf0f780bf78c2b5dc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5a8bc5a2_9b6d2707","line":10,"in_reply_to":"7a8ec9b2_cfe02d2c","updated":"2016-09-22 21:15:35.000000000","message":"Done","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"}],"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75478d37f3604836a4bad55f5680df0e62d3b801","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import segment as model"},{"line_number":37,"context_line":"from neutron.db.models import subnet_service_type as sst_model"},{"line_number":38,"context_line":"from neutron.db import models_v2"},{"line_number":39,"context_line":"from neutron.db import segments_db"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_535a6850","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":46},"updated":"2016-09-23 16:14:52.000000000","message":"this should have a more specific name (seg_model?)","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e393b6b57e90528876961dcc067d6fafac44ff38","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import segment as model"},{"line_number":37,"context_line":"from neutron.db.models import subnet_service_type as sst_model"},{"line_number":38,"context_line":"from neutron.db import models_v2"},{"line_number":39,"context_line":"from neutron.db import segments_db"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_a7e8bdb5","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":46},"in_reply_to":"5a8bc5a2_535a6850","updated":"2016-09-23 19:13:37.000000000","message":"Done","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8762ebe1b99603edf7cb4039b296286c5078e4a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import segment as seg_model"},{"line_number":37,"context_line":"from neutron.db.models import subnet_service_type as sst_model"},{"line_number":38,"context_line":"from neutron.db import models_v2"},{"line_number":39,"context_line":"from neutron.db import segments_db"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_0b355bf6","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":50},"updated":"2016-09-28 13:42:34.000000000","message":"I think we can use \u0027segment_model\u0027 without needing to break up lines too much.","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"56a3fbda62ecf85f6007a8229ceba29997639c0c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.common import ipv6_utils"},{"line_number":34,"context_line":"from neutron.common import utils as common_utils"},{"line_number":35,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":36,"context_line":"from neutron.db.models import segment as seg_model"},{"line_number":37,"context_line":"from neutron.db.models import subnet_service_type as sst_model"},{"line_number":38,"context_line":"from neutron.db import models_v2"},{"line_number":39,"context_line":"from neutron.db import segments_db"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_2f7d8ae7","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":50},"in_reply_to":"5a8bc5a2_0b355bf6","updated":"2016-09-29 15:15:16.000000000","message":"Done","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"}],"neutron/db/migration/models/head.py":[{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"42c58d46f67d77e311b0131a889de212641f0eab","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_geneve  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"},{"line_number":60,"context_line":"from neutron.services.auto_allocate import models as aa_models  # noqa"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_475704ce","line":57,"updated":"2016-09-29 21:45:08.000000000","message":"I think #L57-58 were removed during relocation of vlan and vxlan which got merged.","commit_id":"9058ff24695fc9e7fd1477610bb01a5e03622e35"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"6b734cee6d4ad81c607db875c908fa4063c2edb3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from neutron.db import tag_db  # noqa"},{"line_number":55,"context_line":"from neutron.ipam.drivers.neutrondb_ipam import db_models  # noqa"},{"line_number":56,"context_line":"from neutron.plugins.ml2.drivers import type_geneve  # noqa"},{"line_number":57,"context_line":"from neutron.plugins.ml2.drivers import type_vlan  # noqa"},{"line_number":58,"context_line":"from neutron.plugins.ml2.drivers import type_vxlan  # noqa"},{"line_number":59,"context_line":"from neutron.plugins.ml2 import models as ml2_models  # noqa"},{"line_number":60,"context_line":"from neutron.services.auto_allocate import models as aa_models  # noqa"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_b99d160c","line":57,"in_reply_to":"3a98d1f4_475704ce","updated":"2016-09-30 17:59:04.000000000","message":"Done","commit_id":"9058ff24695fc9e7fd1477610bb01a5e03622e35"}],"neutron/db/models/segment.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"af830280db9d91cbceec741036c18496e19544bb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sqlalchemy as sa"},{"line_number":20,"context_line":"from sqlalchemy import orm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.db import segments_db as db"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentHostMapping(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_b4619a3b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":40},"updated":"2016-09-26 11:17:03.000000000","message":"This patch should be coordinated with:\nhttps://review.openstack.org/#/c/352226/","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"56a3fbda62ecf85f6007a8229ceba29997639c0c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sqlalchemy as sa"},{"line_number":20,"context_line":"from sqlalchemy import orm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.db import segments_db as db"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentHostMapping(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_ef4562b3","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":40},"in_reply_to":"5a8bc5a2_b4619a3b","updated":"2016-09-29 15:15:16.000000000","message":"Do you mean i should make this patch dependent on https://review.openstack.org/#/c/352226/?","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"}],"neutron/db/models/segmenthostmapping.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9ee435c9106d6927499d8a9be7a3597deb0a722","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development, LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_95fed869","line":1,"updated":"2016-09-22 15:38:33.000000000","message":"I disagree with the name of the module. I believe all segment related models should go here, and the module should be called \u0027segment.py\u0027","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b2ea0478457f10d34e8dc830a852acff7a201e9b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development, LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_6a41620b","line":1,"in_reply_to":"5a8bc5a2_95fed869","updated":"2016-09-22 21:15:35.000000000","message":"Done","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9ee435c9106d6927499d8a9be7a3597deb0a722","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sqlalchemy as sa"},{"line_number":20,"context_line":"from sqlalchemy import orm"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.db import segments_db as db"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentHostMapping(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_757eace5","line":22,"updated":"2016-09-22 15:38:33.000000000","message":"(No action required) once we move Segment model here, this will go away.","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"}],"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9ee435c9106d6927499d8a9be7a3597deb0a722","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            query \u003d context.session.query("},{"line_number":69,"context_line":"                segmenthostmapping.SegmentHostMapping.segment_id)"},{"line_number":70,"context_line":"            query \u003d query.filter(segmenthostmapping.SegmentHostMapping.host \u003d\u003d"},{"line_number":71,"context_line":"                                 host)"},{"line_number":72,"context_line":"            segments_on_host \u003d {s.segment_id for s in query}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_75178ca3","line":70,"updated":"2016-09-22 15:38:33.000000000","message":"this is less readable. Consider shrinking the name of the module. Though when you will have the module renamed into segment.py you should not have such a problem.","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b2ea0478457f10d34e8dc830a852acff7a201e9b","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            query \u003d context.session.query("},{"line_number":69,"context_line":"                segmenthostmapping.SegmentHostMapping.segment_id)"},{"line_number":70,"context_line":"            query \u003d query.filter(segmenthostmapping.SegmentHostMapping.host \u003d\u003d"},{"line_number":71,"context_line":"                                 host)"},{"line_number":72,"context_line":"            segments_on_host \u003d {s.segment_id for s in query}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_3b56d329","line":70,"in_reply_to":"5a8bc5a2_75178ca3","updated":"2016-09-22 21:15:35.000000000","message":"Done","commit_id":"726b665c3db09251a1a49cf5ad418c8804b750e8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75478d37f3604836a4bad55f5680df0e62d3b801","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            query \u003d context.session.query("},{"line_number":69,"context_line":"                segment.SegmentHostMapping.segment_id)"},{"line_number":70,"context_line":"            query \u003d query.filter(segment.SegmentHostMapping.host \u003d\u003d"},{"line_number":71,"context_line":"                                 host)"},{"line_number":72,"context_line":"            segments_on_host \u003d {s.segment_id for s in query}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            for dhcp_agent in dhcp_agents:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_f3161454","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":38},"updated":"2016-09-23 16:14:52.000000000","message":"can\u0027t we squash those two lines into one?","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e393b6b57e90528876961dcc067d6fafac44ff38","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            query \u003d context.session.query("},{"line_number":69,"context_line":"                segment.SegmentHostMapping.segment_id)"},{"line_number":70,"context_line":"            query \u003d query.filter(segment.SegmentHostMapping.host \u003d\u003d"},{"line_number":71,"context_line":"                                 host)"},{"line_number":72,"context_line":"            segments_on_host \u003d {s.segment_id for s in query}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            for dhcp_agent in dhcp_agents:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_47d8d91d","line":71,"range":{"start_line":70,"start_character":12,"end_line":71,"end_character":38},"in_reply_to":"5a8bc5a2_f3161454","updated":"2016-09-23 19:13:37.000000000","message":"Done","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"d28fe3646f615cc9c35f9f5134ab6745ea74fe19","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron._i18n import _LI, _LW"},{"line_number":27,"context_line":"from neutron.db import agents_db"},{"line_number":28,"context_line":"from neutron.db import api as db_api"},{"line_number":29,"context_line":"from neutron.db.models import segment"},{"line_number":30,"context_line":"from neutron.db.network_dhcp_agent_binding import models as ndab_model"},{"line_number":31,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":32,"context_line":"from neutron.scheduler import base_resource_filter"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_e9bda0d8","line":29,"updated":"2016-09-27 20:55:28.000000000","message":"nit: it would be nice to have it named as seg_model as in other files","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"56a3fbda62ecf85f6007a8229ceba29997639c0c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron._i18n import _LI, _LW"},{"line_number":27,"context_line":"from neutron.db import agents_db"},{"line_number":28,"context_line":"from neutron.db import api as db_api"},{"line_number":29,"context_line":"from neutron.db.models import segment"},{"line_number":30,"context_line":"from neutron.db.network_dhcp_agent_binding import models as ndab_model"},{"line_number":31,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":32,"context_line":"from neutron.scheduler import base_resource_filter"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_8f03fe41","line":29,"in_reply_to":"5a8bc5a2_ab2e27a3","updated":"2016-09-29 15:15:16.000000000","message":"Done","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8762ebe1b99603edf7cb4039b296286c5078e4a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron._i18n import _LI, _LW"},{"line_number":27,"context_line":"from neutron.db import agents_db"},{"line_number":28,"context_line":"from neutron.db import api as db_api"},{"line_number":29,"context_line":"from neutron.db.models import segment"},{"line_number":30,"context_line":"from neutron.db.network_dhcp_agent_binding import models as ndab_model"},{"line_number":31,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":32,"context_line":"from neutron.scheduler import base_resource_filter"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_ab2e27a3","line":29,"in_reply_to":"5a8bc5a2_e9bda0d8","updated":"2016-09-28 13:42:34.000000000","message":"I would suggest \u0027segment_model\u0027.","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"56a3fbda62ecf85f6007a8229ceba29997639c0c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron._i18n import _LI, _LW"},{"line_number":27,"context_line":"from neutron.db import agents_db"},{"line_number":28,"context_line":"from neutron.db import api as db_api"},{"line_number":29,"context_line":"from neutron.db.models import segment"},{"line_number":30,"context_line":"from neutron.db.network_dhcp_agent_binding import models as ndab_model"},{"line_number":31,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":32,"context_line":"from neutron.scheduler import base_resource_filter"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_eff8024c","line":29,"in_reply_to":"5a8bc5a2_e9bda0d8","updated":"2016-09-29 15:15:16.000000000","message":"used segment_model","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"}],"neutron/services/segments/db.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6e609f616176b63796e7ef96e94ae8a8f46ca490","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":319,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":320,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset("},{"line_number":321,"context_line":"    globals(),"},{"line_number":322,"context_line":"    segmenthostmapping)"},{"line_number":323,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_b2ebecaf","line":320,"updated":"2016-08-31 12:36:29.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"faffb578b0f8c041421e7fd5fb38fc4e1738ccf7"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"ea4a8e0c1a2ec4fa51dd436c3befa16dfb8c52c5","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":319,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":320,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset("},{"line_number":321,"context_line":"    globals(),"},{"line_number":322,"context_line":"    segmenthostmapping)"},{"line_number":323,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_a9a44c08","line":320,"in_reply_to":"fa7ab95a_b2ebecaf","updated":"2016-08-31 17:09:59.000000000","message":"Done","commit_id":"faffb578b0f8c041421e7fd5fb38fc4e1738ccf7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75478d37f3604836a4bad55f5680df0e62d3b801","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.common import _deprecate"},{"line_number":31,"context_line":"from neutron.db import api as db_api"},{"line_number":32,"context_line":"from neutron.db import common_db_mixin"},{"line_number":33,"context_line":"from neutron.db.models import segment as model"},{"line_number":34,"context_line":"from neutron.db import segments_db as db"},{"line_number":35,"context_line":"from neutron.extensions import segment as extension"},{"line_number":36,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_130e203b","line":33,"range":{"start_line":33,"start_character":41,"end_line":33,"end_character":46},"updated":"2016-09-23 16:14:52.000000000","message":"the name is not specific enough. consider e.g. \u0027seg_model\u0027","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e393b6b57e90528876961dcc067d6fafac44ff38","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.common import _deprecate"},{"line_number":31,"context_line":"from neutron.db import api as db_api"},{"line_number":32,"context_line":"from neutron.db import common_db_mixin"},{"line_number":33,"context_line":"from neutron.db.models import segment as model"},{"line_number":34,"context_line":"from neutron.db import segments_db as db"},{"line_number":35,"context_line":"from neutron.extensions import segment as extension"},{"line_number":36,"context_line":"from neutron import manager"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_6705d578","line":33,"range":{"start_line":33,"start_character":41,"end_line":33,"end_character":46},"in_reply_to":"5a8bc5a2_130e203b","updated":"2016-09-23 19:13:37.000000000","message":"Done","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8762ebe1b99603edf7cb4039b296286c5078e4a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \"\"\"Map segment to a collection of hosts.\"\"\""},{"line_number":252,"context_line":"    with db_api.autonested_transaction(context.session):"},{"line_number":253,"context_line":"        for host in hosts:"},{"line_number":254,"context_line":"            context.session.add(seg_model.SegmentHostMapping("},{"line_number":255,"context_line":"                segment_id\u003dsegment_id,"},{"line_number":256,"context_line":"                host\u003dhost))"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def _update_segment_host_mapping_for_agent(resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_2ea4e506","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":27},"updated":"2016-09-28 13:42:34.000000000","message":"Nit: Is it just me or does this choice of line-splitting look awkward?\n\n    context.session.add(\n        seg_model.SegmentHostMapping(segment_id\u003dsegment_id,\n                                     host\u003dhost))\n\nIs that better? I don\u0027t know.","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"56a3fbda62ecf85f6007a8229ceba29997639c0c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \"\"\"Map segment to a collection of hosts.\"\"\""},{"line_number":252,"context_line":"    with db_api.autonested_transaction(context.session):"},{"line_number":253,"context_line":"        for host in hosts:"},{"line_number":254,"context_line":"            context.session.add(seg_model.SegmentHostMapping("},{"line_number":255,"context_line":"                segment_id\u003dsegment_id,"},{"line_number":256,"context_line":"                host\u003dhost))"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def _update_segment_host_mapping_for_agent(resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_257da9e7","line":256,"range":{"start_line":254,"start_character":0,"end_line":256,"end_character":27},"in_reply_to":"5a8bc5a2_2ea4e506","updated":"2016-09-29 15:15:16.000000000","message":"this is better.\nDone","commit_id":"a7e3734c663bfa3dd7b51f1961102c91755e2193"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75478d37f3604836a4bad55f5680df0e62d3b801","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.db import agents_db"},{"line_number":29,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":30,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":31,"context_line":"from neutron.db.models import segment as model"},{"line_number":32,"context_line":"from neutron.db import portbindings_db"},{"line_number":33,"context_line":"from neutron.db import segments_db"},{"line_number":34,"context_line":"from neutron.extensions import ip_allocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_5308a82c","line":31,"range":{"start_line":31,"start_character":41,"end_line":31,"end_character":46},"updated":"2016-09-23 16:14:52.000000000","message":"ditto","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e393b6b57e90528876961dcc067d6fafac44ff38","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.db import agents_db"},{"line_number":29,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":30,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":31,"context_line":"from neutron.db.models import segment as model"},{"line_number":32,"context_line":"from neutron.db import portbindings_db"},{"line_number":33,"context_line":"from neutron.db import segments_db"},{"line_number":34,"context_line":"from neutron.extensions import ip_allocation"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a8bc5a2_c702296f","line":31,"range":{"start_line":31,"start_character":41,"end_line":31,"end_character":46},"in_reply_to":"5a8bc5a2_5308a82c","updated":"2016-09-23 19:13:37.000000000","message":"Done","commit_id":"ed3a7be9d2fbadb203f4c345e10a6a008e58b7e4"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"a61f1fda58552da092c4693a8f29d9c2080c4783","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.db import agents_db"},{"line_number":29,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":30,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":31,"context_line":"from neutron.db.models import segment as seg_model"},{"line_number":32,"context_line":"from neutron.db import portbindings_db"},{"line_number":33,"context_line":"from neutron.db import segments_db"},{"line_number":34,"context_line":"from neutron.extensions import ip_allocation"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_c1b78484","line":31,"range":{"start_line":31,"start_character":41,"end_line":31,"end_character":50},"updated":"2016-09-29 20:59:20.000000000","message":"nit: It would be nice to have the import segment as segment_model instead of seg_model so that it\u0027s consistent across all files","commit_id":"9058ff24695fc9e7fd1477610bb01a5e03622e35"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"6b734cee6d4ad81c607db875c908fa4063c2edb3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.db import agents_db"},{"line_number":29,"context_line":"from neutron.db import agentschedulers_db"},{"line_number":30,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":31,"context_line":"from neutron.db.models import segment as seg_model"},{"line_number":32,"context_line":"from neutron.db import portbindings_db"},{"line_number":33,"context_line":"from neutron.db import segments_db"},{"line_number":34,"context_line":"from neutron.extensions import ip_allocation"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_19028a3d","line":31,"range":{"start_line":31,"start_character":41,"end_line":31,"end_character":50},"in_reply_to":"3a98d1f4_c1b78484","updated":"2016-09-30 17:59:04.000000000","message":"Done","commit_id":"9058ff24695fc9e7fd1477610bb01a5e03622e35"}]}