)]}'
{"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a0977e8caffcb131bdd62551e6b6fa79d6f63101","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            for tbl_index in tbl_index_list:"},{"line_number":245,"context_line":"                ip_device.route.add_gateway(gw_ip, table\u003dtbl_index)"},{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            ip_device.route.add_gateway(gw_ip, table\u003dtbl_index)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def update_gateway_port(self, agent_gateway_port, tbl_index\u003dNone):"},{"line_number":250,"context_line":"        ns_name \u003d self.get_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_2b02db3e","line":247,"range":{"start_line":247,"start_character":0,"end_line":247,"end_character":63},"updated":"2016-09-01 02:21:55.000000000","message":"I don\u0027t understand why this patch is needed. It looks like you set the floating_gateway ip as default route to every route table. So every network packet comes from fpr device will use this default route in different route table. What is the difference between just put the default route in main table? Anyway, they will go out to external network from the floating_gateway port.","commit_id":"7af5f03020e3fde2a51fd1a3f98fffbbc697dcda"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"89b4a0ecb72607bacfece3a0db7d50220d2bfd4f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            for tbl_index in tbl_index_list:"},{"line_number":245,"context_line":"                ip_device.route.add_gateway(gw_ip, table\u003dtbl_index)"},{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            ip_device.route.add_gateway(gw_ip, table\u003dtbl_index)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def update_gateway_port(self, agent_gateway_port, tbl_index\u003dNone):"},{"line_number":250,"context_line":"        ns_name \u003d self.get_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_262d7e46","line":247,"range":{"start_line":247,"start_character":0,"end_line":247,"end_character":63},"in_reply_to":"fa7ab95a_2b02db3e","updated":"2016-09-01 17:18:28.000000000","message":"The reason for this is to add the static next hop routes on a per router basis since this fip namespace is shared between tenants, we don\u0027t want to add all the staic routes to the global table.\nDoes this make sense.","commit_id":"7af5f03020e3fde2a51fd1a3f98fffbbc697dcda"}]}
