)]}'
{"neutron/services/auto_allocate/db.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0eb1204a2b17e903f371a8bf9d6dffe6c6dbffa1","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                          \"Reason: %(reason)s\"),"},{"line_number":318,"context_line":"                      {\u0027tenant_id\u0027: tenant_id, \u0027reason\u0027: e})"},{"line_number":319,"context_line":"            if router:"},{"line_number":320,"context_line":"                router_id \u003d router[\u0027id\u0027]"},{"line_number":321,"context_line":"            else:"},{"line_number":322,"context_line":"                router_id \u003d None"},{"line_number":323,"context_line":"            self._cleanup(context,"},{"line_number":324,"context_line":"                network_id\u003dsubnets[0][\u0027network_id\u0027],"},{"line_number":325,"context_line":"                router_id\u003drouter[\u0027id\u0027], subnets\u003dattached_subnets)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f05b6c2c","line":322,"range":{"start_line":320,"start_character":1,"end_line":322,"end_character":32},"updated":"2016-08-28 08:22:52.000000000","message":"You created `router_id` but you don\u0027t use it anywhere.","commit_id":"39311d1e084aeab166d8ef89fe817d09b091b3b7"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0eb1204a2b17e903f371a8bf9d6dffe6c6dbffa1","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                router_id \u003d None"},{"line_number":323,"context_line":"            self._cleanup(context,"},{"line_number":324,"context_line":"                network_id\u003dsubnets[0][\u0027network_id\u0027],"},{"line_number":325,"context_line":"                router_id\u003drouter[\u0027id\u0027], subnets\u003dattached_subnets)"},{"line_number":326,"context_line":"            raise exceptions.AutoAllocationFailure("},{"line_number":327,"context_line":"                reason\u003d_(\"Unable to provide external connectivity\"))"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_303eb4b8","line":325,"range":{"start_line":325,"start_character":26,"end_line":325,"end_character":38},"updated":"2016-08-28 08:22:52.000000000","message":"I believe, router_id should be included here.","commit_id":"39311d1e084aeab166d8ef89fe817d09b091b3b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"afe76543e927c34a8bd73f549adc6ac7d1692ab5","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                router_id \u003d None"},{"line_number":323,"context_line":"            self._cleanup(context,"},{"line_number":324,"context_line":"                network_id\u003dsubnets[0][\u0027network_id\u0027],"},{"line_number":325,"context_line":"                router_id\u003drouter[\u0027id\u0027], subnets\u003dattached_subnets)"},{"line_number":326,"context_line":"            raise exceptions.AutoAllocationFailure("},{"line_number":327,"context_line":"                reason\u003d_(\"Unable to provide external connectivity\"))"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b009e4df","line":325,"range":{"start_line":325,"start_character":26,"end_line":325,"end_character":38},"in_reply_to":"fa7ab95a_303eb4b8","updated":"2016-08-28 08:44:03.000000000","message":"correct. my bad.","commit_id":"39311d1e084aeab166d8ef89fe817d09b091b3b7"}],"neutron/tests/unit/services/auto_allocate/test_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"628f3bd3ca8f1c2745e8104afac47526a0ecfe41","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test__provision_external_connectivity_fail_expected_cleanup(self):"},{"line_number":55,"context_line":"        \"\"\"Test that the right resources are cleaned up.\"\"\""},{"line_number":56,"context_line":"        subnets \u003d ["},{"line_number":57,"context_line":"            {\u0027id\u0027: \u0027subnet_foo_1\u0027, \u0027network_id\u0027: \u0027network_foo\u0027},"},{"line_number":58,"context_line":"            {\u0027id\u0027: \u0027subnet_foo_2\u0027, \u0027network_id\u0027: \u0027network_foo\u0027},"},{"line_number":59,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_1aa99f24","line":56,"updated":"2016-08-29 15:31:45.000000000","message":"the definition should be unnecessary if you are meant to fail at router creation. I think you can replace them with mock.ANY at line 65, and this would make this test a little less alike the previous one.","commit_id":"9f88641562030f2fe64777072f91941dc5ccc32f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ba49e846296be624e425ddc258959071f69da0b3","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test__provision_external_connectivity_fail_expected_cleanup(self):"},{"line_number":55,"context_line":"        \"\"\"Test that the right resources are cleaned up.\"\"\""},{"line_number":56,"context_line":"        subnets \u003d ["},{"line_number":57,"context_line":"            {\u0027id\u0027: \u0027subnet_foo_1\u0027, \u0027network_id\u0027: \u0027network_foo\u0027},"},{"line_number":58,"context_line":"            {\u0027id\u0027: \u0027subnet_foo_2\u0027, \u0027network_id\u0027: \u0027network_foo\u0027},"},{"line_number":59,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_b5ea84aa","line":56,"in_reply_to":"fa7ab95a_1aa99f24","updated":"2016-08-29 15:41:52.000000000","message":"The method requires subnets. The reason for this is that the retrieval of the network_id is done via accessing the subnets. So we still need this. To change the tests I have deleted one.","commit_id":"9f88641562030f2fe64777072f91941dc5ccc32f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"628f3bd3ca8f1c2745e8104afac47526a0ecfe41","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertRaises(exceptions.AutoAllocationFailure,"},{"line_number":64,"context_line":"                self.mixin._provision_external_connectivity,"},{"line_number":65,"context_line":"                self.ctx, \u0027ext_net_foo\u0027, subnets, \u0027tenant_foo\u0027)"},{"line_number":66,"context_line":"            # expect no subnets to be unplugged"},{"line_number":67,"context_line":"            mock_cleanup.assert_called_once_with("},{"line_number":68,"context_line":"                self.ctx, network_id\u003d\u0027network_foo\u0027,"},{"line_number":69,"context_line":"                router_id\u003dNone, subnets\u003d[])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_3a54a31f","line":66,"updated":"2016-08-29 15:31:45.000000000","message":"This assert is not about no subnets to be unplugged by about the network being cleaned up. Consider replacing the comment.","commit_id":"9f88641562030f2fe64777072f91941dc5ccc32f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ba49e846296be624e425ddc258959071f69da0b3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.assertRaises(exceptions.AutoAllocationFailure,"},{"line_number":64,"context_line":"                self.mixin._provision_external_connectivity,"},{"line_number":65,"context_line":"                self.ctx, \u0027ext_net_foo\u0027, subnets, \u0027tenant_foo\u0027)"},{"line_number":66,"context_line":"            # expect no subnets to be unplugged"},{"line_number":67,"context_line":"            mock_cleanup.assert_called_once_with("},{"line_number":68,"context_line":"                self.ctx, network_id\u003d\u0027network_foo\u0027,"},{"line_number":69,"context_line":"                router_id\u003dNone, subnets\u003d[])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_15da5017","line":66,"in_reply_to":"fa7ab95a_3a54a31f","updated":"2016-08-29 15:41:52.000000000","message":"Done","commit_id":"9f88641562030f2fe64777072f91941dc5ccc32f"}]}
