)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b750f52f8dc995454aad8739be94151a611872a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bindings of the callbacks. The callbacks do not need to be"},{"line_number":11,"context_line":"bound if the variable is not set."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will save needless function calls."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TrivialFix"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_273ac7cc","line":13,"updated":"2016-08-29 15:43:46.000000000","message":"Commit 877778e preserved the existing logic where the dhcp notification methods were called all the way up to the point where they hit the config option; that seemed the least invasive change. The needless function calls have always been there :)","commit_id":"cd878c8d50a979a285550b5cb0052c45db5ec998"}],"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5f0f80991bdf739c7f3f5c932a73e3c056e98ab2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           resources.ROUTER_INTERFACE, events.AFTER_CREATE)"},{"line_number":61,"context_line":"        registry.subscribe(self._after_router_interface_deleted,"},{"line_number":62,"context_line":"                           resources.ROUTER_INTERFACE, events.AFTER_DELETE)"},{"line_number":63,"context_line":"        if cfg.CONF.dhcp_agent_notification:"},{"line_number":64,"context_line":"            # register callbacks for events pertaining resources affecting DHCP"},{"line_number":65,"context_line":"            callback_resources \u003d ("},{"line_number":66,"context_line":"                resources.NETWORK,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_950ae077","line":63,"updated":"2016-08-29 15:38:58.000000000","message":"Kevin has a somewhat overlapping \u0027fix\u0027 [1]. Rather than worrying about the no-op, we should figure out a way to kill this silly config option altogether by making this smart enough to know when it\u0027s meant to be used.\n\n[1] https://review.openstack.org/#/c/355117/1","commit_id":"cd878c8d50a979a285550b5cb0052c45db5ec998"}]}
