)]}'
{"etc/quantum/plugins/ryu/ryu.ini":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"# This line MUST be changed to actually run the plugin."},{"line_number":3,"context_line":"# Example: sql_connection \u003d mysql://root:nova@127.0.0.1:3306/ovs_quantum"},{"line_number":4,"context_line":"#sql_connection \u003d mysql://\u003cuser\u003e:\u003cpass\u003e@\u003cIP\u003e:\u003cport\u003e/\u003cdbname\u003e"},{"line_number":5,"context_line":"sql_connection \u003d sqlite://"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAEn%2F%2F5rg%3D","line":3,"updated":"2012-02-17 07:09:01.000000000","message":"consider using a different database name, like ryu_quantum","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"# This line MUST be changed to actually run the plugin."},{"line_number":3,"context_line":"# Example: sql_connection \u003d mysql://root:nova@127.0.0.1:3306/ovs_quantum"},{"line_number":4,"context_line":"#sql_connection \u003d mysql://\u003cuser\u003e:\u003cpass\u003e@\u003cIP\u003e:\u003cport\u003e/\u003cdbname\u003e"},{"line_number":5,"context_line":"sql_connection \u003d sqlite://"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAEn%2F%2F5nY%3D","line":3,"in_reply_to":"AAAAEn%2F%2F5rg%3D","updated":"2012-02-17 07:51:11.000000000","message":"Done","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"}],"quantum/db/api.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def network_all_tenant_list():"},{"line_number":95,"context_line":"    session \u003d get_session()"},{"line_number":96,"context_line":"    return session.query(models.Network).\\"},{"line_number":97,"context_line":"      all()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F37Y%3D","line":96,"updated":"2012-02-22 03:11:17.000000000","message":"Avoid backslashes for line continuation.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def network_all_tenant_list():"},{"line_number":95,"context_line":"    session \u003d get_session()"},{"line_number":96,"context_line":"    return session.query(models.Network).\\"},{"line_number":97,"context_line":"      all()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F35I%3D","line":96,"in_reply_to":"AAAAEn%2F%2F37Y%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"quantum/plugins/ryu/README":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This directory inclues quantum plugin for Ryu Netowrk Operating System."},{"line_number":4,"context_line":"For details (including how to install this plugin), please refer to"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAEn%2F%2F4%2B4%3D","line":1,"updated":"2012-02-18 11:10:15.000000000","message":"This file should possibly contain more information on how to run Ryu in Quantum, as this is the file plugin users would read in order to understand how to configure the plugin.\n\nFor instance, an information which might be very useful would be how to configure the sql connection (which currently is in ryu.ini)","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This directory inclues quantum plugin for Ryu Netowrk Operating System."},{"line_number":4,"context_line":"For details (including how to install this plugin), please refer to"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAEn%2F%2F40g%3D","line":1,"in_reply_to":"AAAAEn%2F%2F4%2B4%3D","updated":"2012-02-20 07:42:00.000000000","message":"I think the following URL covers what you want. So I added the link explicitly.\nhttp://www.osrg.net/ryu/using_with_openstack.html","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":"This directory inclues quantum plugin for Ryu Netowrk Operating System."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# -- Installation"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F4AA%3D","line":1,"updated":"2012-02-22 03:11:17.000000000","message":"Netowrk \u003d\u003e Network","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":"This directory inclues quantum plugin for Ryu Netowrk Operating System."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# -- Installation"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F35E%3D","line":1,"in_reply_to":"AAAAEn%2F%2F4AA%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":"This directory inclues quantum plugin for Ryu Netowrk Operating System."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# -- Installation"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F4AQ%3D","line":2,"updated":"2012-02-22 03:11:17.000000000","message":"inclues \u003d\u003e includes\n\nNetowrk \u003d\u003e Network","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":"This directory inclues quantum plugin for Ryu Netowrk Operating System."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# -- Installation"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F35A%3D","line":2,"in_reply_to":"AAAAEn%2F%2F4AQ%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":"This directory includes quantum plugin for Ryu Network Operating System."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# -- Installation"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAEn%2F%2F3f4%3D","line":1,"updated":"2012-02-22 20:04:01.000000000","message":"Netowrk \u003d\u003e Network","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Quantum plugin for Ryu Netowrk Operating System"},{"line_number":2,"context_line":"This directory includes quantum plugin for Ryu Network Operating System."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# -- Installation"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAEn%2F%2F28c%3D","line":1,"in_reply_to":"AAAAEn%2F%2F3f4%3D","updated":"2012-02-23 06:14:08.000000000","message":"Done","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"}],"quantum/plugins/ryu/agent/ryu_quantum_agent.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#    under the License."},{"line_number":21,"context_line":"# @author: Somik Behera, Nicira Networks, Inc."},{"line_number":22,"context_line":"# @author: Brad Hall, Nicira Networks, Inc."},{"line_number":23,"context_line":"# @author: Dan Wendlandt, Nicira Networks, Inc."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import ConfigParser"},{"line_number":26,"context_line":"import logging as LOG"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5rc%3D","line":23,"updated":"2012-02-17 07:09:01.000000000","message":"consider adding yourself as an author and removing existing authors, as they won\u0027t be maintaining this file moving forward.  May be worth instead adding a comment that this code is based on the ovs_plugin_agent.","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"#    under the License."},{"line_number":21,"context_line":"# @author: Somik Behera, Nicira Networks, Inc."},{"line_number":22,"context_line":"# @author: Brad Hall, Nicira Networks, Inc."},{"line_number":23,"context_line":"# @author: Dan Wendlandt, Nicira Networks, Inc."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import ConfigParser"},{"line_number":26,"context_line":"import logging as LOG"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5nU%3D","line":23,"in_reply_to":"AAAAEn%2F%2F5rc%3D","updated":"2012-02-17 07:51:11.000000000","message":"Done","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          \", ofport\u003d\" + self.ofport + \", bridge name \u003d \" + self.switch.br_name"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class OVSBridge:"},{"line_number":60,"context_line":"    def __init__(self, br_name):"},{"line_number":61,"context_line":"        self.br_name \u003d br_name"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5rY%3D","line":59,"updated":"2012-02-17 07:09:01.000000000","message":"I\u0027m hoping we can refactor this class out as we were originally hoping to.  Figuring out how this works with packaging though will take a while, so having a local copy here is OK for now.","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"from subprocess import *"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from ryu.app.client import OFPClient"},{"line_number":35,"context_line":"from ryu.app import rest_nw_id"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"OP_STATUS_UP \u003d \"UP\""},{"line_number":38,"context_line":"OP_STATUS_DOWN \u003d \"DOWN\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BI%3D","line":35,"updated":"2012-02-18 11:10:15.000000000","message":"I guess this from 3rd party software, possibly from the ryu controller.\nPlease state how to configure the agent and install the ryu controller packages in the README file. Per-hypervisor information would be more than welcome.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":54,"context_line":"          \", ofport\u003d\" + self.ofport + \", bridge name \u003d \" + self.switch.br_name"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class OVSBridge:"},{"line_number":58,"context_line":"    def __init__(self, br_name):"},{"line_number":59,"context_line":"        self.br_name \u003d br_name"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BA%3D","line":57,"updated":"2012-02-18 11:10:15.000000000","message":"Several methods in this class (such as add_flow), appear not to be used. Is this because this class was ported from the Open vSwitch plugin. \nI know it has been decided to not have a common framework for the two plugin, and I respect that decision.\nThe only point worth making here is that maybe the code for the Ryu plugin agent can be simplified if it turns out that most of the code of OVSBridge class is not needed for this plugin.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":54,"context_line":"          \", ofport\u003d\" + self.ofport + \", bridge name \u003d \" + self.switch.br_name"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class OVSBridge:"},{"line_number":58,"context_line":"    def __init__(self, br_name):"},{"line_number":59,"context_line":"        self.br_name \u003d br_name"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F41A%3D","line":57,"in_reply_to":"AAAAEn%2F%2F4%2BA%3D","updated":"2012-02-20 07:42:00.000000000","message":"I eliminated unused methods.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.datapath_id \u003d r.strip()[1:-1]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def run_cmd(self, args):"},{"line_number":69,"context_line":"        # LOG.debug(\"## running command: \" + \" \".join(args))"},{"line_number":70,"context_line":"        p \u003d Popen(args, stdout\u003dPIPE)"},{"line_number":71,"context_line":"        retval \u003d p.communicate()[0]"},{"line_number":72,"context_line":"        if p.returncode \u003d\u003d -(signal.SIGALRM):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BE%3D","line":69,"updated":"2012-02-18 11:10:15.000000000","message":"Please remove commented lines of code","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.datapath_id \u003d r.strip()[1:-1]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def run_cmd(self, args):"},{"line_number":69,"context_line":"        # LOG.debug(\"## running command: \" + \" \".join(args))"},{"line_number":70,"context_line":"        p \u003d Popen(args, stdout\u003dPIPE)"},{"line_number":71,"context_line":"        retval \u003d p.communicate()[0]"},{"line_number":72,"context_line":"        if p.returncode \u003d\u003d -(signal.SIGALRM):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F41E%3D","line":69,"in_reply_to":"AAAAEn%2F%2F4%2BE%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#    under the License."},{"line_number":21,"context_line":"# @author: Isaku Yamahata"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import ConfigParser"},{"line_number":24,"context_line":"import logging as LOG"},{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2F8%3D","line":23,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8  standardize formatting of imports","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"OP_STATUS_DOWN \u003d \"DOWN\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# A class to represent a VIF (i.e., a port that has \u0027iface-id\u0027 and \u0027vif-mac\u0027"},{"line_number":43,"context_line":"# attributes set)."},{"line_number":44,"context_line":"class VifPort:"},{"line_number":45,"context_line":"    def __init__(self, port_name, ofport, vif_id, vif_mac, switch):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2F4%3D","line":42,"updated":"2012-02-22 03:11:17.000000000","message":"Please prefer docstrings to comments for class documentation.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":39,"context_line":"OP_STATUS_DOWN \u003d \"DOWN\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# A class to represent a VIF (i.e., a port that has \u0027iface-id\u0027 and \u0027vif-mac\u0027"},{"line_number":43,"context_line":"# attributes set)."},{"line_number":44,"context_line":"class VifPort:"},{"line_number":45,"context_line":"    def __init__(self, port_name, ofport, vif_id, vif_mac, switch):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F344%3D","line":42,"in_reply_to":"AAAAEn%2F%2F3%2F4%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.switch \u003d switch"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __str__(self):"},{"line_number":53,"context_line":"        return \"iface-id\u003d\" + self.vif_id + \", vif_mac\u003d\" + \\"},{"line_number":54,"context_line":"          self.vif_mac + \", port_name\u003d\" + self.port_name + \\"},{"line_number":55,"context_line":"          \", ofport\u003d\" + self.ofport + \", bridge name \u003d \" + self.switch.br_name"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2F0%3D","line":53,"updated":"2012-02-22 03:11:17.000000000","message":"Please prefer string formatting to concatenation.\n\nPlease prefer parenthesis to backslashes for line continuation.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.switch \u003d switch"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __str__(self):"},{"line_number":53,"context_line":"        return \"iface-id\u003d\" + self.vif_id + \", vif_mac\u003d\" + \\"},{"line_number":54,"context_line":"          self.vif_mac + \", port_name\u003d\" + self.port_name + \\"},{"line_number":55,"context_line":"          \", ofport\u003d\" + self.ofport + \", bridge name \u003d \" + self.switch.br_name"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F340%3D","line":53,"in_reply_to":"AAAAEn%2F%2F3%2F0%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        r \u003d self.run_vsctl([\"get\", \"Bridge\", self.br_name, \"datapath_id\"])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # remove preceding/trailing double quotes"},{"line_number":68,"context_line":"        dp_id \u003d r.strip()"},{"line_number":69,"context_line":"        if dp_id[0] \u003d\u003d \u0027\"\u0027:"},{"line_number":70,"context_line":"            dp_id \u003d dp_id[1:]"},{"line_number":71,"context_line":"        if dp_id[-1] \u003d\u003d \u0027\"\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Fw%3D","line":68,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using strip to remove the double quotes as well: r.strip(\u0027\" \u0027)","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"        r \u003d self.run_vsctl([\"get\", \"Bridge\", self.br_name, \"datapath_id\"])"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # remove preceding/trailing double quotes"},{"line_number":68,"context_line":"        dp_id \u003d r.strip()"},{"line_number":69,"context_line":"        if dp_id[0] \u003d\u003d \u0027\"\u0027:"},{"line_number":70,"context_line":"            dp_id \u003d dp_id[1:]"},{"line_number":71,"context_line":"        if dp_id[-1] \u003d\u003d \u0027\"\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34w%3D","line":68,"in_reply_to":"AAAAEn%2F%2F3%2Fw%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.run_vsctl([\"set-controller\", self.br_name, target])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def db_get_map(self, table, record, column):"},{"line_number":94,"context_line":"        str \u003d self.run_vsctl([\"get\", table, record, column]).rstrip(\"\\n\\r\")"},{"line_number":95,"context_line":"        return self.db_str_to_map(str)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def db_get_val(self, table, record, column):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Fs%3D","line":94,"updated":"2012-02-22 03:11:17.000000000","message":"Please do not override builtin functions (str in this case).  At the least, suffix the builtin name with an underscore (str_).","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.run_vsctl([\"set-controller\", self.br_name, target])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def db_get_map(self, table, record, column):"},{"line_number":94,"context_line":"        str \u003d self.run_vsctl([\"get\", table, record, column]).rstrip(\"\\n\\r\")"},{"line_number":95,"context_line":"        return self.db_str_to_map(str)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def db_get_val(self, table, record, column):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34s%3D","line":94,"in_reply_to":"AAAAEn%2F%2F3%2Fs%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def get_port_name_list(self):"},{"line_number":112,"context_line":"        res \u003d self.run_vsctl([\"list-ports\", self.br_name])"},{"line_number":113,"context_line":"        return res.split(\"\\n\")[0:-1]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_xapi_iface_id(self, xs_vif_uuid):"},{"line_number":116,"context_line":"        return self.run_cmd("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Fo%3D","line":113,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using [:-1] since the first argument to a slice operation defaults to 0.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def get_port_name_list(self):"},{"line_number":112,"context_line":"        res \u003d self.run_vsctl([\"list-ports\", self.br_name])"},{"line_number":113,"context_line":"        return res.split(\"\\n\")[0:-1]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_xapi_iface_id(self, xs_vif_uuid):"},{"line_number":116,"context_line":"        return self.run_cmd("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34o%3D","line":113,"in_reply_to":"AAAAEn%2F%2F3%2Fo%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        port_names \u003d self.get_port_name_list()"},{"line_number":131,"context_line":"        for name in port_names:"},{"line_number":132,"context_line":"            port \u003d get_port(name)"},{"line_number":133,"context_line":"            if port is not None:"},{"line_number":134,"context_line":"                ports.append(port)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Fk%3D","line":133,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using implicit boolean conversion.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"        port_names \u003d self.get_port_name_list()"},{"line_number":131,"context_line":"        for name in port_names:"},{"line_number":132,"context_line":"            port \u003d get_port(name)"},{"line_number":133,"context_line":"            if port is not None:"},{"line_number":134,"context_line":"                ports.append(port)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34k%3D","line":133,"in_reply_to":"AAAAEn%2F%2F3%2Fk%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # returns a VIF object for each VIF port"},{"line_number":139,"context_line":"    def get_vif_ports(self):"},{"line_number":140,"context_line":"        def _get_vif_port(name):"},{"line_number":141,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":142,"context_line":"            if \"iface-id\" in external_ids and \"attached-mac\" in external_ids:"},{"line_number":143,"context_line":"                return self._vifport(name, external_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Fc%3D","line":140,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider defining this inline function as a top-level private method.  Inline functions can\u0027t be directly tested.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # returns a VIF object for each VIF port"},{"line_number":139,"context_line":"    def get_vif_ports(self):"},{"line_number":140,"context_line":"        def _get_vif_port(name):"},{"line_number":141,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":142,"context_line":"            if \"iface-id\" in external_ids and \"attached-mac\" in external_ids:"},{"line_number":143,"context_line":"                return self._vifport(name, external_ids)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34g%3D","line":140,"in_reply_to":"AAAAEn%2F%2F3%2Fc%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":142,"context_line":"            if \"iface-id\" in external_ids and \"attached-mac\" in external_ids:"},{"line_number":143,"context_line":"                return self._vifport(name, external_ids)"},{"line_number":144,"context_line":"            elif \"xs-vif-uuid\" in external_ids and \\"},{"line_number":145,"context_line":"                 \"attached-mac\" in external_ids:"},{"line_number":146,"context_line":"                # if this is a xenserver and iface-id is not automatically"},{"line_number":147,"context_line":"                # synced to OVS from XAPI, we grab it from XAPI directly"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2FY%3D","line":144,"updated":"2012-02-22 03:11:17.000000000","message":"Prefer parenthesis to backslashes for line continuation.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":141,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":142,"context_line":"            if \"iface-id\" in external_ids and \"attached-mac\" in external_ids:"},{"line_number":143,"context_line":"                return self._vifport(name, external_ids)"},{"line_number":144,"context_line":"            elif \"xs-vif-uuid\" in external_ids and \\"},{"line_number":145,"context_line":"                 \"attached-mac\" in external_ids:"},{"line_number":146,"context_line":"                # if this is a xenserver and iface-id is not automatically"},{"line_number":147,"context_line":"                # synced to OVS from XAPI, we grab it from XAPI directly"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34c%3D","line":144,"in_reply_to":"AAAAEn%2F%2F3%2FY%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                return VifPort(name, ofport, iface_id,"},{"line_number":151,"context_line":"                               external_ids[\"attached-mac\"], self)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            return None"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return self._get_ports(_get_vif_port)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2FU%3D","line":153,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using just \u0027return\u0027 instead - None is implied.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":150,"context_line":"                return VifPort(name, ofport, iface_id,"},{"line_number":151,"context_line":"                               external_ids[\"attached-mac\"], self)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            return None"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        return self._get_ports(_get_vif_port)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34Y%3D","line":153,"in_reply_to":"AAAAEn%2F%2F3%2FU%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return self._get_ports(_get_vif_port)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_external_ports(self):"},{"line_number":158,"context_line":"        def _get_external_port(name):"},{"line_number":159,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":160,"context_line":"            if external_ids:"},{"line_number":161,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2FM%3D","line":158,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider defining this inline function as a top-level private method.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return self._get_ports(_get_vif_port)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def get_external_ports(self):"},{"line_number":158,"context_line":"        def _get_external_port(name):"},{"line_number":159,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":160,"context_line":"            if external_ids:"},{"line_number":161,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34U%3D","line":158,"in_reply_to":"AAAAEn%2F%2F3%2FM%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        def _get_external_port(name):"},{"line_number":159,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":160,"context_line":"            if external_ids:"},{"line_number":161,"context_line":"                return None"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            ofport \u003d self.db_get_val(\"Interface\", name, \"ofport\")"},{"line_number":164,"context_line":"            return VifPort(name, ofport, None, None, self)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2FQ%3D","line":161,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using just \u0027return\u0027 instead","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"        def _get_external_port(name):"},{"line_number":159,"context_line":"            external_ids \u003d self.db_get_map(\"Interface\", name, \"external_ids\")"},{"line_number":160,"context_line":"            if external_ids:"},{"line_number":161,"context_line":"                return None"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            ofport \u003d self.db_get_val(\"Interface\", name, \"ofport\")"},{"line_number":164,"context_line":"            return VifPort(name, ofport, None, None, self)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34Q%3D","line":161,"in_reply_to":"AAAAEn%2F%2F3%2FQ%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":195,"context_line":"class OVSQuantumOFPRyuAgent:"},{"line_number":196,"context_line":"    def __init__(self, integ_br, db):"},{"line_number":197,"context_line":"        ret \u003d check_ofp_mode(db)"},{"line_number":198,"context_line":"        assert ret"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        (ofp_controller_addr, ofp_rest_api_addr) \u003d ret"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2FI%3D","line":198,"updated":"2012-02-22 03:11:17.000000000","message":"Avoid asserts in non-test code.  An explicit exception with a reasonable message is much preferable.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":195,"context_line":"class OVSQuantumOFPRyuAgent:"},{"line_number":196,"context_line":"    def __init__(self, integ_br, db):"},{"line_number":197,"context_line":"        ret \u003d check_ofp_mode(db)"},{"line_number":198,"context_line":"        assert ret"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        (ofp_controller_addr, ofp_rest_api_addr) \u003d ret"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34I%3D","line":198,"in_reply_to":"AAAAEn%2F%2F3%2FI%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def _all_bindings(self, db):"},{"line_number":217,"context_line":"        \"\"\"return interface id -\u003e port which include network id bindings\"\"\""},{"line_number":218,"context_line":"        all_ports \u003d db.ports.all()"},{"line_number":219,"context_line":"        all_bindings \u003d {}"},{"line_number":220,"context_line":"        for port in all_ports:"},{"line_number":221,"context_line":"            all_bindings[port.interface_id] \u003d port"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2FE%3D","line":218,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using a generator to convert this method into a one-liner:\n\nreturn dict((port.interface_id, port) for port in db.ports.all())","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def _all_bindings(self, db):"},{"line_number":217,"context_line":"        \"\"\"return interface id -\u003e port which include network id bindings\"\"\""},{"line_number":218,"context_line":"        all_ports \u003d db.ports.all()"},{"line_number":219,"context_line":"        all_bindings \u003d {}"},{"line_number":220,"context_line":"        for port in all_ports:"},{"line_number":221,"context_line":"            all_bindings[port.interface_id] \u003d port"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34E%3D","line":218,"in_reply_to":"AAAAEn%2F%2F3%2FE%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        local_bindings \u003d {}"},{"line_number":230,"context_line":"        vif_ports \u003d {}"},{"line_number":231,"context_line":"        for p in self.int_br.get_vif_ports():"},{"line_number":232,"context_line":"            vif_ports[p.vif_id] \u003d p"},{"line_number":233,"context_line":"            if p.vif_id in all_bindings:"},{"line_number":234,"context_line":"                net_id \u003d all_bindings[p.vif_id].network_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Bk%3D","line":231,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using a more descriptive variable name (say, port).  Single-letter names are generally only used for index variables.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        local_bindings \u003d {}"},{"line_number":230,"context_line":"        vif_ports \u003d {}"},{"line_number":231,"context_line":"        for p in self.int_br.get_vif_ports():"},{"line_number":232,"context_line":"            vif_ports[p.vif_id] \u003d p"},{"line_number":233,"context_line":"            if p.vif_id in all_bindings:"},{"line_number":234,"context_line":"                net_id \u003d all_bindings[p.vif_id].network_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F34A%3D","line":231,"in_reply_to":"AAAAEn%2F%2F3%2Bk%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        old_local_bindings \u003d local_bindings"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        while True:"},{"line_number":246,"context_line":"            time.sleep(2)"},{"line_number":247,"context_line":"            all_bindings \u003d self._all_bindings(db)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            new_vif_ports \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2B8%3D","line":246,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - is there a good reason for an initial delay in loop processing?  If not, consider moving the sleep() call to the end of the loop.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":243,"context_line":"        old_local_bindings \u003d local_bindings"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        while True:"},{"line_number":246,"context_line":"            time.sleep(2)"},{"line_number":247,"context_line":"            all_bindings \u003d self._all_bindings(db)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            new_vif_ports \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F338%3D","line":246,"in_reply_to":"AAAAEn%2F%2F3%2B8%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                    net_id \u003d all_bindings[p.vif_id].network_id"},{"line_number":255,"context_line":"                    new_local_bindings[p.vif_id] \u003d net_id"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"                old_b \u003d old_local_bindings.get(p.vif_id, None)"},{"line_number":258,"context_line":"                new_b \u003d new_local_bindings.get(p.vif_id, None)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"                if old_b !\u003d new_b:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2B0%3D","line":257,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider omitting None as the default value for dict.get().","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":254,"context_line":"                    net_id \u003d all_bindings[p.vif_id].network_id"},{"line_number":255,"context_line":"                    new_local_bindings[p.vif_id] \u003d net_id"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"                old_b \u003d old_local_bindings.get(p.vif_id, None)"},{"line_number":258,"context_line":"                new_b \u003d new_local_bindings.get(p.vif_id, None)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"                if old_b !\u003d new_b:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F334%3D","line":257,"in_reply_to":"AAAAEn%2F%2F3%2B0%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                new_b \u003d new_local_bindings.get(p.vif_id, None)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"                if old_b !\u003d new_b:"},{"line_number":261,"context_line":"                    if old_b is not None:"},{"line_number":262,"context_line":"                        LOG.info(\"Removing binding to net-id \u003d %s for %s\","},{"line_number":263,"context_line":"                                 old_b, str(p))"},{"line_number":264,"context_line":"                        if p.vif_id in all_bindings:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Bw%3D","line":261,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using implicit boolean conversion.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":258,"context_line":"                new_b \u003d new_local_bindings.get(p.vif_id, None)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"                if old_b !\u003d new_b:"},{"line_number":261,"context_line":"                    if old_b is not None:"},{"line_number":262,"context_line":"                        LOG.info(\"Removing binding to net-id \u003d %s for %s\","},{"line_number":263,"context_line":"                                 old_b, str(p))"},{"line_number":264,"context_line":"                        if p.vif_id in all_bindings:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F330%3D","line":261,"in_reply_to":"AAAAEn%2F%2F3%2Bw%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                        LOG.info(\"Adding binding to net-id \u003d %s for %s\","},{"line_number":270,"context_line":"                                 new_b, str(p))"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            for vif_id in old_vif_ports.keys():"},{"line_number":273,"context_line":"                if vif_id not in new_vif_ports:"},{"line_number":274,"context_line":"                    LOG.info(\"Port Disappeared: %s\", vif_id)"},{"line_number":275,"context_line":"                    if vif_id in all_bindings:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Bo%3D","line":272,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider simplifying to use implicit iteration over a dictionary\u0027s keys:\n\nif vif_id in old_vif_ports:\n  pass","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":269,"context_line":"                        LOG.info(\"Adding binding to net-id \u003d %s for %s\","},{"line_number":270,"context_line":"                                 new_b, str(p))"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            for vif_id in old_vif_ports.keys():"},{"line_number":273,"context_line":"                if vif_id not in new_vif_ports:"},{"line_number":274,"context_line":"                    LOG.info(\"Port Disappeared: %s\", vif_id)"},{"line_number":275,"context_line":"                    if vif_id in all_bindings:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33w%3D","line":272,"in_reply_to":"AAAAEn%2F%2F3%2Bo%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        port_names \u003d self.get_port_name_list()"},{"line_number":131,"context_line":"        for name in port_names:"},{"line_number":132,"context_line":"            port \u003d get_port(name)"},{"line_number":133,"context_line":"            if not port:"},{"line_number":134,"context_line":"                ports.append(port)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F3fQ%3D","line":133,"updated":"2012-02-22 20:04:01.000000000","message":"\u0027port is not None\u0027 \u003d\u003e \u0027port\u0027, not \u0027not port\u0027.","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"        port_names \u003d self.get_port_name_list()"},{"line_number":131,"context_line":"        for name in port_names:"},{"line_number":132,"context_line":"            port \u003d get_port(name)"},{"line_number":133,"context_line":"            if not port:"},{"line_number":134,"context_line":"                ports.append(port)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        return ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F28w%3D","line":133,"in_reply_to":"AAAAEn%2F%2F3fQ%3D","updated":"2012-02-23 06:14:08.000000000","message":"Done","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            iface_id \u003d self.get_xapi_iface_id(external_ids[\"xs-vif-uuid\"])"},{"line_number":148,"context_line":"            return VifPort(name, ofport, iface_id,"},{"line_number":149,"context_line":"                           external_ids[\"attached-mac\"], self)"},{"line_number":150,"context_line":"        return"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_vif_ports(self):"},{"line_number":153,"context_line":"        \"returns a VIF object for each VIF port\""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F3e0%3D","line":150,"updated":"2012-02-22 20:04:01.000000000","message":"My apologies, my original suggestion was in error.  It is preferable to simply omit empty return statements at the end of a function.","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":"            iface_id \u003d self.get_xapi_iface_id(external_ids[\"xs-vif-uuid\"])"},{"line_number":148,"context_line":"            return VifPort(name, ofport, iface_id,"},{"line_number":149,"context_line":"                           external_ids[\"attached-mac\"], self)"},{"line_number":150,"context_line":"        return"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_vif_ports(self):"},{"line_number":153,"context_line":"        \"returns a VIF object for each VIF port\""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F28s%3D","line":150,"in_reply_to":"AAAAEn%2F%2F3e0%3D","updated":"2012-02-23 06:14:08.000000000","message":"Done","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _all_bindings(self, db):"},{"line_number":212,"context_line":"        \"\"\"return interface id -\u003e port which include network id bindings\"\"\""},{"line_number":213,"context_line":"        return dict([(port.interface_id, port) for port in db.ports.all()])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def daemon_loop(self, db):"},{"line_number":216,"context_line":"        # on startup, register all existing ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F3ec%3D","line":213,"updated":"2012-02-22 20:04:01.000000000","message":"The square brackets (denoting a list comprehension) are not required here - a generator works just as well.\n\ndict([(x,x) for x in foo]) \u003d\u003d dict((x,x) for x in foo)","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _all_bindings(self, db):"},{"line_number":212,"context_line":"        \"\"\"return interface id -\u003e port which include network id bindings\"\"\""},{"line_number":213,"context_line":"        return dict([(port.interface_id, port) for port in db.ports.all()])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def daemon_loop(self, db):"},{"line_number":216,"context_line":"        # on startup, register all existing ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F28o%3D","line":213,"in_reply_to":"AAAAEn%2F%2F3ec%3D","updated":"2012-02-23 06:14:08.000000000","message":"Done","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"                old_b \u003d old_local_bindings.get(port.vif_id)"},{"line_number":247,"context_line":"                new_b \u003d new_local_bindings.get(port.vif_id)"},{"line_number":248,"context_line":"                if old_b \u003d\u003d new_b:"},{"line_number":249,"context_line":"                    continue"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"                if not old_b:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F3eI%3D","line":248,"updated":"2012-02-22 20:04:01.000000000","message":"What if old_b \u003d\u003d new_b \u003d\u003d None?  Is it desirable to skip the subsequent checks?","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"                old_b \u003d old_local_bindings.get(port.vif_id)"},{"line_number":247,"context_line":"                new_b \u003d new_local_bindings.get(port.vif_id)"},{"line_number":248,"context_line":"                if old_b \u003d\u003d new_b:"},{"line_number":249,"context_line":"                    continue"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"                if not old_b:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F28k%3D","line":248,"in_reply_to":"AAAAEn%2F%2F3eI%3D","updated":"2012-02-23 06:14:08.000000000","message":"Yes. the code reacts the changes. old_b \u003d\u003d new_b \u003d\u003d None means no change. So no more action is necessary.","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"import time"},{"line_number":27,"context_line":"from optparse import OptionParser"},{"line_number":28,"context_line":"from subprocess import PIPE, Popen"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from sqlalchemy.ext.sqlsoup import SqlSoup"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from quantum.common import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2kk%3D","line":29,"updated":"2012-02-24 00:05:25.000000000","message":"space here is unneeded.  consider ordering alphabetically, as required by quantum.","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"import time"},{"line_number":27,"context_line":"from optparse import OptionParser"},{"line_number":28,"context_line":"from subprocess import PIPE, Popen"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from sqlalchemy.ext.sqlsoup import SqlSoup"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from quantum.common import exceptions as exc"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2gI%3D","line":29,"in_reply_to":"AAAAEn%2F%2F2kk%3D","updated":"2012-02-24 01:15:30.000000000","message":"Done","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from sqlalchemy.ext.sqlsoup import SqlSoup"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from quantum.common import exceptions as exc"},{"line_number":33,"context_line":"from ryu.app import rest_nw_id"},{"line_number":34,"context_line":"from ryu.app.client import OFPClient"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2ko%3D","line":32,"updated":"2012-02-24 00:05:25.000000000","message":"Do you need to be importing from quantum.common here?  This means that the agent has python-quantumclient as a dependency.   Doesn\u0027t seem like there\u0027s any value from here, as you aren\u0027t using any of the quantum exceptions.","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from sqlalchemy.ext.sqlsoup import SqlSoup"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from quantum.common import exceptions as exc"},{"line_number":33,"context_line":"from ryu.app import rest_nw_id"},{"line_number":34,"context_line":"from ryu.app.client import OFPClient"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2gE%3D","line":32,"in_reply_to":"AAAAEn%2F%2F2ko%3D","updated":"2012-02-24 01:15:30.000000000","message":"elminate it","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if serv.host_type \u003d\u003d \"REST_API\":"},{"line_number":176,"context_line":"            ofp_rest_api_addr \u003d serv.address"},{"line_number":177,"context_line":"        elif serv.host_type \u003d\u003d \"controller\":"},{"line_number":178,"context_line":"            ofp_controller_addr \u003d serv.address"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    LOG.debug(\"controller %s\", ofp_controller_addr)"},{"line_number":181,"context_line":"    LOG.debug(\"api %s\", ofp_rest_api_addr)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2kg%3D","line":178,"updated":"2012-02-24 00:05:25.000000000","message":"consider warning if you are silently ignoring a database entry here.","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if serv.host_type \u003d\u003d \"REST_API\":"},{"line_number":176,"context_line":"            ofp_rest_api_addr \u003d serv.address"},{"line_number":177,"context_line":"        elif serv.host_type \u003d\u003d \"controller\":"},{"line_number":178,"context_line":"            ofp_controller_addr \u003d serv.address"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    LOG.debug(\"controller %s\", ofp_controller_addr)"},{"line_number":181,"context_line":"    LOG.debug(\"api %s\", ofp_rest_api_addr)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2f8%3D","line":178,"in_reply_to":"AAAAEn%2F%2F2kg%3D","updated":"2012-02-24 01:15:30.000000000","message":"Done","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":267,"context_line":"            old_vif_ports \u003d new_vif_ports"},{"line_number":268,"context_line":"            old_local_bindings \u003d new_local_bindings"},{"line_number":269,"context_line":"            db.commit()"},{"line_number":270,"context_line":"            time.sleep(2)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2h4%3D","line":270,"updated":"2012-02-24 00:05:25.000000000","message":"Am I understanding this correctly that the only reason you use the agent at all is to set the Operational Status of a port?  Or am I missing something else?","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":267,"context_line":"            old_vif_ports \u003d new_vif_ports"},{"line_number":268,"context_line":"            old_local_bindings \u003d new_local_bindings"},{"line_number":269,"context_line":"            db.commit()"},{"line_number":270,"context_line":"            time.sleep(2)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2f0%3D","line":270,"in_reply_to":"AAAAEn%2F%2F2h4%3D","updated":"2012-02-24 01:15:30.000000000","message":"You\u0027re right.\nthis agent\n- sets up OVS at startup\n- tracks port status","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"}],"quantum/plugins/ryu/db/api.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from . import models"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def add_ofp_servers(hosts):"},{"line_number":24,"context_line":"    session \u003d db.get_session()"},{"line_number":25,"context_line":"    session.query(models.OFPServers).delete()"},{"line_number":26,"context_line":"    for (host_address, host_type) in hosts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5rQ%3D","line":23,"updated":"2012-02-17 07:09:01.000000000","message":"consider a name like set_ofp_servers, as this might be more clear that the existing servers are deleted, prior to adding the list passed in.","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"from . import models"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def add_ofp_servers(hosts):"},{"line_number":24,"context_line":"    session \u003d db.get_session()"},{"line_number":25,"context_line":"    session.query(models.OFPServers).delete()"},{"line_number":26,"context_line":"    for (host_address, host_type) in hosts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5nQ%3D","line":23,"in_reply_to":"AAAAEn%2F%2F5rQ%3D","updated":"2012-02-17 07:51:11.000000000","message":"Done","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"from sqlalchemy.orm import exc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import quantum.db.api as db"},{"line_number":20,"context_line":"from . import models"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def set_ofp_servers(hosts):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F498%3D","line":20,"updated":"2012-02-18 11:10:15.000000000","message":"Please avoid relative imports","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"from sqlalchemy.orm import exc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import quantum.db.api as db"},{"line_number":20,"context_line":"from . import models"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def set_ofp_servers(hosts):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F41o%3D","line":20,"in_reply_to":"AAAAEn%2F%2F498%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def ofp_has_servers():"},{"line_number":33,"context_line":"    session \u003d db.get_session()"},{"line_number":34,"context_line":"    try:"},{"line_number":35,"context_line":"        session.query(models.OFPServer).first()"},{"line_number":36,"context_line":"        return True"},{"line_number":37,"context_line":"    except exc.NoResultFound:"},{"line_number":38,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3%2Bc%3D","line":35,"updated":"2012-02-22 03:11:17.000000000","message":"Unlike one(), first() does not raise an exception if no result is found.  Thus, this function as written will always return True.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"def ofp_has_servers():"},{"line_number":33,"context_line":"    session \u003d db.get_session()"},{"line_number":34,"context_line":"    try:"},{"line_number":35,"context_line":"        session.query(models.OFPServer).first()"},{"line_number":36,"context_line":"        return True"},{"line_number":37,"context_line":"    except exc.NoResultFound:"},{"line_number":38,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33s%3D","line":35,"in_reply_to":"AAAAEn%2F%2F3%2Bc%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"    session.flush()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def ofp_has_servers():"},{"line_number":33,"context_line":"    session \u003d db.get_session()"},{"line_number":34,"context_line":"    try:"},{"line_number":35,"context_line":"        session.query(models.OFPServer).one()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2kc%3D","line":32,"updated":"2012-02-24 00:05:25.000000000","message":"seems like this method isn\u0027t used, consider removing it.  \n\nnot sure how useful it is, as it doesn\u0027t check that both a API and a OF server are set.","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"    session.flush()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def ofp_has_servers():"},{"line_number":33,"context_line":"    session \u003d db.get_session()"},{"line_number":34,"context_line":"    try:"},{"line_number":35,"context_line":"        session.query(models.OFPServer).one()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2fs%3D","line":32,"in_reply_to":"AAAAEn%2F%2F2kc%3D","updated":"2012-02-24 01:15:30.000000000","message":"Done","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"}],"quantum/plugins/ryu/db/models.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from quantum.db.models import BASE"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class OFPServers(BASE):"},{"line_number":23,"context_line":"    \"\"\"Openflow Server/API address\"\"\""},{"line_number":24,"context_line":"    __tablename__ \u003d \u0027ofp_servers\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5rI%3D","line":22,"updated":"2012-02-17 07:09:01.000000000","message":"consider making this OFPServer (singular vs. plural)","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"from quantum.db.models import BASE"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class OFPServers(BASE):"},{"line_number":23,"context_line":"    \"\"\"Openflow Server/API address\"\"\""},{"line_number":24,"context_line":"    __tablename__ \u003d \u0027ofp_servers\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5nM%3D","line":22,"in_reply_to":"AAAAEn%2F%2F5rI%3D","updated":"2012-02-17 07:51:11.000000000","message":"Done","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"}],"quantum/plugins/ryu/nova/firewall.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nova.virt import firewall"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class NopFirewallDriver(firewall.FirewallDriver):"},{"line_number":24,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":25,"context_line":"        super(NopFirewallDriver, self).__init__()"},{"line_number":26,"context_line":"        for k, _v in inspect.getmembers(self, inspect.ismethod):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2B0%3D","line":23,"updated":"2012-02-18 11:10:15.000000000","message":"I believe the purpose of this class is to bypass nova\u0027s firewall driver for implementing security groups.\nIt looks fine to me, and I\u0027m not suggesting any change to this.\nHowever, I would like to suggest some possible improvements for the future:\n1) Merge this code into nova rather than quantum,as the security group feature at the moment, and possibly also for the Folsom release, will stay in Nova\n2) Rather than having a No-Op Firewall driver, consider having a change in nova for allowing to deploy nova without a firewall driver\n3) Consider implement a Firewall driver for implementing security groups (and possibly provider firewall) through Ryu,","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"}],"quantum/plugins/ryu/nova/linux_net.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.openstack.common import cfg"},{"line_number":23,"context_line":"from ryu.app.client import OFPClient"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from . import ovs_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.plugins.openvswitch.ryu.nova.linux_net\u0027)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BM%3D","line":25,"updated":"2012-02-18 11:10:15.000000000","message":"Please avoid relative imports","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.openstack.common import cfg"},{"line_number":23,"context_line":"from ryu.app.client import OFPClient"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from . import ovs_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.plugins.openvswitch.ryu.nova.linux_net\u0027)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F42Q%3D","line":25,"in_reply_to":"AAAAEn%2F%2F4%2BM%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Or factor out nova.network.linux_net somehow."},{"line_number":47,"context_line":"# load lazily FLAGS.linuxnet_interface_driver?"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class LinuxOVSRyuInterfaceDriver(object):"},{"line_number":52,"context_line":"    nova_linux_net \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BQ%3D","line":49,"updated":"2012-02-18 11:10:15.000000000","message":"The above comment is quite cryptic to me. This is possibly just due to lack of english skills on my side. However, I guess it tries to explain that the code below tries to circumvent a circular import issue.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Or factor out nova.network.linux_net somehow."},{"line_number":47,"context_line":"# load lazily FLAGS.linuxnet_interface_driver?"},{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class LinuxOVSRyuInterfaceDriver(object):"},{"line_number":52,"context_line":"    nova_linux_net \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F42M%3D","line":49,"in_reply_to":"AAAAEn%2F%2F4%2BQ%3D","updated":"2012-02-20 07:42:00.000000000","message":"Yes, you\u0027re right. It\u0027s for avoiding circular import.\nI updated the comment trying to improve the comment.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.plugins.openvswitch.ryu.nova.linux_net\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ryu_linux_net_opt \u003d \\"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027linuxnet_ovs_ryu_api_host\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027127.0.0.1:8080\u0027,"},{"line_number":31,"context_line":"               help\u003d\u0027Openflow Ryu REST API host:port\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F37o%3D","line":28,"updated":"2012-02-22 03:11:17.000000000","message":"Prefer parenthesis to backslashes for line continuation.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.plugins.openvswitch.ryu.nova.linux_net\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ryu_linux_net_opt \u003d \\"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027linuxnet_ovs_ryu_api_host\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027127.0.0.1:8080\u0027,"},{"line_number":31,"context_line":"               help\u003d\u0027Openflow Ryu REST API host:port\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33o%3D","line":28,"in_reply_to":"AAAAEn%2F%2F37o%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self):"},{"line_number":55,"context_line":"        if self.nova_linux_net is None:"},{"line_number":56,"context_line":"            self.nova_linux_net \u003d utils.import_object(\u0027nova.network.linux_net\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        cls \u003d utils.import_class("},{"line_number":59,"context_line":"            \u0027nova.network.linux_net.LinuxOVSInterfaceDriver\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F37s%3D","line":56,"updated":"2012-02-22 03:11:17.000000000","message":"Is there a reason this import can\u0027t just be performed directly?  The same question applies to utils.import_class below.  I understand there is a problem with a circular import, but I have yet to see a case where an import can\u0027t be made in a function or method.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self):"},{"line_number":55,"context_line":"        if self.nova_linux_net is None:"},{"line_number":56,"context_line":"            self.nova_linux_net \u003d utils.import_object(\u0027nova.network.linux_net\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        cls \u003d utils.import_class("},{"line_number":59,"context_line":"            \u0027nova.network.linux_net.LinuxOVSInterfaceDriver\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33k%3D","line":56,"in_reply_to":"AAAAEn%2F%2F37s%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"from nova import flags"},{"line_number":19,"context_line":"from nova import log as logging"},{"line_number":20,"context_line":"from nova.openstack.common import cfg"},{"line_number":21,"context_line":"from quantum.plugins.ryu.nova import ovs_utils"},{"line_number":22,"context_line":"from ryu.app.client import OFPClient"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2kQ%3D","line":21,"updated":"2012-02-24 00:05:25.000000000","message":"this class does not seem to exist, does this import work?  \n\nIn general, it seems odd to have code that is supposed to run in nova import something from the quantum.plugins namespace, as that namespace is part of the quantum server (which nova-network should not depend on).","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"from nova import flags"},{"line_number":19,"context_line":"from nova import log as logging"},{"line_number":20,"context_line":"from nova.openstack.common import cfg"},{"line_number":21,"context_line":"from quantum.plugins.ryu.nova import ovs_utils"},{"line_number":22,"context_line":"from ryu.app.client import OFPClient"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2eU%3D","line":21,"in_reply_to":"AAAAEn%2F%2F2kQ%3D","updated":"2012-02-24 01:15:30.000000000","message":"the relative import \u0027from . import ovs_utils\u0027 is also suppressed.\nSo I duplicated the code into linux_net.py and vif.py as they are two small helper functions and remove ovs_utils.py.\nThis dupliation will be solved when those codes are moved from quantum to nova.","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"}],"quantum/plugins/ryu/nova/ovs_utils.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"    out, _err \u003d utils.execute(\u0027ovs-vsctl\u0027, \u0027get\u0027, \u0027Bridge\u0027,"},{"line_number":23,"context_line":"                              bridge_name, \u0027datapath_id\u0027, run_as_root\u003dTrue)"},{"line_number":24,"context_line":"    # remove preceding/trailing double quotes"},{"line_number":25,"context_line":"    return out.strip()[1:-1]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def get_port_no(dev):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BU%3D","line":25,"updated":"2012-02-18 11:10:15.000000000","message":"Question: against which version of OVS has been tested? I recollect that for some older versions of ovs-vsctl (1.0.2 possibly), returned data were not surrounded by quotes.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"    out, _err \u003d utils.execute(\u0027ovs-vsctl\u0027, \u0027get\u0027, \u0027Bridge\u0027,"},{"line_number":23,"context_line":"                              bridge_name, \u0027datapath_id\u0027, run_as_root\u003dTrue)"},{"line_number":24,"context_line":"    # remove preceding/trailing double quotes"},{"line_number":25,"context_line":"    return out.strip()[1:-1]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def get_port_no(dev):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F42g%3D","line":25,"in_reply_to":"AAAAEn%2F%2F4%2BU%3D","updated":"2012-02-20 07:42:00.000000000","message":"OVS 1.2. More concretely 1.2.0-1ubuntu3 of Ubutunu 11.10\nBy looking at the commit log, the following change set seems a cause of it.\nOkay I\u0027ll add the check for the first/last char is double quotes.\n\ncommit 0194f33a6c734f0ff946fad9fb6b059b29ebf13e\nAuthor: Ben Pfaff \u003cblp@nicira.com\u003e\nDate:   Mon Jan 25 10:16:52 2010 -0800\n\n    ovsdb-datum: Add functions for parsing and formatting atoms, data.\n    \n    These functions provide an alternative to JSON parsing and formatting that\n    is more human-friendly (and shorter).\n    \n    These will be used in an upcoming commit to enhance ovs-vsctl.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"def get_datapath_id(bridge_name):"},{"line_number":22,"context_line":"    out, _err \u003d utils.execute(\u0027ovs-vsctl\u0027, \u0027get\u0027, \u0027Bridge\u0027,"},{"line_number":23,"context_line":"                              bridge_name, \u0027datapath_id\u0027, run_as_root\u003dTrue)"},{"line_number":24,"context_line":"    out \u003d out.strip()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # the result may have preceding/trailing double quotes, depending on"},{"line_number":27,"context_line":"    # OVS version. We can safely assume datapath_id doesn\u0027t have doublequotes"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F4Ag%3D","line":24,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - consider using strip to remove the quotes, too, instead of doing so manually:\n\nout \u003d out.strip(\u0027\" \u0027)","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":"def get_datapath_id(bridge_name):"},{"line_number":22,"context_line":"    out, _err \u003d utils.execute(\u0027ovs-vsctl\u0027, \u0027get\u0027, \u0027Bridge\u0027,"},{"line_number":23,"context_line":"                              bridge_name, \u0027datapath_id\u0027, run_as_root\u003dTrue)"},{"line_number":24,"context_line":"    out \u003d out.strip()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # the result may have preceding/trailing double quotes, depending on"},{"line_number":27,"context_line":"    # OVS version. We can safely assume datapath_id doesn\u0027t have doublequotes"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33g%3D","line":24,"in_reply_to":"AAAAEn%2F%2F4Ag%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"quantum/plugins/ryu/nova/vif.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":14,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import httplib"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2Bc%3D","line":16,"updated":"2012-02-18 11:10:15.000000000","message":"I have no problem with pushing this patch into Quantum for the Essex release.\nHowever, this should go into nova, as all the VIF drivers are currently in nova\u0027s source tree.\n\nPlease also provide information about nova\u0027s VIF drivers into the README file.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":14,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import httplib"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F43M%3D","line":16,"in_reply_to":"AAAAEn%2F%2F4%2Bc%3D","updated":"2012-02-20 07:42:00.000000000","message":"Basically I agree with you. I just followed the way of already existing plugings.\nI think moving quantum/plugin/*/nova/* into nova should be done at once. i.e. All plugins should do it consistently.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova.virt.libvirt import vif as libvirt_vif"},{"line_number":24,"context_line":"from ryu.app.client import OFPClient"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from . import ovs_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.plugins.openvswitch.ryu.nova.vif\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2BY%3D","line":26,"updated":"2012-02-18 11:10:15.000000000","message":"Please avoid relative imports","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"from nova.virt.libvirt import vif as libvirt_vif"},{"line_number":24,"context_line":"from ryu.app.client import OFPClient"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from . import ovs_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.plugins.openvswitch.ryu.nova.vif\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F43Q%3D","line":26,"in_reply_to":"AAAAEn%2F%2F4%2BY%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova import log as logging"},{"line_number":22,"context_line":"from nova.openstack.common import cfg"},{"line_number":23,"context_line":"from nova.virt.libvirt import vif as libvirt_vif"},{"line_number":24,"context_line":"from quantum.plugins.ryu.nova import ovs_utils"},{"line_number":25,"context_line":"from ryu.app.client import OFPClient"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAEn%2F%2F2j4%3D","line":24,"updated":"2012-02-24 00:05:25.000000000","message":"same comment as last file.","commit_id":"bd06a9e2509eeee920bb1ca64600bc638b0810e4"}],"quantum/plugins/ryu/ovs_quantum_plugin_base.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"# @author: Somik Behera, Nicira Networks, Inc."},{"line_number":17,"context_line":"# @author: Brad Hall, Nicira Networks, Inc."},{"line_number":18,"context_line":"# @author: Dan Wendlandt, Nicira Networks, Inc."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ConfigParser"},{"line_number":21,"context_line":"import logging as LOG"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5ns%3D","line":18,"updated":"2012-02-17 07:09:01.000000000","message":"Consider changing authors here, as described before.","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"# @author: Somik Behera, Nicira Networks, Inc."},{"line_number":17,"context_line":"# @author: Brad Hall, Nicira Networks, Inc."},{"line_number":18,"context_line":"# @author: Dan Wendlandt, Nicira Networks, Inc."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import ConfigParser"},{"line_number":21,"context_line":"import logging as LOG"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5nI%3D","line":18,"in_reply_to":"AAAAEn%2F%2F5ns%3D","updated":"2012-02-17 07:51:11.000000000","message":"Done","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Copyright 2012 Isaku Yamahata"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2011 Nicira Networks, Inc."},{"line_number":6,"context_line":"# All Rights Reserved."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2Bw%3D","line":5,"updated":"2012-02-18 11:10:15.000000000","message":"[Minor and optional] Consider changing the above copyright line","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Copyright 2012 Isaku Yamahata"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2011 Nicira Networks, Inc."},{"line_number":6,"context_line":"# All Rights Reserved."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F43U%3D","line":5,"in_reply_to":"AAAAEn%2F%2F4%2Bw%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class OVSQuantumPluginBase(QuantumPluginBase):"},{"line_number":53,"context_line":"    def __init__(self, CONF_FILE, mod_file, configfile\u003dNone):"},{"line_number":54,"context_line":"        config \u003d ConfigParser.ConfigParser()"},{"line_number":55,"context_line":"        if configfile is None:"},{"line_number":56,"context_line":"            if os.path.exists(CONF_FILE):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2Bs%3D","line":53,"updated":"2012-02-18 11:10:15.000000000","message":"[optional, minor] use of block capitals for parameter names is discouraged","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class OVSQuantumPluginBase(QuantumPluginBase):"},{"line_number":53,"context_line":"    def __init__(self, CONF_FILE, mod_file, configfile\u003dNone):"},{"line_number":54,"context_line":"        config \u003d ConfigParser.ConfigParser()"},{"line_number":55,"context_line":"        if configfile is None:"},{"line_number":56,"context_line":"            if os.path.exists(CONF_FILE):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F43o%3D","line":53,"in_reply_to":"AAAAEn%2F%2F4%2Bs%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":69,"context_line":"        db.configure_db(options)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.config \u003d config"},{"line_number":72,"context_line":"        # Subclass must set self.driver to its own OVSQuantumPluginDriverBase"},{"line_number":73,"context_line":"        self.driver \u003d None"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_all_networks(self, tenant_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2Bo%3D","line":72,"updated":"2012-02-18 11:10:15.000000000","message":"This comment is quite important. It should be in the class\u0027 docstring","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":69,"context_line":"        db.configure_db(options)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.config \u003d config"},{"line_number":72,"context_line":"        # Subclass must set self.driver to its own OVSQuantumPluginDriverBase"},{"line_number":73,"context_line":"        self.driver \u003d None"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_all_networks(self, tenant_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F43c%3D","line":72,"in_reply_to":"AAAAEn%2F%2F4%2Bo%3D","updated":"2012-02-20 07:42:00.000000000","message":"Done","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if port.state \u003d\u003d \"ACTIVE\":"},{"line_number":124,"context_line":"            op_status \u003d port.op_status"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            op_status \u003d OperationalStatus.DOWN"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return {\u0027port-id\u0027: str(port.uuid),"},{"line_number":129,"context_line":"                \u0027port-state\u0027: port.state,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2Bk%3D","line":126,"updated":"2012-02-18 11:10:15.000000000","message":"[Question]: Should the decision about the default operational status for a port belong to the driver? [Same for the network]","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if port.state \u003d\u003d \"ACTIVE\":"},{"line_number":124,"context_line":"            op_status \u003d port.op_status"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            op_status \u003d OperationalStatus.DOWN"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return {\u0027port-id\u0027: str(port.uuid),"},{"line_number":129,"context_line":"                \u0027port-state\u0027: port.state,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F43Y%3D","line":126,"in_reply_to":"AAAAEn%2F%2F4%2Bk%3D","updated":"2012-02-20 07:42:00.000000000","message":"Maybe no. At the moment, OVS and RYU don\u0027t have such needs.\nI\u0027m not sure future OVS plugin or other ovs-based plugins.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import logging as LOG"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from abc import ABCMeta, abstractmethod"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from quantum.api.api_common import OperationalStatus"},{"line_number":26,"context_line":"from quantum.common import exceptions as q_exc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39s%3D","line":23,"updated":"2012-02-22 03:11:17.000000000","message":"I don\u0027t see abc in the tools/pip-requires, despite it being imported by both this and other plugins.  Is there a reason it is not in the list of dependencies?","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"import logging as LOG"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from abc import ABCMeta, abstractmethod"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from quantum.api.api_common import OperationalStatus"},{"line_number":26,"context_line":"from quantum.common import exceptions as q_exc"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33c%3D","line":23,"in_reply_to":"AAAAEn%2F%2F39s%3D","updated":"2012-02-22 12:45:25.000000000","message":"Because abc is in python standard library.\nPlease refer to http://docs.python.org/library/abc\n\nSo this import should be in first import groups.\nDone","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def get_all_networks(self, tenant_id, **kwargs):"},{"line_number":80,"context_line":"        nets \u003d []"},{"line_number":81,"context_line":"        for x in db.network_list(tenant_id):"},{"line_number":82,"context_line":"            LOG.debug(\"Adding network: %s\" % x.uuid)"},{"line_number":83,"context_line":"            nets.append(self._make_net_dict(str(x.uuid), x.name,"},{"line_number":84,"context_line":"                                            None, x.op_status))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39k%3D","line":81,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - avoid using single-letter names for non-index variables.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def get_all_networks(self, tenant_id, **kwargs):"},{"line_number":80,"context_line":"        nets \u003d []"},{"line_number":81,"context_line":"        for x in db.network_list(tenant_id):"},{"line_number":82,"context_line":"            LOG.debug(\"Adding network: %s\" % x.uuid)"},{"line_number":83,"context_line":"            nets.append(self._make_net_dict(str(x.uuid), x.name,"},{"line_number":84,"context_line":"                                            None, x.op_status))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33Y%3D","line":81,"in_reply_to":"AAAAEn%2F%2F39k%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _make_net_dict(self, net_id, net_name, ports, op_status):"},{"line_number":88,"context_line":"        res \u003d {\u0027net-id\u0027: net_id,"},{"line_number":89,"context_line":"                \u0027net-name\u0027: net_name,"},{"line_number":90,"context_line":"                \u0027net-op-status\u0027: op_status}"},{"line_number":91,"context_line":"        if ports:"},{"line_number":92,"context_line":"            res[\u0027net-ports\u0027] \u003d ports"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39g%3D","line":89,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _make_net_dict(self, net_id, net_name, ports, op_status):"},{"line_number":88,"context_line":"        res \u003d {\u0027net-id\u0027: net_id,"},{"line_number":89,"context_line":"                \u0027net-name\u0027: net_name,"},{"line_number":90,"context_line":"                \u0027net-op-status\u0027: op_status}"},{"line_number":91,"context_line":"        if ports:"},{"line_number":92,"context_line":"            res[\u0027net-ports\u0027] \u003d ports"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33U%3D","line":89,"in_reply_to":"AAAAEn%2F%2F39g%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def create_network(self, tenant_id, net_name, **kwargs):"},{"line_number":96,"context_line":"        net \u003d db.network_create(tenant_id, net_name,"},{"line_number":97,"context_line":"                          op_status\u003dOperationalStatus.UP)"},{"line_number":98,"context_line":"        LOG.debug(\"Created network: %s\" % net)"},{"line_number":99,"context_line":"        self.driver.create_network(net)"},{"line_number":100,"context_line":"        return self._make_net_dict(str(net.uuid), net.name, [],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39c%3D","line":97,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def create_network(self, tenant_id, net_name, **kwargs):"},{"line_number":96,"context_line":"        net \u003d db.network_create(tenant_id, net_name,"},{"line_number":97,"context_line":"                          op_status\u003dOperationalStatus.UP)"},{"line_number":98,"context_line":"        LOG.debug(\"Created network: %s\" % net)"},{"line_number":99,"context_line":"        self.driver.create_network(net)"},{"line_number":100,"context_line":"        return self._make_net_dict(str(net.uuid), net.name, [],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33Q%3D","line":97,"in_reply_to":"AAAAEn%2F%2F39c%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        LOG.debug(\"Created network: %s\" % net)"},{"line_number":99,"context_line":"        self.driver.create_network(net)"},{"line_number":100,"context_line":"        return self._make_net_dict(str(net.uuid), net.name, [],"},{"line_number":101,"context_line":"                                        net.op_status)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def delete_network(self, tenant_id, net_id):"},{"line_number":104,"context_line":"        net \u003d db.network_get(net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39Y%3D","line":101,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":98,"context_line":"        LOG.debug(\"Created network: %s\" % net)"},{"line_number":99,"context_line":"        self.driver.create_network(net)"},{"line_number":100,"context_line":"        return self._make_net_dict(str(net.uuid), net.name, [],"},{"line_number":101,"context_line":"                                        net.op_status)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def delete_network(self, tenant_id, net_id):"},{"line_number":104,"context_line":"        net \u003d db.network_get(net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33M%3D","line":101,"in_reply_to":"AAAAEn%2F%2F39Y%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        net \u003d db.network_destroy(net_id)"},{"line_number":111,"context_line":"        self.driver.delete_network(net)"},{"line_number":112,"context_line":"        return self._make_net_dict(str(net.uuid), net.name, [],"},{"line_number":113,"context_line":"                                        net.op_status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_network_details(self, tenant_id, net_id):"},{"line_number":116,"context_line":"        net \u003d db.network_get(net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39U%3D","line":113,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":110,"context_line":"        net \u003d db.network_destroy(net_id)"},{"line_number":111,"context_line":"        self.driver.delete_network(net)"},{"line_number":112,"context_line":"        return self._make_net_dict(str(net.uuid), net.name, [],"},{"line_number":113,"context_line":"                                        net.op_status)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_network_details(self, tenant_id, net_id):"},{"line_number":116,"context_line":"        net \u003d db.network_get(net_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33I%3D","line":113,"in_reply_to":"AAAAEn%2F%2F39U%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        net \u003d db.network_get(net_id)"},{"line_number":117,"context_line":"        ports \u003d self.get_all_ports(tenant_id, net_id)"},{"line_number":118,"context_line":"        return self._make_net_dict(str(net.uuid), net.name,"},{"line_number":119,"context_line":"                                    ports, net.op_status)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def update_network(self, tenant_id, net_id, **kwargs):"},{"line_number":122,"context_line":"        net \u003d db.network_update(net_id, tenant_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39Q%3D","line":119,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":"        net \u003d db.network_get(net_id)"},{"line_number":117,"context_line":"        ports \u003d self.get_all_ports(tenant_id, net_id)"},{"line_number":118,"context_line":"        return self._make_net_dict(str(net.uuid), net.name,"},{"line_number":119,"context_line":"                                    ports, net.op_status)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def update_network(self, tenant_id, net_id, **kwargs):"},{"line_number":122,"context_line":"        net \u003d db.network_update(net_id, tenant_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33E%3D","line":119,"in_reply_to":"AAAAEn%2F%2F39Q%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def update_network(self, tenant_id, net_id, **kwargs):"},{"line_number":122,"context_line":"        net \u003d db.network_update(net_id, tenant_id, **kwargs)"},{"line_number":123,"context_line":"        return self._make_net_dict(str(net.uuid), net.name,"},{"line_number":124,"context_line":"                                        None, net.op_status)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _make_port_dict(self, port):"},{"line_number":127,"context_line":"        if port.state \u003d\u003d \"ACTIVE\":"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39M%3D","line":124,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def update_network(self, tenant_id, net_id, **kwargs):"},{"line_number":122,"context_line":"        net \u003d db.network_update(net_id, tenant_id, **kwargs)"},{"line_number":123,"context_line":"        return self._make_net_dict(str(net.uuid), net.name,"},{"line_number":124,"context_line":"                                        None, net.op_status)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _make_port_dict(self, port):"},{"line_number":127,"context_line":"        if port.state \u003d\u003d \"ACTIVE\":"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F33A%3D","line":124,"in_reply_to":"AAAAEn%2F%2F39M%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def create_port(self, tenant_id, net_id, port_state\u003dNone, **kwargs):"},{"line_number":144,"context_line":"        LOG.debug(\"Creating port with network_id: %s\" % net_id)"},{"line_number":145,"context_line":"        port \u003d db.port_create(net_id, port_state,"},{"line_number":146,"context_line":"                                op_status\u003dOperationalStatus.DOWN)"},{"line_number":147,"context_line":"        return self._make_port_dict(port)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def delete_port(self, tenant_id, net_id, port_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F39I%3D","line":146,"updated":"2012-02-22 03:11:17.000000000","message":"PEP8 vertical alignment","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"quantum/plugins/ryu/run_tests.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"This file should be run from the top dir in the quantum directory"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"To run all tests::"},{"line_number":25,"context_line":"    PLUGIN_DIR\u003dquantum/plugins/linuxbridge ./run_tests.sh"},{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEn%2F%2F4r4%3D","line":25,"updated":"2012-02-20 19:37:01.000000000","message":"you\u0027ll want to fix up this line and the line just above.","commit_id":"37136c12e3653e3626ba4649c3270dd223102178"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"This file should be run from the top dir in the quantum directory"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"To run all tests::"},{"line_number":25,"context_line":"    PLUGIN_DIR\u003dquantum/plugins/linuxbridge ./run_tests.sh"},{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAEn%2F%2F4iI%3D","line":25,"in_reply_to":"AAAAEn%2F%2F4r4%3D","updated":"2012-02-21 06:49:54.000000000","message":"Done","commit_id":"37136c12e3653e3626ba4649c3270dd223102178"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    limitations under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"Unittest runner for quantum Linux Bridge plugin"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This file should be run from the top dir in the quantum directory"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F370%3D","line":20,"updated":"2012-02-22 03:11:17.000000000","message":"Not the linux bridge plugin.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    limitations under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"Unittest runner for quantum Linux Bridge plugin"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This file should be run from the top dir in the quantum directory"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F328%3D","line":20,"in_reply_to":"AAAAEn%2F%2F370%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"quantum/plugins/ryu/ryu_quantum_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6840971d0ab5af1bc8a3e60b52846cffed06bb4b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF_FILE \u003d find_config_file("},{"line_number":32,"context_line":"  {\"config_file\": \"etc/quantum/plugins/ryu/ryu.ini\"}, None, \"ryu.ini\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class OFPRyuDriver(ovs_quantum_plugin_base.OVSQuantumPluginDriverBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5nk%3D","line":32,"updated":"2012-02-17 07:09:01.000000000","message":"I think you\u0027re going to want this to be: \n\n({ \"plugin\": \"ryu\"}, None, \"ryu.ini\")\n\nWe fixed this bug in OVS plugin since you branched.","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF_FILE \u003d find_config_file("},{"line_number":32,"context_line":"  {\"config_file\": \"etc/quantum/plugins/ryu/ryu.ini\"}, None, \"ryu.ini\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class OFPRyuDriver(ovs_quantum_plugin_base.OVSQuantumPluginDriverBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5nE%3D","line":32,"in_reply_to":"AAAAEn%2F%2F5nk%3D","updated":"2012-02-17 07:51:11.000000000","message":"Done","commit_id":"2a91cbfb8ad635b8a18d368e1271d73297108bd4"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from ryu.app import client"},{"line_number":28,"context_line":"from ryu.app import rest_nw_id"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF_FILE \u003d find_config_file({\"plugin\": \"ryu\"}, None, \"ryu.ini\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F4%2Bg%3D","line":28,"updated":"2012-02-18 11:10:15.000000000","message":"I think this is a 3rd party package, possibly the Ryu controller. \nIt is important to include all this information in the README file for the Ryu plugin.","commit_id":"bcdf8e0ec062fb3f5298060eb250cf859ffdd336"}],"quantum/plugins/ryu/tests/unit/.gitignore":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fake_ryu.ini"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F4AE%3D","line":1,"updated":"2012-02-22 03:11:17.000000000","message":"Please remove this ignorefile - test configuration should be written to a temporary location.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"fake_ryu.ini"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAEn%2F%2F324%3D","line":1,"in_reply_to":"AAAAEn%2F%2F4AE%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"quantum/plugins/ryu/tests/unit/_test.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Isaku Yamahata \u003cyamahata at private email ne jp\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F38o%3D","line":1,"updated":"2012-02-22 03:11:17.000000000","message":"Suggestion - change the name of this module to better represent what it contains - say, basetest.py.  _test.py is not clear and the convention is not used anywhere else in openstack.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012 Isaku Yamahata \u003cyamahata at private email ne jp\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F320%3D","line":1,"in_reply_to":"AAAAEn%2F%2F38o%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"quantum/plugins/ryu/tests/unit/fake_plugin.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class FakePlugin(ovs_quantum_plugin_base.OVSQuantumPluginBase):"},{"line_number":34,"context_line":"    def __init__(self, configfile\u003dNone):"},{"line_number":35,"context_line":"        ini_file \u003d utils.create_fake_ryu_ini()"},{"line_number":36,"context_line":"        super(FakePlugin, self).__init__(ini_file, __file__, configfile)"},{"line_number":37,"context_line":"        self.driver \u003d FakePluginDriver(self.config)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F3cs%3D","line":35,"updated":"2012-02-22 20:04:01.000000000","message":"Consider creating the fake ini file in a setup method (at whatever level - package, module, or class) and removing it on teardown.","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class FakePlugin(ovs_quantum_plugin_base.OVSQuantumPluginBase):"},{"line_number":34,"context_line":"    def __init__(self, configfile\u003dNone):"},{"line_number":35,"context_line":"        ini_file \u003d utils.create_fake_ryu_ini()"},{"line_number":36,"context_line":"        super(FakePlugin, self).__init__(ini_file, __file__, configfile)"},{"line_number":37,"context_line":"        self.driver \u003d FakePluginDriver(self.config)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F278%3D","line":35,"in_reply_to":"AAAAEn%2F%2F3cs%3D","updated":"2012-02-23 06:14:08.000000000","message":"Done","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"}],"quantum/plugins/ryu/tests/unit/utils.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"openflow-rest-api \u003d %s"},{"line_number":34,"context_line":"\"\"\" % (FAKE_CONTROLLER_ADDR, FAKE_REST_ADDR)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"FAKE_RYU_INI_PATH \u003d os.path.join(os.path.dirname(__file__), \u0027fake_ryu.ini\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def create_fake_ryu_ini():"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F38M%3D","line":36,"updated":"2012-02-22 03:11:17.000000000","message":"Avoid writing test data to non-temporary locations.  Instead, use tempfile.mkstemp to find a temporary location to write to.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":33,"context_line":"openflow-rest-api \u003d %s"},{"line_number":34,"context_line":"\"\"\" % (FAKE_CONTROLLER_ADDR, FAKE_REST_ADDR)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"FAKE_RYU_INI_PATH \u003d os.path.join(os.path.dirname(__file__), \u0027fake_ryu.ini\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def create_fake_ryu_ini():"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F32w%3D","line":36,"in_reply_to":"AAAAEn%2F%2F38M%3D","updated":"2012-02-22 12:45:25.000000000","message":"Done","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def create_module(name, parent_mod\u003dNone):"},{"line_number":54,"context_line":"    mod \u003d sys.modules.get(name)"},{"line_number":55,"context_line":"    if mod is not None:"},{"line_number":56,"context_line":"        return mod"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F38A%3D","line":54,"updated":"2012-02-22 03:11:17.000000000","message":"Custom monkeypatching for the purposes of testing is highly discouraged.  It would be much preferable to use a popular mocking library that supports patching (e.g. Mock: http://www.voidspace.org.uk/python/mock/), because the semantics of use are well-documented and the functionality in question does not have to be maintained as part of the quantum project.","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def create_module(name, parent_mod\u003dNone):"},{"line_number":54,"context_line":"    mod \u003d sys.modules.get(name)"},{"line_number":55,"context_line":"    if mod is not None:"},{"line_number":56,"context_line":"        return mod"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAEn%2F%2F3zw%3D","line":54,"in_reply_to":"AAAAEn%2F%2F38A%3D","updated":"2012-02-22 12:45:25.000000000","message":"I converted it to use mock.patch.dict. And added mock to pip-requires","commit_id":"661ee115e1716772854431bde7bf293c28cef23e"}],"setup.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"1618cd7c7562e649e0d9201b3b03226083485cb6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    eager_resources\u003dEagerResources,"},{"line_number":109,"context_line":"    entry_points\u003d{"},{"line_number":110,"context_line":"        \u0027console_scripts\u0027: ["},{"line_number":111,"context_line":"            \u0027quantum-linuxbridge-agent \u003d \\"},{"line_number":112,"context_line":"quantum.plugins.linuxbridge.agent.linuxbridge_quantum_agent:main\u0027,"},{"line_number":113,"context_line":"            \u0027quantum-openvswitch-agent \u003d \\"},{"line_number":114,"context_line":"quantum.plugins.openvswitch.agent.ovs_quantum_agent:main\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F3dE%3D","line":111,"updated":"2012-02-22 20:04:01.000000000","message":"Why is a backslash being embedded in these strings?  It looks like line continuation is being attempted, but the likely intent is string concatenation.","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"    eager_resources\u003dEagerResources,"},{"line_number":109,"context_line":"    entry_points\u003d{"},{"line_number":110,"context_line":"        \u0027console_scripts\u0027: ["},{"line_number":111,"context_line":"            \u0027quantum-linuxbridge-agent \u003d \\"},{"line_number":112,"context_line":"quantum.plugins.linuxbridge.agent.linuxbridge_quantum_agent:main\u0027,"},{"line_number":113,"context_line":"            \u0027quantum-openvswitch-agent \u003d \\"},{"line_number":114,"context_line":"quantum.plugins.openvswitch.agent.ovs_quantum_agent:main\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAEn%2F%2F28g%3D","line":111,"in_reply_to":"AAAAEn%2F%2F3dE%3D","updated":"2012-02-23 06:14:08.000000000","message":"Done","commit_id":"32abc293e1a1264cd00dcc6d738c3dc3a17d5d29"}]}
