)]}'
{"etc/neutron/plugins/cisco/cisco_plugins.ini":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#vlan_name_prefix\u003dq-"},{"line_number":9,"context_line":"#provider_vlan_name_prefix\u003dp-"},{"line_number":10,"context_line":"#provider_vlan_auto_create\u003dTrue"},{"line_number":11,"context_line":"#provider_vlan_auto_trunk\u003dTrue"},{"line_number":12,"context_line":"#max_ports\u003d100"},{"line_number":13,"context_line":"#max_port_profiles\u003d65568"},{"line_number":14,"context_line":"#max_networks\u003d65568"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAP3%2F%2F1tY%3D","line":11,"updated":"2013-07-10 16:26:52.000000000","message":"Add some help text above to explain what these options are and when they should be turned off/on.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#vlan_name_prefix\u003dq-"},{"line_number":9,"context_line":"#provider_vlan_name_prefix\u003dp-"},{"line_number":10,"context_line":"#provider_vlan_auto_create\u003dTrue"},{"line_number":11,"context_line":"#provider_vlan_auto_trunk\u003dTrue"},{"line_number":12,"context_line":"#max_ports\u003d100"},{"line_number":13,"context_line":"#max_port_profiles\u003d65568"},{"line_number":14,"context_line":"#max_networks\u003d65568"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAP3%2F%2F1TE%3D","line":11,"in_reply_to":"AAAAP3%2F%2F1tY%3D","updated":"2013-07-10 19:38:54.000000000","message":"This will be a first for this file. I will add help for these three new options, and open an enhancement bug to add help to the rest.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"}],"neutron/db/migration/alembic_migrations/versions/33df4d28b073_cisco_provider_vlans.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.create_table("},{"line_number":48,"context_line":"        \u0027cisco_provider_vlans\u0027,"},{"line_number":49,"context_line":"        sa.Column(\u0027network_id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027vlan_id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":51,"context_line":"        sa.PrimaryKeyConstraint(\u0027network_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1tQ%3D","line":48,"updated":"2013-07-10 16:26:52.000000000","message":"Change to cisco_provider_networks.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.create_table("},{"line_number":48,"context_line":"        \u0027cisco_provider_vlans\u0027,"},{"line_number":49,"context_line":"        sa.Column(\u0027network_id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027vlan_id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":51,"context_line":"        sa.PrimaryKeyConstraint(\u0027network_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1X0%3D","line":48,"in_reply_to":"AAAAP3%2F%2F1tQ%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    op.create_table("},{"line_number":48,"context_line":"        \u0027cisco_provider_vlans\u0027,"},{"line_number":49,"context_line":"        sa.Column(\u0027network_id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027vlan_id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":51,"context_line":"        sa.PrimaryKeyConstraint(\u0027network_id\u0027)"},{"line_number":52,"context_line":"    )"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1tM%3D","line":50,"updated":"2013-07-10 16:26:52.000000000","message":"Change to segmentation_id.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    op.create_table("},{"line_number":48,"context_line":"        \u0027cisco_provider_vlans\u0027,"},{"line_number":49,"context_line":"        sa.Column(\u0027network_id\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":50,"context_line":"        sa.Column(\u0027vlan_id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":51,"context_line":"        sa.PrimaryKeyConstraint(\u0027network_id\u0027)"},{"line_number":52,"context_line":"    )"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Xg%3D","line":50,"in_reply_to":"AAAAP3%2F%2F1tM%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if not migration.should_run(active_plugin, migration_for_plugins):"},{"line_number":57,"context_line":"        return"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    op.drop_table(\u0027cisco_provider_vlans\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1tU%3D","line":59,"updated":"2013-07-10 16:26:52.000000000","message":"Change to cisco_provider_networks.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if not migration.should_run(active_plugin, migration_for_plugins):"},{"line_number":57,"context_line":"        return"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    op.drop_table(\u0027cisco_provider_vlans\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Xc%3D","line":59,"in_reply_to":"AAAAP3%2F%2F1tU%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"}],"neutron/plugins/cisco/common/cisco_exceptions.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"class ProviderVlanNetworkExists(exceptions.NeutronException):"},{"line_number":83,"context_line":"    \"\"\"Provider VLAN for this network already exists.\"\"\""},{"line_number":84,"context_line":"    message \u003d _(\"Provider VLAN network %s already exists\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NexusComputeHostNotConfigured(exceptions.NeutronException):"},{"line_number":88,"context_line":"    \"\"\"Connection to compute host is not configured.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1ss%3D","line":85,"updated":"2013-07-10 16:26:52.000000000","message":"Change ProviderVlanNetwork to Provider network above.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":82,"context_line":"class ProviderVlanNetworkExists(exceptions.NeutronException):"},{"line_number":83,"context_line":"    \"\"\"Provider VLAN for this network already exists.\"\"\""},{"line_number":84,"context_line":"    message \u003d _(\"Provider VLAN network %s already exists\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NexusComputeHostNotConfigured(exceptions.NeutronException):"},{"line_number":88,"context_line":"    \"\"\"Connection to compute host is not configured.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1ZE%3D","line":85,"in_reply_to":"AAAAP3%2F%2F1ss%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"057dca4c1f0148d20bcbfec26eea586811fc0b7f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class ProviderNetworkExists(exceptions.NeutronException):"},{"line_number":83,"context_line":"    \"\"\"Provider VLAN for this network already exists.\"\"\""},{"line_number":84,"context_line":"    message \u003d _(\"Provider VLAN network %s already exists\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NexusComputeHostNotConfigured(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyRc%3D","line":84,"updated":"2013-07-11 14:48:25.000000000","message":"Remove VLAN from comment and message. Change to Provider network.","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d20f498d22b16c7ad70c9fbb35a6836728411f43","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class ProviderNetworkExists(exceptions.NeutronException):"},{"line_number":83,"context_line":"    \"\"\"Provider VLAN for this network already exists.\"\"\""},{"line_number":84,"context_line":"    message \u003d _(\"Provider VLAN network %s already exists\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NexusComputeHostNotConfigured(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyHA%3D","line":84,"in_reply_to":"AAAAP3%2F%2FyRc%3D","updated":"2013-07-15 15:53:46.000000000","message":"Done","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"}],"neutron/plugins/cisco/common/config.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                \u0027on the Nexus switch\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027provider_vlan_auto_trunk\u0027, default\u003dTrue,"},{"line_number":47,"context_line":"                help\u003d\u0027Provider VLANs are automatically trunked as needed \u0027"},{"line_number":48,"context_line":"                \u0027on the ports of the Nexus switch\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027max_ports\u0027, default\u003d\u0027100\u0027,"},{"line_number":50,"context_line":"               help\u003d_(\"Maximum Port value\")),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027max_port_profiles\u0027, default\u003d\u002765568\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1sc%3D","line":48,"updated":"2013-07-10 16:26:52.000000000","message":"Change all above to provider network instead of provider vlan network.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                \u0027on the Nexus switch\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027provider_vlan_auto_trunk\u0027, default\u003dTrue,"},{"line_number":47,"context_line":"                help\u003d\u0027Provider VLANs are automatically trunked as needed \u0027"},{"line_number":48,"context_line":"                \u0027on the ports of the Nexus switch\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027max_ports\u0027, default\u003d\u0027100\u0027,"},{"line_number":50,"context_line":"               help\u003d_(\"Maximum Port value\")),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027max_port_profiles\u0027, default\u003d\u002765568\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Yo%3D","line":48,"in_reply_to":"AAAAP3%2F%2F1sc%3D","updated":"2013-07-10 19:38:54.000000000","message":"These options apply specifically to provider *VLAN* management on the Nexus. I think these are correctly named here.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"}],"neutron/plugins/cisco/db/network_db_v2.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"ba8a88349d07f6285d868c7ddcb0320db4e39dae","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                       tenant_id\u003dtenant_id)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"def add_provider_network(network_id, network_type, segmentation_id):"},{"line_number":282,"context_line":"    session \u003d db.get_session()"},{"line_number":283,"context_line":"    if session.query(network_models_v2.ProviderNetwork).filter_by("},{"line_number":284,"context_line":"            network_id\u003dnetwork_id).first():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2Fgo%3D","line":281,"updated":"2013-07-17 21:19:06.000000000","message":"Add docstring please.","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8e4b11eedd78433e61e130c32b926453fccc4d2c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                       tenant_id\u003dtenant_id)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"def add_provider_network(network_id, network_type, segmentation_id):"},{"line_number":282,"context_line":"    session \u003d db.get_session()"},{"line_number":283,"context_line":"    if session.query(network_models_v2.ProviderNetwork).filter_by("},{"line_number":284,"context_line":"            network_id\u003dnetwork_id).first():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FQA%3D","line":281,"in_reply_to":"AAAAQn%2F%2F%2Fgo%3D","updated":"2013-07-17 23:00:39.000000000","message":"Done","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"ba8a88349d07f6285d868c7ddcb0320db4e39dae","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        return network_id"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"def is_provider_network(network_id):"},{"line_number":309,"context_line":"    session \u003d db.get_session()"},{"line_number":310,"context_line":"    if session.query(network_models_v2.ProviderNetwork).filter_by("},{"line_number":311,"context_line":"            network_id\u003dnetwork_id).first():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2Fgk%3D","line":308,"updated":"2013-07-17 21:19:06.000000000","message":"Add docstring please.","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8e4b11eedd78433e61e130c32b926453fccc4d2c","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        return network_id"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"def is_provider_network(network_id):"},{"line_number":309,"context_line":"    session \u003d db.get_session()"},{"line_number":310,"context_line":"    if session.query(network_models_v2.ProviderNetwork).filter_by("},{"line_number":311,"context_line":"            network_id\u003dnetwork_id).first():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FPE%3D","line":308,"in_reply_to":"AAAAQn%2F%2F%2Fgk%3D","updated":"2013-07-17 23:00:39.000000000","message":"Done","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"ba8a88349d07f6285d868c7ddcb0320db4e39dae","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        return True"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def is_provider_vlan(vlan_id):"},{"line_number":316,"context_line":"    session \u003d db.get_session()"},{"line_number":317,"context_line":"    if (session.query(network_models_v2.ProviderNetwork)."},{"line_number":318,"context_line":"            filter_by(network_type\u003dconst.NETWORK_TYPE_VLAN)."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2Fgg%3D","line":315,"updated":"2013-07-17 21:19:06.000000000","message":"Add docstring please.","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8e4b11eedd78433e61e130c32b926453fccc4d2c","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        return True"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"def is_provider_vlan(vlan_id):"},{"line_number":316,"context_line":"    session \u003d db.get_session()"},{"line_number":317,"context_line":"    if (session.query(network_models_v2.ProviderNetwork)."},{"line_number":318,"context_line":"            filter_by(network_type\u003dconst.NETWORK_TYPE_VLAN)."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FPA%3D","line":315,"in_reply_to":"AAAAQn%2F%2F%2Fgg%3D","updated":"2013-07-17 23:00:39.000000000","message":"Done","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"6df4add8a565af31b7648d07a1bf3510db5fff29","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    \"\"\""},{"line_number":323,"context_line":"    session \u003d db.get_session()"},{"line_number":324,"context_line":"    if (session.query(network_models_v2.ProviderNetwork)."},{"line_number":325,"context_line":"            filter_by(network_type\u003dconst.NETWORK_TYPE_VLAN)."},{"line_number":326,"context_line":"            filter_by(segmentation_id\u003dvlan_id).first()):"},{"line_number":327,"context_line":"        return True"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2F6%2Fk%3D","line":325,"updated":"2013-07-19 03:57:05.000000000","message":"you can do one filter_by with two keyword parameters instead of two calls.","commit_id":"f102dda6b96ab3f57e3a2b30a9b9030b3a87d3ad"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7c0b3c7c35a2f7f788e32ad07032f95a14a87610","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    \"\"\""},{"line_number":323,"context_line":"    session \u003d db.get_session()"},{"line_number":324,"context_line":"    if (session.query(network_models_v2.ProviderNetwork)."},{"line_number":325,"context_line":"            filter_by(network_type\u003dconst.NETWORK_TYPE_VLAN)."},{"line_number":326,"context_line":"            filter_by(segmentation_id\u003dvlan_id).first()):"},{"line_number":327,"context_line":"        return True"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2Fvho%3D","line":325,"in_reply_to":"AAAAQn%2F%2F6%2Fk%3D","updated":"2013-07-24 04:27:52.000000000","message":"Done","commit_id":"f102dda6b96ab3f57e3a2b30a9b9030b3a87d3ad"}],"neutron/plugins/cisco/db/network_models_v2.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                                  self.password)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class ProviderVlanNetworks(model_base.BASEV2, L2NetworkBase):"},{"line_number":134,"context_line":"    \"\"\"Represents VLAN networks that were created as provider networks.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1uk%3D","line":133,"updated":"2013-07-10 16:26:52.000000000","message":"Make this ProviderNetworks instead of ProviderVlanNetworks to account for other network types as well.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                                  self.password)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class ProviderVlanNetworks(model_base.BASEV2, L2NetworkBase):"},{"line_number":134,"context_line":"    \"\"\"Represents VLAN networks that were created as provider networks.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1WI%3D","line":133,"in_reply_to":"AAAAP3%2F%2F1uk%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"class ProviderVlanNetworks(model_base.BASEV2, L2NetworkBase):"},{"line_number":134,"context_line":"    \"\"\"Represents VLAN networks that were created as provider networks.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":139,"context_line":"    vlan_id \u003d Column(Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1uI%3D","line":136,"updated":"2013-07-10 16:26:52.000000000","message":"Change to cisco_provider_networks.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"2f558b4ec4e82e147f6c05a583887c0108f41dcc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"class ProviderVlanNetworks(model_base.BASEV2, L2NetworkBase):"},{"line_number":134,"context_line":"    \"\"\"Represents VLAN networks that were created as provider networks.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":139,"context_line":"    vlan_id \u003d Column(Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F2P0%3D","line":136,"updated":"2013-07-10 16:35:17.000000000","message":"I believe that the convention for a neutron base class is that the class name is singular (e.g. \"ProviderNetwork\") and the table name is the pluralized name of the class (e.g. \"cisco_provider_networks\"). (I\u0027m basing this on the comment following the definition of __tablename__ in class NeutronBaseV2).","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":133,"context_line":"class ProviderVlanNetworks(model_base.BASEV2, L2NetworkBase):"},{"line_number":134,"context_line":"    \"\"\"Represents VLAN networks that were created as provider networks.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":139,"context_line":"    vlan_id \u003d Column(Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Uk%3D","line":136,"in_reply_to":"AAAAP3%2F%2F1uI%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":133,"context_line":"class ProviderVlanNetworks(model_base.BASEV2, L2NetworkBase):"},{"line_number":134,"context_line":"    \"\"\"Represents VLAN networks that were created as provider networks.\"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":139,"context_line":"    vlan_id \u003d Column(Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Ug%3D","line":136,"in_reply_to":"AAAAP3%2F%2F2P0%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":139,"context_line":"    vlan_id \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, network_id, vlan_id):"},{"line_number":142,"context_line":"        self.network_id \u003d network_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1uY%3D","line":139,"updated":"2013-07-10 16:26:52.000000000","message":"Change to segmentation_id for all networks types.\n\nAdd another column for network_type (vlan, gre, vxlan etc..)","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    __tablename__ \u003d \u0027cisco_provider_vlans\u0027"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":139,"context_line":"    vlan_id \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, network_id, vlan_id):"},{"line_number":142,"context_line":"        self.network_id \u003d network_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1UY%3D","line":139,"in_reply_to":"AAAAP3%2F%2F1uY%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"dca9fbd6dcf1ce42f962aebfcd213cdc2853762e","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, network_id, vlan_id):"},{"line_number":142,"context_line":"        self.network_id \u003d network_id"},{"line_number":143,"context_line":"        self.vlan_id \u003d vlan_id"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __repr__(self):"},{"line_number":146,"context_line":"        return \"\u003cProviderVlanNetwork(%s)\u003e\" % (self.network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1uU%3D","line":143,"updated":"2013-07-10 16:26:52.000000000","message":"Change to segmentation_id.","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, network_id, vlan_id):"},{"line_number":142,"context_line":"        self.network_id \u003d network_id"},{"line_number":143,"context_line":"        self.vlan_id \u003d vlan_id"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __repr__(self):"},{"line_number":146,"context_line":"        return \"\u003cProviderVlanNetwork(%s)\u003e\" % (self.network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1UU%3D","line":143,"in_reply_to":"AAAAP3%2F%2F1uU%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"057dca4c1f0148d20bcbfec26eea586811fc0b7f","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, network_id, segmentation_id):"},{"line_number":142,"context_line":"        self.network_id \u003d network_id"},{"line_number":143,"context_line":"        self.segmentation_id \u003d segmentation_id"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __repr__(self):"},{"line_number":146,"context_line":"        return \"\u003cProviderNetwork(%s, %s)\u003e\" % (self.network_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyRE%3D","line":143,"updated":"2013-07-11 14:48:25.000000000","message":"Add another string field for network_type to differentiate between vlan, gre, vxlan etc. networks.","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d20f498d22b16c7ad70c9fbb35a6836728411f43","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, network_id, segmentation_id):"},{"line_number":142,"context_line":"        self.network_id \u003d network_id"},{"line_number":143,"context_line":"        self.segmentation_id \u003d segmentation_id"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __repr__(self):"},{"line_number":146,"context_line":"        return \"\u003cProviderNetwork(%s, %s)\u003e\" % (self.network_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyAc%3D","line":143,"in_reply_to":"AAAAP3%2F%2FyRE%3D","updated":"2013-07-15 15:53:46.000000000","message":"Done","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"ba8a88349d07f6285d868c7ddcb0320db4e39dae","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    network_type \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":94,"context_line":"    segmentation_id \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, network_id, network_type, segmentation_id):"},{"line_number":97,"context_line":"        self.network_id \u003d network_id"},{"line_number":98,"context_line":"        self.network_type \u003d network_type"},{"line_number":99,"context_line":"        self.segmentation_id \u003d segmentation_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FgQ%3D","line":96,"updated":"2013-07-17 21:19:06.000000000","message":"We don\u0027t need __init__ methods anymore with the neutron model_base.","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8e4b11eedd78433e61e130c32b926453fccc4d2c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    network_type \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":94,"context_line":"    segmentation_id \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, network_id, network_type, segmentation_id):"},{"line_number":97,"context_line":"        self.network_id \u003d network_id"},{"line_number":98,"context_line":"        self.network_type \u003d network_type"},{"line_number":99,"context_line":"        self.segmentation_id \u003d segmentation_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FRY%3D","line":96,"in_reply_to":"AAAAQn%2F%2F%2FgQ%3D","updated":"2013-07-17 23:00:39.000000000","message":"Done","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"ba8a88349d07f6285d868c7ddcb0320db4e39dae","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.network_type \u003d network_type"},{"line_number":99,"context_line":"        self.segmentation_id \u003d segmentation_id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __repr__(self):"},{"line_number":102,"context_line":"        return \"\u003cProviderNetwork(%s, %s, %s)\u003e\" % (self.network_id,"},{"line_number":103,"context_line":"                                                  self.network_type,"},{"line_number":104,"context_line":"                                                  self.segmentation_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FgM%3D","line":101,"updated":"2013-07-17 21:19:06.000000000","message":"We don\u0027t need __repr__ methods anymore with the model_base.","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8e4b11eedd78433e61e130c32b926453fccc4d2c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.network_type \u003d network_type"},{"line_number":99,"context_line":"        self.segmentation_id \u003d segmentation_id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __repr__(self):"},{"line_number":102,"context_line":"        return \"\u003cProviderNetwork(%s, %s, %s)\u003e\" % (self.network_id,"},{"line_number":103,"context_line":"                                                  self.network_type,"},{"line_number":104,"context_line":"                                                  self.segmentation_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F%2FRU%3D","line":101,"in_reply_to":"AAAAQn%2F%2F%2FgM%3D","updated":"2013-07-17 23:00:39.000000000","message":"Done","commit_id":"bab5eba5e1464afbf1ab3ad9a2625cc2ecf6b786"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"6df4add8a565af31b7648d07a1bf3510db5fff29","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    __tablename__ \u003d \u0027cisco_provider_networks\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":93,"context_line":"    network_type \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":94,"context_line":"    segmentation_id \u003d Column(Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2F6%2Fc%3D","line":92,"updated":"2013-07-19 03:57:05.000000000","message":"This should have ForeignKey relationship to a Neutron net id.  It should also be 36 chars.","commit_id":"f102dda6b96ab3f57e3a2b30a9b9030b3a87d3ad"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7c0b3c7c35a2f7f788e32ad07032f95a14a87610","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    __tablename__ \u003d \u0027cisco_provider_networks\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    network_id \u003d Column(String(255), primary_key\u003dTrue)"},{"line_number":93,"context_line":"    network_type \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":94,"context_line":"    segmentation_id \u003d Column(Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FvhI%3D","line":92,"in_reply_to":"AAAAQn%2F%2F6%2Fc%3D","updated":"2013-07-24 04:27:52.000000000","message":"Done","commit_id":"f102dda6b96ab3f57e3a2b30a9b9030b3a87d3ad"}],"neutron/plugins/cisco/models/virt_phy_sw_v2.py":[{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"2f558b4ec4e82e147f6c05a583887c0108f41dcc","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                                    self._func_name(),"},{"line_number":269,"context_line":"                                                    args)"},{"line_number":270,"context_line":"        cdb.remove_provider_vlan_network(id)"},{"line_number":271,"context_line":"        LOG.debug(_(\"provider network removed from DB: %s\"), id)"},{"line_number":272,"context_line":"        return ovs_output[0]"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_network(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F2D8%3D","line":271,"updated":"2013-07-10 16:35:17.000000000","message":"Should this LOG.debug message be generated conditionally, based on whether this is an actual provider network?","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                                    self._func_name(),"},{"line_number":269,"context_line":"                                                    args)"},{"line_number":270,"context_line":"        cdb.remove_provider_vlan_network(id)"},{"line_number":271,"context_line":"        LOG.debug(_(\"provider network removed from DB: %s\"), id)"},{"line_number":272,"context_line":"        return ovs_output[0]"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_network(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1Zk%3D","line":271,"in_reply_to":"AAAAP3%2F%2F2D8%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"}],"neutron/plugins/cisco/network_plugin.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"884e062fd6a4f7e992b96aaf3e6688d9f7a5f974","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class PluginV2(db_base_plugin_v2.NeutronDbPluginV2):"},{"line_number":39,"context_line":"    \"\"\"Meta-Plugin with v2 API support for multiple sub-plugins.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    supported_extension_aliases \u003d [\"Cisco Credential\", \"Cisco qos\"]"},{"line_number":42,"context_line":"    _methods_to_delegate \u003d [\u0027create_network\u0027,"},{"line_number":43,"context_line":"                            \u0027delete_network\u0027, \u0027update_network\u0027, \u0027get_network\u0027,"},{"line_number":44,"context_line":"                            \u0027get_networks\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FtCY%3D","line":41,"updated":"2013-07-24 18:53:15.000000000","message":"No need to add providernet here?","commit_id":"731401e59c11755f2de457a95719478f7035ccba"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a6c4c964306c3f1618e374a383d52d953b690f37","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class PluginV2(db_base_plugin_v2.NeutronDbPluginV2):"},{"line_number":39,"context_line":"    \"\"\"Meta-Plugin with v2 API support for multiple sub-plugins.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    supported_extension_aliases \u003d [\"Cisco Credential\", \"Cisco qos\"]"},{"line_number":42,"context_line":"    _methods_to_delegate \u003d [\u0027create_network\u0027,"},{"line_number":43,"context_line":"                            \u0027delete_network\u0027, \u0027update_network\u0027, \u0027get_network\u0027,"},{"line_number":44,"context_line":"                            \u0027get_networks\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2Fs%2Bc%3D","line":41,"in_reply_to":"AAAAQn%2F%2FtCY%3D","updated":"2013-07-24 19:10:32.000000000","message":"These are Cisco extensions, and providernet is a Neutron extension, so it doesn\u0027t get added here. It is added in the sub-plugin (VirtualPhysicalSwitchModelV2).","commit_id":"731401e59c11755f2de457a95719478f7035ccba"}],"neutron/plugins/cisco/nexus/cisco_nexus_plugin_v2.py":[{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"057dca4c1f0148d20bcbfec26eea586811fc0b7f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                         int(nexus_ssh_port),"},{"line_number":72,"context_line":"                                         nexus_username,"},{"line_number":73,"context_line":"                                         nexus_password)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_all_networks(self, tenant_id):"},{"line_number":76,"context_line":"        \"\"\"Get all networks."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyM0%3D","line":74,"updated":"2013-07-11 14:48:25.000000000","message":"Ideally this should be in the cisco_nexus_driver_v2.py file. There can be multiple drivers under the plugin like netconf, OnePK, thrift etc. and it\u0027s best to let each driver manage connections instead of trying to account for all of them in the plugin.","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d20f498d22b16c7ad70c9fbb35a6836728411f43","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                         int(nexus_ssh_port),"},{"line_number":72,"context_line":"                                         nexus_username,"},{"line_number":73,"context_line":"                                         nexus_password)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def get_all_networks(self, tenant_id):"},{"line_number":76,"context_line":"        \"\"\"Get all networks."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fojk%3D","line":74,"in_reply_to":"AAAAP3%2F%2FyM0%3D","updated":"2013-07-15 15:53:46.000000000","message":"Done","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"057dca4c1f0148d20bcbfec26eea586811fc0b7f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            auto_trunk \u003d conf.CISCO.provider_vlan_auto_trunk"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Check if this network is already in the DB"},{"line_number":117,"context_line":"        vlan_created_and_trunked \u003d False"},{"line_number":118,"context_line":"        vlan_created \u003d False"},{"line_number":119,"context_line":"        vlan_trunked \u003d False"},{"line_number":120,"context_line":"        man \u003d self.get_management_connection(switch_ip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyLE%3D","line":117,"updated":"2013-07-11 14:48:25.000000000","message":"Is this flag required? the two flags below this seem to answer this question.","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d20f498d22b16c7ad70c9fbb35a6836728411f43","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            auto_trunk \u003d conf.CISCO.provider_vlan_auto_trunk"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Check if this network is already in the DB"},{"line_number":117,"context_line":"        vlan_created_and_trunked \u003d False"},{"line_number":118,"context_line":"        vlan_created \u003d False"},{"line_number":119,"context_line":"        vlan_trunked \u003d False"},{"line_number":120,"context_line":"        man \u003d self.get_management_connection(switch_ip)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fojg%3D","line":117,"in_reply_to":"AAAAP3%2F%2FyLE%3D","updated":"2013-07-15 15:53:46.000000000","message":"Done","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"057dca4c1f0148d20bcbfec26eea586811fc0b7f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":154,"context_line":"                # Add binding failed, roll back any vlan creation/enabling"},{"line_number":155,"context_line":"                if vlan_created_and_trunked:"},{"line_number":156,"context_line":"                    LOG.debug(\"Nexus: delete \u0026 untrunk vlan %s\" % vlan_name)"},{"line_number":157,"context_line":"                    self._client.delete_and_untrunk_vlan(man, vlan_id,"},{"line_number":158,"context_line":"                                                         port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyKs%3D","line":155,"updated":"2013-07-11 14:48:25.000000000","message":"Can remove this flag by just replacing this with if vlan_created and vlan_trunked.","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d20f498d22b16c7ad70c9fbb35a6836728411f43","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":154,"context_line":"                # Add binding failed, roll back any vlan creation/enabling"},{"line_number":155,"context_line":"                if vlan_created_and_trunked:"},{"line_number":156,"context_line":"                    LOG.debug(\"Nexus: delete \u0026 untrunk vlan %s\" % vlan_name)"},{"line_number":157,"context_line":"                    self._client.delete_and_untrunk_vlan(man, vlan_id,"},{"line_number":158,"context_line":"                                                         port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fojc%3D","line":155,"in_reply_to":"AAAAP3%2F%2FyKs%3D","updated":"2013-07-15 15:53:46.000000000","message":"Done","commit_id":"86c60d936eae3a615bbb98dd7558ccccb119b6a5"}],"neutron/tests/unit/cisco/test_network_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"6df4add8a565af31b7648d07a1bf3510db5fff29","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        cfg.CONF.set_override(\u0027network_vlan_ranges\u0027, [phys_vrange], \u0027OVS\u0027)"},{"line_number":530,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        super(TestCiscoNetworksV2, self).setUp()"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def test_create_networks_bulk_emulated_plugin_failure(self):"},{"line_number":535,"context_line":"        real_has_attr \u003d hasattr"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2F6%2FM%3D","line":532,"updated":"2013-07-19 03:57:05.000000000","message":"I would suggest calling setUp first instead of last.","commit_id":"f102dda6b96ab3f57e3a2b30a9b9030b3a87d3ad"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7c0b3c7c35a2f7f788e32ad07032f95a14a87610","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        cfg.CONF.set_override(\u0027network_vlan_ranges\u0027, [phys_vrange], \u0027OVS\u0027)"},{"line_number":530,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        super(TestCiscoNetworksV2, self).setUp()"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def test_create_networks_bulk_emulated_plugin_failure(self):"},{"line_number":535,"context_line":"        real_has_attr \u003d hasattr"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FvfI%3D","line":532,"in_reply_to":"AAAAQn%2F%2F6%2FM%3D","updated":"2013-07-24 04:27:52.000000000","message":"That doesn\u0027t work. I have to override the OVS settings before calling the superclass setUps.","commit_id":"f102dda6b96ab3f57e3a2b30a9b9030b3a87d3ad"}],"neutron/tests/unit/cisco/test_nexus_plugin.py":[{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"495e6c47de4f1de787bf194f3b16215eb995999c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_create_providernet(self):"},{"line_number":132,"context_line":"        with mock.patch.object(cdb, \u0027is_provider_vlan\u0027,"},{"line_number":133,"context_line":"                               return_value\u003dself.vlan_id) as mock_db:"},{"line_number":134,"context_line":"            new_net_dict \u003d self._cisco_nexus_plugin.create_network("},{"line_number":135,"context_line":"                self.providernet, self.attachment)"},{"line_number":136,"context_line":"            mock_db.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1gw%3D","line":133,"updated":"2013-07-10 16:45:26.000000000","message":"Should the return_value for is_provider_vlan be set to True, instead of self.vlan_id?","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d8d16ee6c0614342f192e18bb40135dcc1c4871","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_create_providernet(self):"},{"line_number":132,"context_line":"        with mock.patch.object(cdb, \u0027is_provider_vlan\u0027,"},{"line_number":133,"context_line":"                               return_value\u003dself.vlan_id) as mock_db:"},{"line_number":134,"context_line":"            new_net_dict \u003d self._cisco_nexus_plugin.create_network("},{"line_number":135,"context_line":"                self.providernet, self.attachment)"},{"line_number":136,"context_line":"            mock_db.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F1aA%3D","line":133,"in_reply_to":"AAAAP3%2F%2F1gw%3D","updated":"2013-07-10 19:38:54.000000000","message":"Done","commit_id":"7c800fe7a500378c4aa89aecb26c637ba71fdc04"}]}