)]}'
{"neutron/services/trunk/plugin.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d36a16db884921a1e66eebd4c845fdb94c587bf","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # Otherwise a transition to BUILD (or ERROR) should be expected"},{"line_number":166,"context_line":"        # depending on how the driver reacts. PRECOMMIT failures prevent the"},{"line_number":167,"context_line":"        # trunk from being created altogether."},{"line_number":168,"context_line":"        trunk_description \u003d trunk.get(\u0027description\u0027, \u0027\u0027)"},{"line_number":169,"context_line":"        trunk_obj \u003d trunk_objects.Trunk(context\u003dcontext,"},{"line_number":170,"context_line":"                                        admin_state_up\u003dadmin_state_up,"},{"line_number":171,"context_line":"                                        id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fbf6855b","line":168,"updated":"2016-08-30 11:36:54.000000000","message":"Given that trunk payload is already validated, why don\u0027t we just pass all values to the object and let object layer handle the defaults. Mandatory fields can be passed explicitly i.e.\n\n  trunk_obj \u003d trunk_objects.Trunk(\n     context\u003dcontext,\n     tenant_id\u003dtrunk[\u0027tenant_id\u0027]\n     ...\n     **trunk)","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8ab5f3456aa74a730dd19a6b32418edfd3f1fccc","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # Otherwise a transition to BUILD (or ERROR) should be expected"},{"line_number":166,"context_line":"        # depending on how the driver reacts. PRECOMMIT failures prevent the"},{"line_number":167,"context_line":"        # trunk from being created altogether."},{"line_number":168,"context_line":"        trunk_description \u003d trunk.get(\u0027description\u0027, \u0027\u0027)"},{"line_number":169,"context_line":"        trunk_obj \u003d trunk_objects.Trunk(context\u003dcontext,"},{"line_number":170,"context_line":"                                        admin_state_up\u003dadmin_state_up,"},{"line_number":171,"context_line":"                                        id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_1c9ea606","line":168,"in_reply_to":"fa7ab95a_1aa151f8","updated":"2016-08-30 17:11:30.000000000","message":"If you think so :) With leaving objects handle the default, you have it all in one place. With current code the default value lies somewhere in this method.","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"281b28af8cb0b71d09fc507d6405018395e959d4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # Otherwise a transition to BUILD (or ERROR) should be expected"},{"line_number":166,"context_line":"        # depending on how the driver reacts. PRECOMMIT failures prevent the"},{"line_number":167,"context_line":"        # trunk from being created altogether."},{"line_number":168,"context_line":"        trunk_description \u003d trunk.get(\u0027description\u0027, \u0027\u0027)"},{"line_number":169,"context_line":"        trunk_obj \u003d trunk_objects.Trunk(context\u003dcontext,"},{"line_number":170,"context_line":"                                        admin_state_up\u003dadmin_state_up,"},{"line_number":171,"context_line":"                                        id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_1aa151f8","line":168,"in_reply_to":"fa7ab95a_4f007966","updated":"2016-08-30 15:12:00.000000000","message":"And by ugly I mean not readable and self documenting.","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"928861eac7b01b0022670f501092be29bb57b030","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        # Otherwise a transition to BUILD (or ERROR) should be expected"},{"line_number":166,"context_line":"        # depending on how the driver reacts. PRECOMMIT failures prevent the"},{"line_number":167,"context_line":"        # trunk from being created altogether."},{"line_number":168,"context_line":"        trunk_description \u003d trunk.get(\u0027description\u0027, \u0027\u0027)"},{"line_number":169,"context_line":"        trunk_obj \u003d trunk_objects.Trunk(context\u003dcontext,"},{"line_number":170,"context_line":"                                        admin_state_up\u003dadmin_state_up,"},{"line_number":171,"context_line":"                                        id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_4f007966","line":168,"in_reply_to":"fa7ab95a_fbf6855b","updated":"2016-08-30 15:06:58.000000000","message":"because it\u0027s ugly :)","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"}],"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d36a16db884921a1e66eebd4c845fdb94c587bf","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_trunk, trunk_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.idempotent_id(\u00274ce46c22-a2b6-4659-bc5a-0ef2463cab32\u0027)"},{"line_number":95,"context_line":"    def test_create_update_trunk(self):"},{"line_number":96,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":97,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":98,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_9e99e7c6","line":95,"updated":"2016-08-30 11:36:54.000000000","message":"As description is not mandatory, we should also cover a case where we don\u0027t pass description. i.e. I\u0027d leave the previous test as is and create a new one using description.","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8ab5f3456aa74a730dd19a6b32418edfd3f1fccc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_trunk, trunk_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.idempotent_id(\u00274ce46c22-a2b6-4659-bc5a-0ef2463cab32\u0027)"},{"line_number":95,"context_line":"    def test_create_update_trunk(self):"},{"line_number":96,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":97,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":98,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fce2e2d3","line":95,"in_reply_to":"fa7ab95a_8f3d212d","updated":"2016-08-30 17:11:30.000000000","message":"I think we should have a test where we pass all the parameters and where we test only mandatory parameters. We can add it as followup though, if you want.","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"928861eac7b01b0022670f501092be29bb57b030","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_trunk, trunk_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.idempotent_id(\u00274ce46c22-a2b6-4659-bc5a-0ef2463cab32\u0027)"},{"line_number":95,"context_line":"    def test_create_update_trunk(self):"},{"line_number":96,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":97,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":98,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_8f3d212d","line":95,"in_reply_to":"fa7ab95a_9e99e7c6","updated":"2016-08-30 15:06:58.000000000","message":"neither is the name. I can split the test if you like though.","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"730ae6e346d81a97008308e77955111a5cc5b50a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_trunk, trunk_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.idempotent_id(\u00274ce46c22-a2b6-4659-bc5a-0ef2463cab32\u0027)"},{"line_number":95,"context_line":"    def test_create_update_trunk(self):"},{"line_number":96,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":97,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":98,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_433da229","line":95,"in_reply_to":"fa7ab95a_fce2e2d3","updated":"2016-08-30 19:17:12.000000000","message":"To be honest, I also like having separate tests testing separate things. You won me over.","commit_id":"3af91143594b2b5ed20944ac4b72b0e7b46709e5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"463db6936f6fde170e5e1086b205dcb1fa0b2f89","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @test.idempotent_id(\u00275ff46c22-a2b6-5559-bc5a-0ef2463cab32\u0027)"},{"line_number":110,"context_line":"    def test_create_update_trunk_with_description(self):"},{"line_number":111,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":112,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":113,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"},{"line_number":114,"context_line":"        self.assertEqual(\"foo description\", trunk[\u0027trunk\u0027][\u0027description\u0027])"},{"line_number":115,"context_line":"        trunk \u003d self.client.update_trunk(trunk_id, description\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_a962cf3b","line":112,"updated":"2016-08-30 19:52:50.000000000","message":"I\u0027d also add \u0027name\u0027 here. So we have test cases for mandatory and optional parameters.","commit_id":"625c2233d07f706df7eacb7114986196d62fbdf5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9fdb962aa54c8a491674502c1b2230b7d70e0df8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @test.idempotent_id(\u00275ff46c22-a2b6-5559-bc5a-0ef2463cab32\u0027)"},{"line_number":110,"context_line":"    def test_create_update_trunk_with_description(self):"},{"line_number":111,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":112,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":113,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"},{"line_number":114,"context_line":"        self.assertEqual(\"foo description\", trunk[\u0027trunk\u0027][\u0027description\u0027])"},{"line_number":115,"context_line":"        trunk \u003d self.client.update_trunk(trunk_id, description\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_dbaefa7f","line":112,"in_reply_to":"fa7ab95a_9b28f287","updated":"2016-08-30 20:04:32.000000000","message":"That was brainfart, sorry.  Testing \u0027name\u0027 is not in scope of this patch.","commit_id":"625c2233d07f706df7eacb7114986196d62fbdf5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ede0833fb8ca1e66294302e4e3e55e356cd3a8f6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @test.idempotent_id(\u00275ff46c22-a2b6-5559-bc5a-0ef2463cab32\u0027)"},{"line_number":110,"context_line":"    def test_create_update_trunk_with_description(self):"},{"line_number":111,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":112,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":113,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"},{"line_number":114,"context_line":"        self.assertEqual(\"foo description\", trunk[\u0027trunk\u0027][\u0027description\u0027])"},{"line_number":115,"context_line":"        trunk \u003d self.client.update_trunk(trunk_id, description\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_9b28f287","line":112,"in_reply_to":"fa7ab95a_a962cf3b","updated":"2016-08-30 19:57:50.000000000","message":"why? Name is not mandatory, and neither is description.\n\nThis test is about checking that the description attribute is accepted/returned and processed properly. What does \u0027name\u0027 have to do with this test condition?","commit_id":"625c2233d07f706df7eacb7114986196d62fbdf5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f94c582666707af914da695fc864499b15c444e1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @test.idempotent_id(\u00275ff46c22-a2b6-5559-bc5a-0ef2463cab32\u0027)"},{"line_number":110,"context_line":"    def test_create_update_trunk_with_description(self):"},{"line_number":111,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent("},{"line_number":112,"context_line":"            None, description\u003d\"foo description\")"},{"line_number":113,"context_line":"        trunk_id \u003d trunk[\u0027trunk\u0027][\u0027id\u0027]"},{"line_number":114,"context_line":"        self.assertEqual(\"foo description\", trunk[\u0027trunk\u0027][\u0027description\u0027])"},{"line_number":115,"context_line":"        trunk \u003d self.client.update_trunk(trunk_id, description\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_3e38b4d2","line":112,"in_reply_to":"fa7ab95a_dbaefa7f","updated":"2016-08-30 20:12:47.000000000","message":"no problemo! Now APPROVE :)","commit_id":"625c2233d07f706df7eacb7114986196d62fbdf5"}]}
