)]}'
{"neutron/extensions/trunk.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1528121a907bf99ae0265393b5a75ee244c51cf9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027created_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":58,"context_line":"        \u0027updated_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":59,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":60,"context_line":"    },"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_3b8e2d2e","line":59,"updated":"2016-08-30 11:25:03.000000000","message":"I think you should just add trunk resource to timestamp extension: https://github.com/openstack/neutron/blob/master/neutron/extensions/timestamp_core.py and let the extension handle the resource just like it does with all other resources.","commit_id":"a6a5025a330a4fd67959c945f4d048e1b210c94c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"82659353256713dd0c6cf8809fe3d1513babda72","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027created_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":58,"context_line":"        \u0027updated_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":59,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":60,"context_line":"    },"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_aff025ca","line":59,"in_reply_to":"fa7ab95a_3b8e2d2e","updated":"2016-08-30 15:04:07.000000000","message":"This is not a core resource, besides there\u0027s an effort in progress [1] to apply these attributes to other resources, which should be more appropriate. Having said that, since this API is not released, there\u0027s no point in going through a level of indirection when we can simply advertise the attributes here. Hence I did it this way. There\u0027s a glitch with the API tests that I am still figuring out though, but using any other approach won\u0027t change that.\n\n[1] https://review.openstack.org/#/c/312873/","commit_id":"a6a5025a330a4fd67959c945f4d048e1b210c94c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"36dc4f5d897e4e533feb4ba7513d79be907cd842","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027created_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":58,"context_line":"        \u0027updated_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":59,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":60,"context_line":"    },"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f763dbae","line":59,"in_reply_to":"fa7ab95a_5adf5939","updated":"2016-08-30 17:24:00.000000000","message":"If we diverse of what\u0027s in tree then it will be harder for maintainers to look where the things are defined - core resources in timestamp extension vs extension resources in extensions itself.","commit_id":"a6a5025a330a4fd67959c945f4d048e1b210c94c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b1090660bbaa90d320817a3b2c8bb758b39456ff","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027created_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":58,"context_line":"        \u0027updated_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":59,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":60,"context_line":"    },"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_5adf5939","line":59,"in_reply_to":"fa7ab95a_aff025ca","updated":"2016-08-30 15:14:22.000000000","message":"To me it makes more sense to be cohesive and have things closer to where they belong.","commit_id":"a6a5025a330a4fd67959c945f4d048e1b210c94c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"02ab702356e0ba388576714243b897f112eede30","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027created_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":58,"context_line":"        \u0027updated_at\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":59,"context_line":"                       \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":60,"context_line":"    },"},{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fb13be62","line":59,"in_reply_to":"fa7ab95a_f763dbae","updated":"2016-08-30 20:12:10.000000000","message":"I talked to Kevin, we\u0027ll clean this up afterwards so that these are no longer required in here, same way with description.","commit_id":"a6a5025a330a4fd67959c945f4d048e1b210c94c"}]}
