)]}'
{"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"cf636baffedc58c3a55f37df7bcebbd6bd592db4","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_3bcc4688","line":720,"updated":"2016-08-30 20:02:16.000000000","message":"I\u0027m not sure about this. The test in this repo sets everything up so that l3-ha is supported. You\u0027re running this test in a separate repo and doing the setup differently, but running this test anyway. Can\u0027t you skip it in the ODL repo?","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f8d39c20a2a09a235ef5c138fe4ec95e0ea005e","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_712eed8c","line":720,"in_reply_to":"fa7ab95a_3bcc4688","updated":"2016-08-30 20:48:31.000000000","message":"Yes, such patch is in process.\nhttps://review.openstack.org/#/c/363184/\n\nml2/test_plugin.py is common code base for each plugins, right?\nAt least the fact is that multiple plugins(OVN, ODL, etc) are using test case as base class.  And it\u0027s how tests have been written before neutron repo split.\n\n\nIf this test case should preclude l3 plugin without l3-ha, such test case shouldn\u0027t live in this file, but something like ml2/test_l3_ha_agent_based_plugin.py.","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b7472180c10749175b00f8ad242460d5ad48c3fa","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_8062353c","line":720,"in_reply_to":"fa7ab95a_712eed8c","updated":"2016-08-30 22:31:38.000000000","message":"That makes more sense, to have a test class that isn\u0027t inherited by out of tree projects that can make sure the setup includes ML2 + in-tree L3 service plugin, but to have tests in this file that conditionally skip according to out of tree test classes that we have no knowledge of control over is bizarre.","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"589a592d0a701b6ebadecb48bc9f280044370ce5","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e83f6785","line":720,"in_reply_to":"fa7ab95a_8062353c","updated":"2016-08-31 00:04:30.000000000","message":"Unfortunately most of ML2 drivers work only with its own L3 plugin. don\u0027t work with in-tree L3 plugin.\nIn-tree L3 plugin is effectively only for ovs-agent (or agent based one).\n\nIt\u0027s a bad idea to mix in-tree l3 plugin specific test with general ML2 tests because it makes SDN controllers life difficult unnecessarily. Let\u0027s keep them separated.","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"589a592d0a701b6ebadecb48bc9f280044370ce5","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_28c30f8c","line":720,"in_reply_to":"fa7ab95a_8062353c","updated":"2016-08-31 00:04:30.000000000","message":"Unforunately most of ML2 drivers work only with its own L3 plugin. don\u0027t work with in-tree L3 plugin.\nIn-tree L3 plugin is effectively only for ovs-agnet (or agent based one).\n\nIt\u0027s a bad idea to mix in-tree l3 plugin specific test with general ML2 tests because it makes SDN controllers life difficult unnecessarily. Let\u0027s keep them separated.","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"589a592d0a701b6ebadecb48bc9f280044370ce5","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e8c847ab","line":720,"in_reply_to":"fa7ab95a_8062353c","updated":"2016-08-31 00:04:30.000000000","message":"Unforunately most of ML2 drivers work only with its own L3 plugin. don\u0027t work with in-tree L3 plugin.\nIn-tree L3 plugin is effectively only for ovs-agnet (or agent based one).\n\nIt\u0027s a bad idea to mix in-tree l3 plugin specific test with general ML2 tests because it makes SDN controllers life difficult unnecessarily. Let\u0027s keep them separated.","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"168491fd7321a85489d2accda07dbe2a89b2d8f6","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        l3_router_plugin.L3RouterPlugin()"},{"line_number":718,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":719,"context_line":"            p_const.L3_ROUTER_NAT)"},{"line_number":720,"context_line":"        if \u0027l3-ha\u0027 not in l3plugin.supported_extension_aliases:"},{"line_number":721,"context_line":"            self.skipTest(\"l3-ha isn\u0027t enabled\")"},{"line_number":722,"context_line":"        host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":723,"context_line":"        with mock.patch.object(l3plugin.l3_rpc_notifier,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_c66b5984","line":720,"in_reply_to":"fa7ab95a_e8c847ab","updated":"2016-08-31 10:49:42.000000000","message":"Yup, we\u0027re in agreement, are you moving this test then?","commit_id":"a8d1dcae7ff1da4b6e18a34e993af88a79d53241"}]}
