)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c88536354ac4e8763098139b5331ce76dde45c5a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Morales \u003cvictor.morales@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-17 17:15:20 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"GeneveAllocation OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces and implements OVO for Geneve Allocation."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da6895a0_93aa946f","line":7,"updated":"2016-10-20 21:27:46.000000000","message":"This patch also adds the OVO for GeneveEndpoint. Please add that to the title and the description of the message","commit_id":"a944f6fa110f3409b1bff83641e3f09bd5b876d3"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c88536354ac4e8763098139b5331ce76dde45c5a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"GeneveAllocation OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces and implements OVO for Geneve Allocation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ifcbc354acd1924be074da5f43c18a8c8462bd19a"},{"line_number":12,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da6895a0_7376e03f","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":36},"updated":"2016-10-20 21:27:46.000000000","message":"As Victor mentioned this patch does not implement the OVO for GeneveAllocation.","commit_id":"a944f6fa110f3409b1bff83641e3f09bd5b876d3"}],"neutron/objects/plugins/ml2/geneveallocation.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f03a31d403da52a69de73eee0197c5c9de86cb38","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db.models.plugins.ml2 import geneveallocation"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_34320860","line":18,"updated":"2016-09-15 16:48:24.000000000","message":"I think the db_model should be imported from /neutron/plugins/ml2/drivers/type_geneve.py\n\nSee: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_geneve.py#L50-L73","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f3462b998584ff507d131558754f8702a1b69141","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db.models.plugins.ml2 import geneveallocation"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_b74a9a24","line":18,"in_reply_to":"7a8ec9b2_34320860","updated":"2016-09-15 16:58:52.000000000","message":"I think this is good,if the patch is based on top of the relocate db_model patch.","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a445f1263bed8a1ffaf0a4cc4e30abf312ac024a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db.models.plugins.ml2 import geneveallocation"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_c15f40e3","line":18,"in_reply_to":"7a8ec9b2_b74a9a24","updated":"2016-09-16 09:40:17.000000000","message":"Nakul, but the patch IS based on that patch...","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"35870d0957ff24ddd301002dcde75d386123d01c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db.models.plugins.ml2 import geneveallocation"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_27db8350","line":18,"in_reply_to":"7a8ec9b2_c15f40e3","updated":"2016-09-16 14:43:15.000000000","message":"Yes it is,missed that earlier.","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f03a31d403da52a69de73eee0197c5c9de86cb38","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    db_model \u003d geneveallocation.GeneveAllocation"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_f11b52c8","line":30,"updated":"2016-09-15 16:48:24.000000000","message":"I think \u0027nullable\u003dFalse\u0027 is not needed here as it is set to False by default in Oslo fields.\nSee: https://review.openstack.org/#/c/336518/8/doc/source/devref/objects_usage.rst\nLine:157\nAn example can be found here:\n1)https://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L43-L44\n2)https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L114-L115","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a445f1263bed8a1ffaf0a4cc4e30abf312ac024a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    db_model \u003d geneveallocation.GeneveAllocation"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_a1e2342d","line":30,"in_reply_to":"7a8ec9b2_f11b52c8","updated":"2016-09-16 09:40:17.000000000","message":"+1","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":20136,"name":"John Woodburn","email":"john.l.woodburn@intel.com","username":"woodburn"},"change_message_id":"d27cdcf7051dac7e12e30d73e28aefef41aecae3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    db_model \u003d geneveallocation.GeneveAllocation"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_eb0196b0","line":30,"in_reply_to":"7a8ec9b2_f11b52c8","updated":"2016-09-16 20:21:38.000000000","message":"Fixed","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f03a31d403da52a69de73eee0197c5c9de86cb38","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    primary_keys \u003d [\u0027geneve_vni\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_d17576fa","line":31,"updated":"2016-09-15 16:48:24.000000000","message":"Ditto: Line30","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":20136,"name":"John Woodburn","email":"john.l.woodburn@intel.com","username":"woodburn"},"change_message_id":"d27cdcf7051dac7e12e30d73e28aefef41aecae3","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(nullable\u003dFalse),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    primary_keys \u003d [\u0027geneve_vni\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_4b336aab","line":31,"in_reply_to":"7a8ec9b2_d17576fa","updated":"2016-09-16 20:21:38.000000000","message":"Fixed","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f03a31d403da52a69de73eee0197c5c9de86cb38","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    db_model \u003d geneveallocation.GeneveEndpoints"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    fields \u003d {"},{"line_number":45,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(nullable\u003dFalse),"},{"line_number":46,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_d1e3b6a2","line":45,"updated":"2016-09-15 16:48:24.000000000","message":"Ditto: Line30","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":20136,"name":"John Woodburn","email":"john.l.woodburn@intel.com","username":"woodburn"},"change_message_id":"d27cdcf7051dac7e12e30d73e28aefef41aecae3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    db_model \u003d geneveallocation.GeneveEndpoints"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    fields \u003d {"},{"line_number":45,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(nullable\u003dFalse),"},{"line_number":46,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_2919c679","line":45,"in_reply_to":"7a8ec9b2_d1e3b6a2","updated":"2016-09-16 20:21:38.000000000","message":"Fixed","commit_id":"2f7db37f5c5c81b1988b56a9c9f286f75a4dd1c2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"5d14c4bd247eb519c33866f5675eb05934c5cc32","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    primary_keys \u003d [\u0027geneve_vni\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_7f8b5e68","line":31,"range":{"start_line":31,"start_character":44,"end_line":31,"end_character":46},"updated":"2016-09-26 14:35:33.000000000","message":"default\u003dFalse.","commit_id":"0c637ca3bf8def7effb66c5426a0cd2beecc08cd"},{"author":{"_account_id":20136,"name":"John Woodburn","email":"john.l.woodburn@intel.com","username":"woodburn"},"change_message_id":"d441cdbdb5cff38e82e8524153b93267c1c43572","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    primary_keys \u003d [\u0027geneve_vni\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_ba2f0f3d","line":31,"range":{"start_line":31,"start_character":44,"end_line":31,"end_character":46},"in_reply_to":"5a8bc5a2_7f8b5e68","updated":"2016-09-29 16:17:35.000000000","message":"Done","commit_id":"0c637ca3bf8def7effb66c5426a0cd2beecc08cd"},{"author":{"_account_id":20136,"name":"John Woodburn","email":"john.l.woodburn@intel.com","username":"woodburn"},"change_message_id":"cfd6641bb9867023ac94c06caf00957ee11e7597","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    primary_keys \u003d [\u0027geneve_vni\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a98d1f4_51b9d4e8","line":31,"range":{"start_line":31,"start_character":44,"end_line":31,"end_character":46},"in_reply_to":"5a8bc5a2_7f8b5e68","updated":"2016-09-28 16:30:09.000000000","message":"I\u0027m not sure I understand the comment. The field is defaulted to false. Are you suggesting to default to true?","commit_id":"0c637ca3bf8def7effb66c5426a0cd2beecc08cd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"586cab00aa621df35e9e930f4d1b08b09059485d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027geneve_vni\u0027: obj_fields.IntegerField(),"},{"line_number":31,"context_line":"        \u0027allocated\u0027: obj_fields.BooleanField(),"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    primary_keys \u003d [\u0027geneve_vni\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_3a693f26","line":31,"updated":"2016-09-29 16:24:11.000000000","message":"I think the default\u003dFalse got uploaded as a new patch at [1]. It is not reflected here. Can be committed here itself by amending the old commit.\n\n[1] - https://review.openstack.org/#/c/379570/","commit_id":"f1766cc147e220ada1c9112ae6e7094b3ea6f798"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c88536354ac4e8763098139b5331ce76dde45c5a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":38,"context_line":"class GeneveEndpoints(base.NeutronDbObject):"},{"line_number":39,"context_line":"    # Version 1.0: Intial version"},{"line_number":40,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da6895a0_b3dcf819","line":38,"updated":"2016-10-20 21:27:46.000000000","message":"The class name must be in singular form","commit_id":"a944f6fa110f3409b1bff83641e3f09bd5b876d3"}]}