)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"fe50a80b3222412b25891c39fa5603b182188992","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_cec86658","line":9,"updated":"2016-09-12 16:47:12.000000000","message":"open a launchpad ticket and link that for tracking","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0a9a4fe5ffec00ee9bceae6993dc73b2b6419a8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_ccdeae6c","line":9,"in_reply_to":"9a89bdaa_510b17d6","updated":"2016-09-12 17:20:17.000000000","message":"if this is required for few objects I thought would be good to have bug ticket to track these specific changes.","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2bfeec7ff794b661409baceb8c7dcd52041b0da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_e1e8d8e4","line":9,"in_reply_to":"9a89bdaa_6c3202a9","updated":"2016-09-12 18:54:17.000000000","message":"We already have one: blueprint adopt-oslo-versioned-objects-for-db. Just reuse it as we do for all other objects related patches.","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"441e2ff9981f42479a8e0842955ad84ff99c84e3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_6c3202a9","line":9,"in_reply_to":"9a89bdaa_ccdeae6c","updated":"2016-09-12 17:23:40.000000000","message":"blueprint may be time consuming ? does it require to submit spec as well? thought bug ticket would be quick and easy.","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0f6d62b2ec3ec6d3244457934825aef3f7af29f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_510b17d6","line":9,"in_reply_to":"9a89bdaa_cec86658","updated":"2016-09-12 17:00:01.000000000","message":"Wait, why a bug? Blueprint should be enough because it\u0027s Ocata material.","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4ad3ec398503a38cd65c08e4f1425565d83b24b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_a76b40b8","line":9,"in_reply_to":"9a89bdaa_e1e8d8e4","updated":"2016-09-12 19:45:15.000000000","message":"IMOH, bugs are more related with issues on the system. So, I\u0027m agree to reuse the blueprint adopt-oslo-versioned-objects-for-db but we have to explain better why we\u0027re changing the caller instead the OVO implementation.","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"64480150b992b081e0ceb72e851950fa7654b378","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohit Malik \u003cmohit.malik@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-12 15:07:19 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_4723e405","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"updated":"2016-09-13 18:31:23.000000000","message":"have one line heading followed by line space and description afterwards. for ref look\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"7e3fc1061eea134f1c7a98c0e64c078363a67b99"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"d29eb504fcfeb63ac72f9df1aedb288893aad20d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohit Malik \u003cmohit.malik@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-12 15:07:19 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_4d9305a4","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"in_reply_to":"7a8ec9b2_4723e405","updated":"2016-09-13 19:02:02.000000000","message":"Fixed","commit_id":"7e3fc1061eea134f1c7a98c0e64c078363a67b99"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"64480150b992b081e0ceb72e851950fa7654b378","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_a7dca819","line":9,"updated":"2016-09-13 18:31:23.000000000","message":"as per discussion add a tag \nPartially-Implements: blueprint adopt-oslo-versioned-objects-for-db\n\nfor tracking.","commit_id":"7e3fc1061eea134f1c7a98c0e64c078363a67b99"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"d29eb504fcfeb63ac72f9df1aedb288893aad20d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":"This change is required for implementing IPAM OVO."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I600ce4384632bf013846e8aa1618acb126f7c598"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_ade80918","line":9,"in_reply_to":"7a8ec9b2_a7dca819","updated":"2016-09-13 19:02:02.000000000","message":"Added","commit_id":"7e3fc1061eea134f1c7a98c0e64c078363a67b99"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b22befc1e581cc11d110f4c4ab9d378ce2b76739","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change IPAM DB API to use context instead of session object."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This code is not being used outside neutron tree so it\u0027s"},{"line_number":10,"context_line":"safe to change the api to use context instead of session."},{"line_number":11,"context_line":"This change is required for implementing Ipam OVO and is"},{"line_number":12,"context_line":"consistent with rest of the DB API code in neutron."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1a95cdbc_6eda727a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":57},"updated":"2016-10-04 17:39:51.000000000","message":"nit: I\u0027m not sure that this paragraph is still valid","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"}],"neutron/ipam/drivers/neutrondb_ipam/db_api.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b22befc1e581cc11d110f4c4ab9d378ce2b76739","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            neutron_subnet_id\u003dneutron_subnet_id).delete()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_pool(self, context, pool_start, pool_end):"},{"line_number":69,"context_line":"        \"\"\"Create an allocation pool and availability ranges for the subnet."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        This method does not perform any validation on parameters; it simply"},{"line_number":72,"context_line":"        persist data on the database."}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_aebb9a0d","line":69,"range":{"start_line":69,"start_character":37,"end_line":69,"end_character":60},"updated":"2016-10-04 17:39:51.000000000","message":"This change is unrelated","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"437e3d1a9df2b3e0add60dd4d427760b40f77624","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            neutron_subnet_id\u003dneutron_subnet_id).delete()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_pool(self, context, pool_start, pool_end):"},{"line_number":69,"context_line":"        \"\"\"Create an allocation pool and availability ranges for the subnet."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        This method does not perform any validation on parameters; it simply"},{"line_number":72,"context_line":"        persist data on the database."}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_4913f05c","line":69,"range":{"start_line":69,"start_character":37,"end_line":69,"end_character":60},"in_reply_to":"1a95cdbc_aebb9a0d","updated":"2016-10-04 17:47:46.000000000","message":"Fixed","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"}],"neutron/ipam/drivers/neutrondb_ipam/driver.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4ad3ec398503a38cd65c08e4f1425565d83b24b0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":185,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":186,"context_line":"        # should not create new nested transaction blocks."},{"line_number":187,"context_line":"        context \u003d self._context"},{"line_number":188,"context_line":"        all_pool_id \u003d None"},{"line_number":189,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"},{"line_number":190,"context_line":"        # model for address requests and just check whether there is a"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_87d63c4d","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":31},"updated":"2016-09-12 19:45:15.000000000","message":"do we need to keep this value in a variable? why we don\u0027t just pass the value itself?","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"8e3e149f66864f7ef9b698ca345bb3e7f76edc15","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":185,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":186,"context_line":"        # should not create new nested transaction blocks."},{"line_number":187,"context_line":"        context \u003d self._context"},{"line_number":188,"context_line":"        all_pool_id \u003d None"},{"line_number":189,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"},{"line_number":190,"context_line":"        # model for address requests and just check whether there is a"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_84a7aa4e","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":31},"in_reply_to":"9a89bdaa_87d63c4d","updated":"2016-09-13 18:13:42.000000000","message":"Because context is being used multiple times here, it\u0027s better to store the reference locally and use that instead of doing multiple operations each time using. (dot)","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4ad3ec398503a38cd65c08e4f1425565d83b24b0","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # delete IPAllocation objects, neither rebuilds availability ranges"},{"line_number":211,"context_line":"        # at every deallocation. The only operation it performs is to delete"},{"line_number":212,"context_line":"        # an IPRequest entry."},{"line_number":213,"context_line":"        context \u003d self._context"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        count \u003d self.subnet_manager.delete_allocation("},{"line_number":216,"context_line":"            context, address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_c7ccc4bd","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":31},"updated":"2016-09-12 19:45:15.000000000","message":"ditto: line 187","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"8e3e149f66864f7ef9b698ca345bb3e7f76edc15","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # delete IPAllocation objects, neither rebuilds availability ranges"},{"line_number":211,"context_line":"        # at every deallocation. The only operation it performs is to delete"},{"line_number":212,"context_line":"        # an IPRequest entry."},{"line_number":213,"context_line":"        context \u003d self._context"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        count \u003d self.subnet_manager.delete_allocation("},{"line_number":216,"context_line":"            context, address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_0472bae5","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":31},"in_reply_to":"9a89bdaa_c7ccc4bd","updated":"2016-09-13 18:13:42.000000000","message":"Will fix this","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4ad3ec398503a38cd65c08e4f1425565d83b24b0","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        # Pools have already been validated in the subnet request object which"},{"line_number":232,"context_line":"        # was sent to the subnet pool driver. Further validation should not be"},{"line_number":233,"context_line":"        # required."},{"line_number":234,"context_line":"        context \u003d self._context"},{"line_number":235,"context_line":"        if self._no_pool_changes(context, pools):"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":"        self.subnet_manager.delete_allocation_pools(context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_27bc9005","line":234,"updated":"2016-09-12 19:45:15.000000000","message":"ditto: line 187","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"8e3e149f66864f7ef9b698ca345bb3e7f76edc15","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        # Pools have already been validated in the subnet request object which"},{"line_number":232,"context_line":"        # was sent to the subnet pool driver. Further validation should not be"},{"line_number":233,"context_line":"        # required."},{"line_number":234,"context_line":"        context \u003d self._context"},{"line_number":235,"context_line":"        if self._no_pool_changes(context, pools):"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":"        self.subnet_manager.delete_allocation_pools(context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_a4490691","line":234,"in_reply_to":"9a89bdaa_27bc9005","updated":"2016-09-13 18:13:42.000000000","message":"same as above","commit_id":"ec57e4beca38b03accf0496e31f7c565a48684c8"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0dd4a42d62fa603564157d842ab2a92221202a5e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":185,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":186,"context_line":"        # should not create new nested transaction blocks."},{"line_number":187,"context_line":"        context \u003d self._context"},{"line_number":188,"context_line":"        all_pool_id \u003d None"},{"line_number":189,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"},{"line_number":190,"context_line":"        # model for address requests and just check whether there is a"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_a840db57","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":31},"updated":"2016-09-14 09:27:22.000000000","message":"no need for local variable.","commit_id":"abc0ddb69a1f3bf6a315b3f9507fe920e7adbb5b"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"67751a4cfb19de1686bbd20c983588df4ea5fe39","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # running transaction, which is started on create_port or upper level."},{"line_number":185,"context_line":"        # To be able to do rollback/retry actions correctly ipam driver"},{"line_number":186,"context_line":"        # should not create new nested transaction blocks."},{"line_number":187,"context_line":"        context \u003d self._context"},{"line_number":188,"context_line":"        all_pool_id \u003d None"},{"line_number":189,"context_line":"        # NOTE(salv-orlando): It would probably better to have a simpler"},{"line_number":190,"context_line":"        # model for address requests and just check whether there is a"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_dd02240b","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":31},"in_reply_to":"7a8ec9b2_a840db57","updated":"2016-09-14 18:01:00.000000000","message":"Fixed","commit_id":"abc0ddb69a1f3bf6a315b3f9507fe920e7adbb5b"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"0dd4a42d62fa603564157d842ab2a92221202a5e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        # Pools have already been validated in the subnet request object which"},{"line_number":230,"context_line":"        # was sent to the subnet pool driver. Further validation should not be"},{"line_number":231,"context_line":"        # required."},{"line_number":232,"context_line":"        context \u003d self._context"},{"line_number":233,"context_line":"        if self._no_pool_changes(context, pools):"},{"line_number":234,"context_line":"            return"},{"line_number":235,"context_line":"        self.subnet_manager.delete_allocation_pools(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_e8090333","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":31},"updated":"2016-09-14 09:27:22.000000000","message":"ditto line 187.","commit_id":"abc0ddb69a1f3bf6a315b3f9507fe920e7adbb5b"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"67751a4cfb19de1686bbd20c983588df4ea5fe39","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        # Pools have already been validated in the subnet request object which"},{"line_number":230,"context_line":"        # was sent to the subnet pool driver. Further validation should not be"},{"line_number":231,"context_line":"        # required."},{"line_number":232,"context_line":"        context \u003d self._context"},{"line_number":233,"context_line":"        if self._no_pool_changes(context, pools):"},{"line_number":234,"context_line":"            return"},{"line_number":235,"context_line":"        self.subnet_manager.delete_allocation_pools(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_400aa722","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":31},"in_reply_to":"7a8ec9b2_e8090333","updated":"2016-09-14 18:01:00.000000000","message":"Fixed","commit_id":"abc0ddb69a1f3bf6a315b3f9507fe920e7adbb5b"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b22befc1e581cc11d110f4c4ab9d378ce2b76739","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                              subnet_request.gateway_ip)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            pools \u003d subnet_request.allocation_pools"},{"line_number":72,"context_line":"        # Create IPAM allocation pools and availability ranges"},{"line_number":73,"context_line":"        cls.create_allocation_pools(subnet_manager, ctx, pools,"},{"line_number":74,"context_line":"                                    subnet_request.subnet_cidr)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_2ee22a04","line":72,"range":{"start_line":72,"start_character":38,"end_line":72,"end_character":62},"updated":"2016-10-04 17:39:51.000000000","message":"This change is unrelated","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"437e3d1a9df2b3e0add60dd4d427760b40f77624","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                              subnet_request.gateway_ip)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            pools \u003d subnet_request.allocation_pools"},{"line_number":72,"context_line":"        # Create IPAM allocation pools and availability ranges"},{"line_number":73,"context_line":"        cls.create_allocation_pools(subnet_manager, ctx, pools,"},{"line_number":74,"context_line":"                                    subnet_request.subnet_cidr)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_e92afc7d","line":72,"range":{"start_line":72,"start_character":38,"end_line":72,"end_character":62},"in_reply_to":"1a95cdbc_2ee22a04","updated":"2016-10-04 17:47:46.000000000","message":"Fixed","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b22befc1e581cc11d110f4c4ab9d378ce2b76739","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def deallocate(self, address):"},{"line_number":217,"context_line":"        # This is almost a no-op because the Neutron DB IPAM driver does not"},{"line_number":218,"context_line":"        # delete IPAllocation objects, neither rebuilds availability ranges"},{"line_number":219,"context_line":"        # at every deallocation. The only operation it performs is to delete"},{"line_number":220,"context_line":"        # an IPRequest entry."},{"line_number":221,"context_line":"        count \u003d self.subnet_manager.delete_allocation("}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_ce870611","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":74},"updated":"2016-10-04 17:39:51.000000000","message":"ditto","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"437e3d1a9df2b3e0add60dd4d427760b40f77624","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def deallocate(self, address):"},{"line_number":217,"context_line":"        # This is almost a no-op because the Neutron DB IPAM driver does not"},{"line_number":218,"context_line":"        # delete IPAllocation objects, neither rebuilds availability ranges"},{"line_number":219,"context_line":"        # at every deallocation. The only operation it performs is to delete"},{"line_number":220,"context_line":"        # an IPRequest entry."},{"line_number":221,"context_line":"        count \u003d self.subnet_manager.delete_allocation("}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_2925c4aa","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":74},"in_reply_to":"1a95cdbc_ce870611","updated":"2016-10-04 17:47:46.000000000","message":"Fixed","commit_id":"3fab108f326cfae50489399b4e97c9cb93f890ca"}],"releasenotes/notes/change-ipam-db-api-fa043cbafb1dbddc.yaml":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ac3ffbec50ff06b92f10c15d82d9356e51cc7432","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Change Ipam DB API to use context instead of session"},{"line_number":4,"context_line":"    object. This makes it more consistent with rest of"},{"line_number":5,"context_line":"    the DB API code in neutron."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a95cdbc_c173544c","line":2,"updated":"2016-10-04 20:23:44.000000000","message":"I think it makes better sense for this to be under \"other\" section and not upgrade.  I think of upgrade as being more for db changes, but I could be wrong.\n\nI\u0027d like others to chime in first though.","commit_id":"59965c964c7b9fc988224e524b0c47470f2470bb"}]}
