)]}'
{"neutron/tests/unit/test_extension_ext_gw_mode.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"522e7e7511f0cd6ae600f446e24bdf19230bcc11","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        l3.RESOURCE_ATTRIBUTE_MAP \u003d self._l3_attribute_map_bk"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def tearDown(self):"},{"line_number":322,"context_line":"        del test_config[\u0027extension_manager\u0027]"},{"line_number":323,"context_line":"        super(ExtGwModeTestCase, self).tearDown()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _set_router_external_gateway(self, router_id, network_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FuQU%3D","line":322,"updated":"2013-07-12 12:48:05.000000000","message":"The change itself is needed.\n\nMy concern is test_config is a global variable. Now we run tests in parallel and it means other test use this configuration.\ntest_config should be reset as soon as possible. I suggest to move it just after the plugin is configured (at L.315) if possible.\n\nActually I experience test_config violation during unittest refactoring when I ran the unittest in parallel on a machine with 16 cores. Ideally global test_config should be removed, but i think it is not a scope of this patch.","commit_id":"2d7c14c93e77aeb672f5e89fe98f0906f9d7d49b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dd9408ca682cc2e5d0c441195048900c6d87acc2","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        l3.RESOURCE_ATTRIBUTE_MAP \u003d self._l3_attribute_map_bk"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def tearDown(self):"},{"line_number":322,"context_line":"        del test_config[\u0027extension_manager\u0027]"},{"line_number":323,"context_line":"        super(ExtGwModeTestCase, self).tearDown()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _set_router_external_gateway(self, router_id, network_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fh%2F8%3D","line":322,"in_reply_to":"AAAAP3%2F%2FrJY%3D","updated":"2013-07-16 21:56:28.000000000","message":"The issue with test_config being a global variable will continue presenting in several forms with parallel testing.\n\nWe need to get rid of it, but  surely this patch is not the right place for doing that.\n\nEven if make local shallow copy of test_config, the superclass will still process the global test_config.\n\nI will think of an alternative solution; I\u0027d rather spend some more time and push something that satisfies everybody rather than doing workarounds.","commit_id":"2d7c14c93e77aeb672f5e89fe98f0906f9d7d49b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"f4381cc3865b2e98301e8f6e29a2f7b59503c185","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        l3.RESOURCE_ATTRIBUTE_MAP \u003d self._l3_attribute_map_bk"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def tearDown(self):"},{"line_number":322,"context_line":"        del test_config[\u0027extension_manager\u0027]"},{"line_number":323,"context_line":"        super(ExtGwModeTestCase, self).tearDown()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _set_router_external_gateway(self, router_id, network_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FrJY%3D","line":322,"in_reply_to":"AAAAP3%2F%2FuQU%3D","updated":"2013-07-14 02:33:34.000000000","message":"I think the workaround in this case is to make a copy of test_config local to this module.  A shallow copy should be sufficient here.","commit_id":"2d7c14c93e77aeb672f5e89fe98f0906f9d7d49b"}]}