)]}'
{"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c540b819bc2b755e28e62634cf60150afdabcf8f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            chain \u003d self.chain"},{"line_number":121,"context_line":"        rule \u003d \u0027-A %s %s\u0027 % (chain, self.rule)"},{"line_number":122,"context_line":"        return comment_rule(rule.strip(), self.comment)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class IptablesTable(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_ad034d0c","line":122,"updated":"2016-09-06 13:22:14.000000000","message":"Did you find a particular case where there was a preceding or trailing space on a rule?","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b0f439b9ba2a3c26cc476eeae5b0d41eada725e9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            chain \u003d self.chain"},{"line_number":121,"context_line":"        rule \u003d \u0027-A %s %s\u0027 % (chain, self.rule)"},{"line_number":122,"context_line":"        return comment_rule(rule.strip(), self.comment)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class IptablesTable(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_89ec2fbc","line":122,"in_reply_to":"9a89bdaa_98eb0478","updated":"2016-09-08 16:07:02.000000000","message":"Ah, self.rule is \u0027\u0027 so we get a trailing space.  Can you just put a comment here so noone accidentally removes this in the future?","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"cb4c7ccdf875bf713f6e6018c61719021ba85da1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        else:"},{"line_number":120,"context_line":"            chain \u003d self.chain"},{"line_number":121,"context_line":"        rule \u003d \u0027-A %s %s\u0027 % (chain, self.rule)"},{"line_number":122,"context_line":"        return comment_rule(rule.strip(), self.comment)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class IptablesTable(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_98eb0478","line":122,"in_reply_to":"9a89bdaa_ad034d0c","updated":"2016-09-07 02:52:54.000000000","message":"yes, When invoke _process_associate_metering_label, it will cause the rule trailing space.  \nCode:neutron/services/metering/drivers/iptables/iptables_driver.py +214                rm.iptables_manager.ipv4[\u0027filter\u0027].add_rule(label_chain, \u0027\u0027,                                                         wrap\u003dFalse)\n\nResult:\n....\n-D neutron-meter-l-00e4e019-099 1\n-I neutron-meter-l-00e4e019-099 1\n....","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"}],"neutron/services/metering/drivers/iptables/iptables_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c540b819bc2b755e28e62634cf60150afdabcf8f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            dir_opt \u003d \u0027-d %s -o %s\u0027 % (remote_ip, ext_dev)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            dir_opt \u003d \u0027-s %s -i %s\u0027 % (remote_ip, ext_dev)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if rule[\u0027excluded\u0027]:"},{"line_number":189,"context_line":"            ipt_rule \u003d \u0027%s -j RETURN\u0027 % dir_opt"},{"line_number":190,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_42fe1038","line":187,"updated":"2016-09-06 13:22:14.000000000","message":"Good catch, iptables-save always puts the address first.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"cb4c7ccdf875bf713f6e6018c61719021ba85da1","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            dir_opt \u003d \u0027-d %s -o %s\u0027 % (remote_ip, ext_dev)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            dir_opt \u003d \u0027-s %s -i %s\u0027 % (remote_ip, ext_dev)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if rule[\u0027excluded\u0027]:"},{"line_number":189,"context_line":"            ipt_rule \u003d \u0027%s -j RETURN\u0027 % dir_opt"},{"line_number":190,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_f856d028","line":187,"in_reply_to":"9a89bdaa_42fe1038","updated":"2016-09-07 02:52:54.000000000","message":"it\u0027s very serious problem.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6715d97c0c601b70c0a2703834482e09b0744eb1","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def _prepare_rule(self, ext_dev, rule, label_chain):"},{"line_number":182,"context_line":"        remote_ip \u003d rule[\u0027remote_ip_prefix\u0027]"},{"line_number":183,"context_line":"        if rule[\u0027direction\u0027] \u003d\u003d \u0027egress\u0027:"},{"line_number":184,"context_line":"            dir_opt \u003d \u0027-d %s -o %s\u0027 % (remote_ip, ext_dev)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            dir_opt \u003d \u0027-s %s -i %s\u0027 % (remote_ip, ext_dev)"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_4f492f8b","line":184,"updated":"2016-09-14 01:32:07.000000000","message":"are we sure this change is intended?","commit_id":"5b7c71a327d735134fa0eeb4427d0e1bd1f7d1e5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9e61d7fe8fe653724aef5adebc37db9c2a5854bd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def _prepare_rule(self, ext_dev, rule, label_chain):"},{"line_number":182,"context_line":"        remote_ip \u003d rule[\u0027remote_ip_prefix\u0027]"},{"line_number":183,"context_line":"        if rule[\u0027direction\u0027] \u003d\u003d \u0027egress\u0027:"},{"line_number":184,"context_line":"            dir_opt \u003d \u0027-d %s -o %s\u0027 % (remote_ip, ext_dev)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            dir_opt \u003d \u0027-s %s -i %s\u0027 % (remote_ip, ext_dev)"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_5581c049","line":184,"in_reply_to":"7a8ec9b2_4f492f8b","updated":"2016-09-14 02:11:23.000000000","message":"yes, iptables-save puts the address (w/-d or -s) first, followed by the interface.  For example, look at floating_forward_rules() in dvr_local_router.py","commit_id":"5b7c71a327d735134fa0eeb4427d0e1bd1f7d1e5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6715d97c0c601b70c0a2703834482e09b0744eb1","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        if rule[\u0027direction\u0027] \u003d\u003d \u0027egress\u0027:"},{"line_number":184,"context_line":"            dir_opt \u003d \u0027-d %s -o %s\u0027 % (remote_ip, ext_dev)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            dir_opt \u003d \u0027-s %s -i %s\u0027 % (remote_ip, ext_dev)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if rule[\u0027excluded\u0027]:"},{"line_number":189,"context_line":"            ipt_rule \u003d \u0027%s -j RETURN\u0027 % dir_opt"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_af2f13a0","line":186,"updated":"2016-09-14 01:32:07.000000000","message":"this isn\u0027t messing a non-backward compatible change is it?","commit_id":"5b7c71a327d735134fa0eeb4427d0e1bd1f7d1e5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9e61d7fe8fe653724aef5adebc37db9c2a5854bd","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        if rule[\u0027direction\u0027] \u003d\u003d \u0027egress\u0027:"},{"line_number":184,"context_line":"            dir_opt \u003d \u0027-d %s -o %s\u0027 % (remote_ip, ext_dev)"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            dir_opt \u003d \u0027-s %s -i %s\u0027 % (remote_ip, ext_dev)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if rule[\u0027excluded\u0027]:"},{"line_number":189,"context_line":"            ipt_rule \u003d \u0027%s -j RETURN\u0027 % dir_opt"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_95c18883","line":186,"in_reply_to":"7a8ec9b2_af2f13a0","updated":"2016-09-14 02:11:23.000000000","message":"I don\u0027t believe so, we\u0027ve fixed other ordering issues like this in the past year.","commit_id":"5b7c71a327d735134fa0eeb4427d0e1bd1f7d1e5"}],"neutron/tests/unit/agent/linux/test_iptables_manager.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c540b819bc2b755e28e62634cf60150afdabcf8f","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"        iptables_args \u003d {}"},{"line_number":1204,"context_line":"        iptables_args.update(IPTABLES_ARG)"},{"line_number":1205,"context_line":"        filter_rules \u003d (\u0027-A %(bn)s-test-filter -d 192.168.0.2 -i tap-xxx\u0027"},{"line_number":1206,"context_line":"                        \u0027 -j ACCEPT\\n\u0027"},{"line_number":1207,"context_line":"                        % iptables_args)"},{"line_number":1208,"context_line":"        iptables_args[\u0027filter_rules\u0027] \u003d filter_rules"},{"line_number":1209,"context_line":"        filter_dump_mod \u003d FILTER_RESTORE_DUMP % iptables_args"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_ed455517","line":1206,"updated":"2016-09-06 13:22:14.000000000","message":"Can you make this a trailing space on the previous line?  It\u0027s a convention we try and follow.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b0f439b9ba2a3c26cc476eeae5b0d41eada725e9","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"        iptables_args \u003d {}"},{"line_number":1204,"context_line":"        iptables_args.update(IPTABLES_ARG)"},{"line_number":1205,"context_line":"        filter_rules \u003d (\u0027-A %(bn)s-test-filter -d 192.168.0.2 -i tap-xxx\u0027"},{"line_number":1206,"context_line":"                        \u0027 -j ACCEPT\\n\u0027"},{"line_number":1207,"context_line":"                        % iptables_args)"},{"line_number":1208,"context_line":"        iptables_args[\u0027filter_rules\u0027] \u003d filter_rules"},{"line_number":1209,"context_line":"        filter_dump_mod \u003d FILTER_RESTORE_DUMP % iptables_args"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_293de3c3","line":1206,"in_reply_to":"9a89bdaa_786ba0f1","updated":"2016-09-08 16:07:02.000000000","message":"Right, I want you to leave the spacing alone, just make it:\n\n\u0027... tap-xxx \u0027\n\u0027-j ACCEPT\\n\u0027","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"cb4c7ccdf875bf713f6e6018c61719021ba85da1","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"        iptables_args \u003d {}"},{"line_number":1204,"context_line":"        iptables_args.update(IPTABLES_ARG)"},{"line_number":1205,"context_line":"        filter_rules \u003d (\u0027-A %(bn)s-test-filter -d 192.168.0.2 -i tap-xxx\u0027"},{"line_number":1206,"context_line":"                        \u0027 -j ACCEPT\\n\u0027"},{"line_number":1207,"context_line":"                        % iptables_args)"},{"line_number":1208,"context_line":"        iptables_args[\u0027filter_rules\u0027] \u003d filter_rules"},{"line_number":1209,"context_line":"        filter_dump_mod \u003d FILTER_RESTORE_DUMP % iptables_args"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_786ba0f1","line":1206,"in_reply_to":"9a89bdaa_ed455517","updated":"2016-09-07 02:52:54.000000000","message":"please look up 1171 line, it will test rule trailing space.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c540b819bc2b755e28e62634cf60150afdabcf8f","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"                         \u0027*filter\\n\u0027"},{"line_number":1213,"context_line":"                         \u0027-D run.py-test-filter 1\\n\u0027"},{"line_number":1214,"context_line":"                         \u0027-I run.py-test-filter 1\u0027"},{"line_number":1215,"context_line":"                         \u0027 -i tap-xxx -d 192.168.0.2 -j ACCEPT\\n\u0027"},{"line_number":1216,"context_line":"                         \u0027COMMIT\\n\u0027"},{"line_number":1217,"context_line":"                         \u0027# Completed by iptables_manager\\n\u0027"},{"line_number":1218,"context_line":"                         % IPTABLES_ARG)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_add42d47","line":1215,"updated":"2016-09-06 13:22:14.000000000","message":"Here too.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"cb4c7ccdf875bf713f6e6018c61719021ba85da1","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"                         \u0027*filter\\n\u0027"},{"line_number":1213,"context_line":"                         \u0027-D run.py-test-filter 1\\n\u0027"},{"line_number":1214,"context_line":"                         \u0027-I run.py-test-filter 1\u0027"},{"line_number":1215,"context_line":"                         \u0027 -i tap-xxx -d 192.168.0.2 -j ACCEPT\\n\u0027"},{"line_number":1216,"context_line":"                         \u0027COMMIT\\n\u0027"},{"line_number":1217,"context_line":"                         \u0027# Completed by iptables_manager\\n\u0027"},{"line_number":1218,"context_line":"                         % IPTABLES_ARG)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_384cb89d","line":1215,"in_reply_to":"9a89bdaa_add42d47","updated":"2016-09-07 02:52:54.000000000","message":"Please look up 1171 line.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c540b819bc2b755e28e62634cf60150afdabcf8f","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        self.iptables.ipv4[\u0027filter\u0027].add_chain(\u0027test-filter\u0027)"},{"line_number":1234,"context_line":"        self.iptables.ipv4[\u0027filter\u0027].add_rule(\u0027test-filter\u0027,"},{"line_number":1235,"context_line":"                                              \u0027-i tap-xxx -d 192.168.0.2\u0027"},{"line_number":1236,"context_line":"                                              \u0027 -j ACCEPT\u0027)"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        self.iptables.apply()"},{"line_number":1239,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_4dc0017c","line":1236,"updated":"2016-09-06 13:22:14.000000000","message":"Here too, thanks.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"cb4c7ccdf875bf713f6e6018c61719021ba85da1","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        self.iptables.ipv4[\u0027filter\u0027].add_chain(\u0027test-filter\u0027)"},{"line_number":1234,"context_line":"        self.iptables.ipv4[\u0027filter\u0027].add_rule(\u0027test-filter\u0027,"},{"line_number":1235,"context_line":"                                              \u0027-i tap-xxx -d 192.168.0.2\u0027"},{"line_number":1236,"context_line":"                                              \u0027 -j ACCEPT\u0027)"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        self.iptables.apply()"},{"line_number":1239,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_7842c069","line":1236,"in_reply_to":"9a89bdaa_4dc0017c","updated":"2016-09-07 02:52:54.000000000","message":"Please look up 1171 line.","commit_id":"8db09e3d235bdad61e168d13a4ef12ee185139f3"}]}
