)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"09a910d6ce0bb13cd8da4bbc7b1d311559b07377","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not have much physical sense to have a rule without the limit set, just"},{"line_number":10,"context_line":"direction. Require the parameter to avoid creating rules without the limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13c54be22f35ac7eb5835d8424a919d0b61a8e95"},{"line_number":13,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_1e7f0c67","line":11,"updated":"2016-09-01 08:07:50.000000000","message":"Why do we always require it? Current implementation just follows the spec[1].\n\n[1]: https://specs.openstack.org/openstack/neutron-specs/specs/newton/ml2-qos-minimum-egress-bw-support.html#data-model-impact","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8c278f76868fe40e21666e5292b4b8235e238cdd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not have much physical sense to have a rule without the limit set, just"},{"line_number":10,"context_line":"direction. Require the parameter to avoid creating rules without the limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13c54be22f35ac7eb5835d8424a919d0b61a8e95"},{"line_number":13,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_9ee07c98","line":11,"in_reply_to":"fa7ab95a_1e7f0c67","updated":"2016-09-01 08:16:26.000000000","message":"It looks to me that when the spec was written it was not realized that a rule without a min_kbps value is effectively the same as not having the rule at all. So I understand Ihar\u0027s wish to enforce a value. However, I suspect a complete solution will require a schema update, together with a tool that either removes records that have no min_kbps value, or updates them with some value.","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6ae52f12c51c7f475213d143b917b20491621aac","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not have much physical sense to have a rule without the limit set, just"},{"line_number":10,"context_line":"direction. Require the parameter to avoid creating rules without the limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13c54be22f35ac7eb5835d8424a919d0b61a8e95"},{"line_number":13,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_2d19ef79","line":11,"in_reply_to":"fa7ab95a_5c8fd9cb","updated":"2016-09-01 13:25:52.000000000","message":"Agree.\n\nAnyway, actually we cannot create the rule without min_kbps because it has range validation. So don\u0027t worry about schema.","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"99be0c38f88bee2f25e686f98f46b2d47812d8c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not have much physical sense to have a rule without the limit set, just"},{"line_number":10,"context_line":"direction. Require the parameter to avoid creating rules without the limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13c54be22f35ac7eb5835d8424a919d0b61a8e95"},{"line_number":13,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_d67108aa","line":11,"in_reply_to":"fa7ab95a_9ee07c98","updated":"2016-09-01 09:07:05.000000000","message":"This change makese sense to me. This rule is about minimum bandwidht rule, so specifying minimum required rate is completely reasonable.\nOtherwise, I think we need to provide a way to define the default rate.","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c5aa3a64f610c03455c288f747583aeacf18252d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It does not have much physical sense to have a rule without the limit set, just"},{"line_number":10,"context_line":"direction. Require the parameter to avoid creating rules without the limit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13c54be22f35ac7eb5835d8424a919d0b61a8e95"},{"line_number":13,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_5c8fd9cb","line":11,"in_reply_to":"fa7ab95a_d67108aa","updated":"2016-09-01 09:36:03.000000000","message":"Henry, we landed it yesterday. I don\u0027t think it\u0027s reasonable to go through cleanup. As for the schema, my main concern is that we may allow wrong configuration when we ship it with N final. Schema may be refined on its own schedule.","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"}],"neutron/extensions/qos.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b45199e2df7938543b4625553bb1182c074a1a70","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \u0027parameters\u0027: dict(QOS_RULE_COMMON_FIELDS,"},{"line_number":103,"context_line":"                           **{\u0027min_kbps\u0027: {"},{"line_number":104,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":105,"context_line":"                                  \u0027is_visible\u0027: True,"},{"line_number":106,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":107,"context_line":"                                  common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":108,"context_line":"                              \u0027direction\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_83aae317","line":105,"updated":"2016-09-01 08:04:33.000000000","message":"The DB column is still nullable though, in the schema. Is that OK?\n\nHow do you deal with existing records that have this field null? It\u0027s not an issue because QoS is still new?","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c5aa3a64f610c03455c288f747583aeacf18252d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \u0027parameters\u0027: dict(QOS_RULE_COMMON_FIELDS,"},{"line_number":103,"context_line":"                           **{\u0027min_kbps\u0027: {"},{"line_number":104,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":105,"context_line":"                                  \u0027is_visible\u0027: True,"},{"line_number":106,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":107,"context_line":"                                  common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":108,"context_line":"                              \u0027direction\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_bc446574","line":105,"in_reply_to":"fa7ab95a_3907871d","updated":"2016-09-01 09:36:03.000000000","message":"Right Akihiro. That\u0027s why I don\u0027t want to go modifying the schema, we can do it later.\n\nThe rule landed yesterday.","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c63c8ed81688baf8dc638fda5447aecce63e412","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \u0027parameters\u0027: dict(QOS_RULE_COMMON_FIELDS,"},{"line_number":103,"context_line":"                           **{\u0027min_kbps\u0027: {"},{"line_number":104,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":105,"context_line":"                                  \u0027is_visible\u0027: True,"},{"line_number":106,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":107,"context_line":"                                  common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":108,"context_line":"                              \u0027direction\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_3907871d","line":105,"in_reply_to":"fa7ab95a_83aae317","updated":"2016-09-01 09:22:21.000000000","message":"Very gray zone. The table was introduced only 1 day ago.","commit_id":"3804d0b0b4304d8a570b53197585af55b3357365"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"66b27ad1084ce4976acd013f9d7bd1dc7aa94ab4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027parameters\u0027: dict(QOS_RULE_COMMON_FIELDS,"},{"line_number":77,"context_line":"                           **{\u0027max_kbps\u0027: {"},{"line_number":78,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":79,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":81,"context_line":"                                      common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":82,"context_line":"                              \u0027max_burst_kbps\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f8f26799","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":69},"updated":"2016-09-01 13:41:10.000000000","message":"same issue?","commit_id":"85bbeedbe0a83b42771258f117f2db9befa0a9d8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cf3e2f69c2086832cf1d1bee04a6b0bd8babd882","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027parameters\u0027: dict(QOS_RULE_COMMON_FIELDS,"},{"line_number":77,"context_line":"                           **{\u0027max_kbps\u0027: {"},{"line_number":78,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":79,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":81,"context_line":"                                      common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":82,"context_line":"                              \u0027max_burst_kbps\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b877ffd2","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":69},"in_reply_to":"fa7ab95a_f89347f8","updated":"2016-09-01 13:43:51.000000000","message":"Yes, same thing, but I did not want to touch it right now because it belongs to rules that are not new.","commit_id":"85bbeedbe0a83b42771258f117f2db9befa0a9d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0f5acf7bf58ebb4320f031bc4e6c8867a1b48050","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027parameters\u0027: dict(QOS_RULE_COMMON_FIELDS,"},{"line_number":77,"context_line":"                           **{\u0027max_kbps\u0027: {"},{"line_number":78,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":79,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":81,"context_line":"                                      common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":82,"context_line":"                              \u0027max_burst_kbps\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f89347f8","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":69},"in_reply_to":"fa7ab95a_f8f26799","updated":"2016-09-01 13:43:10.000000000","message":"I think this can be clean up later.","commit_id":"85bbeedbe0a83b42771258f117f2db9befa0a9d8"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"66b27ad1084ce4976acd013f9d7bd1dc7aa94ab4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                           **{\u0027dscp_mark\u0027: {"},{"line_number":93,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":94,"context_line":"                                  \u0027convert_to\u0027: converters.convert_to_int,"},{"line_number":95,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":96,"context_line":"                                  \u0027validate\u0027: {\u0027type:values\u0027: common_constants."},{"line_number":97,"context_line":"                                              VALID_DSCP_MARKS}}})"},{"line_number":98,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_78357744","line":95,"range":{"start_line":95,"start_character":54,"end_line":95,"end_character":69},"updated":"2016-09-01 13:41:10.000000000","message":"ditto","commit_id":"85bbeedbe0a83b42771258f117f2db9befa0a9d8"}]}
