)]}'
{"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3552fda94f0b8e3726411a59baf2eed4bd88056d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    load_conf_hook quotas"},{"line_number":68,"context_line":"    load_rc_hook qos"},{"line_number":69,"context_line":"    load_rc_hook trunk"},{"line_number":70,"context_line":"    load_conf_hook trunk_mtu"},{"line_number":71,"context_line":"    load_conf_hook osprofiler"},{"line_number":72,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-scenario\" ]]; then"},{"line_number":73,"context_line":"        load_conf_hook iptables_verify"}],"source_content_type":"text/x-sh","patch_set":9,"id":"7a8ec9b2_06646c47","line":70,"updated":"2016-09-19 17:51:44.000000000","message":"I\u0027d personally name this hook simply \u0027mtu\u0027, as there\u0027s nothing specific about trunk here, is there?. In fact, this hook might as well be used to write other tests, which may be MTU specific or am I misinterpreting the meaning here?","commit_id":"1b534563c1c2f4fb7ad677c21e3774a9ca0ad9e8"}],"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a9800acef940361625ed83e7e3e79724de663e51","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        trunk \u003d self.client.create_trunk(self.gre_port[\u0027id\u0027], subports)"},{"line_number":284,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @test.idempotent_id(\u00272004c5c6-e557-4c43-8100-c820ad4953e8\u0027)"},{"line_number":287,"context_line":"    def test_create_add_trunk_with_mtu_greater_than_subport(self):"},{"line_number":288,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_aca236fa","line":285,"updated":"2016-09-02 07:42:30.000000000","message":"You are verifying if there are exceptions in \"smaller\" use-cases, but you don\u0027t verify if \"greater\"s are correct.\nDoes it mean, it\u0027s done automagically, under the hood?\nCould you add assert to check, if it was successful? Or is it not necessary?","commit_id":"7351ac9fec83523c753396458130081f1ef6ab11"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ee199f5c2f9cd9154f21e2cb92d85b36e0c2b47a","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        trunk \u003d self.client.create_trunk(self.gre_port[\u0027id\u0027], subports)"},{"line_number":284,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @test.idempotent_id(\u00272004c5c6-e557-4c43-8100-c820ad4953e8\u0027)"},{"line_number":287,"context_line":"    def test_create_add_trunk_with_mtu_greater_than_subport(self):"},{"line_number":288,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_2e0d3b3e","line":285,"in_reply_to":"fa7ab95a_2cc62668","updated":"2016-09-02 08:25:16.000000000","message":"Hmm... I see there `_test_create_trunk` in `TrunkTestJSON` class, which verifies, if everything is correct and valid.\nI don\u0027t see anything similar in `TrunkTestJSONBase`, but maybe it\u0027s hidden deeper, and I just don\u0027t know all the details.\n\nWould it be possible, to verify this, using method `_test_create_trunk`?","commit_id":"7351ac9fec83523c753396458130081f1ef6ab11"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"4209983229a3b5c0ed205c3b8c43d8335f02f72f","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        trunk \u003d self.client.create_trunk(self.gre_port[\u0027id\u0027], subports)"},{"line_number":284,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @test.idempotent_id(\u00272004c5c6-e557-4c43-8100-c820ad4953e8\u0027)"},{"line_number":287,"context_line":"    def test_create_add_trunk_with_mtu_greater_than_subport(self):"},{"line_number":288,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_914f4a33","line":285,"in_reply_to":"fa7ab95a_2e0d3b3e","updated":"2016-09-02 08:33:08.000000000","message":"I\u0027m afraid not, because in _test_create_trunk, both trunk port and subport are from the same type of network, hence having the same mtu. In this test case the situation is different - the ports need to have different mtu to test that trunk cannot contain any port with greater mtu, hence the network needs to be explicitly defined and differ for the ports. Hence _test_create_trunk cannot be used.","commit_id":"7351ac9fec83523c753396458130081f1ef6ab11"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ce4376fccd7b5acb0722f573a77f15c81faa0c0b","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        trunk \u003d self.client.create_trunk(self.gre_port[\u0027id\u0027], subports)"},{"line_number":284,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @test.idempotent_id(\u00272004c5c6-e557-4c43-8100-c820ad4953e8\u0027)"},{"line_number":287,"context_line":"    def test_create_add_trunk_with_mtu_greater_than_subport(self):"},{"line_number":288,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_8e82bc50","line":285,"in_reply_to":"fa7ab95a_914f4a33","updated":"2016-09-02 11:18:50.000000000","message":"Thank you Hynek for this explanation. I see your point.","commit_id":"7351ac9fec83523c753396458130081f1ef6ab11"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"3cf4198334b934c39e73bf724af5c04504d649b9","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        trunk \u003d self.client.create_trunk(self.gre_port[\u0027id\u0027], subports)"},{"line_number":284,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @test.idempotent_id(\u00272004c5c6-e557-4c43-8100-c820ad4953e8\u0027)"},{"line_number":287,"context_line":"    def test_create_add_trunk_with_mtu_greater_than_subport(self):"},{"line_number":288,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_2cc62668","line":285,"in_reply_to":"fa7ab95a_aca236fa","updated":"2016-09-02 07:49:40.000000000","message":"The correctness of trunk creation is tested above in the TrunkTestJSON test case. Hence not throwing an exception is enough to assure that the trunk was successfully created. This tests verifies whether the trunk is created (no exception) or not (exception thrown).\n\nIf it is not created, exception is thrown and test fails, or it would fail for a reason already covered in the TrunkTestJSON test case. Hence no additional checks should be necessary. Did I overlook anything?","commit_id":"7351ac9fec83523c753396458130081f1ef6ab11"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c720497b11b99f62ed1903f28999084ed8956e57","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        if any(t"},{"line_number":234,"context_line":"               not in config.CONF.neutron_plugin_options.available_type_drivers"},{"line_number":235,"context_line":"               for t in [\u0027gre\u0027, \u0027vxlan\u0027]):"},{"line_number":236,"context_line":"            msg \u003d \"Either vxlan or gre type driver not enabled.\""},{"line_number":237,"context_line":"            raise cls.skipException(msg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_88776439","line":236,"updated":"2016-09-06 10:15:39.000000000","message":"Nit: Missing word \u0027is\u0027","commit_id":"95e9a2d8f18ea280bff63a6c28be95a887959c01"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"94672a6115a769de7ab1f7eb111a6eec2eb24d86","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        if any(t"},{"line_number":234,"context_line":"               not in config.CONF.neutron_plugin_options.available_type_drivers"},{"line_number":235,"context_line":"               for t in [\u0027gre\u0027, \u0027vxlan\u0027]):"},{"line_number":236,"context_line":"            msg \u003d \"Either vxlan or gre type driver not enabled.\""},{"line_number":237,"context_line":"            raise cls.skipException(msg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_4621cd4c","line":236,"in_reply_to":"9a89bdaa_88776439","updated":"2016-09-06 10:48:49.000000000","message":"\u0027Is\u0027 is not intended here. See other places in the code where passive is used similarly - line 230 above, AgentManagementTestJSON, FloatingIPTestJSON, ...","commit_id":"95e9a2d8f18ea280bff63a6c28be95a887959c01"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c720497b11b99f62ed1903f28999084ed8956e57","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                          self.vxlan_port[\u0027id\u0027], subports)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @test.idempotent_id(\u00273b32bf77-8002-403e-ad01-6f4cf018daa5\u0027)"},{"line_number":265,"context_line":"    def test_create_add_trunk_with_mtu_smaller_than_subport(self):"},{"line_number":266,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.gre_port[\u0027id\u0027],"},{"line_number":267,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":268,"context_line":"                     \u0027segmentation_id\u0027: 2}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_954a1dc4","line":265,"range":{"start_line":265,"start_character":8,"end_line":265,"end_character":59},"updated":"2016-09-06 10:15:39.000000000","message":"test_add_subport_with_mtu_greater_than_trunk","commit_id":"95e9a2d8f18ea280bff63a6c28be95a887959c01"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c720497b11b99f62ed1903f28999084ed8956e57","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @test.idempotent_id(\u00272004c5c6-e557-4c43-8100-c820ad4953e8\u0027)"},{"line_number":287,"context_line":"    def test_create_add_trunk_with_mtu_greater_than_subport(self):"},{"line_number":288,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"},{"line_number":289,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":290,"context_line":"                     \u0027segmentation_id\u0027: 2}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_d5c74510","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":59},"updated":"2016-09-06 10:15:39.000000000","message":"test_add_subport_with_mtu_lesser_than_trunk","commit_id":"95e9a2d8f18ea280bff63a6c28be95a887959c01"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c720497b11b99f62ed1903f28999084ed8956e57","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @test.idempotent_id(\u0027175b05ae-66ad-44c7-857a-a12d16f1058f\u0027)"},{"line_number":307,"context_line":"    def test_create_add_trunk_with_mtu_equal_to_subport(self):"},{"line_number":308,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.vxlan_port[\u0027id\u0027],"},{"line_number":309,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":310,"context_line":"                     \u0027segmentation_id\u0027: 2}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_b58f21cb","line":307,"range":{"start_line":307,"start_character":8,"end_line":307,"end_character":55},"updated":"2016-09-06 10:15:39.000000000","message":"test_add_subport_with_mtu_equal_to_trunk","commit_id":"95e9a2d8f18ea280bff63a6c28be95a887959c01"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d592f273751585d3cb201902d41f62bfc4749605","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @classmethod"},{"line_number":226,"context_line":"    def skip_checks(cls):"},{"line_number":227,"context_line":"        super(TrunkTestMtusJSON, cls).skip_checks()"},{"line_number":228,"context_line":"        for ext in (\u0027net-mtu\u0027, \u0027provider\u0027, \u0027trunk\u0027):"},{"line_number":229,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":230,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":231,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_7d09ca83","line":228,"updated":"2016-09-12 18:36:59.000000000","message":"the code is supposed to work even without the net-mtu extension though so are you sure you want this to be part of the list?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"56f06898103bfa34b56861e199c7a42c7af5dc47","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @classmethod"},{"line_number":226,"context_line":"    def skip_checks(cls):"},{"line_number":227,"context_line":"        super(TrunkTestMtusJSON, cls).skip_checks()"},{"line_number":228,"context_line":"        for ext in (\u0027net-mtu\u0027, \u0027provider\u0027, \u0027trunk\u0027):"},{"line_number":229,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":230,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":231,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_5474c9fc","line":228,"in_reply_to":"9a89bdaa_0153fc6b","updated":"2016-09-13 08:28:05.000000000","message":"I think we test them: Non-MTU code path and validations are tested in TrunkTestJSON testcase above. Even the case testing that MTU validation is skipped without failure when net-mtu extension is not enabled on server is thus tested in that testcase, provided the API tests would be executed in such an environment.\n\nThe added testcase only contains MTU validity checks, thus only those relevant when net-mtu extension is enabled. If net-mtu would not not present, tests expecting validation errors in this test case would fail.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"de1efc3d4d9de7ab3c44420e0d800afc343f0830","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @classmethod"},{"line_number":226,"context_line":"    def skip_checks(cls):"},{"line_number":227,"context_line":"        super(TrunkTestMtusJSON, cls).skip_checks()"},{"line_number":228,"context_line":"        for ext in (\u0027net-mtu\u0027, \u0027provider\u0027, \u0027trunk\u0027):"},{"line_number":229,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":230,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":231,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_0153fc6b","line":228,"in_reply_to":"9a89bdaa_01a21c99","updated":"2016-09-12 19:05:07.000000000","message":"Understood, but with this arrangement we\u0027re not testing the trunk code path that does not strictly need the MTU extension to work. I wonder if we are interested in API coverage for it.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"133a1e2e440374e3f192177f63c8959c44197512","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @classmethod"},{"line_number":226,"context_line":"    def skip_checks(cls):"},{"line_number":227,"context_line":"        super(TrunkTestMtusJSON, cls).skip_checks()"},{"line_number":228,"context_line":"        for ext in (\u0027net-mtu\u0027, \u0027provider\u0027, \u0027trunk\u0027):"},{"line_number":229,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":230,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":231,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_4adbe0ed","line":228,"in_reply_to":"9a89bdaa_5474c9fc","updated":"2016-09-14 00:04:21.000000000","message":"true, though this does not strictly apply to the test configuration we have in the gate.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"5326972ca2d2eeb041d283a235e99db780f8985d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @classmethod"},{"line_number":226,"context_line":"    def skip_checks(cls):"},{"line_number":227,"context_line":"        super(TrunkTestMtusJSON, cls).skip_checks()"},{"line_number":228,"context_line":"        for ext in (\u0027net-mtu\u0027, \u0027provider\u0027, \u0027trunk\u0027):"},{"line_number":229,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":230,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":231,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_01a21c99","line":228,"in_reply_to":"9a89bdaa_7d09ca83","updated":"2016-09-12 18:57:35.000000000","message":"The code needs mtu field in network detail, this was noted in Ihar\u0027s comment [1] and addressed by adding net-mtu requirement.\n\n[1] https://review.openstack.org/#/c/362917/2/neutron/services/trunk/rules.py@152","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"133a1e2e440374e3f192177f63c8959c44197512","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        vxlan_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027vxlan-net-\u0027),"},{"line_number":243,"context_line":"                        \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":244,"context_line":"        self.vxlan_net \u003d self.create_shared_network(**vxlan_kwargs)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        gre_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027gre-net-\u0027),"},{"line_number":247,"context_line":"                      \u0027provider:network_type\u0027: \u0027gre\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_ca9450ea","line":244,"updated":"2016-09-14 00:04:21.000000000","message":"Why are these shared? I worry that these may accidentally show up in other tests\u0027 asserts and thus interfere.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"338110f1c9d5ed61be540c6d1e5fd3e21e2e5334","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        vxlan_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027vxlan-net-\u0027),"},{"line_number":243,"context_line":"                        \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":244,"context_line":"        self.vxlan_net \u003d self.create_shared_network(**vxlan_kwargs)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        gre_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027gre-net-\u0027),"},{"line_number":247,"context_line":"                      \u0027provider:network_type\u0027: \u0027gre\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_483757b0","line":244,"in_reply_to":"7a8ec9b2_8c897acd","updated":"2016-09-14 09:16:11.000000000","message":"Note that all API tests that run in parallel run against a single neutron-server instance.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"8e299a59ecde4cbfe1a3b6c9cfcaffc119dc4c98","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        vxlan_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027vxlan-net-\u0027),"},{"line_number":243,"context_line":"                        \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":244,"context_line":"        self.vxlan_net \u003d self.create_shared_network(**vxlan_kwargs)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        gre_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027gre-net-\u0027),"},{"line_number":247,"context_line":"                      \u0027provider:network_type\u0027: \u0027gre\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_976edac7","line":244,"in_reply_to":"7a8ec9b2_ca9450ea","updated":"2016-09-14 11:18:10.000000000","message":"Ah, you might mean shared _network_ - that\u0027s because admin access is needed to create network with given network type, and while create_shared_network uses admin connection, create_network uses an ordinary user\u0027s connection (and thus is disallowed by policy to actually create the network).\n\nThe interference with other tests is as likely as in case of qos where it is used for over a year. Was there any significant issue with that?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"eb147f49a73b9a05106ba2aad18cd604c97ed4c5","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        vxlan_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027vxlan-net-\u0027),"},{"line_number":243,"context_line":"                        \u0027provider:network_type\u0027: \u0027vxlan\u0027}"},{"line_number":244,"context_line":"        self.vxlan_net \u003d self.create_shared_network(**vxlan_kwargs)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        gre_kwargs \u003d {\u0027network_name\u0027: data_utils.rand_name(\u0027gre-net-\u0027),"},{"line_number":247,"context_line":"                      \u0027provider:network_type\u0027: \u0027gre\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_8c897acd","line":244,"in_reply_to":"7a8ec9b2_ca9450ea","updated":"2016-09-14 09:09:36.000000000","message":"These are not shared. They are initialized before each test as setUp() is called per test (not per test case, cf. setUpClass() method).","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"133a1e2e440374e3f192177f63c8959c44197512","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                      \u0027provider:network_type\u0027: \u0027gre\u0027}"},{"line_number":248,"context_line":"        self.gre_net \u003d self.create_shared_network(**gre_kwargs)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self.vxlan_port \u003d self.create_port(self.vxlan_net)"},{"line_number":251,"context_line":"        self.vxlan_port_2 \u003d self.create_port(self.vxlan_net)"},{"line_number":252,"context_line":"        self.gre_port \u003d self.create_port(self.gre_net)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_cabb7074","line":250,"updated":"2016-09-14 00:04:21.000000000","message":"can we use more meaningful names? Like prefix them with the role you intend for them?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"eb147f49a73b9a05106ba2aad18cd604c97ed4c5","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                      \u0027provider:network_type\u0027: \u0027gre\u0027}"},{"line_number":248,"context_line":"        self.gre_net \u003d self.create_shared_network(**gre_kwargs)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self.vxlan_port \u003d self.create_port(self.vxlan_net)"},{"line_number":251,"context_line":"        self.vxlan_port_2 \u003d self.create_port(self.vxlan_net)"},{"line_number":252,"context_line":"        self.gre_port \u003d self.create_port(self.gre_net)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_62d6f5c6","line":250,"in_reply_to":"7a8ec9b2_cabb7074","updated":"2016-09-14 09:09:36.000000000","message":"Done","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"133a1e2e440374e3f192177f63c8959c44197512","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        trunk \u003d self.client.create_trunk(self.vxlan_port[\u0027id\u0027], [])"},{"line_number":271,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.assertRaises(lib_exc.Conflict,"},{"line_number":274,"context_line":"                          self.client.add_subports,"},{"line_number":275,"context_line":"                          trunk[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_aaa7044e","line":273,"updated":"2016-09-14 00:04:21.000000000","message":"The ones that raise Conflict should probably be part of the negative test cases, though it would be nice to share a bit more between the resulting test cases.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"eb147f49a73b9a05106ba2aad18cd604c97ed4c5","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        trunk \u003d self.client.create_trunk(self.vxlan_port[\u0027id\u0027], [])"},{"line_number":271,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.assertRaises(lib_exc.Conflict,"},{"line_number":274,"context_line":"                          self.client.add_subports,"},{"line_number":275,"context_line":"                          trunk[\u0027trunk\u0027][\u0027id\u0027], subports)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_82db01ed","line":273,"in_reply_to":"7a8ec9b2_aaa7044e","updated":"2016-09-14 09:09:36.000000000","message":"Done","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e2a02a20ca9a253d62fc7f472d69bfc10b741fed","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self.larger_mtu_port \u003d self.create_port(self.larger_mtu_net)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"class TrunkTestInvalidMtusJSON(TrunkTestMtusJSONBase):"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    required_extensions \u003d TrunkTestMtusJSONBase.required_extensions + \\"},{"line_number":249,"context_line":"                          [\u0027net-mtu\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_8a221300","line":246,"updated":"2016-09-14 16:47:34.000000000","message":"these should go in test_trunk_negative.py though","commit_id":"9a16e6563060fb9d6e1b66c2e9bde7056981e375"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"83899ab1eb2384a48bde2453f92d327e19b6250f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self.larger_mtu_port \u003d self.create_port(self.larger_mtu_net)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"class TrunkTestInvalidMtusJSON(TrunkTestMtusJSONBase):"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    required_extensions \u003d TrunkTestMtusJSONBase.required_extensions + \\"},{"line_number":249,"context_line":"                          [\u0027net-mtu\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_63a7944f","line":246,"in_reply_to":"7a8ec9b2_8a221300","updated":"2016-09-15 08:19:43.000000000","message":"Done","commit_id":"9a16e6563060fb9d6e1b66c2e9bde7056981e375"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a120c18c483ac01b7fbf05d0de979e7de10d49fc","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    @classmethod"},{"line_number":216,"context_line":"    def skip_checks(cls):"},{"line_number":217,"context_line":"        super(TrunkTestMtusJSONBase, cls).skip_checks()"},{"line_number":218,"context_line":"        for ext in (cls.required_extensions):"},{"line_number":219,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":220,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":221,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_cbd29434","line":218,"range":{"start_line":218,"start_character":19,"end_line":218,"end_character":20},"updated":"2016-09-22 11:30:43.000000000","message":"Nit: Parenthesis are not needed","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"9258bed474dd368bda19549f49d6b506068ac6d0","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    @classmethod"},{"line_number":216,"context_line":"    def skip_checks(cls):"},{"line_number":217,"context_line":"        super(TrunkTestMtusJSONBase, cls).skip_checks()"},{"line_number":218,"context_line":"        for ext in (cls.required_extensions):"},{"line_number":219,"context_line":"            if not test.is_extension_enabled(ext, \u0027network\u0027):"},{"line_number":220,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":221,"context_line":"                raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_1a20439b","line":218,"range":{"start_line":218,"start_character":19,"end_line":218,"end_character":20},"in_reply_to":"5a8bc5a2_cbd29434","updated":"2016-09-22 14:00:35.000000000","message":"Done","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a120c18c483ac01b7fbf05d0de979e7de10d49fc","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":261,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        trunk \u003d self.client.create_trunk(self.larger_mtu_port[\u0027id\u0027], [])"},{"line_number":264,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        self.client.add_subports(trunk[\u0027trunk\u0027][\u0027id\u0027], subports)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_d1efa6ae","line":263,"range":{"start_line":263,"start_character":69,"end_line":263,"end_character":71},"updated":"2016-09-22 11:30:43.000000000","message":"Maybe None is better to avoid sending empty list to API","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"9258bed474dd368bda19549f49d6b506068ac6d0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":261,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        trunk \u003d self.client.create_trunk(self.larger_mtu_port[\u0027id\u0027], [])"},{"line_number":264,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        self.client.add_subports(trunk[\u0027trunk\u0027][\u0027id\u0027], subports)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_e80028ad","line":263,"range":{"start_line":263,"start_character":69,"end_line":263,"end_character":71},"in_reply_to":"5a8bc5a2_d1efa6ae","updated":"2016-09-22 14:00:35.000000000","message":"It is consistent with usage of create_trunk in TrunksSearchCriteriaTest.resource_setup() method but it makes sense to test None as well. Done","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a120c18c483ac01b7fbf05d0de979e7de10d49fc","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":282,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        trunk \u003d self.client.create_trunk(self.smaller_mtu_port_2[\u0027id\u0027], [])"},{"line_number":285,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.client.add_subports(trunk[\u0027trunk\u0027][\u0027id\u0027], subports)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_11302e56","line":284,"range":{"start_line":284,"start_character":72,"end_line":284,"end_character":74},"updated":"2016-09-22 11:30:43.000000000","message":"ditto","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"9258bed474dd368bda19549f49d6b506068ac6d0","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":282,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        trunk \u003d self.client.create_trunk(self.smaller_mtu_port_2[\u0027id\u0027], [])"},{"line_number":285,"context_line":"        self.trunks.append(trunk[\u0027trunk\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self.client.add_subports(trunk[\u0027trunk\u0027][\u0027id\u0027], subports)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_8820844b","line":284,"range":{"start_line":284,"start_character":72,"end_line":284,"end_character":74},"in_reply_to":"5a8bc5a2_11302e56","updated":"2016-09-22 14:00:35.000000000","message":"Done","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"}],"neutron/tests/tempest/api/test_trunk_negative.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"db6eec067ec99e5f08321a818a04950bcb7155c7","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                          test_trunk.TrunkTestMtusJSONBase.required_extensions"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @test.idempotent_id(\u0027228380ef-1b7a-495e-b759-5b1f08e3e858\u0027)"},{"line_number":246,"context_line":"    def test_create_trunk_with_mtu_smaller_than_subport(self):"},{"line_number":247,"context_line":"        subports \u003d [{\u0027port_id\u0027: self.larger_mtu_port[\u0027id\u0027],"},{"line_number":248,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":249,"context_line":"                     \u0027segmentation_id\u0027: 2}]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_3f8c957e","line":246,"updated":"2016-09-15 21:27:34.000000000","message":"You need to add decorator to be able to just run negative tests.\n\n @test.attr(type\u003d\u0027negative\u0027)","commit_id":"a1d3401ccf30f4c5d57a90264e194f0126974377"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0b6428f3e85d5f4dab1a47e2a811a85e53ff5d35","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class TrunkTestMtusJSON(test_trunk.TrunkTestMtusJSONBase):"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    required_extensions \u003d [\u0027net-mtu\u0027] + \\"},{"line_number":243,"context_line":"                          test_trunk.TrunkTestMtusJSONBase.required_extensions"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_cb4c0c79","line":242,"updated":"2016-09-20 17:09:54.000000000","message":"ideally you\u0027d do:\n\nrequired_extensions \u003d (\n    [\u0027net-mtu\u0027] + test_trunk.TrunkTestMtusJSONBase.required_extensions)","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"9258bed474dd368bda19549f49d6b506068ac6d0","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class TrunkTestMtusJSON(test_trunk.TrunkTestMtusJSONBase):"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    required_extensions \u003d [\u0027net-mtu\u0027] + \\"},{"line_number":243,"context_line":"                          test_trunk.TrunkTestMtusJSONBase.required_extensions"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_5f255dc0","line":242,"in_reply_to":"5a8bc5a2_b1adba8a","updated":"2016-09-22 14:00:35.000000000","message":"Done","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a120c18c483ac01b7fbf05d0de979e7de10d49fc","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class TrunkTestMtusJSON(test_trunk.TrunkTestMtusJSONBase):"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    required_extensions \u003d [\u0027net-mtu\u0027] + \\"},{"line_number":243,"context_line":"                          test_trunk.TrunkTestMtusJSONBase.required_extensions"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_b1adba8a","line":242,"in_reply_to":"7a8ec9b2_cb4c0c79","updated":"2016-09-22 11:30:43.000000000","message":"+1","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a120c18c483ac01b7fbf05d0de979e7de10d49fc","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":250,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertRaises(lib_exc.Conflict,"},{"line_number":253,"context_line":"                          self.client.create_trunk,"},{"line_number":254,"context_line":"                          self.smaller_mtu_port[\u0027id\u0027], subports)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_d11de6be","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":25},"updated":"2016-09-22 11:30:43.000000000","message":"Thing to consider - if this fails (i.e. trunk is created successfully), we\u0027ll leave trunk leftover in Neutron","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"9258bed474dd368bda19549f49d6b506068ac6d0","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":250,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertRaises(lib_exc.Conflict,"},{"line_number":253,"context_line":"                          self.client.create_trunk,"},{"line_number":254,"context_line":"                          self.smaller_mtu_port[\u0027id\u0027], subports)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_082c7449","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":25},"in_reply_to":"5a8bc5a2_d11de6be","updated":"2016-09-22 14:00:35.000000000","message":"Done","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5a3672b316920d58cad0b0846158b71afa8070cc","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                     \u0027segmentation_type\u0027: \u0027vlan\u0027,"},{"line_number":250,"context_line":"                     \u0027segmentation_id\u0027: 2}]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertRaises(lib_exc.Conflict,"},{"line_number":253,"context_line":"                          self.client.create_trunk,"},{"line_number":254,"context_line":"                          self.smaller_mtu_port[\u0027id\u0027], subports)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_75f30c74","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":25},"in_reply_to":"5a8bc5a2_d11de6be","updated":"2016-09-22 15:38:02.000000000","message":"but the build fails so who cares? :)","commit_id":"065328eda0156d423f56ed637f76cbceff54ad98"}],"neutron/tests/tempest/config.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0f18366eed5f5e1a4a76e472f7a0697393bf1e5e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003dTrue,"},{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027available_type_drivers\u0027,"},{"line_number":27,"context_line":"                default\u003d[],"},{"line_number":28,"context_line":"                help\u003d\u0027List of network types available to neutron, \u0027"},{"line_number":29,"context_line":"                     \u0027e.g. vxlan,vlan,gre.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_e1a48bba","line":26,"updated":"2016-09-06 11:00:46.000000000","message":"do we need a DocImpact flag in the commit message?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3456b4db0f9db0446228ebf5b6533c7f98906872","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003dTrue,"},{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027available_type_drivers\u0027,"},{"line_number":27,"context_line":"                default\u003d[],"},{"line_number":28,"context_line":"                help\u003d\u0027List of network types available to neutron, \u0027"},{"line_number":29,"context_line":"                     \u0027e.g. vxlan,vlan,gre.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_6a5b3c55","line":26,"in_reply_to":"9a89bdaa_56bb360e","updated":"2016-09-14 00:04:47.000000000","message":"This matters to Neutron developers only. There\u0027s nothing user facing worth documenting here.","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d518a92a0b3f60feb4fbc04bbeb12576221d4c8b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003dTrue,"},{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027available_type_drivers\u0027,"},{"line_number":27,"context_line":"                default\u003d[],"},{"line_number":28,"context_line":"                help\u003d\u0027List of network types available to neutron, \u0027"},{"line_number":29,"context_line":"                     \u0027e.g. vxlan,vlan,gre.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_f3b1bc90","line":26,"in_reply_to":"9a89bdaa_8159ff5c","updated":"2016-09-06 11:53:59.000000000","message":"Where are these config variables documented?\nWhy do we need to actually set this. Is there no way of learning this from a ML2 extension?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"c979fd8eb5402e15e52a4f16d746e7f6014ecc2b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003dTrue,"},{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027available_type_drivers\u0027,"},{"line_number":27,"context_line":"                default\u003d[],"},{"line_number":28,"context_line":"                help\u003d\u0027List of network types available to neutron, \u0027"},{"line_number":29,"context_line":"                     \u0027e.g. vxlan,vlan,gre.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_8159ff5c","line":26,"in_reply_to":"9a89bdaa_e1a48bba","updated":"2016-09-06 11:07:05.000000000","message":"Which document do you see impacted by this change?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"3929995e43ba550f7180d4db4901f7bbbb13e42a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003dTrue,"},{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.ListOpt(\u0027available_type_drivers\u0027,"},{"line_number":27,"context_line":"                default\u003d[],"},{"line_number":28,"context_line":"                help\u003d\u0027List of network types available to neutron, \u0027"},{"line_number":29,"context_line":"                     \u0027e.g. vxlan,vlan,gre.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_56bb360e","line":26,"in_reply_to":"9a89bdaa_f3b1bc90","updated":"2016-09-06 12:02:05.000000000","message":"\u003e Where are these config variables documented?\n\nActually, that was my question above for you. :) I have not found any document where specify_floating_ip_address_available option would be documented.\n\n\u003e Why do we need to actually set this. Is there no way of learning this from a ML2 extension?\n\nAFAIK no, available type drivers are not exposed in ML2. Even if there was a specific way for ML2, tempest tests should be able to test core plugins other than ML2. Would you advice on generic mechanism that would expose this information regardless of core plugin?","commit_id":"2f66abd5f9c883801432d6400dcb1587bac7a0e0"}]}
