)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae3bab5ad27d942793da04dc9e89b7b087cc1812","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"        # Get the set of DHCP-enabled subnets on this network."},{"line_number":1253,"context_line":"        dhcp_subnets \u003d {subnet.id: subnet for subnet in network.subnets"},{"line_number":1254,"context_line":"                        if subnet.enable_dhcp}"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"        # There are 3 cases: either the DHCP port already exists (but"},{"line_number":1257,"context_line":"        # might need to be updated for a changed set of subnets); or"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_cb2148fe","line":1254,"updated":"2016-09-01 14:41:09.000000000","message":"perhaps here should be \u0027and not ipv6_utils.is_auto_address_subnet(subnet)\u0027 instead?  That\u0027s what setup() does.\n\nI didn\u0027t know we didn\u0027t allow enable_dhcp\u003dFalse on an IPv6 subnet, regardless of the setting from what I can tell :(","commit_id":"e5339b4a3d79693a09e19322ebc804b5e1c765ec"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2aae44729cb4a8df2e32be82550f5870a0c421b","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"        # Get the set of DHCP-enabled subnets on this network."},{"line_number":1253,"context_line":"        dhcp_subnets \u003d {subnet.id: subnet for subnet in network.subnets"},{"line_number":1254,"context_line":"                        if subnet.enable_dhcp}"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"        # There are 3 cases: either the DHCP port already exists (but"},{"line_number":1257,"context_line":"        # might need to be updated for a changed set of subnets); or"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b5bffdfa","line":1254,"in_reply_to":"fa7ab95a_244d8172","updated":"2016-09-01 15:50:40.000000000","message":"Kevin - yes, I see what you mean.  So this issue is a race caused by a subnet getting created while we\u0027re processing, but the fixed ip is here (below).   I\u0027m fine with the patch below then.","commit_id":"e5339b4a3d79693a09e19322ebc804b5e1c765ec"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"93f9e53ab6bb14ecb8703688cc261e6de1e1953f","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"        # Get the set of DHCP-enabled subnets on this network."},{"line_number":1253,"context_line":"        dhcp_subnets \u003d {subnet.id: subnet for subnet in network.subnets"},{"line_number":1254,"context_line":"                        if subnet.enable_dhcp}"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"        # There are 3 cases: either the DHCP port already exists (but"},{"line_number":1257,"context_line":"        # might need to be updated for a changed set of subnets); or"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_244d8172","line":1254,"in_reply_to":"fa7ab95a_cb2148fe","updated":"2016-09-01 15:04:54.000000000","message":"Well this var controls the subnets we ask the server for a port on. Even if we included ipv6 here, there would still be a race where we don\u0027t know about the ipv6 subnet yet on the agent so we don\u0027t include it here, but then the port still gets an ipv6 IP because the subnet was just created.","commit_id":"e5339b4a3d79693a09e19322ebc804b5e1c765ec"}]}
