)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d55e126f0b401cfb9cea10cd2be6bef667fbdc50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: /v2.0/ views response with resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The legacy framework return a list of resources as the response to:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"GET /v2.0/"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba2be162_416e63ca","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":27},"updated":"2017-02-28 22:59:19.000000000","message":"returns","commit_id":"3a51c7a2a531ead49c3f1190e5b911d0ddb6ed00"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d55e126f0b401cfb9cea10cd2be6bef667fbdc50","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"GET /v2.0/"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Current pecan 2.0 controller seems return the same as root controller"},{"line_number":14,"context_line":"content. This patch will make it return the same response as legacy"},{"line_number":15,"context_line":"framework"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba2be162_a1655fe2","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":41},"updated":"2017-02-28 22:59:19.000000000","message":"seems to return","commit_id":"3a51c7a2a531ead49c3f1190e5b911d0ddb6ed00"}],"neutron/pecan_wsgi/controllers/root.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8b375bc41dafcef4444d91bb89d20bb588283478","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                        \u0027links\u0027: [{\u0027rel\u0027: \u0027self\u0027,"},{"line_number":81,"context_line":"                                   \u0027href\u0027: href}]}"},{"line_number":82,"context_line":"            layout.append(resource)"},{"line_number":83,"context_line":"        return dict(resources\u003dlayout)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @utils.when(index, method\u003d\u0027HEAD\u0027)"},{"line_number":86,"context_line":"    @utils.when(index, method\u003d\u0027POST\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da7fb54a_f598206d","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":37},"updated":"2016-09-02 16:23:58.000000000","message":"from performance PoV, better idea is to use just {\u0027resource\u0027: layout}","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"94bdeca37b05b4ec1383090d3843c032f20abc2b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                        \u0027links\u0027: [{\u0027rel\u0027: \u0027self\u0027,"},{"line_number":81,"context_line":"                                   \u0027href\u0027: href}]}"},{"line_number":82,"context_line":"            layout.append(resource)"},{"line_number":83,"context_line":"        return dict(resources\u003dlayout)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @utils.when(index, method\u003d\u0027HEAD\u0027)"},{"line_number":86,"context_line":"    @utils.when(index, method\u003d\u0027POST\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_8aaff37b","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":37},"in_reply_to":"da7fb54a_f598206d","updated":"2016-09-07 21:18:40.000000000","message":"Done","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"}],"neutron/tests/functional/pecan_wsgi/test_controllers.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8b375bc41dafcef4444d91bb89d20bb588283478","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    base_url \u003d \u0027/v2.0\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_get(self):"},{"line_number":96,"context_line":"        \"\"\"Verify current version info are returned.\"\"\""},{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da7fb54a_1503c474","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":16},"updated":"2016-09-02 16:23:58.000000000","message":"I\u0027m not sure, you should modify this test. Could you tell, why are you doing this?\nI assume, it shouldn\u0027t be different. Am I missing something?","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"b29b604dc32d603e861deda8755450acd7038c57","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    base_url \u003d \u0027/v2.0\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_get(self):"},{"line_number":96,"context_line":"        \"\"\"Verify current version info are returned.\"\"\""},{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_1a76c4d6","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":16},"in_reply_to":"9a89bdaa_ea6b1f1c","updated":"2016-09-08 05:59:06.000000000","message":"Thanks.","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"94bdeca37b05b4ec1383090d3843c032f20abc2b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    base_url \u003d \u0027/v2.0\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_get(self):"},{"line_number":96,"context_line":"        \"\"\"Verify current version info are returned.\"\"\""},{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_ea6b1f1c","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":16},"in_reply_to":"da7fb54a_1503c474","updated":"2016-09-07 21:18:40.000000000","message":"The legacy framework will return response like this:\nGET /v2.0 :   https://gist.github.com/tonytan4ever/c499cc72ad19f6879b581ffa49925b04\n\nThis is different than the current pecan framework\u0027s return: \nhttps://gist.github.com/tonytan4ever/c5b27ac0d545ba0d60aea70c32888a34\n\nI am here to make pecan framework to be consistent with legacy framework in terms of REST response.  Thus I need to modify this test.","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8b375bc41dafcef4444d91bb89d20bb588283478","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"},{"line_number":99,"context_line":"        json_body \u003d jsonutils.loads(response.body)"},{"line_number":100,"context_line":"        self.assertTrue(\u0027resources\u0027 in json_body)"},{"line_number":101,"context_line":"        self.assertIsInstance(json_body[\u0027resources\u0027], list)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_routing_successs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da7fb54a_b5b938ef","line":100,"range":{"start_line":100,"start_character":13,"end_line":100,"end_character":23},"updated":"2016-09-02 16:23:58.000000000","message":"please use \u0027assertIn\u0027","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"94bdeca37b05b4ec1383090d3843c032f20abc2b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"},{"line_number":99,"context_line":"        json_body \u003d jsonutils.loads(response.body)"},{"line_number":100,"context_line":"        self.assertTrue(\u0027resources\u0027 in json_body)"},{"line_number":101,"context_line":"        self.assertIsInstance(json_body[\u0027resources\u0027], list)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_routing_successs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_8a8293c6","line":100,"range":{"start_line":100,"start_character":13,"end_line":100,"end_character":23},"in_reply_to":"da7fb54a_b5b938ef","updated":"2016-09-07 21:18:40.000000000","message":"Done","commit_id":"62744985fc74e62158d7f0ef48d809d2d0a0c10b"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"36d17e19f46fa35af7465e27bf9913754a4ddb7f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    base_url \u003d \u0027/v2.0\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_get(self):"},{"line_number":96,"context_line":"        \"\"\"Verify current version info are returned.\"\"\""},{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"},{"line_number":99,"context_line":"        json_body \u003d jsonutils.loads(response.body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_584712bb","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":55},"updated":"2016-09-22 22:12:16.000000000","message":"This test was originally checking for details in the body, now you have reduced it to, has it returned a body of type list called \u0027resources\u0027. I would like to see a test that confirms the base_url is in the href of one of these. As for status being CURRENT I don\u0027t think that is relevant anymore.","commit_id":"74f09ddcecae566de99a9e33037bcbe1c8d0075b"},{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"230a1527db6f9a16de9e45cb4f8c6da6bfbd1f40","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    base_url \u003d \u0027/v2.0\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_get(self):"},{"line_number":96,"context_line":"        \"\"\"Verify current version info are returned.\"\"\""},{"line_number":97,"context_line":"        response \u003d self.app.get(self.base_url)"},{"line_number":98,"context_line":"        self.assertEqual(response.status_int, 200)"},{"line_number":99,"context_line":"        json_body \u003d jsonutils.loads(response.body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_4a189c1e","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":55},"in_reply_to":"5a8bc5a2_584712bb","updated":"2016-11-17 18:17:08.000000000","message":"Done","commit_id":"74f09ddcecae566de99a9e33037bcbe1c8d0075b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d55e126f0b401cfb9cea10cd2be6bef667fbdc50","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertIsInstance(json_body[\u0027resources\u0027], list)"},{"line_number":102,"context_line":"        self.assertIn(\"links\", json_body[\u0027resources\u0027][0])"},{"line_number":103,"context_line":"        self.assertIn(self.base_url,"},{"line_number":104,"context_line":"                      json_body[\u0027resources\u0027][0][\u0027links\u0027][0][\u0027href\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_routing_successs(self):"},{"line_number":107,"context_line":"        \"\"\"Test dispatch to controller for existing resource.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_612527aa","line":104,"updated":"2017-02-28 22:59:19.000000000","message":"Why not test for the presence of \u0027name\u0027 and \u0027collection\u0027? We might as well check the whole thing","commit_id":"3a51c7a2a531ead49c3f1190e5b911d0ddb6ed00"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8541ac9bca2d2d6063e93cf3d9f4fa57882d07c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertIsInstance(json_body[\u0027resources\u0027], list)"},{"line_number":102,"context_line":"        self.assertIn(\"links\", json_body[\u0027resources\u0027][0])"},{"line_number":103,"context_line":"        self.assertIn(self.base_url,"},{"line_number":104,"context_line":"                      json_body[\u0027resources\u0027][0][\u0027links\u0027][0][\u0027href\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_routing_successs(self):"},{"line_number":107,"context_line":"        \"\"\"Test dispatch to controller for existing resource.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_4883d305","line":104,"in_reply_to":"ba2be162_612527aa","updated":"2017-04-13 00:19:38.000000000","message":"Done","commit_id":"3a51c7a2a531ead49c3f1190e5b911d0ddb6ed00"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d55e126f0b401cfb9cea10cd2be6bef667fbdc50","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertIn(\"links\", json_body[\u0027resources\u0027][0])"},{"line_number":103,"context_line":"        self.assertIn(self.base_url,"},{"line_number":104,"context_line":"                      json_body[\u0027resources\u0027][0][\u0027links\u0027][0][\u0027href\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_routing_successs(self):"},{"line_number":107,"context_line":"        \"\"\"Test dispatch to controller for existing resource.\"\"\""},{"line_number":108,"context_line":"        response \u003d self.app.get(\u0027%sports.json\u0027 % self.base_url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_e13117ee","line":105,"updated":"2017-02-28 22:59:19.000000000","message":"It might also be useful to add another test case to check this path: https://review.openstack.org/#/c/364368/4/neutron/pecan_wsgi/controllers/root.py@76","commit_id":"3a51c7a2a531ead49c3f1190e5b911d0ddb6ed00"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8541ac9bca2d2d6063e93cf3d9f4fa57882d07c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertIn(\"links\", json_body[\u0027resources\u0027][0])"},{"line_number":103,"context_line":"        self.assertIn(self.base_url,"},{"line_number":104,"context_line":"                      json_body[\u0027resources\u0027][0][\u0027links\u0027][0][\u0027href\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_routing_successs(self):"},{"line_number":107,"context_line":"        \"\"\"Test dispatch to controller for existing resource.\"\"\""},{"line_number":108,"context_line":"        response \u003d self.app.get(\u0027%sports.json\u0027 % self.base_url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_28888f1d","line":105,"in_reply_to":"ba2be162_e13117ee","updated":"2017-04-13 00:19:38.000000000","message":"Done","commit_id":"3a51c7a2a531ead49c3f1190e5b911d0ddb6ed00"}]}
