)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"62306cd2e27b4f6342d37b4b1e6cf1beac69ac8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-02 01:49:45 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add common way to extra standard attribute models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a way for standard attribute models to declare"},{"line_number":10,"context_line":"the API resources they show up in. It then adds a utility"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da7fb54a_36728e7d","line":7,"updated":"2016-09-02 17:21:22.000000000","message":"do we consider description an edge case, now?","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"060a0617123145774721f4bb884e317eefdb7d69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-02 19:49:06 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add common way to extend standard attribute models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a way for standard attribute models to declare"},{"line_number":10,"context_line":"the API resources they show up in. It then adds a utility"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_29034cb9","line":7,"updated":"2016-09-08 02:56:50.000000000","message":"wanna revise devref?\n\nhttp://docs.openstack.org/developer/neutron/devref/db_layer.html#the-standard-attribute-table","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"07f61cbda18986a1afb08b2387632094ab6e92f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-02 19:49:06 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add common way to extend standard attribute models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds a way for standard attribute models to declare"},{"line_number":10,"context_line":"the API resources they show up in. It then adds a utility"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_8829a9e8","line":7,"in_reply_to":"9a89bdaa_29034cb9","updated":"2016-09-08 08:33:31.000000000","message":"Done","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6a1584574d097e6988c611ef6b8a29f4c7cc0821","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_e6b35396","line":18,"updated":"2016-09-08 02:42:06.000000000","message":"This partially-implements: blueprint add-neutron-extension-resource-timestamp","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"07f61cbda18986a1afb08b2387632094ab6e92f5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a89bdaa_a824ad0c","line":18,"in_reply_to":"9a89bdaa_e6b35396","updated":"2016-09-08 08:33:31.000000000","message":"Done","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b8120339040a39abfdc0da8b6fe8f1ab601f7d61","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_45ebccb0","line":18,"updated":"2016-09-09 07:02:37.000000000","message":"I don\u0027t understand this client development workflow so I\u0027m not sure what you want me to put in the release note. What do you want me to change/document more specifically?","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4c4724711093b40c9c021f2afa1f14c93417d18","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_4cb32298","line":18,"updated":"2016-09-08 13:31:51.000000000","message":"This also changes definitions of those extensions (before, they had a limited set of resources that they span to; now, we expose all of them to all resources that support any standard attributes).\n\nAt least such a change is worth APIImpact tag, and a release note. I also wonder why we now need timestamp_ext at all. Could be a good opportunity to kill it before it\u0027s released as part of Newton.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"240d1550cf0a3975ef2be6bd9a28cac9cfc96db0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_862bf581","line":18,"in_reply_to":"7a8ec9b2_42e8197d","updated":"2016-09-14 15:22:23.000000000","message":"We can\u0027t just bind the flavor model to the attribute table and that\u0027s it, for the obvious reason you just described. Every model change that leads to an API change requires an extension. That\u0027s the workflow we\u0027ve had since for ever. It may suck but that\u0027s what we got.\n\nWhy do you keep getting hung up on this?","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"98ac36b09f380d6d6ddb4c9799b4b879ae62f181","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_a1e8db7d","line":18,"in_reply_to":"7a8ec9b2_469d6d64","updated":"2016-09-14 15:38:35.000000000","message":"Well, you just filter out there what actually belongs to the extension. It should not be hard, is it? New per-resource extensions can still use the same mechanism, just with a different filter.\n\nOtherwise you keep attributes defined in an extension that does not really provide them. Makes no sense to me.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59a43370a38756c4b475687368b3b2bdee415df2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_d6e92c1c","line":18,"in_reply_to":"7a8ec9b2_5c04607d","updated":"2016-09-14 15:53:22.000000000","message":"Oh well, I guess that\u0027s that damned narrow focus that got us into the mess. So let\u0027s now apply some looking at the bigger picture, and we will have it all solved!\n\nHave I used all the right vague words in my pitch?\n\nI guess I will let you guys put that house on fire. I never liked it anyway.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b21cdc22f15a8a08fb105d5a35f806c3bf515fb0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_469d6d64","line":18,"in_reply_to":"7a8ec9b2_665ee9ea","updated":"2016-09-14 15:28:29.000000000","message":"Ok, but hard-coding the map makes no sense either, otherwise that defeats the whole point of having a standard mechanism to add attributes automatically (btw how many common attributes can we really think of adding going forward, really)?\n\nI think the patch is on the right track, we just need more documentation and development guidance to fill the gaps.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"332aca663dd2da51d13b85f2aeba85803c23567e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_665ee9ea","line":18,"in_reply_to":"7a8ec9b2_862bf581","updated":"2016-09-14 15:24:56.000000000","message":"Because the goal of the patches was not really clear to me until the last comments from Kevin that we are still going to have a new extension per new resource plugged into standard attributes.\n\nI believe what misled me is the fact that we removed hard coded list of resources form \u0027timestamp\u0027 and \u0027revision\u0027 and \u0027description\u0027 extensions. I believe those should stay hardcoded; for new resources that could get support for those features in the future, we will need a new extension, which will host the corresponding attribute map.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a281f16405d5fc569255f507d1eccae77203482b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_42e8197d","line":18,"in_reply_to":"7a8ec9b2_93c43d93","updated":"2016-09-14 08:11:46.000000000","message":"\u003e I can\u0027t imagine a scenario where a client may end up assuming attributes to be available when they aren\u0027t, because this means they are not inspecting the list of extensions correctly\n\nConsider this:\n- we release Newton with timestamp extension that does not cover \u0027flavour\u0027 resources;\n- in Ocata, we bind flavour model to standard attributes, making the timestamp extension expose the created_at/updated_at attributes on flavours too;\n- client looks at Ocata definition of the extension and assumes that all flavours support those attributes; they also support changed_since filter;\n- client sends changed_since/accesses created_at-updated_at attributes on all setups that claim support for \u0027timestamp\u0027 extension.\n\nNow, if the client gets to interact with Newton server that *claims* support for the extension but *does not support* it for flavours, then the client will crash on accessing those attributes/will get its changed_since filter not applied as expected for the flavour resource.\n\nThat\u0027s where we make our extension definition vague.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"07ed3b41ea90822297a5769ef422d8170713208f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_5c04607d","line":18,"in_reply_to":"7a8ec9b2_a1e8db7d","updated":"2016-09-14 15:48:42.000000000","message":"\u003e Otherwise you keep attributes defined in an extension that does not really provide them. Makes no sense to me.\n\nOnly if you keep a narrow focus without looking at the bigger picture. That\u0027s a dangerous position to put yourself in whenever you look at anything as far as Neutron goes :)","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7bb4e12c75409e94c04115dca31ffaf82e5ad30d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_f6f1c86b","line":18,"in_reply_to":"7a8ec9b2_d6e92c1c","updated":"2016-09-14 15:58:08.000000000","message":"does it looks like we\u0027re trading favors? Some might argue we let you put the DB house on fire :)","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a923c6c889ffe1f7fc86bb52d3d3ef1b1ecc6717","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_7b0a5627","line":18,"in_reply_to":"9a89bdaa_229b4767","updated":"2016-09-08 14:40:35.000000000","message":"\u003eAnd yes, I understand that due to the lack of filtering of dicts passed from plugins we return any garbage to users irrespective of enabled extensions. But that\u0027s something we should change in the future.\n\nAs far as our in-tree plugins, this is just recently a regression with things failing to define and call _make_\u003cresource\u003e_dict. If we added fields to a dict before, they wouldn\u0027t accidentally leak out without an extension being registered with a dict_extend_function to populate it.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a923c6c889ffe1f7fc86bb52d3d3ef1b1ecc6717","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_7bcfb655","line":18,"in_reply_to":"9a89bdaa_22a7c70b","updated":"2016-09-08 14:40:35.000000000","message":"\u003efor one, floating ip is not in the initial list).\n\nThat\u0027s why the timestamp_ext extension exists. That\u0027s the user-visible flag that indicates the timestamp is available on the rest of the resources.\n\n\u003eSo, f.e. someone consumes the new (after this patch) definition of timestamp_core, and fetches floating-ips from Mitaka setup, and assumes that if the extension is in /extensions list, then the client can safely extract created_at and updated_at from the resulting port dicts. But then the client will crash because the code would work with Newton+ setups only.\n\nThe only user-visible thing in the API the the alias/description/etc of the extension. We don\u0027t publish anything about what it does. There is no way for them to \u0027consume the definition of timestamp_core\u0027 that I\u0027m aware of. Did I miss something? Can you show me a client that consumes our extension attribute maps? How do they deal with third-party extensions that don\u0027t live in our repo?","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"56db3bbe844ae7ce6a269dde90e3d6af31b454c1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_62e54f07","line":18,"in_reply_to":"9a89bdaa_22a7c70b","updated":"2016-09-08 13:52:49.000000000","message":"Sorry, there is a typo above. \u0027from the resulting port dicts \u0027 should be read as \u0027from the resulting FIP dicts\u0027","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bc08c721ad2b11affa7ca639a9b6895695ff8b81","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_7b1f835b","line":18,"in_reply_to":"9a89bdaa_45ebccb0","updated":"2016-09-09 10:23:33.000000000","message":"We should document that the definition of timestamp_core extension changed from \u0027created_at/updated_at attributes available for (limited-set-of-resources)\u0027 to \u0027created_at/update_at attributes available for any resource that supports standard attributes in the current setup\u0027 (which is a really vague definition of API, but that\u0027s what the patch implements).\n\nWith that\u0027s, it\u0027s also not clear what timestamp_ext extension is supposed to mean. How would you describe its meaning?","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8d44de3245bb84e9e2dd049d3b6ffcda3bdd33cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_cf280489","line":18,"in_reply_to":"9a89bdaa_4cb32298","updated":"2016-09-08 13:41:27.000000000","message":"\u003etimestamp_ext at all\n\nThese must be discoverable. Timestamps were previously released on only some of the objects. That extension acts as a flag so you can see it with neutron-ext list.\n\nThis change shouldn\u0027t require either APIImpact or release note unless it started showing something that wasn\u0027t visible before, are you aware of something? If something is visible now that wasn\u0027t last cycle, there has to be a corresponding extension that can be checked for.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf6a228b1df8ae931e210b035d3f54954efde5a3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_229b4767","line":18,"in_reply_to":"9a89bdaa_62e54f07","updated":"2016-09-08 13:54:28.000000000","message":"And yes, I understand that due to the lack of filtering of dicts passed from plugins we return any garbage to users irrespective of enabled extensions. But that\u0027s something we should change in the future.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a4d1e20b53edcc8b2eefb3c09cbcbe6afa400aae","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_d6bc19de","line":18,"in_reply_to":"9a89bdaa_7b0a5627","updated":"2016-09-08 14:50:46.000000000","message":"Correct, but those extension functions may be registered even without corresponding extension being claimed as supported. We basically pass the result dict into registered extensions and HOPE that they don\u0027t mess with the payload. Nothing ENFORCES they don\u0027t.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dad8a0241a55a211da450631bf74f340f814a2fd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_93c43d93","line":18,"in_reply_to":"9a89bdaa_7b1f835b","updated":"2016-09-14 05:36:12.000000000","message":"The part that resonates with me is this:\n\n\"I consider extension attribute maps as a contract between neutron developers and clients. Since clients have no way to determine or choose version of API they interact with, extension definitions should generally stay static.\nNow, I understand that timestamp_core case is a bit special, because we probably want to expose those attributes on all resources, not just a limited set of those. But that\u0027s strictly speaking breaking our only way to set API contract with users (extensions that are exposed as alias strings, with no way to discover details.\"\n\nI don\u0027t believe we break our way to set a contract. The attributes may seem they are no longer hardcoded but in reality they are because for any given release you can see what resources are available and which of those adopts the \u0027standard\u0027 list of attributes by inspecting the models. We only made this slightly more complex to discover, but we can address this with documentation (api-ref), as right now fishing through extension definition is not exactly very discoverable either. \n\nI can\u0027t imagine a scenario where a client may end up assuming attributes to be available when they aren\u0027t, because this means they are not inspecting the list of extensions correctly. Each new attribute added to the standardattr table needs a new extension and that signals to end users that it will be available to all resources that do use the base model. New attributes are additional and thus bw compat by definition. Timestamp_core and Timestamp_ext are a glitch. We screwed up, yes, but the follow up patch is just yet another demonstration of the fact.\n\nI think it would be nice if as part of this patch, we\u0027d list/document for easy lookup what models use the StandardAttr mixin and link that to the resource attribute exposed for the given release. That should suffice and we can finally resolve the timestamp snafus.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a4d1e20b53edcc8b2eefb3c09cbcbe6afa400aae","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_166cc106","line":18,"in_reply_to":"9a89bdaa_7bcfb655","updated":"2016-09-08 14:50:46.000000000","message":"\u003e That\u0027s why the timestamp_ext extension exists\nIf I, as a user, look at the version of the extension as defined in this patch, then what I deduce from it is that the attribute map is empty, so the extension does not really change the payload. You basically then need to go and document the specific meaning of the extension in English somewhere, instead of relying on the attribute map self-documenting the extension.\n\n\u003e There is no way for them to \u0027consume the definition of timestamp_core\u0027 that I\u0027m aware of. Did I miss something?\nYou did not. But with the plan on horizon to keep all extension definitions, including attribute maps, in neutron-lib, it\u0027s not a stretch to expect that those definitions describe actual neutron API (all branches) instead of a specific branch of it.\n\n\u003e Can you show me a client that consumes our extension attribute maps?\nNo, but I hope that people will get access to those maps through neutron-lib, and will rely on them.\n\n\u003e How do they deal with third-party extensions that don\u0027t live in our repo?\nHowever those third parties communicate definitions to their users. The fact that we allow 3party extensions right now does not mean that we should not keep our own extension definitions consistent throughout supported branches.\n\nOverall, I only suggested that this patch is a shift in how we defined and evolved our API so far, and hence requires proper documentation and release note.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6f8ec9f9f2ee2f5cd91dec327500812e7f1bccc0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fields to standard attribute resources."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also adjusts the existing extensions to leverage this"},{"line_number":18,"context_line":"new functionality."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially-Implements: blueprint add-neutron-extension-resource-timestamp"},{"line_number":21,"context_line":"Change-Id: Idc8923d0e983fcb0690f8cb5b55a5aff8690154f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_22a7c70b","line":18,"in_reply_to":"9a89bdaa_cf280489","updated":"2016-09-08 13:51:20.000000000","message":"Doesn\u0027t the change modify extension map in a way that exposes all stadattrs to all resources that inherit from the model at the time of server load (not at the time of initial extension definition)?\n\nF.e., at least from looking at attribute map, https://review.openstack.org/#/c/364681/9/neutron/extensions/timestamp_core.py timestamp_core extension now defines created_at and updated_at attributes for more resources than before (for one, floating ip is not in the initial list).\n\nI would think that once we move those extension definitions into neutron-lib, as the Armando\u0027s plan seems to stand for, we will be able to allow library users to consume those definitions as actual attribute maps for the extension.\n\nSo, f.e. someone consumes the new (after this patch) definition of timestamp_core, and fetches floating-ips from Mitaka setup, and assumes that if the extension is in /extensions list, then the client can safely extract created_at and updated_at from the resulting port dicts. But then the client will crash because the code would work with Newton+ setups only.\n\nI consider extension attribute maps as a contract between neutron developers and clients. Since clients have no way to determine or choose version of API they interact with, extension definitions should generally stay static.\n\nNow, I understand that timestamp_core case is a bit special, because we probably want to expose those attributes on all resources, not just a limited set of those. But that\u0027s strictly speaking breaking our only way to set API contract with users (extensions that are exposed as alias strings, with no way to discover details of the API).","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"}],"doc/source/devref/api_extensions.rst":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"For example, if Flavors were migrated to include standard attributes, we"},{"line_number":62,"context_line":"we need a new \u0027flavor-standardattr\u0027 extension. Then as an API caller, I will"},{"line_number":63,"context_line":"know that flavors will have timestamps by checking for \u0027flavor-standardattr\u0027"},{"line_number":64,"context_line":"and \u0027timestamps\u0027."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a8ec9b2_cbddec15","line":63,"updated":"2016-09-15 00:16:00.000000000","message":"Well, the presence of flavor-standardattr is going to tell you that the resource is going to have the attributes as defined by the standardattr model. Each attribute on the standardattr will need to have its own extension.","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7557ee86bc63be89fcc535e68c5dc095f692a071","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"For example, if Flavors were migrated to include standard attributes, we"},{"line_number":62,"context_line":"we need a new \u0027flavor-standardattr\u0027 extension. Then as an API caller, I will"},{"line_number":63,"context_line":"know that flavors will have timestamps by checking for \u0027flavor-standardattr\u0027"},{"line_number":64,"context_line":"and \u0027timestamps\u0027."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a8ec9b2_6e2146b4","line":63,"in_reply_to":"7a8ec9b2_cbddec15","updated":"2016-09-15 01:02:43.000000000","message":"pretty sure you just said the same thing i did","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":61,"context_line":"For example, if Flavors were migrated to include standard attributes, we"},{"line_number":62,"context_line":"we need a new \u0027flavor-standardattr\u0027 extension. Then as an API caller, I will"},{"line_number":63,"context_line":"know that flavors will have timestamps by checking for \u0027flavor-standardattr\u0027"},{"line_number":64,"context_line":"and \u0027timestamps\u0027."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a8ec9b2_2b9d7059","line":64,"updated":"2016-09-15 00:16:00.000000000","message":"can we list the models that do use api_collections here for the sake of the reader? Perhaps if we came up with a more unique name we\u0027re sure the not to hit other projects entries.\n\n[1] http://codesearch.openstack.org/?q\u003dapi_collections\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d6a9b38ac30f8acb1946e0c49bf09ae268c1210f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"For example, if Flavors were migrated to include standard attributes, we"},{"line_number":62,"context_line":"we need a new \u0027flavor-standardattr\u0027 extension. Then as an API caller, I will"},{"line_number":63,"context_line":"know that flavors will have timestamps by checking for \u0027flavor-standardattr\u0027"},{"line_number":64,"context_line":"and \u0027timestamps\u0027."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a8ec9b2_cebc1a6f","line":64,"in_reply_to":"7a8ec9b2_2b9d7059","updated":"2016-09-15 00:59:37.000000000","message":"Sure","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"}],"doc/source/devref/db_layer.rst":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4c4724711093b40c9c021f2afa1f14c93417d18","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A model that inherits HasStandardAttributes must implement the property"},{"line_number":85,"context_line":"\u0027api_collections\u0027, which is a list of API resources that the new object"},{"line_number":86,"context_line":"may appear under. In most cases, this will only be one (e.g. \u0027ports\u0027 for"},{"line_number":87,"context_line":"the Port model). This is used by all of the service plugins that add standard"},{"line_number":88,"context_line":"attribute fields to determine which API responses need to be populated."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a89bdaa_2c6fbefc","line":86,"updated":"2016-09-08 13:31:51.000000000","message":"Honestly, that \u0027one-to-many\u0027 feature seems like a YAGNI, but ok.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8d44de3245bb84e9e2dd049d3b6ffcda3bdd33cb","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A model that inherits HasStandardAttributes must implement the property"},{"line_number":85,"context_line":"\u0027api_collections\u0027, which is a list of API resources that the new object"},{"line_number":86,"context_line":"may appear under. In most cases, this will only be one (e.g. \u0027ports\u0027 for"},{"line_number":87,"context_line":"the Port model). This is used by all of the service plugins that add standard"},{"line_number":88,"context_line":"attribute fields to determine which API responses need to be populated."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a89bdaa_ef0a28d1","line":86,"in_reply_to":"9a89bdaa_2c6fbefc","updated":"2016-09-08 13:41:27.000000000","message":"Segments are exposed under both the network and as a top-level object. They did turn out to be the same collection name in this case so it wasn\u0027t necessary, but I left it in case we experience something similar for something like IP allocations if that became first class.\n\nhttps://github.com/openstack/neutron/blob/master/neutron/extensions/segment.py#L39\n\nhttps://github.com/openstack/neutron/blob/master/neutron/extensions/multiprovidernet.py#L75-L80","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6f8ec9f9f2ee2f5cd91dec327500812e7f1bccc0","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"A model that inherits HasStandardAttributes must implement the property"},{"line_number":85,"context_line":"\u0027api_collections\u0027, which is a list of API resources that the new object"},{"line_number":86,"context_line":"may appear under. In most cases, this will only be one (e.g. \u0027ports\u0027 for"},{"line_number":87,"context_line":"the Port model). This is used by all of the service plugins that add standard"},{"line_number":88,"context_line":"attribute fields to determine which API responses need to be populated."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a89bdaa_e2eebf20","line":86,"in_reply_to":"9a89bdaa_ef0a28d1","updated":"2016-09-08 13:51:20.000000000","message":"Thanks for clarification.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"}],"neutron/db/qos/models.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5aeffd62e2caae2a15878ee42d54a3c4ae19a89b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.QosPolicyRBAC,"},{"line_number":31,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":32,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":33,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QosNetworkPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_719c89c0","line":33,"range":{"start_line":33,"start_character":24,"end_line":33,"end_character":32},"updated":"2016-09-02 07:22:47.000000000","message":"\u0027qos/policies\u0027?","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d43f1d88e716504c09d3a740b9c059cc66c27a1e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.QosPolicyRBAC,"},{"line_number":31,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":32,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":33,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QosNetworkPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_f1efb61a","line":33,"range":{"start_line":33,"start_character":24,"end_line":33,"end_character":32},"in_reply_to":"fa7ab95a_2e6e1b2f","updated":"2016-09-02 08:31:17.000000000","message":"The prefix doesn\u0027t matter for extension processing. (e.g. security group rules in the API are underneath security group but the extension processing just goes by \u0027securitygrouprules\u0027. https://github.com/openstack/neutron/blob/master/neutron/extensions/securitygroup.py#L234)","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e02d83365a6a7b3133e2d32a05448b667d5dac34","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.QosPolicyRBAC,"},{"line_number":31,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":32,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":33,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QosNetworkPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_cc285a36","line":33,"range":{"start_line":33,"start_character":24,"end_line":33,"end_character":32},"in_reply_to":"fa7ab95a_719c89c0","updated":"2016-09-02 07:48:40.000000000","message":"just \u0027policies\u0027 https://github.com/openstack/neutron/blob/903eb250bcf829173fe701e3fef20dbd8fc51ef8/neutron/extensions/qos.py#L48","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"167798cf0e10276fcc5de7e834209849d6e8c93a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.QosPolicyRBAC,"},{"line_number":31,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":32,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":33,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QosNetworkPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_2e6e1b2f","line":33,"range":{"start_line":33,"start_character":24,"end_line":33,"end_character":32},"in_reply_to":"fa7ab95a_cc285a36","updated":"2016-09-02 08:20:05.000000000","message":"So these collections are top level, not under the resource\u0027s path_prefix?","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1a3e108b2416b4f58cb335f1857cff4b62de289f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    rbac_entries \u003d sa.orm.relationship(rbac_db_models.QosPolicyRBAC,"},{"line_number":31,"context_line":"                                       backref\u003d\u0027qos_policy\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":32,"context_line":"                                       cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":33,"context_line":"    api_collections \u003d [\u0027policies\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class QosNetworkPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_5494d089","line":33,"range":{"start_line":33,"start_character":24,"end_line":33,"end_character":32},"in_reply_to":"fa7ab95a_f1efb61a","updated":"2016-09-02 08:50:42.000000000","message":"OK, got it. At least they didn\u0027t call them \u0027rules\u0027.","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"}],"neutron/db/standard_attr.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5aeffd62e2caae2a15878ee42d54a3c4ae19a89b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        (e.g. created_at/updated_at/etc)."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        # NOTE(kevinbenton): can\u0027t use abc because the metaclass conflicts"},{"line_number":87,"context_line":"        # with the declartive base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_96502334","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":29},"updated":"2016-09-02 07:22:47.000000000","message":"spelling","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e02d83365a6a7b3133e2d32a05448b667d5dac34","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        (e.g. created_at/updated_at/etc)."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        # NOTE(kevinbenton): can\u0027t use abc because the metaclass conflicts"},{"line_number":87,"context_line":"        # with the declartive base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_acda3649","line":87,"range":{"start_line":87,"start_character":19,"end_line":87,"end_character":29},"in_reply_to":"fa7ab95a_96502334","updated":"2016-09-02 07:48:40.000000000","message":"Done","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5aeffd62e2caae2a15878ee42d54a3c4ae19a89b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declartive base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\""},{"line_number":91,"context_line":"                                  % cls)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @declarative.declared_attr"},{"line_number":94,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_d63d4bde","line":91,"range":{"start_line":90,"start_character":8,"end_line":91,"end_character":40},"updated":"2016-09-02 07:22:47.000000000","message":"Looks like this could fit on one line.","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e02d83365a6a7b3133e2d32a05448b667d5dac34","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declartive base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\""},{"line_number":91,"context_line":"                                  % cls)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @declarative.declared_attr"},{"line_number":94,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0ce6c214","line":91,"range":{"start_line":90,"start_character":8,"end_line":91,"end_character":40},"in_reply_to":"fa7ab95a_d63d4bde","updated":"2016-09-02 07:48:40.000000000","message":"Done","commit_id":"4a7020ba40192f97bd3618b4321de07ca8e6e929"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"62306cd2e27b4f6342d37b4b1e6cf1beac69ac8b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declarative base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\" % cls)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @declarative.declared_attr"},{"line_number":93,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da7fb54a_56dab279","line":90,"updated":"2016-09-02 17:21:22.000000000","message":"you did not define it for trunks under neutron/services/trunk/models, but this hasn\u0027t failed in the api job, how come?","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6599779c5ceb56f72637a823c5e7fadb5f396ccd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declarative base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\" % cls)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @declarative.declared_attr"},{"line_number":93,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_13491c8c","line":90,"in_reply_to":"9a89bdaa_e88207c8","updated":"2016-09-02 21:53:19.000000000","message":"There you go: that\u0027s the evidence I need a vacation, I have become useless at reviewing!!","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"dfabddf5bcaba7076e2e341baef9ec3099f1bbda","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declarative base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\" % cls)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @declarative.declared_attr"},{"line_number":93,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_e88207c8","line":90,"in_reply_to":"da7fb54a_56dab279","updated":"2016-09-02 21:05:47.000000000","message":"Didn\u0027t I? https://review.openstack.org/#/c/364681/2/neutron/services/trunk/models.py","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"62306cd2e27b4f6342d37b4b1e6cf1beac69ac8b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"def get_standard_attr_resource_model_map():"},{"line_number":159,"context_line":"    rs_map \u003d {}"},{"line_number":160,"context_line":"    for subclass in HasStandardAttributes.__subclasses__():"},{"line_number":161,"context_line":"        for resource in subclass.get_api_collections():"},{"line_number":162,"context_line":"            if resource in rs_map:"},{"line_number":163,"context_line":"                raise RuntimeError(_LE(\"Model %(sub)s tried to register for \""},{"line_number":164,"context_line":"                                       \"API resource %(res)s which conflicts \""}],"source_content_type":"text/x-python","patch_set":2,"id":"da7fb54a_96bb5a0e","line":161,"updated":"2016-09-02 17:21:22.000000000","message":"shouldn\u0027t have we failed here because Trunk did not have api_collections?","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"34ec33a8c5d2156f1ed44d91a09d5aee70fe9e28","unresolved":false,"context_lines":[{"line_number":158,"context_line":"def get_standard_attr_resource_model_map():"},{"line_number":159,"context_line":"    rs_map \u003d {}"},{"line_number":160,"context_line":"    for subclass in HasStandardAttributes.__subclasses__():"},{"line_number":161,"context_line":"        for resource in subclass.get_api_collections():"},{"line_number":162,"context_line":"            if resource in rs_map:"},{"line_number":163,"context_line":"                raise RuntimeError(_LE(\"Model %(sub)s tried to register for \""},{"line_number":164,"context_line":"                                       \"API resource %(res)s which conflicts \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_884b3bb0","line":161,"in_reply_to":"9a89bdaa_286dcf32","updated":"2016-09-02 21:06:18.000000000","message":"I mean *I* did.","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"dfabddf5bcaba7076e2e341baef9ec3099f1bbda","unresolved":false,"context_lines":[{"line_number":158,"context_line":"def get_standard_attr_resource_model_map():"},{"line_number":159,"context_line":"    rs_map \u003d {}"},{"line_number":160,"context_line":"    for subclass in HasStandardAttributes.__subclasses__():"},{"line_number":161,"context_line":"        for resource in subclass.get_api_collections():"},{"line_number":162,"context_line":"            if resource in rs_map:"},{"line_number":163,"context_line":"                raise RuntimeError(_LE(\"Model %(sub)s tried to register for \""},{"line_number":164,"context_line":"                                       \"API resource %(res)s which conflicts \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_286dcf32","line":161,"in_reply_to":"da7fb54a_96bb5a0e","updated":"2016-09-02 21:05:47.000000000","message":"but it did? https://review.openstack.org/#/c/364681/2/neutron/services/trunk/models.py","commit_id":"d636f2e7c19e675b13610d89eabdf0e200fb7ee5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8cdef48212a3e1d2cdfd975d3d00084d1e8f3f80","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declarative base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\" % cls)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @declarative.declared_attr"},{"line_number":93,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_e60fd334","line":90,"updated":"2016-09-08 02:55:21.000000000","message":"This is better rephrase: \"%s must define api_collections\"","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd75966f5fd389aecc0b8edaccb4fc9926334ebd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # with the declarative base others inherit from."},{"line_number":88,"context_line":"        if hasattr(cls, \u0027api_collections\u0027):"},{"line_number":89,"context_line":"            return cls.api_collections"},{"line_number":90,"context_line":"        raise NotImplementedError(\"%s hasn\u0027t defined api_collections\" % cls)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @declarative.declared_attr"},{"line_number":93,"context_line":"    def standard_attr_id(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_68438513","line":90,"in_reply_to":"9a89bdaa_e60fd334","updated":"2016-09-08 08:25:50.000000000","message":"Done","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"}],"neutron/extensions/revisions.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2b18cbc4a0c7bf8ae4092b3e6ec34d52ae70efa2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_123244a7","side":"PARENT","line":22,"updated":"2016-09-13 11:43:29.000000000","message":"the definition of revisions extension has changed to from \u0027revision_number exposed for the limited list of resources\u0027 to \u0027revision_number exposed for all resources that happen to support standard attributes\u0027. This change should be documented somewhere.\n\nThis is also a change that makes it unclear for API users whether the attribute is available for new resources that will happen to be linked to standard attributes in next releases; but that\u0027s the problem shared with the new \u0027timestamp\u0027 extension, so I guess you are fine with that too. But at least a release note describing the shift of the paradigm is due.","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"00b4450283babbbbf5dbe9529bbdcc0d16588f31","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_c2e509a9","side":"PARENT","line":22,"in_reply_to":"7a8ec9b2_42fe596c","updated":"2016-09-14 08:10:01.000000000","message":"they will be dummy flags. much like the ones added to indicate sorting, pagination, etc","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4660875112d00939447390fe4cb62871098ce410","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_42fe596c","side":"PARENT","line":22,"in_reply_to":"7a8ec9b2_46f834e6","updated":"2016-09-14 08:05:13.000000000","message":"Wow. So then what\u0027s the goal of this patch really if we will get new extensions emerging in the future for exact same attributes?","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a58db32760cc28053b1b8f8bea0b4a242d01b4ce","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_1d04b613","side":"PARENT","line":22,"in_reply_to":"7a8ec9b2_c2e509a9","updated":"2016-09-14 08:14:58.000000000","message":"So in the flavour example I proposed in my last comment on the commit message, you would introduce a \u0027timestamp_flavour\u0027 extension? And then if you decide to tag agents in Pike, you will introduce \u0027timestamp_agent\u0027?\n\nIf that\u0027s the goal here, then I don\u0027t follow the premise of the change, since the proposed path forward is not very different from what we have now with timestamp_core and timestamp_ext.","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ca92592acb582295dda581e133e53e10757636d7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_a6c15d31","side":"PARENT","line":22,"in_reply_to":"9a89bdaa_123244a7","updated":"2016-09-13 11:58:51.000000000","message":"If there is a new resource next cycle, there will be an extension indicating that resource\u0027s presence. We could have that extension depend on these if you want it to be more explicit.\n\nIn the comments on the next patch, you said hardcoding doesn\u0027t fix anything, but that\u0027s exactly what is here...","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e01c1c31ea8331810baa3593cf61bf7c13e4c0e3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_46f834e6","side":"PARENT","line":22,"in_reply_to":"9a89bdaa_49dfc239","updated":"2016-09-14 04:07:22.000000000","message":"new extension indicating that they are now standard resources with all of the benefits provided by that club","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4bb01d83eef910f76e4c3808599a8d77ea3da29b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    REVISION: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":20,"context_line":"               \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":"RESOURCES \u003d (\u0027security_group_rules\u0027, \u0027security_groups\u0027, \u0027ports\u0027, \u0027subnets\u0027,"},{"line_number":23,"context_line":"             \u0027networks\u0027, \u0027routers\u0027, \u0027floatingips\u0027, \u0027subnetpools\u0027)"},{"line_number":24,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {}"},{"line_number":25,"context_line":"for resource in RESOURCES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_49dfc239","side":"PARENT","line":22,"in_reply_to":"9a89bdaa_a6c15d31","updated":"2016-09-13 12:08:36.000000000","message":"For new resources, it\u0027s more easy. What about existing resources? (flavor? lbaas*?)","commit_id":"80c1a6b9815ae712744ef7ba85335eb5308dd751"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def get_name(cls):"},{"line_number":30,"context_line":"        return \"Resource revision numbers\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_cb2b2cea","line":30,"updated":"2016-09-15 00:16:00.000000000","message":"Can you revise this name to be of the format:\n\n\"standardattr - Resource revision numbers\"","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d6a9b38ac30f8acb1946e0c49bf09ae268c1210f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def get_name(cls):"},{"line_number":30,"context_line":"        return \"Resource revision numbers\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_ae7d0eb3","line":30,"in_reply_to":"7a8ec9b2_cb2b2cea","updated":"2016-09-15 00:59:37.000000000","message":"I\u0027ll do the aliases. Leave the names for humans","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def get_alias(cls):"},{"line_number":34,"context_line":"        return \"revisions\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def get_description(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_0b36f451","line":34,"updated":"2016-09-15 00:16:00.000000000","message":"perhaps this could become:\n\nstandardattr-revisions","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"}],"neutron/extensions/standardattrdescription.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f920fa6ba3693d94bd2d448be194cdb435212648","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.db import standard_attr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DESCRIPTION_BODY \u003d {"},{"line_number":22,"context_line":"    \u0027description\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":23,"context_line":"                    \u0027validate\u0027: {\u0027type:string\u0027: attr.DESCRIPTION_MAX_LEN},"},{"line_number":24,"context_line":"                    \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_b891b254","line":21,"updated":"2016-09-06 20:32:20.000000000","message":"Shouldn\u0027t you be able to clean up [1,2] in the context of this patch; that\u0027ll further validate this is doing what\u0027s meant to do no?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/extensions/trunk.py#L35\n[2] https://github.com/openstack/neutron/blob/master/neutron/extensions/segment.py#L75","commit_id":"1ec1cd49c2424d65b80ec97fc91a376881aedb5b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2b18cbc4a0c7bf8ae4092b3e6ec34d52ae70efa2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.db import standard_attr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DESCRIPTION_BODY \u003d {"},{"line_number":22,"context_line":"    \u0027description\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":23,"context_line":"                    \u0027validate\u0027: {\u0027type:string\u0027: attr.DESCRIPTION_MAX_LEN},"},{"line_number":24,"context_line":"                    \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_f2d32036","line":21,"updated":"2016-09-13 11:43:29.000000000","message":"same comment as for revisions extension.","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def get_name(cls):"},{"line_number":32,"context_line":"        return \"standard-attr-description\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_ab4500b4","line":32,"updated":"2016-09-15 00:16:00.000000000","message":"like you did here. I think we should be consistent if we can.","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"}],"neutron/extensions/timestamp_core.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8cdef48212a3e1d2cdfd975d3d00084d1e8f3f80","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return \"2016-03-01T10:00:00-00:00\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def get_extended_resources(self, version):"},{"line_number":58,"context_line":"        if version !\u003d \"2.0\":"},{"line_number":59,"context_line":"            return {}"},{"line_number":60,"context_line":"        rs_map \u003d standard_attr.get_standard_attr_resource_model_map()"},{"line_number":61,"context_line":"        return {resource: TIMESTAMP_BODY for resource in rs_map}"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_a9a4bc07","line":58,"updated":"2016-09-08 02:55:21.000000000","message":"is that because of the changes in the next file?","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bd75966f5fd389aecc0b8edaccb4fc9926334ebd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return \"2016-03-01T10:00:00-00:00\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def get_extended_resources(self, version):"},{"line_number":58,"context_line":"        if version !\u003d \"2.0\":"},{"line_number":59,"context_line":"            return {}"},{"line_number":60,"context_line":"        rs_map \u003d standard_attr.get_standard_attr_resource_model_map()"},{"line_number":61,"context_line":"        return {resource: TIMESTAMP_BODY for resource in rs_map}"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_88752965","line":58,"in_reply_to":"9a89bdaa_a9a4bc07","updated":"2016-09-08 08:25:50.000000000","message":"This didn\u0027t alter the logic. Just allows the 2.0 case to not be indented.","commit_id":"19a23d7a224116b9363e6b20262f02b498ae4a16"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def get_name(cls):"},{"line_number":41,"context_line":"        return \"Time Stamp Fields addition for core resources\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_cb124cb4","line":40,"updated":"2016-09-15 00:16:00.000000000","message":"same here.","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d6a9b38ac30f8acb1946e0c49bf09ae268c1210f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def get_name(cls):"},{"line_number":41,"context_line":"        return \"Time Stamp Fields addition for core resources\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_0ea0c242","line":40,"in_reply_to":"7a8ec9b2_cb124cb4","updated":"2016-09-15 00:59:37.000000000","message":"this is gone in next patch. will address it there.","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"}],"neutron/extensions/timestamp_ext.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4c4724711093b40c9c021f2afa1f14c93417d18","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def get_extended_resources(self, version):"},{"line_number":44,"context_line":"        # NOTE(kevinbenton): this extension is basically a no-op because"},{"line_number":45,"context_line":"        # the timestamp_core extension already defines all of the resources"},{"line_number":46,"context_line":"        # now."},{"line_number":47,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a89bdaa_8c1feab5","line":46,"updated":"2016-09-08 13:31:51.000000000","message":"then should we kill it before RC???","commit_id":"ee1d5372af3b0544e021656cd501c823b9ca053b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b67175f786a9dd31538a0efaebb7d4db6adce068","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def get_description(cls):"},{"line_number":35,"context_line":"        return (\"This extension adds create/update timestamps for all \""},{"line_number":36,"context_line":"                \"standard neutron resources not included by the \""},{"line_number":37,"context_line":"                \"\u0027timestamp_core\u0027 extension.\")"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_eb15489b","line":35,"updated":"2016-09-15 00:16:00.000000000","message":"this is going away so don\u0027t bother.","commit_id":"973b93de1bb5a95b8306c41203e71fd2d69cd476"}],"neutron/tests/contrib/hooks/api_extensions":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d68cb794850ad2d5f7e87b8e9d3c15533cf68ca6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    qos, \\"},{"line_number":28,"context_line":"    quotas, \\"},{"line_number":29,"context_line":"    rbac-policies, \\"},{"line_number":30,"context_line":"    standard-attr-revisions, \\"},{"line_number":31,"context_line":"    router, \\"},{"line_number":32,"context_line":"    router_availability_zone, \\"},{"line_number":33,"context_line":"    security-group, \\"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a8ec9b2_81f3c39d","line":30,"updated":"2016-09-15 01:28:22.000000000","message":"these are alphabetically ordered","commit_id":"5d79d7b3adcab17301bc7a6ff817068d0f4953b3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6bd0d01c8b823bc6ac1a499c1c8931be2a0e6d26","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    qos, \\"},{"line_number":28,"context_line":"    quotas, \\"},{"line_number":29,"context_line":"    rbac-policies, \\"},{"line_number":30,"context_line":"    standard-attr-revisions, \\"},{"line_number":31,"context_line":"    router, \\"},{"line_number":32,"context_line":"    router_availability_zone, \\"},{"line_number":33,"context_line":"    security-group, \\"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a8ec9b2_c1794bfe","line":30,"in_reply_to":"7a8ec9b2_81f3c39d","updated":"2016-09-15 01:31:38.000000000","message":"not anymore","commit_id":"5d79d7b3adcab17301bc7a6ff817068d0f4953b3"}]}
